On 14/05/2020 21:12, Mandy Chung wrote:
MethodHandles::privateLookupIn should prepare for being called during
early startup when the module of java.base classes are not yet
assigned. This bug is uncovered by panama prototype converting NIO to
use memory access API.
The fix is very simple and
Hi,
Thanks for the review comments. I will work on the same and get back with the
same soon.
Thanks & Regards
Vipin MV
On 05/15/20 03:39 am, Alexey Semenyuk wrote:
> Looks good.
>
> - Alexey
Thanks Alexey. Can I get another reviewer to look at it before pushing?
Nick
>> Hi,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8244981
>> Webrev: http://cr.openjdk.java.net/~ngasson/8244981/webrev.0/
>>
>> Several
Hi,
On Wed, 2020-05-13 at 16:11 +0100, Andrew Hughes wrote:
> On 12/05/2020 15:14, Severin Gehwolf wrote:
> > Hi Andrew,
> >
> > Thanks for looking at this.
> >
> > On Tue, 2020-05-12 at 14:07 +0100, Andrew Haley wrote:
> > > On 5/7/20 4:09 PM, Severin Gehwolf wrote:
> > > > jvm_version_info.jvm
Hi Andrew,
Sigh, I only now realized that the bug number was missing the
subject. Fixed now.
On Fri, 2020-05-15 at 06:53 +0100, Andrew Hughes wrote:
> On 13/05/2020 20:26, Severin Gehwolf wrote:
> > Hi Andrew,
> >
> > Thanks for looking at this.
> >
>
> No problem. Thanks for taking it on.
>
Hi,
by adding a bridge method in JavaLangAcces to call into the
StringConcatHelper.initialCoder - which is done only once during
initialization - we can reduce bootstrap overhead of SCF by a few
million instructions - ~0.5ms on wall clock measures.
Webrev: http://cr.openjdk.java.net/~redestad/82
Yes - sorry - thought I had replied.
looks good.
/Andy
On 5/15/2020 3:36 AM, Nick Gasson wrote:
On 05/15/20 03:39 am, Alexey Semenyuk wrote:
Looks good.
- Alexey
Thanks Alexey. Can I get another reviewer to look at it before pushing?
Nick
Hi,
Bug: https://bugs.openjdk.java.net/browse/J
+1
> On May 15, 2020, at 7:54 AM, Claes Redestad wrote:
>
> Hi,
>
> by adding a bridge method in JavaLangAcces to call into the
> StringConcatHelper.initialCoder - which is done only once during
> initialization - we can reduce bootstrap overhead of SCF by a few
> million instructions - ~0.5ms
Hello,
Please review this trivial change for
https://bugs.openjdk.java.net/browse/JDK-8245111:
http://cr.openjdk.java.net/~prappo/8245111/webrev.00/
In addition to fixing the main issue, this includes a blanket change from
"followed with" to "followed by" as the latter seemed idiomatic to me
On 5/15/20 9:45 AM, Severin Gehwolf wrote:
> So, Andrew Haley, what's the verdict on this one? There is a risk, yes.
> Not fixing the bug seems riskier, though. Thoughts?
Thanks for the detailed explanation.
I think we have to keep sun.misc.Version working correctly but
sacrifice binary consisten
Hi Pavel,
This looks good to me - but English is not my native language ;-)
cheers,
-- daniel
On 15/05/2020 13:35, Pavel Rappo wrote:
Hello,
Please review this trivial change for
https://bugs.openjdk.java.net/browse/JDK-8245111:
http://cr.openjdk.java.net/~prappo/8245111/webrev.00/
In
On Fri, 2020-05-15 at 14:29 +0100, Andrew Haley wrote:
> On 5/15/20 9:45 AM, Severin Gehwolf wrote:
> > So, Andrew Haley, what's the verdict on this one? There is a risk, yes.
> > Not fixing the bug seems riskier, though. Thoughts?
>
> Thanks for the detailed explanation.
>
> I think we have to k
+1
Cheers,
Joe
On 5/15/2020 7:00 AM, Daniel Fuchs wrote:
Hi Pavel,
This looks good to me - but English is not my native language ;-)
cheers,
-- daniel
On 15/05/2020 13:35, Pavel Rappo wrote:
Hello,
Please review this trivial change for
https://bugs.openjdk.java.net/browse/JDK-8245111:
Please review fix for issue [1] at [2].
The change enables packaging runtime images as a dmg on MacOS.
[1] - https://bugs.openjdk.java.net/browse/JDK-8237971
[2] - http://cr.openjdk.java.net/~herrick/8237971/webrev.01/
/Andy
Hi Pavel,
No problem with the "with" -> "by" changes.
javax/naming/NameNotFoundException.java: 55
"initialized" -> "are initialized"
java/util/jar/Attributes.java:594
The period was in the correct place.
The second sentence is a separate comment about the use (non-use).
"used for the ex
On 2020-05-15 13:53, Jim Laskey wrote:
+1
Thanks, Jim!
/Claes
On May 15, 2020, at 7:54 AM, Claes Redestad wrote:
Hi,
by adding a bridge method in JavaLangAcces to call into the
StringConcatHelper.initialCoder - which is done only once during
initialization - we can reduce bootstrap ove
> On 15 May 2020, at 16:53, Roger Riggs wrote:
>
> Hi Pavel,
>
> No problem with the "with" -> "by" changes.
>
> javax/naming/NameNotFoundException.java: 55
> "initialized" -> "are initialized"
>
> java/util/jar/Attributes.java:594
> The period was in the correct place.
> The second se
+1
Paul.
> On May 15, 2020, at 3:54 AM, Claes Redestad wrote:
>
> Hi,
>
> by adding a bridge method in JavaLangAcces to call into the
> StringConcatHelper.initialCoder - which is done only once during
> initialization - we can reduce bootstrap overhead of SCF by a few
> million instructions -
+1
Paul.
> On May 14, 2020, at 1:12 PM, Mandy Chung wrote:
>
> MethodHandles::privateLookupIn should prepare for being called during early
> startup when the module of java.base classes are not yet assigned. This bug
> is uncovered by panama prototype converting NIO to use memory access API.
Thanks, Paul!
/Claes
On 2020-05-15 18:00, Paul Sandoz wrote:
+1
Paul.
On May 15, 2020, at 3:54 AM, Claes Redestad wrote:
Hi,
by adding a bridge method in JavaLangAcces to call into the
StringConcatHelper.initialCoder - which is done only once during
initialization - we can reduce bootstra
Hi Pavel,
Yes, I think that would be an improvement.
But its a slippery slope beyond what you originally observed and wanted
to fix.
Thanks, Roger
On 5/15/20 11:59 AM, Pavel Rappo wrote:
On 15 May 2020, at 16:53, Roger Riggs wrote:
Hi Pavel,
No problem with the "with" -> "by" changes.
j
Roger, I think I will not do that even though it might be an improvement.
If you look closely, the "attribute used for" pattern carpet-bombs that file. I
guess if we are making this change you suggest, this should be done in a
separate changeset. You are absolutely right saying that it's a slipp
Hi Pavel,
+1
No problem, local consistency is more important.
Roger
On 5/15/20 12:47 PM, Pavel Rappo wrote:
Roger, I think I will not do that even though it might be an improvement.
If you look closely, the "attribute used for" pattern carpet-bombs that file. I
guess if we are making this
Hi Pavel
> On May 15, 2020, at 12:34 PM, Roger Riggs wrote:
>
> Hi Pavel,
>
> Yes, I think that would be an improvement.
> But its a slippery slope beyond what you originally observed and wanted to
> fix.
I understand why you want to fix this. When you look at the rest of the field
descript
Hi,
Please review a fix for the compilation warnings. Thanks Roger for the
detailed instructions! If you could verify the fix with the
work-in-progress processor, that would be great too. Regular build and
test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342
http://cr.openjdk.java.n
Looks ok joe
> On May 15, 2020, at 1:54 PM, Joe Wang wrote:
>
> Hi,
>
> Please review a fix for the compilation warnings. Thanks Roger for the
> detailed instructions! If you could verify the fix with the work-in-progress
> processor, that would be great too. Regular build and test passed.
>
+1
Naoto
On 5/15/20 11:35 AM, Lance Andersen wrote:
Looks ok joe
On May 15, 2020, at 1:54 PM, Joe Wang wrote:
Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed
instructions! If you could verify the fix with the work-in-progress processor,
that would be g
Looks good.
- Alexey
On 5/15/2020 11:55 AM, Andy Herrick wrote:
Please review fix for issue [1] at [2].
The change enables packaging runtime images as a dmg on MacOS.
[1] - https://bugs.openjdk.java.net/browse/JDK-8237971
[2] - http://cr.openjdk.java.net/~herrick/8237971/webrev.01/
/Andy
Hi Andy,
Looks good.
Thanks,
Alexander
On 5/15/20 8:55 AM, Andy Herrick wrote:
Please review fix for issue [1] at [2].
The change enables packaging runtime images as a dmg on MacOS.
[1] - https://bugs.openjdk.java.net/browse/JDK-8237971
[2] - http://cr.openjdk.java.net/~herrick/8237971/webr
29 matches
Mail list logo
