Please review the jpackage fix for bug [1] at [2].
- Detach fails sometimes due to disk image being busy. Not sure what
keeps disk image busy. Probably antivirus or something else. Within
short period of time disk image can be detach. So, fix is just re-try
detach if it did not work right away
On 5/22/20 3:55 PM, Claes Redestad wrote:
> There are no guarantees any particular fallback is not going to break in
> similar ways or - more likely - bit rot and break sooner. Seeing how all
> but the default strategy sees rather superficial testing in practice, I
> think you are exaggerating the
Looks good to me.
Naoto
On 5/22/20 2:33 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8239013: java.util.logging.Logger catalog cache keeps strong
references to ResourceBundles
https://bugs.openjdk.java.net/browse/JDK-8239013
webrev:
http://cr.openjdk.java.net/~dfuchs/we
Hi Daniel,
This looks good. Surprisingly no one reports this long standing bug.
thanks
Mandy
On 5/22/20 2:33 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8239013: java.util.logging.Logger catalog cache keeps strong
references to ResourceBundles
https://bugs.openjdk.java
Jim, Paul, Rémi, Mandy,
thank you all for your reviewing and supporting the suggested approach.
/Claes
On 2020-05-22 20:35, Mandy Chung wrote:
Hi Claes,
The change looks good.
I also support the removal of all non-default strategies. The default
strategy has been baked for long enough time
Hi Claes,
The change looks good.
I also support the removal of all non-default strategies. The default
strategy has been baked for long enough time and shown solid (the issues
in j.l.invoke quoted already were 2 years old).
Mandy
On 5/22/20 10:28 AM, Paul Sandoz wrote:
Hi,
I support the
Hi,
Thanks Jan and Maurizio for the reviews. I have created another
iteration that I hope addresses all of the comments. I recognize that
dealing with `sealed`, `non-sealed` is the most complicated part as
there is no guide right now from the spec. So I have tried to make them
contextual keyw
> On May 22, 2020, at 10:40 AM, Andrew Haley wrote:
>
> On 5/22/20 5:12 PM, Paul Sandoz wrote:
>
>> I am not terribly familiar with the AArch64 code, but I would note
>> the Vector API comes with a bunch of unit tests should exercise the
>> code gen, just not as directly as I presume you woul
- Mail original -
> De: "Paul Sandoz"
> À: "Claes Redestad"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 22 Mai 2020 19:28:39
> Objet: Re: RFR: 8245455: Remove alternative StringConcatFactory strategies
> Hi,
>
> I support the removal of all the other strategies to simplify SCF and make it
On 5/22/20 5:12 PM, Paul Sandoz wrote:
> I am not terribly familiar with the AArch64 code, but I would note
> the Vector API comes with a bunch of unit tests should exercise the
> code gen, just not as directly as I presume you would like.
Yes, you've understood me: direct is what I want. The ass
Hi,
I support the removal of all the other strategies to simplify SCF and make it
more maintainable.
Having one or more strategies to fall back on (with an undocumented flag) was I
think right thing to do when initially introducing the feature. Over time, the
default strategy has become more a
HI Andrew,
Thanks for looking.
I am not terribly familiar with the AArch64 code, but I would note the Vector
API comes with a bunch of unit tests should exercise the code gen, just not as
directly as I presume you would like.
To what extent do you feel we can follow up with additional issues
Thanks Lois!
I'll add the two ResourceMarks before the changes get pushed.
Harold
On 5/22/2020 11:07 AM, Lois Foltan wrote:
On 5/21/2020 2:33 PM, Harold Seigel wrote:
Hi David,
Thanks for looking at this! Please review this new webrev:
http://cr.openjdk.java.net/~hseigel/webrev.01/webre
On 5/21/2020 2:33 PM, Harold Seigel wrote:
Hi David,
Thanks for looking at this! Please review this new webrev:
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
Hi Harold,
I think this webrev looks good! A couple of minor comments:
- oops/instanceKlass.cpp:
line #236, do you nee
LGTM.
> On May 22, 2020, at 6:52 AM, Claes Redestad wrote:
>
> Hi,
>
> this patch removes the alternative, undocumented strategies from
> StringConcatFactory.
>
> The default strategy has been optimized and stabilized since inception in JDK
> 9, while the alternative strategies have been fal
On 2020-05-22 14:40, Aleksey Shipilev wrote:
On 5/22/20 2:16 PM, Claes Redestad wrote:
What I'm asking for is whether there exist any operational issues that
means users have to use any of the fallback strategies in the wild on
JDK 11/14 today. That would be a good argument to keep maintaining t
Hi Daniel,
This looks good to me :-)
Best
Lance
> On May 22, 2020, at 5:33 AM, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for:
>
> 8239013: java.util.logging.Logger catalog cache keeps strong
> references to ResourceBundles
> https://bugs.openjdk.java.net/browse/JDK-8239
Looks fine.
On 5/20/20 5:31 PM, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8239480
The proposed changeset, and the release note draft are located at:
https://cr.openjdk.java.net/~naoto/8239480/webrev.00/
https://
On 5/19/20 11:55 AM, Yang Zhang wrote:
> Following up on review requests of API [0], Java implementation and
> test [1], General Hotspot changes[2] for Vector API and x86 backend
> changes [3]. Here's a request for review of AArch64 backend changes
> required for supporting the Vector API:
>
> JEP
On 5/22/20 2:16 PM, Claes Redestad wrote:
> What I'm asking for is whether there exist any operational issues that
> means users have to use any of the fallback strategies in the wild on
> JDK 11/14 today. That would be a good argument to keep maintaining the
> code, but I've not heard of such a ca
On 2020-05-22 13:56, Aleksey Shipilev wrote:
On 5/22/20 1:53 PM, Claes Redestad wrote:
Do you have any example of a case when one of the fallbacks was used to
work around any issues? We've heard of no such case.
For example, the bug in j.l.invoke caused semantic bug in String concat:
htt
On 5/22/20 1:53 PM, Claes Redestad wrote:
> Do you have any example of a case when one of the fallbacks was used to
> work around any issues? We've heard of no such case.
For example, the bug in j.l.invoke caused semantic bug in String concat:
https://bugs.openjdk.java.net/browse/JDK-8200118
h
On 2020-05-22 13:43, Aleksey Shipilev wrote:
On 5/22/20 11:52 AM, Claes Redestad wrote:
Webrev: http://cr.openjdk.java.net/~redestad/8245455/open.00/
The experience with dealing with string concat bugs tells me we better leave at
least one strategy
as the fallback. It does not have to be v
On 5/22/20 11:52 AM, Claes Redestad wrote:
> Webrev: http://cr.openjdk.java.net/~redestad/8245455/open.00/
The experience with dealing with string concat bugs tells me we better leave at
least one strategy
as the fallback. It does not have to be very optimized, but it needs to be
definitely corr
On 22/05/2020 04:28, Mikael Vidstedt wrote:
Please review this change which cleans up the libjli related files a bit:
JBS: https://bugs.openjdk.java.net/browse/JDK-8245600
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8245600/webrev.00/open/webrev/
Looks good, don't have a strong opini
Hi,
this patch removes the alternative, undocumented strategies from
StringConcatFactory.
The default strategy has been optimized and stabilized since inception
in JDK 9, while the alternative strategies have been falling behind
both in terms of performance and stability - while adding mainten
On 2020-05-22 11:36, Alan Bateman wrote:
On 22/05/2020 10:33, Claes Redestad wrote:
Hi,
this patch removes four orphaned methods from UnixNativeDispatcher that
are no longer used after the Solaris removal:
Webrev: http://cr.openjdk.java.net/~redestad/8245619/open.00/
Bug: https://bugs.openj
On 22/05/2020 10:33, Claes Redestad wrote:
Hi,
this patch removes four orphaned methods from UnixNativeDispatcher that
are no longer used after the Solaris removal:
Webrev: http://cr.openjdk.java.net/~redestad/8245619/open.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8245619
Looks good,
Hi,
Please find below a fix for:
8239013: java.util.logging.Logger catalog cache keeps strong
references to ResourceBundles
https://bugs.openjdk.java.net/browse/JDK-8239013
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8239013/webrev.00/
java.util.logging.Logger has a `catalog` va
Hi,
this patch removes four orphaned methods from UnixNativeDispatcher that
are no longer used after the Solaris removal:
Webrev: http://cr.openjdk.java.net/~redestad/8245619/open.00/
Bug:https://bugs.openjdk.java.net/browse/JDK-8245619
Testing: tier1
Thanks!
/Claes
30 matches
Mail list logo
