Re: RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

Alexander, There is TKit.assertStringListEquals() already. Is it not sufficient? I think it would make sense to add prefix to platform specific properties in fa property files: `CFBundleTypeRole` -> `mac.CFBundleTypeRole`, etc. - Alexey On 6/9/2020 1:12 AM, alexander.matv...@oracle.com

RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

Hi, Please review a fix to a regression that resulted in invalid output in a transform that contains entity references. The regression was caused by a JDK9 patch [1]. Adding back the conditional checks fixed the issue. JBS: https://bugs.openjdk.java.net/browse/JDK-8237456 webrevs:

RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

Please review the jpackage fix for bug [1] at [2]. Added support for additional (macOS specific) file association properties. These additional properties should be set via same property file which used for file association. Names and values for properties should match name and values as

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Thanks for all your suggestions Brent! They helped a lot. Best regards, Yu L. On Tue, Jun 9, 2020 at 7:24 AM Brent Christian wrote: > Looks good to me as well. Thanks for making the updates to the test case. > > -Brent > > On 6/8/20 2:38 AM, Julia Boes wrote: > > Hi Yu Li, > > > > The

Re: RFR: JDK-8245958: j.l.Record need to mention that canonical constructor may not be public

Looks fine. Mandy On 6/8/20 12:58 PM, Vicente Romero wrote: Please review this API update. The API of java.lang.Record needs to be updated after the changes introduced by JEP 384: Records (Second Preview) [1], in particular this JEP changed the constraint that the canonical constructor had

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Looks good to me as well. Thanks for making the updates to the test case. -Brent On 6/8/20 2:38 AM, Julia Boes wrote: Hi Yu Li, The copyright year of Properties.java needs to be updated to 2020. Otherwise looks good to me! Cheers, Julia

Re: RFR: JDK-8231283: Evaluate option to install Linux packages in /usr hierarchy

Hi Alexey, Looks good. Thanks, Alexander On 6/8/20 7:26 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Add support to jpackage to create Linux packages installing app images in '/usr' tree with splicing of the app image. For --install-dir=/usr jpackag option the

Re: RFR: JDK-8246706: [macos] Allow SigningPackageTest to be built with real certificates

Hi Andy, Looks good. For changing "jpackagerTest.keychain" to ""jpackageTest.keychain" we can file followup bug for this, since SQE depend on this value to be "jpackagerTest.keychain". Thanks, Alexander On 6/5/20 2:27 PM, Alexey Semenyuk wrote: In SigningBase.java: --- KEYCHAIN = (value ==

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hello Sean, Yes, I think we'll need CSR and release notes as soon as this patch adds new property. I do not know exact process for it, so I will be grateful if you could explain me exact steps. This patch was developed to address compatibility issue with new LDAP authentication over SSL/TLS

[15] RFR: 8246662: Test java/time/test/java/time/format/TestUnicodeExtension.java failed on japanese locale.

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8246662 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8246662/webrev.00/ This is a regression caused by the fix to JDK-8244245, where the locale related fields in the

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hello Max, Daniel, Thank you for review and suggestions. Could you please check the updated webrev: http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v6/ This version contains the following changes: 1. Updated license for new files 2. Comments about default address type usage in the

Re: contributing to JDK-8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end

Hi Raffaello, If you are interested in providing a fix, you are more than welcome to do so. Please include a test which validates your fix. Best lance > On Jun 8, 2020, at 3:45 PM, Raffaello Giulietti > wrote: > > Raffaello

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

Hi Kim, Can we amend the JEP itself to be not solely about hotspot. Since it affects other areas I think that 1) They may need to be compiled with C++14 enabled whether they use new features or not 2) They may want - or need - to adopt C++11 or C++14 features too. You already know that soon

RFR: JDK-8245958: j.l.Record need to mention that canonical constructor may not be public

Please review this API update. The API of java.lang.Record needs to be updated after the changes introduced by JEP 384: Records (Second Preview) [1], in particular this JEP changed the constraint that the canonical constructor had to be public. The associated bug is [2], the changeset is at

contributing to JDK-8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end

Hello, as of a very recent changeset [1], this bug [2] is still present. While the bug already has an assignee, there seems to be no recent activity, so I'd like to contribute fixing it. Greetings Raffaello [1] http://hg.openjdk.java.net/jdk/jdk/rev/ac47db0c7ccb [2]

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

(resending to all lists on the review) I'm just catching up a bit on this review. Sorry if this has mentioned before, but are you planning to write a CSR and release note? I think this is needed for the com.sun.jndi.ldap.tls.cbtype property. I'm also wondering if this property should be

Re: RFR: JDK-8230744 Several classes throw OutOfMemoryError without message

Revised to use a consistent error message. Modified AbstractStringBuilder and PriorityBlockingQueue to use ArraysSupport.newLength(). Didn't modify ByteArrayChannel and UnsyncByteArrayOutputStream since those changes would require changes to module exporting. webrev:

Re: RFR: JDK-8231283: Evaluate option to install Linux packages in /usr hierarchy

I don't have a unix system to try this out on, but it looks like there is no net change when install-dir is neither "/usr" or "/user/local", so I'm good with it. /Andy On 6/8/2020 10:26 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Add support to jpackage to create

Re: 8246632: StringConcatFactory::makeConcatWithConstants no longer throws NullPointerException when an unexpected constant is null

Thanks, Mandy! /Claes On 2020-06-08 18:47, Mandy Chung wrote: Looks good (minus the typo Roger caught). Mandy On 6/8/20 7:51 AM, Claes Redestad wrote: Hi, JDK-8246152 triggered a failure in a JCK test that expects a NPE rather than a StringConcatException. We can keep the old behavior,

Re: 8246632: StringConcatFactory::makeConcatWithConstants no longer throws NullPointerException when an unexpected constant is null

Looks good (minus the typo Roger caught). Mandy On 6/8/20 7:51 AM, Claes Redestad wrote: Hi, JDK-8246152 triggered a failure in a JCK test that expects a NPE rather than a StringConcatException. We can keep the old behavior, while retaining most of performance by removing the now superfluous

JPackage with a modular application fails to load record class files even with --enable-preview

I have this app, which uses Java 14 with –enable-preview and records. If I turn it in to a normal non-modular jar, it works with both java -jar –enable-preview myapp.jar, and with a native image built with jpackage. However, when i turn it into a modular jar, I can still launch it with java

Re: 8246632: StringConcatFactory::makeConcatWithConstants no longer throws NullPointerException when an unexpected constant is null

Hi Roger, On 2020-06-08 17:36, Roger Riggs wrote: Hi Claes, The new method name "argumentMistmatch" should be "argumentMismatch". ("Mis" vs "Mist"). nice catch! Will fix that and run a sanity test before push. The rest looks fine. Thanks! /Claes Roger On 6/8/20 10:51 AM, Claes

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

Jim, if there isn’t a dedicated bug report for this (meaning: lack of optimization for macOS), please do create one so that it at least is documented somewhere. Thank you, -hendrik > On Jun 5, 2020, at 13:59, Jim Laskey wrote: > > I know there was a discussion about this elsewhere but I

Re: 8246632: StringConcatFactory::makeConcatWithConstants no longer throws NullPointerException when an unexpected constant is null

Hi Claes, The new method name "argumentMistmatch" should be "argumentMismatch".  ("Mis" vs "Mist"). The rest looks fine. Roger On 6/8/20 10:51 AM, Claes Redestad wrote: Hi, JDK-8246152 triggered a failure in a JCK test that expects a NPE rather than a StringConcatException. We can keep

8246632: StringConcatFactory::makeConcatWithConstants no longer throws NullPointerException when an unexpected constant is null

Hi, JDK-8246152 triggered a failure in a JCK test that expects a NPE rather than a StringConcatException. We can keep the old behavior, while retaining most of performance by removing the now superfluous Objects.requireNonNull calls from within the parse loop. Also fixed an issue where we were

RFR: JDK-8231283: Evaluate option to install Linux packages in /usr hierarchy

Please review fix [2] for jpackage bug [1]. Add support to jpackage to create Linux packages installing app images in '/usr' tree with splicing of the app image. For --install-dir=/usr jpackag option the resulting Debian package will have the following layout: - Launchers will be installed

Re: [OpenJDK 2D-Dev] RFR: 8246032: Implementation of JEP 347: Adopt C++14 Language Features in HotSpot

Hendrik, Yes, I will file one once I have some data. The benefits are not clear cut and I should annotate the request with validity. :-) Cheers, -- Jim > On Jun 6, 2020, at 11:13 AM, Hendrik Schreiber wrote: > > Jim, > > if there isn’t a dedicated bug report for this (meaning: lack of

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, I've looked through LdapCtx/LdapClient/SaslBind changes: Do we need to check if CHANNEL_BINDING is set explicitly for all connection types? Maybe we can move the check inside 'if (conn.sock instanceof SSLSocket) {' block. Also, instead of setting CHANNEL_BINDING in context

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi Julia, Thanks a lot! Didn't realise I was allowed to modify the copyright of Properties.java. Sure, will do! Best regards, Yu L. On Mon, Jun 8, 2020 at 5:41 PM Julia Boes wrote: > Hi Yu Li, > > The copyright year of Properties.java needs to be updated to 2020. > Otherwise looks good to me!

Re: [PATCH] 8245694 : java.util.Properties.entrySet() does not override java.lang.Object methods

Hi Yu Li, The copyright year of Properties.java needs to be updated to 2020. Otherwise looks good to me! Cheers, Julia