On Wed, 16 Sep 2020 19:05:56 GMT, Ioi Lam wrote:
>> This patch is reorganized after 8252725, which is separated from this patch
>> to refactor jlink glugin code. The previous
>> webrev with hg can be found at:
>> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>>
On 9/16/20 1:59 PM, Remi Forax wrote:
- Mail original -
De: "Nir Lisker"
À: "core-libs-dev"
Envoyé: Lundi 14 Septembre 2020 20:56:27
Objet: 'Find' method for Iterable
Hi,
This has probably been brought up at some point. When we need to find an
item in a collection based on its
On Wed, 16 Sep 2020 19:53:26 GMT, Roger Riggs wrote:
>> Looks in line with the discussion on core-libs.
>
> Removing hashcode from the serialized form needs a CSR because it was
> non-transient in JDK 15.
> The intent is to not use the serialized value, so the readObject method
> should zero
- Mail original -
> De: "Nir Lisker"
> À: "core-libs-dev"
> Envoyé: Lundi 14 Septembre 2020 20:56:27
> Objet: 'Find' method for Iterable
> Hi,
>
> This has probably been brought up at some point. When we need to find an
> item in a collection based on its properties, we can either do
On Wed, 16 Sep 2020 17:51:18 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing Roger's comments.
>
> Looks in line with the discussion on core-libs.
Removing hashcode from the
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote:
> JDK-8230652
> Extracting the commands displayed by verbose output (including commands
> called thru ToolProvider) , to contain the the
> command, it's output, and it's return value on separate lines and formatted
> in a way that they can
On Tue, 15 Sep 2020 18:57:55 GMT, Yumin Qi wrote:
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by
> jlink.
Ian Graves
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by
> jlink.
Ian Graves
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing Roger's comments.
-
Changes:
-
On Wed, 16 Sep 2020 17:47:17 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing Roger's comments.
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:
>
>> 1151:
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Looks in line with the discussion on core-libs.
-
Marked as reviewed by lancea (Reviewer).
PR:
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
Changes requested by rriggs (Reviewer).
src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1153:
Hi,
Please review the fix to the issue wrt missing hashCode() javadoc, which was
recently discussed in core-libs ml.
-
Commit messages:
- 8253240: No javadoc for DecimalFormatSymbols.hashCode()
Changes: https://git.openjdk.java.net/jdk/pull/208/files
Webrev:
On Tue, 15 Sep 2020 14:30:03 GMT, Alan Bateman wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Comparator cleanup
>
> The update using flatMap looks good. I think we need to explore adding more
> tests if possible.
On Fri, 11 Sep 2020 14:17:45 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for this patch which fixes the issue
> reported in
> https://bugs.openjdk.java.net/browse/JDK-8244706?
> The commit here sets the `OS` header flag to `255` (which represents
> `unknown`) as noted in
I created a JIRA issue for this:
https://bugs.openjdk.java.net/browse/JDK-8253240
Naoto
On 9/16/20 2:11 AM, Pavel Rappo wrote:
On 15 Sep 2020, at 21:50, Rob Spoor wrote:
On 15/09/2020 22:02, Pavel Rappo wrote:
On 15 Sep 2020, at 20:50, Brian Burkhalter wrote:
On Sep 15, 2020, at
On Wed, 9 Sep 2020 12:53:41 GMT, Galder Zamarreño
wrote:
>> Ah yes, my bad 臘♂️
>
> Updated PR.
@galderz did you really update the PR? I still see the _storeFence_ before the
write.
-
PR: https://git.openjdk.java.net/jdk/pull/94
On Tue, 15 Sep 2020 16:54:29 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unintended file commit
>
> Thank you for making the changes that Brent and I suggested. This looks
> good.
> On 15 Sep 2020, at 21:50, Rob Spoor wrote:
>
> On 15/09/2020 22:02, Pavel Rappo wrote:
>>> On 15 Sep 2020, at 20:50, Brian Burkhalter
>>> wrote:
>>>
On Sep 15, 2020, at 12:38 PM, Kevin Rushforth
wrote:
I see this in DecimalFormatSymbols:
/**
On Tue, 15 Sep 2020 19:40:28 GMT, Phil Race wrote:
>> This issue relates to JDK-8250639 '☂ Address reliance on default
>> constructors in the java.desktop module'. The
>> following classes have had an explicit no-arg constructor added, with a
>> protected access modifier and accompanying API
On Tue, 15 Sep 2020 15:18:20 GMT, Rafael Winterhalter
wrote:
>> This patch assures that an annotation on a type bound is placed on the
>> correct bound index.
>
> Rafael Winterhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The
> incremental
On Tue, 15 Sep 2020 20:02:38 GMT, Coleen Phillimore wrote:
>> The change fixes a 'deadlock' situation in
>> VM_RedefineClasses::lock_classes() when the current thread is in the middle
>> of redefining the same class. The change is based on the fix [1] suggested
>> in the Jira issue [2]
On Tue, 15 Sep 2020 20:02:33 GMT, Coleen Phillimore wrote:
>> The change fixes a 'deadlock' situation in
>> VM_RedefineClasses::lock_classes() when the current thread is in the middle
>> of redefining the same class. The change is based on the fix [1] suggested
>> in the Jira issue [2]
24 matches
Mail list logo
