On Tue, 10 Nov 2020 21:26:59 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the fix for JDK-8256018 which addresses the issue that the
> update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
> Reference.reachabilityFence to ensure that direct byte buffer are kept kept
>
On Tue, 10 Nov 2020 14:16:22 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Tue, 10 Nov 2020 18:36:22 GMT, Aleksey Shipilev wrote:
>> Hui Shi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Tue, 10 Nov 2020 18:28:11 GMT, Aleksey Shipilev wrote:
>> Hui Shi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
> …AccessorImpl object
>
> We met real problem when using protobuf with option optimized for code size,
> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>
> Optimize solution is adding a new boolean field to detect concurrent method
> accessor generation in same
> …AccessorImpl object
>
> We met real problem when using protobuf with option optimized for code size,
> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>
> Optimize solution is adding a new boolean field to detect concurrent method
> accessor generation in same
This is regression from JDK-8242302 and for some reason removing -psn argument
code was removed during refactoring. Fixed be adding removing -psn argument
back. Also, test was added to test this functionality.
-
Commit messages:
- 8255947: [macos] Signed macOS jpackage app doesn't
> …AccessorImpl object
>
> We met real problem when using protobuf with option optimized for code size,
> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>
> Optimize solution is adding a new boolean field to detect concurrent method
> accessor generation in same
On Fri, 6 Nov 2020 18:41:15 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote:
> Please review this small change to add a cgroups keyword to tests that use
> cgroups. The fix was tested by running Mach5 container tests.
Hi Harold,
The fix looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn
On Fri, 23 Oct 2020 17:47:36 GMT, Jorn Vernee wrote:
> Hi,
>
> This patch adds an asExact() combinator to VarHandle, that will return a new
> VarHandle that performs exact type checks, similar to
> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage,
> which can lead
On Fri, 6 Nov 2020 21:59:51 GMT, Alexey Semenyuk wrote:
> 822: Need to create exploded tests covering all forms of modules
This pull request has now been integrated.
Changeset: d6f1463c
Author:Alexey Semenyuk
URL: https://git.openjdk.java.net/jdk/commit/d6f1463c
Stats: 65
On Tue, 10 Nov 2020 21:26:59 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the fix for JDK-8256018 which addresses the issue that the
> update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
> Reference.reachabilityFence to ensure that direct byte buffer are kept kept
>
On Tue, 10 Nov 2020 14:16:22 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
Hi,
Please review the fix for JDK-8256018 which addresses the issue that the
update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
Reference.reachabilityFence to ensure that direct byte buffer are kept kept
alive when they are accessed directly.
The Mach5 jdk-tier1,
Please review this small change to add a cgroups keyword to tests that use
cgroups. The fix was tested by running Mach5 container tests.
-
Commit messages:
- 8255787: Tag container tests that use cGroups with cgroups keyword
Changes:
On Mon, 9 Nov 2020 16:31:23 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 121:
>>
>>> 119: upcall_info.upcall_method.name,
>>> upcall_info.upcall_method.sig,
>>> 120: , thread);
>>> 121: }
>>
>>
On Fri, 6 Nov 2020 21:59:51 GMT, Alexey Semenyuk wrote:
> 822: Need to create exploded tests covering all forms of modules
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1103
On Mon, 9 Nov 2020 01:37:39 GMT, Naoto Sato wrote:
>> I've had a look tonight, but found two more problems!
>>
>> The comments at the start of `resolveTimeLenient()` indicate that setting
>> the midpoint in `resolveTimeFields()` is a bad idea - it needs to be done
>> inside
> Hi,
>
> Please review the changes for the subject issue. This is to enhance the
> java.time package to support day periods, such as "in the morning", defined
> in CLDR. It will add a new pattern character 'B' and its supporting builder
> method. The motivation and its spec are in this CSR:
>
On Sun, 8 Nov 2020 05:07:07 GMT, Hui Shi wrote:
>> …AccessorImpl object
>>
>> We met real problem when using protobuf with option optimized for code size,
>> detail in JBS https://bugs.openjdk.java.net/browse/JDK-8255883
>>
>> Optimize solution is adding a new boolean field to detect
On Fri, 6 Nov 2020 21:59:51 GMT, Alexey Semenyuk wrote:
> 822: Need to create exploded tests covering all forms of modules
looks good.
-
Marked as reviewed by herrick (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1103
> Hi,
>
> This patch adds an asExact() combinator to VarHandle, that will return a new
> VarHandle that performs exact type checks, similar to
> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage,
> which can lead to performance degradation.
>
> This is implemented
On Tue, 10 Nov 2020 16:27:48 GMT, Chris Hegarty wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Re-order javadoc
>
> LGTM.
>
> The test could be sprinkled with a number of assertions related to the
> invocation
Did this discussion get lost?
On Sun, Sep 20, 2020 at 1:27 AM Nir Lisker wrote:
> While it might not be difficult to add a find() method to Iterable, why
>> limit it to
>> the find operation, and what about all the other operations available on
>> Stream?
>
>
> Good question. I would say it's a
On Tue, 10 Nov 2020 17:41:28 GMT, Mandy Chung wrote:
> @ExpectedExceptions is no longer available in TestNG 7.*. Update the tests
> to use @Test(expectedExceptions = "...") instead.
This pull request has now been integrated.
Changeset: 6d8acd26
Author:Mandy Chung
URL:
On Tue, 10 Nov 2020 17:41:28 GMT, Mandy Chung wrote:
> @ExpectedExceptions is no longer available in TestNG 7.*. Update the tests
> to use @Test(expectedExceptions = "...") instead.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1145
@ExpectedExceptions is no longer available in TestNG 7.*. Update the tests
to use @Test(expectedExceptions = "...") instead.
-
Commit messages:
- 8256066: Tests use deprecated TestNG API that is no longer available in new
versions
Changes:
On Tue, 10 Nov 2020 15:02:08 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This patch adds an asExact() combinator to VarHandle, that will return a new
>> VarHandle that performs exact type checks, similar to
>> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage,
>> which can
> Hi,
>
> This patch adds an asExact() combinator to VarHandle, that will return a new
> VarHandle that performs exact type checks, similar to
> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage,
> which can lead to performance degradation.
>
> This is implemented
On Mon, 9 Nov 2020 04:10:30 GMT, David Holmes wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 64 commits:
>>
>> - Merge branch '8254162' into 8254231_linker
>> - Fix post-merge issues caused by
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Sun, 8 Nov 2020 16:58:24 GMT, Phil Race wrote:
> You reference a desktop bug that discusses many, many deprecations ...
Yep. In my opinion this is a bot problem here and need other place to discuss.
> Yet you propose to fix precisely one of these.
@prrace: Not really.
The way to work with
On Mon, 9 Nov 2020 16:07:13 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the third incubation round
>> of the foreign memory access API incubation (see JEP 393 [1]). This
>> iteration focus on improving the usability of the API in 3 main ways:
>>
>> *
Finalizer calls Reference.get() from the Finalizer to acquire the finalizee.
Concurrent reference processing GCs like Shenandoah and ZGC would return NULL
for unreachable referents, and thus would not call finalize() on them.
ZGC works around this by fixing the referent before enqueuing, so
On Sun, 8 Nov 2020 15:55:58 GMT, Peter Levart wrote:
>> Hi Stuart,
>>
>> I would like to discuss the serialization. You introduce new
>> CollSer.IMM_LIST_NULLS type of immutable collection. This means that if this
>> change goes into JDK16 for example, JDK15 and before will not be able to
>>
37 matches
Mail list logo
