On Thu, 21 Jan 2021 19:57:04 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one additi
On Thu, 21 Jan 2021 22:43:50 GMT, Naoto Sato wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reduce code duplication in getBytes/getBytesNoRepl
>
> Marked as reviewed by naoto (Reviewer).
Passed testing tiers 1-
On Fri, 15 Jan 2021 14:33:19 GMT, Claes Redestad wrote:
> The `StringCoding.resultCached` mechanism is used to remove the allocation of
> a `StringCoding.Result` object on potentially hot paths used in some `String`
> constructors. Using a `ThreadLocal` has overheads though, and the overhead
>
On Thu, 21 Jan 2021 16:54:36 GMT, Paul Sandoz wrote:
>>> Unfortunately it is still problematic because you have replaced the
>>> intrinsic check (that performed by `Object.checksIndex`, or more
>>> specifically
>>> [here](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/j
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2191
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
src/java.base/share/classes/java/time/zone/ZoneRules.java line 263:
> 261: // last rules
> 262: Object[] temp = lastRules.toArray();
> 263: ZoneOffsetTransitionRule[] rul
On Fri, 22 Jan 2021 02:57:36 GMT, Hamlin Li wrote:
> this is minor optimization following JDK-8254078.
> based on my tests with jmh, it has better performance when apply following
> patch:
>
> diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java
> b/src/java.base/share/classe
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one additi
On Fri, 22 Jan 2021 02:57:36 GMT, Hamlin Li wrote:
> this is minor optimization following JDK-8254078.
> based on my tests with jmh, it has better performance when apply following
> patch:
>
> diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java
> b/src/java.base/share/classe
> https://bugs.openjdk.java.net/browse/JDK-8183372
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
NonJavaName Tests updated
Used newInstance() method to create the different EnclosingClasses at runtime
-
Changes:
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2191
On Thu, 21 Jan 2021 05:19:00 GMT, Brent Christian wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Can this be done all in `EnclosingClassTest.java`, without a new
> `RunEnclosingClassTest.java`?
>
> Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may
> j
On Fri, 22 Jan 2021 14:48:00 GMT, Daniel Fuchs wrote:
>> Tighten up argument checking in constructor.
>
> src/java.base/share/classes/java/time/zone/ZoneRules.java line 263:
>
>> 261: // last rules
>> 262: Object[] temp = lastRules.toArray();
>> 263: ZoneOffsetTransitionR
On Fri, 22 Jan 2021 15:00:17 GMT, Florent Guillaume
wrote:
>> src/java.base/share/classes/java/time/zone/ZoneRules.java line 263:
>>
>>> 261: // last rules
>>> 262: Object[] temp = lastRules.toArray();
>>> 263: ZoneOffsetTransitionRule[] rulesArray = Arrays.copyOf(temp,
On Wed, 20 Jan 2021 18:29:00 GMT, Johannes Kuhn
wrote:
> Add explicit range check to `MethodHandles.collectArgumentsCheck`.
> Added test case that exercises all cases.
>
> This is a behavioral change, from throwing an unspecified exception to
> throwing an IllegalArgumentException, as specif
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one additi
On Fri, 22 Jan 2021 18:16:52 GMT, Daniel Fuchs wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> LGTM. Thanks for taking this on!
I will sponsor this!
-
PR: https://git.open
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote:
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
This pull request has now been integrated.
Changeset: 874aef4a
Author:Alex
On Fri, 22 Jan 2021 16:52:02 GMT, Mahendra Chhipa
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8183372
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> NonJavaName Tests updated
> Used newInstance() method to cre
On Fri, 22 Jan 2021 17:12:34 GMT, Daniel Fuchs wrote:
>> Or even maybe `rulesArray =
>> lastRules.toArray(ZoneOffsetTransitionRule[]::new);`?
>
> Good point - but that would be:
>
> ZoneOffsetTransitionRule[] rulesArray =
> lastRules.toArray(ZoneOffsetTransitionRule[]::new).clone();
Interesti
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote:
> Tighten up argument checking in constructor.
This pull request has now been integrated.
Changeset: a8871776
Author:Stuart Marks
URL: https://git.openjdk.java.net/jdk/commit/a8871776
Stats: 90 lines in 2 files changed: 87 ins
On Mon, 18 Jan 2021 11:03:06 GMT, Martin Buchholz wrote:
>> 8252412: [macos11] system dynamic libraries removed from filesystem
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared t
Please review the implementation of JEP 391: macOS/AArch64 Port.
It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
windows/aarch64.
Major changes are in:
* src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
JDK-8253817, JDK-8253818)
* src/hotspot/os
On Fri, 22 Jan 2021 19:46:13 GMT, Jiangli Zhou wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> src/java.smartcardio/unix/classes/s
My github comment was mangled forwarding to core-libs. I suspect the skara
bidirectional mailing list forwarding bot discards lines with leading "/"
.
Instead the bot should pass on unrecognized github comment commands
unmodified.
On Fri, Jan 22, 2021 at 12:12 PM Martin Buchholz
wrote:
> On Fr
On Fri, 22 Jan 2021 16:57:41 GMT, Mahendra Chhipa
wrote:
>> Can this be done all in `EnclosingClassTest.java`, without a new
>> `RunEnclosingClassTest.java`?
>>
>> Adding the `@BeforeClass` and `@AfterClass` methods to what's there, you may
>> just need to
>> change the `test()` calls to use
On Fri, 22 Jan 2021 18:49:42 GMT, Anton Kozlov wrote:
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new ca
On Fri, 15 Jan 2021 23:50:16 GMT, Alex Menkov wrote:
> The fix adds NMT handling for non-java launchers
This pull request has now been integrated.
Changeset: bdc305e1
Author:Alex Menkov
URL: https://git.openjdk.java.net/jdk/commit/bdc305e1
Stats: 30 lines in 2 files changed: 16 i
On Fri, 22 Jan 2021 20:08:48 GMT, Martin Buchholz wrote:
>> src/java.smartcardio/unix/classes/sun/security/smartcardio/PlatformPCSC.java
>> line 132:
>>
>>> 130: // existence of the containing directory instead of the file.
>>> 131: lib = PCSC_FRAMEWORK;
>>> 132: if (new
On Mon, 18 Jan 2021 11:03:06 GMT, Martin Buchholz wrote:
>> 8252412: [macos11] system dynamic libraries removed from filesystem
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared t
On Fri, 22 Jan 2021 22:16:28 GMT, Jiangli Zhou wrote:
>> The directory structure is intact - only the file is removed from the
>> filesystem.
>> More generally, for many frameworks, where there used to be
>>
>>
>> the file is gone, but
>>
>>
>> remains.
>>
>> I don't think we need a jtreg
On Fri, 22 Jan 2021 22:56:08 GMT, Jiangli Zhou wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> Marked as reviewed by jiangli (Revi
On Fri, 22 Jan 2021 22:55:22 GMT, Jiangli Zhou wrote:
>> Ok, I see Java_sun_security_smartcardio_PlatformPCSC_initialize does dlopen
>> using the 'jLibName' (string) obtained from getLibraryName() and throws
>> IOException if dlopen fails. The change seems safe enough.
>>
>> I'm wondering if y
On Mon, 18 Jan 2021 11:03:06 GMT, Martin Buchholz wrote:
>> 8252412: [macos11] system dynamic libraries removed from filesystem
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared t
On Fri, 22 Jan 2021 16:21:05 GMT, Brian Burkhalter wrote:
>> this is minor optimization following JDK-8254078.
>> based on my tests with jmh, it has better performance when apply following
>> patch:
>>
>> diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java
>> b/src/java.base
On Fri, 22 Jan 2021 02:57:36 GMT, Hamlin Li wrote:
> this is minor optimization following JDK-8254078.
> based on my tests with jmh, it has better performance when apply following
> patch:
>
> diff --git a/src/java.base/share/classes/java/io/DataOutputStream.java
> b/src/java.base/share/classe
37 matches
Mail list logo
