On Fri, 12 Feb 2021 12:40:09 GMT, Florian Weimer wrote:
>> only macos comiplers
>
> The comment is also wrong for glibc: The AArch64 ABI requires a 64 KiB guard
> region independently of page size, otherwise `-fstack-clash-protection` is
> not reliable.
Thanks, I deleted the comment. It descri
On Fri, 12 Feb 2021 13:32:52 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>>
>>> 484: }
>>> 485: }
>>> 486: }
>>
>> This appears to be a mix for Mavericks (10.9) and 10.12
>> work arounds. Is this code needed by this project?
>
> I
On Tue, 2 Feb 2021 22:18:43 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/thread_bsd_aarch64.cpp line 43:
>
>> 41: ass
On Tue, 2 Feb 2021 22:47:04 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/prims/nativeEntryPoint.cpp line 45:
>
>> 43: guarantee(st
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
> For platform files that were copied from other ports to this port, if the
> file wasn't
> changed I presume the copyright years are left alone. If the file required
> changes
> for this port, I expect the year to be updated to 2021.
On Wed, 17 Feb 2021 19:44:35 GMT, Attila Szegedi wrote:
> 8261483: jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with
> "AssertionError: Should have GCd a method handle by now"
This pull request has now been integrated.
Changeset: d185a6c5
Author:Attila Szegedi
URL: ht
On Mon, 1 Mar 2021 11:09:31 GMT, Peter Levart wrote:
>> Attila Szegedi has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
>> commit
> This PR is to introduce a new random number API for the JDK. The primary API
> is found in RandomGenerator and RandomGeneratorFactory. Further description
> can be found in the JEP https://openjdk.java.net/jeps/356 .
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/a
On Thu, 4 Feb 2021 22:15:47 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Mar 2021 06:29:07 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 2 Mar 2021 06:29:07 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Thu, 25 Feb 2021 09:31:01 GMT, Jie Fu wrote:
> Hi all,
>
> Vector API fails to work when:
> - case 1: MaxVectorSize is set to <=8, or
> - case 2: C2 is disabled
>
> The reason is that {max/preferred} VectorShape initialization fails in both
> cases.
> And the root cause is that VectorSupp
On Tue, 2 Mar 2021 02:11:08 GMT, Jie Fu wrote:
>> Hi all,
>>
>> Vector API fails to work when:
>> - case 1: MaxVectorSize is set to <=8, or
>> - case 2: C2 is disabled
>>
>> The reason is that {max/preferred} VectorShape initialization fails in both
>> cases.
>> And the root cause is that Ve
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
> 1. I fixed a problem with overflow checking. In the or
On Tue, 2 Mar 2021 15:05:51 GMT, Pavel Rappo wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year.
>
> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 579:
>
>> 577: /**
On Fri, 4 Dec 2020 06:50:14 GMT, Stuart Marks wrote:
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
>
Please review some minor doc fixes, for issues found by _doccheck_.There
are two kinds of errors that are addressed.
1. Incorrect use of ``. In HTML, `` marks the *beginning* of a paragraph.
It is not a terminator, to mark the end of a paragraph, or a separator to mark
the boundary between
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
> when the app modules have already been jlinked with the runtime, and there is
> no need for module-path, jpackage was acting as if the module-path was "."
> and picking up jars in the current directory.
Andy Herrick has updated the pull request incrementally with one additional
commit since t
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
Hello,
Actually, in HTML was a separator, and in xhtml it should enclose
paragraphs. However I was under the impression Javadoc always used the
separator style (it would be strange to start the first sentence in Javadoc
with . Is this doccheck enforcing a new policy?
This officially Oracle gu
On Thu, 4 Feb 2021 22:34:16 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
Bernd,
With respect, I disagree.
There is a difference between `text` and
`text`.
Anyway, the significant comment in this context is that it is being used
as a terminator, at the logical end of the paragraph.
doccheck is using the standard `htmltidy` command to detect issues in
HTML, and
On Tue, 2 Mar 2021 19:35:47 GMT, Jonathan Gibbons wrote:
> Please review some minor doc fixes, for issues found by _doccheck_.There
> are two kinds of errors that are addressed.
>
> 1. Incorrect use of ``. In HTML, `` marks the *beginning* of a
> paragraph. It is not a terminator, to mark
On Fri, 12 Feb 2021 15:21:06 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 302:
>>
>>> 300: const uint64_t *detail_msg_ptr
>>> 301: = (uint64_t*)(pc + NativeInstruction::instruction_size);
>>> 302: const char *detail_msg = (const
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Thu, 4 Feb 2021 22:58:39 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
Please review a trivial fix to insert a missing word.
-
Commit messages:
- JDK-8262892: minor typo in implSpec comment
Changes: https://git.openjdk.java.net/jdk/pull/2798/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2798&range=00
Issue: https://bugs.openjdk.java.ne
On Tue, 2 Mar 2021 22:01:49 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to insert a missing word.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2798
On Tue, 2 Mar 2021 17:17:37 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Add VectorShape.getMaxVectorBitSize
>
> Marked as reviewed by psandoz (Reviewer).
> The `PreferredSpeciesTest` also needs to b
On Tue, 2 Mar 2021 22:01:49 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to insert a missing word.
This pull request has now been integrated.
Changeset: 93ffe6a6
Author:Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/93ffe6a6
Stats: 1 line in 1 file ch
On Tue, 2 Mar 2021 21:19:18 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Thu, 25 Feb 2021 09:31:01 GMT, Jie Fu wrote:
> Hi all,
>
> Vector API fails to work when:
> - case 1: MaxVectorSize is set to <=8, or
> - case 2: C2 is disabled
>
> The reason is that {max/preferred} VectorShape initialization fails in both
> cases.
> And the root cause is that VectorSupp
On Tue, 2 Mar 2021 19:47:04 GMT, Andy Herrick wrote:
>> when the app modules have already been jlinked with the runtime, and there
>> is no need for module-path, jpackage was acting as if the module-path was
>> "." and picking up jars in the current directory.
>
> Andy Herrick has updated the p
On Wed, 3 Mar 2021 00:40:09 GMT, Alexey Semenyuk wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8261518: jpackage looks for main module in current dir when there is
>> no module-path
>
> Changes requested by
On Fri, 26 Feb 2021 14:25:09 GMT, Maurizio Cimadamore
wrote:
> This simple fix reduces the amount of concurrency on the foreign memory
> TestHandshake test. As this test spins a new accessor thread for each
> available processors, on machines which feature an high number of available
> proces
I considered @stuart-marks previous suggestion during the code review of
JDK-8261123 to include a more explicit discussion of why, say, different
representations of 2 should not be regarded as equivalent. After contemplating
several alternatives, I didn't find anything simpler than Stuart's 2/3
38 matches
Mail list logo
