Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread Jim Laskey
I’ll remove the code and elucidate in the commentary.  > On Apr 3, 2021, at 8:08 PM, David Holmes wrote: > > On 4/04/2021 12:02 am, Jim Laskey wrote: >> Is it in bad form to declare a #define CLOSE_JIMAGE 0 ? > > Still dead code. > > This is a core-libs style call anyway. > > Cheers, >

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread David Holmes
On 4/04/2021 12:02 am, Jim Laskey wrote: Is it in bad form to declare a #define CLOSE_JIMAGE 0 ? Still dead code. This is a core-libs style call anyway. Cheers, David  On Apr 3, 2021, at 9:49 AM, David Holmes wrote: On 2/04/2021 5:34 pm, Alan Bateman wrote: On Thu, 1 Apr 2021

Re: 8214761: Bug in parallel Kahan summation implementation

2021-04-03 Thread Anirvan Sarkar
Hi Pavel, I think I have the same issue as Chris. The new OCA contributors list [1] is incorrectly linking the user names to GitHub as compared to the old contributors list [2]. It seems the new OCA contributors list is assuming that the GitHub username of past contributors is the same as the

Re: 8214761: Bug in parallel Kahan summation implementation

2021-04-03 Thread Chris Dennis
I’m pretty certain that is meant to be me but ‘chris_dennis’ is a now defunct java.net username and not a Github one. The username appears in this list https://oca.opensource.oracle.com/?ojr=old-contrib-list#t too as: “Terracotta Inc. (Christopher Dennis), OpenJDK, chris_dennis”. My Github

Re: 8214761: Bug in parallel Kahan summation implementation

2021-04-03 Thread Pavel Rappo
Hey Chris, I don't know exactly what triggers removal of the "oca" and "oca-verify" labels. The only OCA entry for Chris Dennis I could find [1] had a different GitHub username. Did you mistype it or it belongs to another person? Mind you, that person's GitHub page is 404. -Pavel [1]

Re: 8214761: Bug in parallel Kahan summation implementation

2021-04-03 Thread Chris Dennis
A gentle prod. Am I misunderstanding procedure here? From: Chris Dennis Date: Monday, March 22, 2021 at 2:28 PM To: core-libs-dev Subject: 8214761: Bug in parallel Kahan summation implementation I created a PR for 8214761: https://github.com/openjdk/jdk/pull/2988 - but have been stuck waiting

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread Jim Laskey
Is it in bad form to declare a #define CLOSE_JIMAGE 0 ?  > On Apr 3, 2021, at 9:49 AM, David Holmes wrote: > > On 2/04/2021 5:34 pm, Alan Bateman wrote: >> On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote: src/java.base/share/native/libjimage/imageFile.cpp line 219: > 217:

Re: RFR: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

2021-04-03 Thread David Holmes
On 2/04/2021 5:34 pm, Alan Bateman wrote: On Thu, 1 Apr 2021 18:48:15 GMT, Jim Laskey wrote: src/java.base/share/native/libjimage/imageFile.cpp line 219: 217: // WARNING: Should never close the jimage file. 218: // Threads may still be running at shutdown. 219: #if 0 Are you

Faster double parser?

2021-04-03 Thread Carfield Yim
HI all, just aware of this project, https://github.com/wrandelshofer/FastDoubleParser, not sure if it good idea to use this as default Double Parser in JVM?