On Wed, 28 Apr 2021 00:44:19 GMT, Ioi Lam wrote:
>> Please review this change to the String Deduplication facility. It is being
>> changed to use OopStorage to hold weak references to relevant objects,
>> rather than bespoke data structures requiring dedicated processing phases by
>> supporting
On Tue, 27 Apr 2021 20:25:32 GMT, Brian Burkhalter wrote:
>> Please consider this request to modify `Reader.read(CharBuffer)` to check
>> whether the buffer is read-only before reading any characters from the
>> character stream. This can happen now if the buffer is read-only. Character
>> are
We can see compiler warnings in jni_util.c as following on GCC 11. `buf` should
be initialized.
-
Commit messages:
- 8266173: -Wmaybe-uninitialized happens in jni_util.c
Changes: https://git.openjdk.java.net/jdk/pull/3742/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr
On 4/27/21 9:17 AM, Anthony Vanelverdinghe wrote:
On Tuesday, April 27, 2021 11:25 CEST, Peter Levart
wrote:
Now just some of my thoughts about the proposal:
- SortedSet.addFirst/.addLast - I think an operation that would be used
in situations like: "I know this element should always be gr
jdeps should print "JDK removed internal APIs" to give an informative
description when a JDK internal API that is being referenced has been removed.
JDK-8213909 incorrectly changed it to print `jdk8internals`.
An example output is:
classes -> jdk8internals
p.Main
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3734
On Tue, 27 Apr 2021 22:47:06 GMT, Coleen Phillimore wrote:
>> Please review this change to the String Deduplication facility. It is being
>> changed to use OopStorage to hold weak references to relevant objects,
>> rather than bespoke data structures requiring dedicated processing phases by
>> s
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On 4/27/21 2:25 AM, Peter Levart wrote:
Right, I'm persuaded. Now if only the problems of transition to the usage of new
type that Remi is worried about were mild enough. Source (in)compatibility is not
that important if workarounds exist that are also backwards source compatible so
that the
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Update the CSR. See Update 03 in the CSR
-
Changes:
- all: https://git.openjdk.java.ne
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3734
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Looks all right.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3734
8266155: Convert java.base to use Stream.toList()
-
Commit messages:
- Migrating java.base to use Stream.toList()
Changes: https://git.openjdk.java.net/jdk/pull/3734/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3734&range=00
Issue: https://bugs.openjdk.java.net/bro
On Tue, 27 Apr 2021 20:25:32 GMT, Brian Burkhalter wrote:
>> Please consider this request to modify `Reader.read(CharBuffer)` to check
>> whether the buffer is read-only before reading any characters from the
>> character stream. This can happen now if the buffer is read-only. Character
>> are
> Please consider this request to modify `Reader.read(CharBuffer)` to check
> whether the buffer is read-only before reading any characters from the
> character stream. This can happen now if the buffer is read-only. Character
> are first read thereby advancing the stream before an attempt is ma
On Tue, 27 Apr 2021 18:46:02 GMT, Alan Bateman wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.n
On Tue, 27 Apr 2021 19:07:45 GMT, Igor Ignatyev wrote:
> > I guess this should really be named `isJVMCICompilerEnabled` now and the
> > `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but
> > maybe that's too big a change (or can be done later).
>
> @dougxc, I don't think th
On Tue, 27 Apr 2021 19:31:40 GMT, Roger Riggs wrote:
>> Please consider this request to modify `Reader.read(CharBuffer)` to check
>> whether the buffer is read-only before reading any characters from the
>> character stream. This can happen now if the buffer is read-only. Character
>> are firs
On Tue, 27 Apr 2021 18:47:41 GMT, Brian Burkhalter wrote:
> Please consider this request to modify `Reader.read(CharBuffer)` to check
> whether the buffer is read-only before reading any characters from the
> character stream. This can happen now if the buffer is read-only. Character
> are fir
On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon wrote:
> I guess this should really be named `isJVMCICompilerEnabled` now and the
> `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but maybe
> that's too big a change (or can be done later).
@dougxc, I don't think that we should
Please consider this request to modify `Reader.read(CharBuffer)` to check
whether the buffer is read-only before reading any characters from the
character stream. This can happen now if the buffer is read-only. Character are
first read thereby advancing the stream before an attempt is made to pu
> Please consider this request to correct a minor problem with the optimization
> added for JDK-4926314. The change is to attempt to read the number of
> elements remaining in the target buffer unless that number is non-positive in
> which case read zero. The test addition fails without and pass
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Tue, 27 Apr 2021 17:56:04 GMT, Jatin Bhateja wrote:
> Current VectorAPI Java side implementation expresses rotateLeft and
> rotateRight operation using following operations:-
>
> vec1 = lanewise(VectorOperators.LSHL, n)
> vec2 = lanewise(VectorOperators.LSHR, n)
> res = lanewise(
On Tue, 27 Apr 2021 01:26:53 GMT, Brian Burkhalter wrote:
> Please consider this request to correct a minor problem with the optimization
> added for JDK-4926314. The change is to attempt to read the number of
> elements remaining in the target buffer unless that number is non-positive in
> wh
Current VectorAPI Java side implementation expresses rotateLeft and rotateRight
operation using following operations:-
vec1 = lanewise(VectorOperators.LSHL, n)
vec2 = lanewise(VectorOperators.LSHR, n)
res = lanewise(VectorOperations.OR, vec1 , vec2)
This patch moves above handling fr
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
This PR contains the API and implementation changes for JEP-412 [1]. A more
detailed description of such changes, to avoid repetitions during the review
process, is included as a separate comment.
[1] - https://openjdk.java.net/jeps/412
-
Commit messages:
- Add linker test exclude
On Tue, 27 Apr 2021 00:20:49 GMT, Ian Graves wrote:
> 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3705
On Tue, 27 Apr 2021 00:20:49 GMT, Ian Graves wrote:
> 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3705
On Tuesday, April 27, 2021 11:25 CEST, Peter Levart
wrote:
> Now just some of my thoughts about the proposal:
>
> - SortedSet.addFirst/.addLast - I think an operation that would be used
> in situations like: "I know this element should always be greater than
> any existing element in the set and
On Tue, 27 Apr 2021 00:20:49 GMT, Ian Graves wrote:
> 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3705
Hi,
Not sure if this will end up in the right mailing list thread but let's see.
I just read quickly the proposal and it made me think about another common
issue. I wonder if we could tackle it as well.
I will call it the "find the first element when there is only one" problem.
It happens on un
On Tue, 27 Apr 2021 09:17:43 GMT, Сергей Цыпанов
wrote:
> > Also be careful not to return a string which
> > is not interned (which would happen if you did what you are proposing
> > above).
>
> Ok, I'm probably missing something, but when we move `String.intern()` call
> to `this.packageName
On Thu, 22 Apr 2021 15:08:59 GMT, Jaroslav Bachorik
wrote:
>> I wonder if something similar to below could be added to
>> jdk.jfr.internal.Utils:
>>
>> private static Metrics[] metrics;
>> public static Metrics getMetrics() {
>> if (metrics == null) {
>> metrics = n
> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Remove unnecessary constructor.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3469/files
On Tue, 27 Apr 2021 10:44:10 GMT, Jim Laskey wrote:
>> True that. There are also some mentions in the comments.
>
> Thank you.
Please mark the CSR as reviewed.
-
PR: https://git.openjdk.java.net/jdk/pull/3469
On Thu, 15 Apr 2021 12:17:46 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line
>> 1656:
>>
>>> 1654: // Methods required by class AbstractSpliteratorGenerator
>>> 1655:
>>> 1656: protected Spliterator.OfInt makeIntsSpliterato
On Wed, 21 Apr 2021 13:13:16 GMT, Jim Laskey wrote:
>> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
>
> Jim Laskey has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the
On Tue, 27 Apr 2021 01:26:53 GMT, Brian Burkhalter wrote:
> Please consider this request to correct a minor problem with the optimization
> added for JDK-4926314. The change is to attempt to read the number of
> elements remaining in the target buffer unless that number is non-positive in
> wh
On Thu, 22 Apr 2021 16:00:32 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>> turn
On 4/27/21 5:50 AM, Stuart Marks wrote:
On 4/25/21 11:09 AM, Peter Levart wrote:
When making this proposition, I was only thinking of how to enable
new yet-nonexistent operations on collections that have order / are
reversible and that the code calling these methods would already
knows that
On Mon, 26 Apr 2021 14:12:01 GMT, Peter Levart wrote:
> Also be careful not to return a string which
is not interned (which would happen if you did what you are proposing
above).
Ok, I'm probably missing something, but when we move `String.intern()` call to
`this.packageName = pn.intern();` the
On Thu, 22 Apr 2021 15:08:59 GMT, Jaroslav Bachorik
wrote:
>> I wonder if something similar to below could be added to
>> jdk.jfr.internal.Utils:
>>
>> private static Metrics[] metrics;
>> public static Metrics getMetrics() {
>> if (metrics == null) {
>> metrics = n
46 matches
Mail list logo
