On Thu, 27 May 2021 11:19:24 GMT, Сергей Цыпанов
wrote:
>> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
>> null-checks remaining after
>> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
>> Class.getPackageName() never returns null.
>
> Сергей Цыпанов
On Thu, 27 May 2021 16:28:14 GMT, Maxim Kartashev
wrote:
>> src/hotspot/os/windows/os_windows.cpp line 1541:
>>
>>> 1539: void * os::dll_load(const char *utf8_name, char *ebuf, int ebuflen) {
>>> 1540: LPWSTR utf16_name = NULL;
>>> 1541: errno_t err = convert_UTF8_to_UTF16(utf8_name, &utf16
On Fri, 28 May 2021 03:12:35 GMT, Phil Race wrote:
>> There *is* a tiny refactoring here: a new variable `s2` is introduced so the
>> 2nd `doPrivileged` call on line 636 is now also in a declaration statement
>> (for `s2`) and therefore annotatable. Without this I cannot add the
>> annotation
On Fri, 28 May 2021 02:50:55 GMT, Weijun Wang wrote:
>> src/java.desktop/share/classes/java/awt/Component.java line 630:
>>
>>> 628: }
>>> 629:
>>> 630: @SuppressWarnings("removal")
>>
>> I'm confused. I thought the reason this wasn't done in the JEP
>> implementation PR is be
On Thu, 27 May 2021 17:42:56 GMT, Phil Race wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update FtpClient.java
>
> src/java.desktop/share/classes/java/awt/Component.java line 630:
>
>> 628: }
>> 629:
>>
On Thu, 27 May 2021 22:05:55 GMT, Leonid Mesnik wrote:
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
@lmesnik , ho
On Thu, 27 May 2021 20:16:25 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Sat, 10 Apr 2021 06:30:33 GMT, Tagir F. Valeev wrote:
> With the introduction of `toList()`, preserving the SIZED characteristics in
> more cases becomes more important. This patch preserves SIZED on `skip()` and
> `limit()` operations, so now every combination of
> `map/mapToX/boxed/asXyzS
> With the introduction of `toList()`, preserving the SIZED characteristics in
> more cases becomes more important. This patch preserves SIZED on `skip()` and
> `limit()` operations, so now every combination of
> `map/mapToX/boxed/asXyzStream/skip/limit/sorted` preserves size, and
> `toList()`,
On Thu, 27 May 2021 23:38:48 GMT, David Holmes wrote:
> Hi Leonid,
>
> What is EFH? Please update the bug and PR to explain.
>
> Thanks,
> David
Updated summary to "Improve jtreg test failure handler do get native/mixed
stack traces for cores and live processes".
-
PR: https://g
On 5/27/2021 5:03 PM, Stephen Colebourne wrote:
Hi all,
Is there anything I need to do to progress the CSR and/or PR?
The CSR is in Provisional state. To request the second phase of CSR
review, the assignee can Finalize the CSR; for more details see
https://wiki.openjdk.java.net/display
Hi all,
Is there anything I need to do to progress the CSR and/or PR?
thanks
Stephen
On Thu, 13 May 2021 at 22:05, Stephen Colebourne wrote:
>
> On Wed, 12 May 2021 at 18:41, Roger Riggs wrote:
> > Will you be posting a PR for the implementation?
> > It is frequently helpful to evaluate the CSR
On Thu, 27 May 2021 22:05:55 GMT, Leonid Mesnik wrote:
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Hi Leonid,
W
On Thu, 27 May 2021 20:25:35 GMT, Claes Redestad wrote:
>> This patch fixes a regression caused by
>> https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
>> String.join always get a UTF-16 coder if the delimiter is UTF-16, even when
>> no delimiter is emitted.
>
> Claes Redest
On Thu, 27 May 2021 17:38:42 GMT, Claes Redestad wrote:
> This patch fixes a regression caused by
> https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
> String.join always get a UTF-16 coder if the delimiter is UTF-16, even when
> no delimiter is emitted.
This pull request h
EFH is improved to process cores and get mixed stack traces with jhsdb and
native stack traces with gdb/lldb. It might be useful because hs_err doesn't
contain info about all threads, sometimes it is even not generated.
-
Commit messages:
- Merge branch 'master' of https://github.c
Modify the specification of `java.io.File.equals` to clarify that equality is
based only on a comparison of abstract pathnames as opposed to the file system
objects that the `File`s represent.
-
Commit messages:
- 8267569: java.io.File.equals contains misleading Javadoc
Changes: h
On Thu, 27 May 2021 20:17:59 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> javax/management/remote/mandatory/connection/RMIConnector_NPETest.java.
This pull request has now been integrated.
Changeset: 8a31c075
Author:Daniel D. Daugherty
URL:
https://git.openjdk.
On Thu, 27 May 2021 20:22:31 GMT, Stuart Marks wrote:
>> A trivial fix to ProblemList
>> javax/management/remote/mandatory/connection/RMIConnector_NPETest.java.
>
> Marked as reviewed by smarks (Reviewer).
@stuart-marks - Thanks for the fast review.
-
PR: https://git.openjdk.java.
On Thu, 27 May 2021 20:17:59 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> javax/management/remote/mandatory/connection/RMIConnector_NPETest.java.
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4231
A trivial fix to ProblemList
javax/management/remote/mandatory/connection/RMIConnector_NPETest.java.
-
Commit messages:
- 8267886: ProblemList
javax/management/remote/mandatory/connection/RMIConnector_NPETest.java
Changes: https://git.openjdk.java.net/jdk/pull/4231/files
Webrev:
> This patch fixes a regression caused by
> https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
> String.join always get a UTF-16 coder if the delimiter is UTF-16, even when
> no delimiter is emitted.
Claes Redestad has updated the pull request incrementally with one additional
On Mon, 19 Apr 2021 14:05:31 GMT, Сергей Цыпанов
wrote:
> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
> null-checks remaining after
> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
> Class.getPackageName() never returns null.
This pull request has
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Thu, 27 May 2021 17:38:42 GMT, Claes Redestad wrote:
> This patch fixes a regression caused by
> https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
> String.join always get a UTF-16 coder if the delimiter is UTF-16, even when
> no delimiter is emitted.
Marked as reviewed
On Thu, 27 May 2021 18:19:38 GMT, Rémi Forax wrote:
> in your example, there is no guard so no backward goto
@forax btw this example is not about switch pattern matching - it is about
already existing string switch, where indy not involed 😉
void example(java.lang.String);
descriptor:
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
Marked
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>> with
> 8267706: bin/idea.sh tries to use cygpath on WSL
Nikita Gubarkov has updated the pull request incrementally with one additional
commit since the last revision:
8267706: Break long line in make/ide/idea/jdk/idea.gmk
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4190/
This patch fixes a regression caused by
https://bugs.openjdk.java.net/browse/JDK-8265237 where the result of
String.join always get a UTF-16 coder if the delimiter is UTF-16, even when no
delimiter is emitted.
-
Commit messages:
- Fix copyright, @bug
- 8267529: StringJoiner can c
On Mon, 24 May 2021 13:53:34 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Tue, 25 May 2021 16:37:30 GMT, Nikita Gubarkov
wrote:
> 8267706: bin/idea.sh tries to use cygpath on WSL
I think this looks ok, though I'm not very familiar with the details of this
code. I also very rarely use the idea projects. It would be good if some
frequent users could take this for
On Thu, 27 May 2021 05:13:44 GMT, David Holmes wrote:
>> Maxim Kartashev has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new c
On Thu, 27 May 2021 05:18:50 GMT, David Holmes wrote:
>> Maxim Kartashev has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new c
On Thu, 27 May 2021 04:23:16 GMT, David Holmes wrote:
>> Maxim Kartashev has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR. The pull request
>> contains one new c
> Character strings within JVM are produced and consumed in several formats.
> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
> or dlopen()) consume strings also in UTF8. On Windows, however, the situation
> is far less simple: some new(er) APIs expect UTF16 (wide-ch
On Thu, 27 May 2021 15:57:27 GMT, Aleksei Efimov wrote:
>> Hi,
>>
>> `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
>> with "Address already in use" `BindException`. The reason of this failure is
>> that `disconnect` call in JNDI `DnsClient` fails to rebind the da
On Thu, 27 May 2021 15:33:00 GMT, Daniel Fuchs wrote:
> LGTM. I really wish git had a better `diff` !
> Can you add `@bug 8265309` to com/sun/jndi/dns/ConfigTests/Timeout.java since
> this is a product change?
Thanks for the review and the suggestion @dfuch . Bug ID has been added.
---
> Hi,
>
> `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
> with "Address already in use" `BindException`. The reason of this failure is
> that `disconnect` call in JNDI `DnsClient` fails to rebind the datagram
> socket to the original port during `disconnect` call
On Thu, 27 May 2021 15:33:36 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Thu, 27 May 2021 06:13:40 GMT, Tagir F. Valeev wrote:
>> With the introduction of `toList()`, preserving the SIZED characteristics in
>> more cases becomes more important. This patch preserves SIZED on `skip()`
>> and `limit()` operations, so now every combination of
>> `map/mapToX/boxed/as
On Thu, 27 May 2021 15:02:01 GMT, Aleksei Efimov wrote:
> Hi,
>
> `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
> with "Address already in use" `BindException`. The reason of this failure is
> that `disconnect` call in JNDI `DnsClient` fails to rebind the datagra
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The
On Tue, 25 May 2021 18:04:45 GMT, Stuart Marks wrote:
> This is the implementation of [JEP 407](https://openjdk.java.net/jeps/407).
>
> This is a fairly straightforward removal of this component.
> - Activation implementation classes removed
> - Activation tests removed
> - adjustments to var
Hi,
`com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
with "Address already in use" `BindException`. The reason of this failure is
that `disconnect` call in JNDI `DnsClient` fails to rebind the datagram socket
to the original port during `disconnect` call (the failure
8267706: bin/idea.sh tries to use cygpath on WSL
-
Commit messages:
- 8267706: Added shell run configurations instead of Ant for IDEA project
- 8267706: Improved IDEA project setup
- 8267706: Fix bin/idea.sh cygpath usage on WSL
Changes: https://git.openjdk.java.net/jdk/pull/4190/
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
On Wed, 26 May 2021 07:30:10 GMT, Peter Levart wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 481:
>
>> 479:
On Wed, 26 May 2021 02:36:34 GMT, David Holmes wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 497:
>
>> 495:
>> 49
> Please review this PR which fixes the deadlock in ClassLoader between the two
> lock objects - a lock object associated with the class being loaded, and the
> ClassLoader.loadedLibraryNames hash map, locked during the native library
> load operation.
>
> Problem being fixed:
>
> The initial
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch expres
On Thu, 27 May 2021 12:00:46 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8265418: Compare package names with == instead of equals()
>
> src/java.base/share/classes/sun/reflect/misc/Reflect
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it
> offends some code analysis tools.
> Although the fix is to change the condition error, it turned out that
> `JapaneseImperialCalendar.roll()` did not work for `WEE
On Thu, 27 May 2021 09:23:50 GMT, Athijegannathan Sundararajan
wrote:
> fixed constructor argument passing issue.
This pull request has now been integrated.
Changeset: ec65cf83
Author:Athijegannathan Sundararajan
URL:
https://git.openjdk.java.net/jdk/commit/ec65cf833294e21e9dc59dfe
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description of
> how
On Thu, 27 May 2021 11:19:24 GMT, Сергей Цыпанов
wrote:
>> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
>> null-checks remaining after
>> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
>> Class.getPackageName() never returns null.
>
> Сергей Цыпанов
On Thu, 27 May 2021 10:08:17 GMT, Claes Redestad wrote:
>> One more thing I'm thinking about (not to be done in this PR of course) is
>> to move call to `String.intern()` from where it is now in
>> `Class.getPackageName()`
>>
>> public String getPackageName() {
>> String pn = this.packageN
> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
> null-checks remaining after
> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
> Class.getPackageName() never returns null.
Сергей Цыпанов has updated the pull request incrementally with one additional
c
On Wed, 26 May 2021 17:52:36 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/j
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Mon, 26 Apr 2021 11:24:23 GMT, Сергей Цыпанов
wrote:
>> That should be fine, the null check in Objects.equals is benign with these
>> usages.
>
> One more thing I'm thinking about (not to be done in this PR of course) is to
> move call to `String.intern()` from where it is now in
> `Class.
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 27 May 2021 09:23:50 GMT, Athijegannathan Sundararajan
wrote:
> fixed constructor argument passing issue.
Marked as reviewed by redestad (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4221
On Thu, 27 May 2021 09:23:50 GMT, Athijegannathan Sundararajan
wrote:
> fixed constructor argument passing issue.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4221
fixed constructor argument passing issue.
-
Commit messages:
- 8240347: remove undocumented options from jlink --help message
Changes: https://git.openjdk.java.net/jdk/pull/4221/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4221&range=00
Issue: https://bugs.openjdk.
> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up
> null-checks remaining after
> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as
> Class.getPackageName() never returns null.
Сергей Цыпанов has updated the pull request with a new target base due to a
mer
68 matches
Mail list logo
