8268664: The documentation of the Scanner.hasNextLine is incorrect
-
Commit messages:
- Clarifying docs on Scanner.hasNextLine() regarding line separators
Changes: https://git.openjdk.java.net/jdk/pull/4547/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4547&range=00
On Tue, 22 Jun 2021 02:39:01 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
> the whole JDK codebase.
Yi Yang has updated the pull request incrementally with one additional commit
since the last revision:
corr
On Mon, 21 Jun 2021 20:49:56 GMT, Paul Sandoz wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more replacement 2
>
> src/java.base/share/classes/jdk/internal/util/Preconditions.java line 78:
>
>> 76: = Prec
On Fri, 11 Jun 2021 15:01:20 GMT, Vicente Romero wrote:
> This PR is a copy of [PR-4416](https://github.com/openjdk/jdk/pull/4416)
> which was intended to openjdk/jdk.
>
> Please review this PR which is syncing the implementation of
> `DirectMethodHandleDesc.Kind.valueOf(int)` and
> `DirectMe
On Tue, 22 Jun 2021 00:45:36 GMT, Mandy Chung wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updating after review comments
>
> test/jdk/java/lang/constant/MethodHandleDescTest.java line 379:
>
>> 377:
> This PR is a copy of [PR-4416](https://github.com/openjdk/jdk/pull/4416)
> which was intended to openjdk/jdk.
>
> Please review this PR which is syncing the implementation of
> `DirectMethodHandleDesc.Kind.valueOf(int)` and
> `DirectMethodHandleDesc.Kind.valueOf(int, boolean)` with its spec.
On Fri, 11 Jun 2021 18:17:10 GMT, Vicente Romero wrote:
>> This PR is a copy of [PR-4416](https://github.com/openjdk/jdk/pull/4416)
>> which was intended to openjdk/jdk.
>>
>> Please review this PR which is syncing the implementation of
>> `DirectMethodHandleDesc.Kind.valueOf(int)` and
>> `Di
> This PR is a copy of [PR-4416](https://github.com/openjdk/jdk/pull/4416)
> which was intended to openjdk/jdk.
>
> Please review this PR which is syncing the implementation of
> `DirectMethodHandleDesc.Kind.valueOf(int)` and
> `DirectMethodHandleDesc.Kind.valueOf(int, boolean)` with its spec.
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
> Clas
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 52 commits:
- Merge
- 8268458: Add verification type for evacuation failures
Reviewed-by: kbarrett, iwalulya
- 8268952: Automa
On Mon, 21 Jun 2021 22:03:59 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: 0458113c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/0458113c6b1cf500ffdf049c1e3a698b16ce12ce
Stats: 608 l
On Mon, 21 Jun 2021 20:42:54 GMT, Alexey Semenyuk wrote:
>> …t.java failed "AssertionError: Failed: Check icon"
>
> test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
>
>> 73:
>> 74: // Create another installer with custom icon.
>> 75: long size3 = createInstalle
On Mon, 21 Jun 2021 22:25:49 GMT, Roger Riggs wrote:
> Add java.util.Objects.newIdentity to supply a unique object with identity.
> This is a replacement code can be used today for the traditional new Object()
> idiom, which will be deprecated under Project Valhalla.
> Refer to [JEP 401: Primiti
On Mon, 21 Jun 2021 17:15:03 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger Riggs
Add java.util.Objects.newIdentity to supply a unique object with identity.
This is a replacement code can be used today for the traditional new Object()
idiom, which will be deprecated under Project Valhalla.
Refer to [JEP 401: Primitive Objects
(Preview)](https://openjdk.java.net/jeps/401) for b
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop
or out of both loops only
- 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh
native thread fails
- 8268362: [REDO] C2
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Marked as reviewed by scolebourne (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/4542
On Wed, 16 Jun 2021 22:23:45 GMT, Jorn Vernee wrote:
>> Upstream fix for 8268230 to mainline JDK.
>>
>> Prior review thread can be found here:
>> https://github.com/openjdk/panama-foreign/pull/554
>>
>> Testing: jdk_foreign test suite on Windows and Linux (WSL).
>
> Jorn Vernee has updated the
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has updated the pull request incrementally
On Mon, 21 Jun 2021 20:21:58 GMT, Andy Herrick wrote:
> …t.java failed "AssertionError: Failed: Check icon"
Changes requested by asemenyuk (Reviewer).
test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
> 73:
> 74: // Create another installer with custom icon.
> 75:
…t.java failed "AssertionError: Failed: Check icon"
-
Commit messages:
- JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java
failed "AssertionError: Failed: Check icon"
Changes: https://git.openjdk.java.net/jdk17/pull/111/files
Webrev: https://webrevs.openj
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Associated CSR also reviewed.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4542
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4542
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4542
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4542
Please review this doc clarification fix to `toDaysPart()` method. CSR will
also be filed accordingly.
-
Commit messages:
- 8266901: Clarify the method description of Duration.toDaysPart()
Changes: https://git.openjdk.java.net/jdk/pull/4542/files
Webrev: https://webrevs.openjdk.ja
On Mon, 21 Jun 2021 13:26:14 GMT, Alan Bateman wrote:
>> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
>> against JDK17.
>>
>> This fixes the deadlock in ClassLoader between the two lock objects - a lock
>> object associated with the class being loaded, and the
>> Cla
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
> property.
> Fix description in the example of a filter allowing platform classes.
> Suppress some warnings about use of SecurityManager in tests.
Roger Riggs has updated the pull request incrementally with one additiona
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
> Clas
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
> string and then it looks for "/lib/". But this is wrong order as
On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote:
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so"
> string
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
> Clas
On Mon, 24 May 2021 11:18:57 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee wrote:
> Upstream a critical fix from the panama-foreign repo.
>
> See the prior review thread here:
> https://github.com/openjdk/panama-foreign/pull/558
>
> Testing: tier 1-2, local run of run-test-jdk_foreign.
This pull request has now been inte
35 matches
Mail list logo
