> Generated lambda class can not access protected static method of the target
> class. The following exception is thrown when executing the attached
> reproducible program:
>
>
> Exception in thread "main" java.lang.IllegalAccessError: class
> AccessProtectedStaticMethodFromSuper$B$$Lambda$15/
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote:
> JDK-8269387: jpackage --add-launcher should have option to not create
> shortcuts for additional launchers
src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java
line 39:
> 37:
> 38: /*
> 39: * AddLauncherArgumen
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
Yumin, Ioi, thanks for the review.
All relev
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
This pull request has now been integrated.
Ch
This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of the
changes is `Charset.defaultCharset()` returning `UTF-8` and `file.encoding`
system property being added in the spec, but another notable modification is in
`java.io.PrintStream` where it continues to use the `Console`
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 192 commits:
- Merge
- 8269827: JMH tests for AES/GCM byte[] and bytebuffers
Reviewed-by: ecaspole, weijun
- 8268965: TCP Conn
On Thu, 8 Jul 2021 22:06:32 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: dfd6b2be
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/dfd6b2be7d2cc312bf550a475be91072259f88af
Stats: 675 li
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8269722: NPE in HtmlDocletWriter
- 8270109: ProblemList 4 SA tests on macOS-aarch64
- 6766844: ByteArrayInputStream#read with a byte array of length 0 not
consistent with InputStream when at EOF
- 8269738: AssertionError
On Wed, 7 Jul 2021 14:55:18 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger Riggs
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote:
> JDK-8269387: jpackage --add-launcher should have option to not create
> shortcuts for additional launchers
Review
test/jdk/tools/jpackage/share/AddLShortcutTest.java line 46:
> 44: */
> 45:
> 46: /*
Why do you need two jtreg @test-s if
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote:
> JDK-8269387: jpackage --add-launcher should have option to not create
> shortcuts for additional launchers
test/jdk/tools/jpackage/share/AddLShortcutTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2018, 2020, Oracle and/or its affiliates.
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote:
> JDK-8269387: jpackage --add-launcher should have option to not create
> shortcuts for additional launchers
src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 259:
> 257: for (var name : names) {
> 258:
On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick wrote:
> JDK-8269387: jpackage --add-launcher should have option to not create
> shortcuts for additional launchers
This will need a CSR (so you or someone with a Reviewer role should indicate
this with the `/csr` command).
Also, can you summarize
JDK-8269387: jpackage --add-launcher should have option to not create shortcuts
for additional launchers
-
Commit messages:
- JDK-8269387: jpackage --add-launcher should have option to not create
shortcuts for additional launchers
- JDK-8269387: jpackage --add-launcher should have
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
Thanks Ioi. I have updated the issue descripti
On Thu, 8 Jul 2021 03:12:24 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>
> Yi Yang has refreshed the contents of this pull req
On Thu, 8 Jul 2021 02:32:45 GMT, Yi Yang wrote:
> Generated lambda class can not access protected static method of the target
> class. The following exception is thrown when executing the attached
> reproducible program:
>
>
> Exception in thread "main" java.lang.IllegalAccessError: class
>
On Wed, 30 Jun 2021 23:00:24 GMT, Brian Burkhalter wrote:
> Modify the specification of
> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
> returned instead of `0` when the stream is at its end and the third
> parameter, `len`, is zero.
This pull request has now b
PS The benefit of an intrinsic in a case like this is being to use a
platform-optimized implementation, trading off native instruction,
floating-point branch, and bitwise conversion costs.
-Joe
On 7/8/2021 4:26 AM, Joe Darcy wrote:
On 7/8/2021 3:50 AM, Andrew Haley wrote:
On Thu, 8 Jul 2021
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6506405: Add some tests
-
Changes:
- all: https://gi
On Thu, 8 Jul 2021 15:53:18 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
6506405: Set MAG_BIT_MASKs to bit-wise complements of SIGN_BIT_MASKs
On Thu, 8 Jul 2021 15:34:16 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
> previous commits have been removed. The increme
> Please consider this change to make the `float` and `double` versions of
> `java.lang.Math.abs()` branch-free.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content
On Thu, 8 Jul 2021 01:05:16 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
Dear all,
Can you do me a favor to review this patch. This patch use `ldp` to
implement String.compareTo.
* We add a JMH test case
* Here is the result of this test case
Benchmark |(size)| Mode| Cnt|Score | Error |Units
-|-
After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
the whole JDK codebase.
As Mandy suggested, I create this PR for changes involving JUC changes.
-
Commit messages:
- replace
On Wed, 16 Jun 2021 15:15:25 GMT, Jan Lahoda wrote:
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum c
On 7/8/2021 3:50 AM, Andrew Haley wrote:
On Thu, 8 Jul 2021 09:43:35 GMT, Andrew Haley wrote:
Moves between GPRs and FPRs are often slow. There's a 10-cycle latency on some
AArch64, so we avoid it whenever we can. Mind you, we don't care about this
patch because we always generate FABS from
On Thu, 8 Jul 2021 09:43:35 GMT, Andrew Haley wrote:
> Moves between GPRs and FPRs are often slow. There's a 10-cycle latency on
> some AArch64, so we avoid it whenever we can. Mind you, we don't care about
> this patch because we always generate FABS from an intrinsic anyway.
For avoidance of
On Thu, 8 Jul 2021 01:05:16 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated c
> After I've renamed remove branch GitHub for some reason has closed original
> https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains ten commits:
-
On Thu, 8 Jul 2021 09:17:16 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept enu
> Currently, an enum switch with patterns is desugared in a very non-standard,
> and potentially slow, way. It would be better to use the standard
> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs to
> accept enum constants as labels in order to allow this. A complicat
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've found
> out, that in a few of JDK core classes, e.g. in `j.l.Class` expressions like
> `baseName.replace('.', '/') + '/' + name` are not compiled into
> `invokedynamic`-based code, but into one using `StringBuilder`. This
On Wed, 12 May 2021 13:12:07 GMT, Claes Redestad wrote:
>> But isn't `componentType.descriptorString()` does this itself? Also
>> multi-dimensional arrays are quite an infrequent usecase, aren't they?
>
> Yeah, it's just an optimization. Current code wouldbuild "[[..[[LFoo;" by
> recursively go
On Thu, 8 Jul 2021 00:45:48 GMT, Joe Darcy wrote:
> However, the bitwise conversion should now be fast everywhere.
Doesn't it require moves between general-purpose and floating-point registers?
Those have to go through memory for some targets (including old x86, where the
ISA supports it, but
On Thu, 8 Jul 2021 01:05:16 GMT, Brian Burkhalter wrote:
>> Please consider this change to make the `float` and `double` versions of
>> `java.lang.Math.abs()` branch-free.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On a quick review of version 2, I noticed that the double constant is declared
as integer with same value like the float one.
I think that's wrong, but I wonder why the asserts still pass.
Uwe
Am July 8, 2021 1:05:16 AM UTC schrieb Brian Burkhalter :
>> Please consider this change to make the `
40 matches
Mail list logo
