On Tue, 3 Aug 2021 13:33:07 GMT, Wang Huang wrote:
>> Dear all,
>> Can you do me a favor to review this patch. This patch use `ldp` to
>> implement String.compareTo.
>>
>> * We add a JMH test case
>> * Here is the result of this test case
>>
>> Benchmark |(s
On Wed, 4 Aug 2021 03:27:49 GMT, Nick Gasson wrote:
>> Wang Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sinc
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US options
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
My understanding of this enhancement is to warn user when app image created
without --mac-sign is used in building a signed package. I.e. to warn user they
misused --ma
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
First of all why we only want to cover case when app-image was produced without
--mac-sign? If we want to cover such case only, then we need to use approach
suggested b
On Wed, 4 Aug 2021 20:56:46 GMT, Alexander Matveev wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java
> line 142:
>
>> 140: // is not allready signed.
>> 141:
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
The purpose of this change is to catch the case (and emit a warning) when user
creates an app-image w/o using --mac-sign, and then uses that app image to
build a pkg or
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What options exist for building a package from app image with invalid signature?
-
PR: https://git.openjdk.java.net/jdk/pull/5004
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
I think it will not work. User might modify app image after it was created and
it will invalidate signature.
-
PR: https://git.openjdk.java.net/jdk/pull/50
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What if we save "signed/not signed" flag in ".jpackage.xml" when building app
image and read its value instead of guessing if they signed app image or not
using `codesi
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
Changes requested by almatvee (Reviewer).
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java
line 877:
> 875: try {
> 876:
8271868: Warn user when using mac-sign option with unsigned app-image.
-
Commit messages:
- JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
- JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
- JDK-8271868: Warn user when using ma
On Wed, 4 Aug 2021 18:42:08 GMT, Joe Darcy wrote:
> Remove extraneous tag to fix build breakage.
This pull request has now been integrated.
Changeset: 91bbe2fc
Author:Joe Darcy
URL:
https://git.openjdk.java.net/jdk/commit/91bbe2fcbda008a9adc8aa77149a4f2156e1b46b
Stats: 1 line i
On Wed, 4 Aug 2021 18:42:08 GMT, Joe Darcy wrote:
> Remove extraneous tag to fix build breakage.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5002
On Wed, 4 Aug 2021 18:42:08 GMT, Joe Darcy wrote:
> Remove extraneous tag to fix build breakage.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5002
Remove extraneous tag to fix build breakage.
-
Commit messages:
- 8271888
Changes: https://git.openjdk.java.net/jdk/pull/5002/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5002&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8271888
Stats: 1 line in 1 fi
On Mon, 2 Aug 2021 22:34:58 GMT, Raffaello Giulietti
wrote:
> Hello,
>
> please review the changes in documentation of floorDiv() and floorMod() in
> all their variants. Some are clarifications, some are corrections.
>
> Here's an example of a confusing formulation in the current doc
>> "the
On Tue, 3 Aug 2021 22:44:57 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> please review the changes in documentation of floorDiv() and floorMod() in
>> all their variants. Some are clarifications, some are corrections.
>>
>> Here's an example of a confusing formulation in the current doc
>>
On Mon, 2 Aug 2021 14:24:54 GMT, Coleen Phillimore wrote:
>>> This is an interesting and it seems a better way to solve this problem.
>>> Where were you all those years ago?? I hope @zhengyu123 has a chance to
>>> review it.
>>
>> Thank you! I was here, but we were not yet doing much upstream
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote:
> Short: this patch makes NMT available in custom-launcher scenarios and during
> gtests. It simplifies NMT initialization. It adds a lot of NMT-specific
> testing, cleans them up and makes them sideeffect-free.
>
> -
>
> NMT cont
On Wed, 4 Aug 2021 03:36:11 GMT, Thomas Stuefe wrote:
> Nightlies at SAP showed no problems for several runs now. The failed GHA test
> (StringDeduplication) seems to have nothing to do with my patch.
>
> @zhengyu123 are you fine with the latest version of this patch?
Still good.
On Mon, 1 Feb 2021 13:11:52 GMT, Aleksey Shipilev wrote:
> Since Compact Strings implementation, there are simple methods in String and
> StringBuilders: `coder()`, `value()`, `isLatin1()`. They are mostly there to
> capture `COMPACT_STRINGS` flag that would fold to "false" when compact
> stri
On Wed, 4 Aug 2021 03:29:40 GMT, Nick Gasson wrote:
> Please provide the updated benchmark results for this version. Are you able
> to test it on several different machines?
We tested this version on Raspberry Pi 4B.
base:
Benchmark (diff_pos) (size) Mode
On Wed, 4 Aug 2021 07:46:48 GMT, Claes Redestad wrote:
> This adds Integer.toString microbenchmarks, roughly similar to the
> Long.toString microbenchmarks (toStringSmall should use an equivalent data
> set). This is useful for comparison purposes and completeness.
>
> Also tuned existing benc
Hi Andy,
The problem is you are signing the pkg but building it from an unsigned
> app-image.
>
> If you are building in two phases (app-image, then installer package) you
> need the --mac-sign option on both phases.
>
Thank you very much. It resolved the problem (I wasn't aware that
--mac-sign op
This adds Integer.toString microbenchmarks, roughly similar to the
Long.toString microbenchmarks (toStringSmall should use an equivalent data
set). This is useful for comparison purposes and completeness.
Also tuned existing benchmarks to harmonize setup, reduce runtime without
significantly ha
On Wed, 4 Aug 2021 00:57:16 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8271599: Javadoc of floorDiv() and floorMod() families is inaccurate in
>> some places
>
> Marked as reviewe
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US options
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options should be added in ProcessBuilder.
Masanori Yano has updated
29 matches
Mail list logo
