On Tue, 24 Aug 2021 03:03:37 GMT, Vicente Romero wrote:
>> src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line 327:
>>
>>> 325: * @throws IllegalArgumentException if the bootstrap arguments are
>>> invalid
>>> 326: * or inconsistent
On Tue, 24 Aug 2021 19:15:56 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 2635:
>>
>>> 2633: List childArgs = null;
>>> 2634: Path sleepExe = TEST_NATIVEPATH.resolve("sleepmillis");
>>> 2635: if (sleepExe.toFile().canExecute()) {
>>
>>
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick wrote:
> JDK-8272639: jpackaged applications using microphone on mac
This pull request has now been integrated.
Changeset: b17b821a
Author:Andy Herrick
URL:
On Tue, 24 Aug 2021 10:09:13 GMT, Aleksey Shipilev wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make constants as static final
>
> Some benchmark comments.
@shipilev @nsjian Thanks a lot for the
> This pull request adds a micro benchmark for Vector API.
> The Black Scholes algorithm is implemented with and without Vector API.
> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
> vectors.
Sandhya Viswanathan has updated the pull request incrementally with one
> This pull request adds a micro benchmark for Vector API.
> The Black Scholes algorithm is implemented with and without Vector API.
> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
> vectors.
Sandhya Viswanathan has updated the pull request incrementally with one
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272863: Replace usages of Collections.sort with List.sort call in public
java modules
On Tue, 24 Aug 2021 11:48:46 GMT, Alexander Zvegintsev
wrote:
> Is there any reason to not touch them along with this fix?
Update them too.
-
PR: https://git.openjdk.java.net/jdk/pull/5229
On Tue, 24 Aug 2021 16:16:45 GMT, Ioi Lam wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is unrepentant
On Tue, 24 Aug 2021 16:14:16 GMT, Ioi Lam wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is unrepentant
On Tue, 24 Aug 2021 17:21:20 GMT, Calvin Cheung wrote:
> Please review this trivial change for fixing the copyright year of the two
> files (jlink.properties and ImagePluginStack.java) which were modified
> unintentionally during the fix for JDK-8264322.
This pull request has now been
On Tue, 24 Aug 2021 17:35:50 GMT, Brian Burkhalter wrote:
>> Please review this trivial change for fixing the copyright year of the two
>> files (jlink.properties and ImagePluginStack.java) which were modified
>> unintentionally during the fix for JDK-8264322.
>
> I verified that in the commit
On Tue, 24 Aug 2021 17:21:20 GMT, Calvin Cheung wrote:
> Please review this trivial change for fixing the copyright year of the two
> files (jlink.properties and ImagePluginStack.java) which were modified
> unintentionally during the fix for JDK-8264322.
I verified that in the commit to fix
Please review this trivial change for fixing the copyright year of the two
files (jlink.properties and ImagePluginStack.java) which were modified
unintentionally during the fix for JDK-8264322.
-
Commit messages:
- 8272916: Copyright year was modified unintentionally in
The poor-man's solution would be to detect common cases, with the
comment appearing before a package or import statement.
A more advanced solution would have to be in the lexer or parser,
detecting that there is a "unused" comment when creating a tree node.
-- Jon
On 8/24/21 8:07 AM, Pavel
On Tue, 24 Aug 2021 15:55:28 GMT, Roger Riggs wrote:
> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
> unexpected messages from a child Java VM
> as the cause of the test failure. Attempts to control the output of the
> child VM have failed, the VM is unrepentant
The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
unexpected messages from a child Java VM
as the cause of the test failure. Attempts to control the output of the child
VM have failed, the VM is unrepentant .
There is no functionality in the child except to wait long
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java.time changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Tue, 24 Aug 2021 02:16:31 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @mlchung comments
>
> Thanks for creating a JBS issue. I'm okay to follow up the test improvement
> as a separate
On Wed, 18 Aug 2021 21:21:06 GMT, Calvin Cheung wrote:
> Please review this change for adding a `jlink` command line option
> `--generate-cds-archive` for generating CDS archives as a post processing
> step during the creation of a custom JDK image.
>
> Details can be found in the
Just to clarify that example of mine. I didn't mean the package-info.java file.
I meant an ordinary file that comprises an interface, class, enum or record.
Perhaps a better example from Andrey's list would be this:
/**
* A utility package for the java(1), javaw(1) launchers.
*
> On 24 Aug 2021, at 15:38, Jonathan Gibbons
> wrote:
>
> IIRC, the one in javadoc CommentUtils has recently been fixed.
>
> It might be worth a javac -Xlint option to detect/report such dangling
> comments.
How would you currently implement that? Aren't comments on non-documentable
Hi Jaikiran,
Thanks for taking this on and getting it started.
One use case of canonical storage is repeatable builds.
It would be useful to identify the uses in the JDK that would need to be
changed to use the new function.
On 8/24/21 10:07 AM, Jaikiran Pai wrote:
The java.util.Properties
IIRC, the one in javadoc CommentUtils has recently been fixed.
It might be worth a javac -Xlint option to detect/report such dangling
comments.
-- Jon
On 8/23/21 11:50 PM, Andrey Turbanov wrote:
Hello.
I found a few internal classes in the JDK codebase which don't have
proper javadoc, but
On Tue, 24 Aug 2021 03:03:48 GMT, Vicente Romero wrote:
>> Please review this simple PR along with the associated CSR. The PR is
>> basically adding a line the the specification of method
>> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
>> NPE will be thrown.
>>
The java.util.Properties class allows the properties to be written out
to a stream or through a writer. In its current form, the specification
of these APIs state that a comment comprising of the current date is
always written out. The spec doesn't make any guarantees about the order
of the
On 8/24/2021 6:08 AM, Filteredaccount1 wrote:
Hi Andy,
During the wait for JDK 18, would it be possible to describe on the bug ticket
what manual workaround steps are required to apply to an existing jPackaged app
for distribution both inside and outside the app store?
The instructions
On Thu, 19 Aug 2021 15:15:31 GMT, Aleksey Shipilev wrote:
> See the bug report for more details. I would appreciate if people with their
> corporate testing systems would run this through their systems to avoid
> surprises. (ping @RealCLanger, @iignatev).
I have added this to our internal
> Greetings,
>
> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
> replace and mitigate Object.finalize() uses in the JDK libraries; please see
> https://bugs.openjdk.java.net/browse/JDK-8253568 for more information.
>
> We also like to assist users in replacing and
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java/net and sun/net changes LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On 24/08/2021 07:50, Andrey Turbanov wrote:
Hello.
I found a few internal classes in the JDK codebase which don't have
proper javadoc, but have dangling javadoc-like comments.
Dangling Javadoc comments are ignored by the javadoc tool and IDE.
Perhaps it was intentional to not add proper javadoc
On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung wrote:
>> Please review this change for adding a `jlink` command line option
>> `--generate-cds-archive` for generating CDS archives as a post processing
>> step during the creation of a custom JDK image.
>>
>> Details can be found in the
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
>
On Mon, 23 Aug 2021 23:18:28 GMT, Sandhya Viswanathan
wrote:
> This pull request adds a micro benchmark for Vector API.
> The Black Scholes algorithm is implemented with and without Vector API.
> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
> vectors.
Some
Hi Andy,
During the wait for JDK 18, would it be possible to describe on the bug ticket
what manual workaround steps are required to apply to an existing jPackaged app
for distribution both inside and outside the app store?
There are two info.plist files inside a jPackaged app. In my
Hello.
I found a few internal classes in the JDK codebase which don't have
proper javadoc, but have dangling javadoc-like comments.
Dangling Javadoc comments are ignored by the javadoc tool and IDE.
Perhaps it was intentional to not add proper javadoc to them?
I believe it's better to convert them
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
The changes in the src/java.desktop/ looks fine.
Filed: https://bugs.openjdk.java.net/browse/JDK-8272863
-
Marked as reviewed by
Collections.sort is just a wrapper, so it is better to use an instance method
directly.
-
Commit messages:
- [PATCH] Replace usages of Collections.sort with List.sort call in public
java modules
Changes: https://git.openjdk.java.net/jdk/pull/5229/files
Webrev:
40 matches
Mail list logo
