Re: RFR: 8231640: (prop) Canonical property storage [v21]

2021-09-17 Thread Jaikiran Pai
> The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Properties` have been modified to > now look for the

Re: RFR: 8231640: (prop) Canonical property storage [v7]

2021-09-17 Thread Jaikiran Pai
On Fri, 17 Sep 2021 17:10:10 GMT, Daniel Fuchs wrote: >> "different set implementation" as part of the spec may challenge the >> compatibility test developers to prove or disprove that statement. >> The type of an instance is frequently understood to be the "implementation". >> The visible type

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Joe Wang
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Serguei Spitsyn
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Iris Clark
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP

Integrated: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms

2021-09-17 Thread Remilia Scarlet
On Wed, 15 Sep 2021 06:28:25 GMT, Remilia Scarlet wrote: > The test assumes that it always runs on 64-bit platform and > classes_nocoops.jsa is always created. > It's a test bug. The test should only expect classes_nocoops.jsa exists if > it's running on a supported 64-bit platform. >

RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Naoto Sato
Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. The output from the agent library is in `UTF-8` so it succeeded before the JEP has been implemented, as System.out used `UTF-8` converter. After

Re: RFR: 8231640: (prop) Canonical property storage [v7]

2021-09-17 Thread Roger Riggs
On Thu, 9 Sep 2021 18:31:43 GMT, Roger Riggs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> dummy commit to trigger GitHub actions job to try and reproduce an >> unexplained failure with the new tests that

Re: RFR: 8247980: Exclusive execution of java/util/stream tests slows down tier1

2021-09-17 Thread Paul Sandoz
On Wed, 25 Aug 2021 15:52:06 GMT, Igor Ignatyev wrote: >> See the bug report for more details. I would appreciate if people with their >> corporate testing systems would run this through their systems to avoid >> surprises. (ping @RealCLanger, @iignatev). > > the testing in our infra returned

Integrated: 8273681: Add Vector API vs Arrays.mismatch intrinsic benchmark

2021-09-17 Thread Kartik Ohri
On Fri, 10 Sep 2021 08:32:02 GMT, Kartik Ohri wrote: > Hi all! > > Please review this PR to add a benchmark comparing the performance of > Arrays.mismatch intrinsic in the JDK with that of the Vector API. Kindly > refer to this [thread] on panama-dev regarding some initial discussion about

Re: RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v5]

2021-09-17 Thread Calvin Cheung
On Fri, 17 Sep 2021 02:17:09 GMT, Remilia Scarlet wrote: >> The test assumes that it always runs on 64-bit platform and >> classes_nocoops.jsa is always created. >> It's a test bug. The test should only expect classes_nocoops.jsa exists if >> it's running on a supported 64-bit platform. >>

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 10:14:47 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: RFR: 8266936: Add a finalization JFR event [v11]

2021-09-17 Thread Markus Grönlund
On Fri, 17 Sep 2021 12:02:32 GMT, Coleen Phillimore wrote: >> Markus Grönlund has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - remove rehashing and rely on default grow_hint for table resize >> - mtStatistics > >

Re: RFR: 8273314: Add tier4 test groups [v4]

2021-09-17 Thread Igor Ignatyev
On Fri, 17 Sep 2021 06:59:09 GMT, Aleksey Shipilev wrote: >> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, >> @iignatev suggested to create tier4 groups that capture all tests not in >> tiers{1,2,3}. >> >> Caveats: >> - I excluded `applications` from `hotspot:tier4`,

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v2]

2021-09-17 Thread Jaikiran Pai
> The commit here is a potential fix for the issue noted in > https://bugs.openjdk.java.net/browse/JDK-8258117. > > The change here repurposes an existing internal interface `ModuleInfoEntry` > to keep track of the last modified timestamp of a `module-info.class` > descriptor. > > This commit

Re: RFR: 8193682: Infinite loop in ZipOutputStream.close()

2021-09-17 Thread Alan Bateman
On Wed, 15 Sep 2021 07:40:35 GMT, Ravi Reddy wrote: > Hi all, > > Please review this fix for Infinite loop in ZipOutputStream.close(). > The main issue here is when ever there is an exception during close > operations on GZip we are not setting the deflator to a finished state which > is

Re: RFR: 8266936: Add a finalization JFR event [v11]

2021-09-17 Thread Coleen Phillimore
On Mon, 13 Sep 2021 17:12:49 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-17 Thread Alan Bateman
On Fri, 17 Sep 2021 08:46:52 GMT, Masanori Yano wrote: > Thank you for your comment. According to Microsoft KB316609, CreateFile() > should be tried again a short time later. I think JarURLConnection should > also be retried when antivirus software holds some files. >

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Jaikiran Pai
Hello Bernd, On 17/09/21 3:37 am, Bernd Eckenfels wrote: I also wonder if it makes sense to either only serve files with public permissions, or at least Filter some critical files like .ssh/* and *.jks. FWIW - From what I can see in the proposed implementation as well as the JEP text,

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Jaikiran Pai
Hello Julia, On 17/09/21 3:14 pm, Julia Boes wrote: On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote: Julia Boes has updated the pull request incrementally with one additional commit since the last revision: correct path handling src/jdk.httpserver/share/classes/module-info.java

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-17 Thread Julia Boes
On Thu, 16 Sep 2021 14:05:52 GMT, Jaikiran Pai wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> correct path handling > > src/jdk.httpserver/share/classes/module-info.java line 55: > >> 53: *

Re: RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-17 Thread Masanori Yano
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote: > Could you please review the 8233674 bug fixes? > This problem is caused by the antivirus software opening the file for a short > time, so CreateFile() should be retried. Thank you for your comment. According to Microsoft KB316609,

Re: RFR: 8273314: Add tier4 test groups [v4]

2021-09-17 Thread Sergey Bylokhov
On Fri, 17 Sep 2021 06:59:09 GMT, Aleksey Shipilev wrote: >> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, >> @iignatev suggested to create tier4 groups that capture all tests not in >> tiers{1,2,3}. >> >> Caveats: >> - I excluded `applications` from `hotspot:tier4`,

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v6]

2021-09-17 Thread Wu Yan
On Sun, 5 Sep 2021 13:23:21 GMT, Andrew Haley wrote: >> Thanks, I'll fix it. > > It's fine. I don't think it'll affect any real programs, so it's rather > pointless. I don't know if that's any reason not to approve it. Andrew, can you help us to approve this? - PR:

Re: RFR: 8273314: Add tier4 test groups [v3]

2021-09-17 Thread Aleksey Shipilev
On Mon, 6 Sep 2021 13:22:03 GMT, Aleksey Shipilev wrote: >> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, >> @iignatev suggested to create tier4 groups that capture all tests not in >> tiers{1,2,3}. >> >> Caveats: >> - I excluded `applications` from `hotspot:tier4`,

Re: RFR: 8273314: Add tier4 test groups [v4]

2021-09-17 Thread Aleksey Shipilev
> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, > @iignatev suggested to create tier4 groups that capture all tests not in > tiers{1,2,3}. > > Caveats: > - I excluded `applications` from `hotspot:tier4`, because they require test > dependencies (e.g. jcstress). > -

Re: better random numbers

2021-09-17 Thread John Rose
On Sep 7, 2021, at 4:48 AM, Stefan Zobel mailto:splitera...@gmail.com>> wrote: That "influential researcher" is probably Sebastiano Vigna who has indeed harsh words on PCG: https://pcg.di.unimi.it/pcg.php That link can also be found on ONeill’s blog, along with her responses.

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

2021-09-17 Thread Aleksey Shipilev
On Thu, 16 Sep 2021 09:47:16 GMT, Jan Lahoda wrote: >> This is a GUI test, and it should be `@headful`. >> >> Additional testing: >> - [x] Test still runs in default, and does not run with `!headful` > > Ah, right, I thought it is a JShell test, but it is not. Sorry for the noise. @lahodaj,