On Thu, 18 Nov 2021 07:26:45 GMT, David Holmes wrote:
>> kabutz has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Removed JVM flags from benchmark
>
> To add my 2c IMO a parallel version of this type absolutely **must** be
> opt-in. There
On 26/11/21 7:32 am, Mandy Chung wrote:
On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote:
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
minor fix to avoid casting
Hello Mandy, one small issue - `ClassFileReader`, `Depende
On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor fix to avoid casting
>
> Hello Mandy, one small issue - `ClassFileReader`, `DependencyFinder` and
> `VersionHelpe
On Tue, 23 Nov 2021 20:54:55 GMT, Mandy Chung wrote:
> jdeps intends to report an error if there are multiple versions of the same
> class being parsed. module-info.class should be excluded from such
> detection.
>
> This patch also fixes a data race in `VersionHelper::set` and also unwraps
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
Marked as reviewed by ngasson (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6560
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
Looks good to me.
-
Marked as reviewed by njian (Committer).
PR: https://git.openjdk.java.net/jdk/p
This fix attemps to resolve an issue where threads can stack up on each other
while waiting to get a connection from the ldap pool to an unreachable server.
It does this by having each thread start a countdown prior to holding the
pools' lock. (which has been changed to a ReentrantLock) Once the
I like the idea of an @Immutable annotation. So much so, that I have created
one and use it heavily.
However, my @Immutable is just for documentation; it does not have a rigorous
semantics that would be
needed for a compiler to validate its use or generate different code.
But it could be used by
On 26/11/2021 4:15 am, kabutz wrote:
On Thu, 18 Nov 2021 07:26:45 GMT, David Holmes wrote:
kabutz has updated the pull request incrementally with one additional commit
since the last revision:
Removed JVM flags from benchmark
To add my 2c IMO a parallel version of this type absolutely *
On Thu, 25 Nov 2021 10:55:45 GMT, Andrew Leonard wrote:
> Please consider providing a more general option, say `--date`, which takes an
> [ISO 8601 date/time
> string](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/format/DateTimeFormatter.html#ISO_DATE_TIME).
The `jar`
I would think that if a class is marked immutable that would imply all the
fields in it and from its inherited
classes should be immutable. If fields are marked immutable then it would only
apply to them.
What I wonder is what its relationship to final would be. The final annotation
implies th
On Thu, 18 Nov 2021 07:26:45 GMT, David Holmes wrote:
>> kabutz has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Removed JVM flags from benchmark
>
> To add my 2c IMO a parallel version of this type absolutely **must** be
> opt-in. There
On Wed, 24 Nov 2021 16:43:10 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
@nick-arm @nsjian Could you review, push this please?
-
PR: https://git.openjdk.java.net/jdk/pull/65
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
@stooart-mon Thank you for fixing the bug.
lgtm
-
Marked as reviewed by eas...@github.com (no known
Hello again,
I was trying to run JDK's benchmarks over night (second attempt
actually) but had some difficulties to get stable results.
This makes it difficult to compare the modified version with a
reference. I am not sure what the cause is, I have heard some intel CPUs
can't run avx instru
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
@eastig could you review this please?
-
PR: https://git.openjdk.java.net/jdk/pull/6560
Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
to finish before restarting trial method.
-
Commit messages:
- 8277659: [TESTBUG] ThreadOnSpinWaitProducerConsumer hangs
Changes: https://git.openjdk.java.net/jdk/pull/6560/files
Webrev: https://webrevs.
On Thu, 25 Nov 2021 11:42:30 GMT, Stuart Monteith wrote:
> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
> to finish before restarting trial method.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/p
Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread
to finish before restarting trial method.
-
Commit messages:
- 8277659: [TESTBUG] ThreadOnSpinWaitProducerConsumer hangs
Changes: https://git.openjdk.java.net/jdk/pull/6559/files
Webrev: https://webrevs.
On Wed, 24 Nov 2021 19:40:38 GMT, Mark Reinhold wrote:
> A user who’s not familiar with the lingo of [reproducible
> builds](https://reproducible-builds.org/docs/source-date-epoch/) will be
> mystified by an option named `--source-date`. A user who just wants to set
> the timestamp of new entr
On Wed, 24 Nov 2021 16:48:42 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>
On Thu, 25 Nov 2021 09:37:59 GMT, Andrew Leonard wrote:
>> test/jdk/tools/jar/JarEntryTime.java line 129:
>>
>>> 127: // Make a jar file from that directory structure with
>>> 128: // --source-date set to epoch seconds 1647302400 (15/03/2022)
>>> 129: long sourceDate = 16
On Wed, 24 Nov 2021 16:43:10 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>>
On 11/25/21 08:27, Justin Dekeyser wrote:
Quick question, out of curiosity: how would it behave with respect to
inheritance? Can a @Immutable class inherit from an non immutable one?
And: does @Immutable mean deeply immutable? IMO it really should,
but that's harder to check, and we'd have to
I have not thought about that. I'm not a Java expert.
I just throwed the idea precisely to avoid "fake immutability", because a
programmer could think one record is immutable simply by being a record, while
this is false.
There are probably lots of problems that need to be taken in consideratio
On Tue, 23 Nov 2021 20:29:15 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by: Andr
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
> co
Hello,
Quick question, out of curiosity: how would it behave with respect to
inheritance? Can a @Immutable class inherit from an non immutable one?
if no: that's a bit annoying, no? (fake immutability)
Can @Immutable class be subclassed to a non @Immutable one? if no:
that's a bit annoying too, no
Hi, I was thinking that it could be interesting adding an @Immutable annotation
to Java. It would be a marker annotation for the compiler (similar to
@FunctionalInterface) in order to throw an error if the annotated class/record
has a component that is not @Immutable.
This means that all existi
30 matches
Mail list logo
