This is regression from JDK-8263155. MacHelper.java is now calling test
verification callback with all content in DMG root. SigningPackageTest expects
only path with app name in it and thus it fails when trying to verify app
inside ".background" folder. Fixed by checking that provided path for
On Thu, 16 Dec 2021 17:44:04 GMT, Vicente Romero wrote:
> Hi,
>
> Please review this change that is fixing a bug in reflection in particular in
> `sun.reflect.annotation.TypeAnnotationParser::buildAnnotatedTypes` the
> current code is assuming that for inner class constructors it is always
>
On Fri, 17 Dec 2021 00:05:41 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 634afe8c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/634afe8c5c0855eafb1639f54ecc8e9c9e568814
Stats: 29
On Thu, 16 Dec 2021 22:16:26 GMT, Mark Reinhold wrote:
> Please review this tiny specification clarification.
This pull request has now been integrated.
Changeset: f5d7c777
Author:Mark Reinhold
URL:
https://git.openjdk.java.net/jdk18/commit/f5d7c777bc516fa2e711c19d5281ebf32384b543
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8278574: update --help-extra message to include default value of
--finalization option
- 8278389: SuspendibleThreadSet::_suspend_all should be volatile/atomic
- 8278575: update jcmd GC.finalizer_info to list finalization
On Thu, 16 Dec 2021 21:38:30 GMT, liach wrote:
>> Simply changes this to only read the static field once to prevent `null` on
>> second read.
>
> liach has updated the pull request incrementally with two additional commits
> since the last revision:
>
> - sorry, reintroduced the bug in last
On Thu, 16 Dec 2021 22:16:26 GMT, Mark Reinhold wrote:
> Please review this tiny specification clarification.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/39
On Thu, 16 Dec 2021 22:16:26 GMT, Mark Reinhold wrote:
> Please review this tiny specification clarification.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/39
On Mon, 6 Dec 2021 16:59:41 GMT, Roger Riggs wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Thu, 16 Dec 2021 18:01:54 GMT, Joe Darcy wrote:
> Hi Vicente.
>
> Please file a CSR for the behavioral change.
sure, thanks
-
PR: https://git.openjdk.java.net/jdk/pull/6869
On Thu, 16 Dec 2021 22:16:26 GMT, Mark Reinhold wrote:
> Please review this tiny specification clarification.
Drat, used the wrong bug id.
-
PR: https://git.openjdk.java.net/jdk18/pull/39
Please review this tiny specification clarification.
-
Commit messages:
- 8278465: Clarify the ModuleDescriptor.Version specification’s treatment of
repeated punctuation characters
Changes: https://git.openjdk.java.net/jdk18/pull/39/files
Webrev:
On Thu, 16 Dec 2021 21:48:14 GMT, kabutz wrote:
> > embarrassingly parallelizable
>
> Having looked at [embarrassingly
> parallel](https://en.wikipedia.org/wiki/Embarrassingly_parallel), I'm not
> certain that this particular problem would qualify. The algorithm is easy to
> parallelize, but
On Thu, 16 Dec 2021 21:37:26 GMT, kabutz wrote:
> > embarrassingly parallelizable
>
> Having looked at [embarrassingly
> parallel](https://en.wikipedia.org/wiki/Embarrassingly_parallel), I'm not
> certain that this particular problem would qualify. The algorithm is easy to
> parallelize, but
On Mon, 6 Dec 2021 16:01:43 GMT, Roger Riggs wrote:
>> The specification of ObjectInputStream constructors that invoke
>> `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention
>> exceptions that may be thrown by the apply() method.
>>
>> In both constructors, add the following to
On Tue, 14 Dec 2021 18:25:45 GMT, Naoto Sato wrote:
> This is a doc fix to `StringTokenizer`, where the original spec does not
> account for the delimiter's length in the case of a supplementary character.
> Corresponding CSR has been drafted:
>
On Fri, 26 Nov 2021 12:46:59 GMT, Сергей Цыпанов wrote:
> Instead of something like
>
> long x;
> long y;
> return (x < y) ? -1 : ((x == y) ? 0 : 1);
>
> we can use `return Long.compare(x, y);`
>
> All replacements are done with IDE.
This pull request has now been integrated.
Changeset:
On Thu, 16 Dec 2021 21:30:21 GMT, kabutz wrote:
> embarrassingly parallelizable
Having looked at [embarrassingly
parallel](https://en.wikipedia.org/wiki/Embarrassingly_parallel), I'm not
certain that this particular problem would qualify. The algorithm is easy to
parallelize, but in the end
> Simply changes this to only read the static field once to prevent `null` on
> second read.
liach has updated the pull request incrementally with two additional commits
since the last revision:
- sorry, reintroduced the bug in last patch
- choose a concise name for the local var
On Thu, 16 Dec 2021 21:04:58 GMT, liach wrote:
> Simply changes this to only read the static field once to prevent `null` on
> second read.
src/java.base/share/classes/java/lang/Class.java line 3828:
> 3826: java.security.AccessController.doPrivileged
> 3827:
On Thu, 16 Dec 2021 21:22:02 GMT, Paul Sandoz wrote:
> > "embarrassingly parallel when employing recursive" -> "embarrassingly
> > non-parallel when employing recursive" (?)
>
> I corrected to "embarrassingly parallelizable" (i believe that is a common
> phrase we as software engineers use in
On Thu, 16 Dec 2021 21:04:58 GMT, liach wrote:
> Simply changes this to only read the static field once to prevent `null` on
> second read.
It would be easier to read and clearer if the local was not named the same as
the static.
-
Changes requested by rriggs (Reviewer).
PR:
On Thu, 16 Dec 2021 20:09:59 GMT, kabutz wrote:
> "embarrassingly parallel when employing recursive" -> "embarrassingly
> non-parallel when employing recursive" (?)
I corrected to "embarrassingly parallelizable" (i believe that is a common
phrase we as software engineers use in these cases).
Simply changes this to only read the static field once to prevent `null` on
second read.
-
Commit messages:
- 8261404: Class.getReflectionFactory() is not thread-safe
Changes: https://git.openjdk.java.net/jdk/pull/6870/files
Webrev:
On Mon, 6 Dec 2021 16:59:41 GMT, Roger Riggs wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Mon, 6 Dec 2021 16:01:43 GMT, Roger Riggs wrote:
>> The specification of ObjectInputStream constructors that invoke
>> `ObjectInputFilter.Config.getSerialFilterFactory()` do not mention
>> exceptions that may be thrown by the apply() method.
>>
>> In both constructors, add the following to
> Might need a CSR as now `computeIfAbsent` `computeIfPresent` `compute`
> `merge` would throw CME if the functions modified the map itself, and there
> are corresponding specification changes.
liach has updated the pull request with a new target base due to a merge or a
rebase. The
On Thu, 16 Dec 2021 19:46:19 GMT, Paul Sandoz wrote:
> > Terribly sorry to ask this, but where would I see the CSR? I don't have
> > access to the JIRA in the backend.
>
> You should be able to view it but not edit:
>
> https://bugs.openjdk.java.net/browse/JDK-8278886
>
> (To get
On Thu, 16 Dec 2021 06:07:29 GMT, kabutz wrote:
>> BigInteger currently uses three different algorithms for multiply. The
>> simple quadratic algorithm, then the slightly better Karatsuba if we exceed
>> a bit count and then Toom Cook 3 once we go into the several thousands of
>> bits. Since
On Thu, 16 Dec 2021 18:41:32 GMT, Naoto Sato wrote:
>> This is a doc fix to `StringTokenizer`, where the original spec does not
>> account for the delimiter's length in the case of a supplementary character.
>> Corresponding CSR has been drafted:
>>
On Thu, 16 Dec 2021 18:41:32 GMT, Naoto Sato wrote:
>> This is a doc fix to `StringTokenizer`, where the original spec does not
>> account for the delimiter's length in the case of a supplementary character.
>> Corresponding CSR has been drafted:
>>
The proposed fix is to address the performance degradation caused by the fix to
JDK-8275721. Some amount of the degradation cannot be avoided as the lookup now
falls back up to the bundles at Locale.ROOT. However, by lowering the fallback
priority of `regionFormatFallback` than `COMPAT`'s
On Thu, 16 Dec 2021 19:39:59 GMT, kabutz wrote:
> Terribly sorry to ask this, but where would I see the CSR? I don't have
> access to the JIRA in the backend.
You should be able to view it but not edit:
https://bugs.openjdk.java.net/browse/JDK-8278886
(To get creation/update access rights
On Thu, 16 Dec 2021 18:41:32 GMT, Naoto Sato wrote:
>> This is a doc fix to `StringTokenizer`, where the original spec does not
>> account for the delimiter's length in the case of a supplementary character.
>> Corresponding CSR has been drafted:
>>
On Thu, 16 Dec 2021 05:55:14 GMT, kabutz wrote:
>> This is looking good. I will create the CSR and propose it. Since the
>> holiday season is imminent it's likely no approval of the CSR will happen on
>> until the new year.
>
>> This is looking good. I will create the CSR and propose it. Since
> This is a doc fix to `StringTokenizer`, where the original spec does not
> account for the delimiter's length in the case of a supplementary character.
> Corresponding CSR has been drafted:
> https://bugs.openjdk.java.net/browse/JDK-8278814
Naoto Sato has updated the pull request
On Thu, 16 Dec 2021 17:44:04 GMT, Vicente Romero wrote:
> Hi,
>
> Please review this change that is fixing a bug in reflection in particular in
> `sun.reflect.annotation.TypeAnnotationParser::buildAnnotatedTypes` the
> current code is assuming that for inner class constructors it is always
>
Hi,
Please review this change that is fixing a bug in reflection in particular in
`sun.reflect.annotation.TypeAnnotationParser::buildAnnotatedTypes` the current
code is assuming that for inner class constructors it is always working on type
annotations on parameters, but it is also invoked to
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
This pull request has now been integrated.
Changeset: be6b90d9
Author:Stuart Marks
URL:
https://git.openjdk.java.net/jdk18/commit/be6b90d90b54883ff17f9f5ac0f271de37df7e2a
On Thu, 16 Dec 2021 05:55:14 GMT, kabutz wrote:
>> This is looking good. I will create the CSR and propose it. Since the
>> holiday season is imminent it's likely no approval of the CSR will happen on
>> until the new year.
>
>> This is looking good. I will create the CSR and propose it. Since
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/34
On Thu, 16 Dec 2021 12:31:01 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an issue with alignment constraints not being enforced
> correctly on on-heap segments dereference/copy operations. Alignment of
> on-heap segments cannot be computed exactly, as alignment of elements in
> arrays
This PR fixes an issue with alignment constraints not being enforced correctly
on on-heap segments dereference/copy operations. Alignment of on-heap segments
cannot be computed exactly, as alignment of elements in arrays is, ultimately a
VM implementation detail. Because of this, alignment
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/34
On Tue, 14 Dec 2021 00:14:32 GMT, Claes Redestad wrote:
> A few refactorings to how `java.util.Formatter` sets up `FormatString`s,
> aligning the implementation with changes explored by the TemplatedStrings JEP
> and ever so slightly improving performance:
>
> - turn `Flags` into an `int`
On Tue, 14 Dec 2021 00:14:32 GMT, Claes Redestad wrote:
> A few refactorings to how `java.util.Formatter` sets up `FormatString`s,
> aligning the implementation with changes explored by the TemplatedStrings JEP
> and ever so slightly improving performance:
>
> - turn `Flags` into an `int`
On Wed, 15 Dec 2021 23:04:37 GMT, Claes Redestad wrote:
> During TemplatedStrings work Jim has noticed that we could probably profit
> from reusing the lookup tables also for the 1 or 2 leftmost bytes:
>
> // We know there are at most two digits left at this point.
>
During TemplatedStrings work Jim has noticed that we could probably profit from
reusing the lookup tables also for the 1 or 2 leftmost bytes:
// We know there are at most two digits left at this point.
buf[--charPos] = DigitOnes[-i];
if (i < -9) {
On Thu, 16 Dec 2021 06:33:24 GMT, Stuart Marks wrote:
> A small modification to the Launcher's help text.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk18/pull/34
49 matches
Mail list logo
