On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of `>>>`.
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>> t
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Fri, 29 Apr 2022 02:54:06 GMT, Joe Darcy wrote:
> > Is there intent to backport this to the RI for JSR 337 MR 4?
>
> I think that would be helpful, if not strictly necessary.
PS And if backported, the spec could be updated for earlier release trains to
start at a different value like "4".
On Fri, 29 Apr 2022 03:00:40 GMT, Stuart Marks wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover most of the core functions of `IdentityHashMap`. Unfort
On Fri, 29 Apr 2022 02:12:19 GMT, Iris Clark wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change punctuation from review feedback.
>
> src/java.base/share/classes/java/lang/System.java line 743:
>
>> 741: *
On Fri, 29 Apr 2022 02:00:08 GMT, Iris Clark wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change punctuation from review feedback.
>
> src/java.base/share/classes/java/lang/VersionProps.java.template line 113:
>
>
On Fri, 29 Apr 2022 01:20:17 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On 21/04/2022 7:30 am,
some-java-user-99206970363698485...@vodafonemail.de wrote:
Thanks a lot for your feedback! My original message was a bit vague in parts,
sorry for that.
The proposal consists of the following:
1. Forbidding usage of `break`, `continue`, `yield` and `return` in `finally`
On Fri, 29 Apr 2022 00:06:32 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 257:
>>
>>> 255: checkEntries(map.entrySet(), entry(k1b, v1b),
>>> 256: entry(k2, v2));
>>> 257: }
>>
>> Would an additional check `assert
On Fri, 29 Apr 2022 01:20:17 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Thu, 28 Apr 2022 23:56:27 GMT, Mark Reinhold wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback; make sequence of values explicit.
>
> src/java.base/share/classes/java/lang/System.java line
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please a
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 28 Apr 2022 18:10:57 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Thu, 28 Apr 2022 13:17:59 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Thu, 28 Apr 2022 13:22:34 GMT, Jaikiran Pai wrote:
>> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
>> in the bug report that breaks `IdentityHashMap` now causes several cases in
>> this new test to fail. There's more that could be done, but the new tests
>> c
On Thu, 28 Apr 2022 20:54:29 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
> It should be possible for you finalize now.
Done.
Thanks @PaulSandoz .
-
PR: https://git.openjdk.java.net/jdk/pull/8291
Hi,
Even though many tutorial said that the new java.net.http.HttpClient
support Digest authentication it's not true:
https://github.com/openjdk/jdk/blob/master/src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java#L278
But at the same time HttpURLConnection support it th
On Thu, 28 Apr 2022 15:43:09 GMT, Andrew John Hughes wrote:
>> The new test added as part of the
>> [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot
>> trigger that bug and pass w/ and w/o fix.
>>
>> An updated test validates the "default" case when the
>> `jdk.io.File.e
On Thu, 28 Apr 2022 20:54:29 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Thu, 28 Apr 2022 20:15:44 GMT, Joe Darcy wrote:
> > Also, don't forget to update the CSR with the new specification text, for
> > the record. Otherwise, looks good!
>
> Will do; I'll update the CSR to reflect that change as well as to be more
> explicit about the sequence of values, once th
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please a
On Thu, 28 Apr 2022 20:13:48 GMT, Uwe Schindler wrote:
> By the way: FileOutputStream has exactly the same problem with
> `write(byte[])`. I see no test for it, but I assume this is now also fixed.
> That's a longstanding issue in Lucene (this is why we use a
> ChunkedOutputStream when writing
On Thu, 28 Apr 2022 20:15:36 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Thu, 28 Apr 2022 20:07:41 GMT, Joe Darcy wrote:
>> src/java.base/share/conf/security/java.policy line 34:
>>
>>> 32:"java.specification.version", "read";
>>> 33: permission java.util.PropertyPermission
>>> 34:"java.specification.maintenance.version"
On Thu, 28 Apr 2022 18:53:11 GMT, Mark Reinhold wrote:
> Also, don't forget to update the CSR with the new specification text, for the
> record. Otherwise, looks good!
Will do; I'll update the CSR to reflect that change as well as to be more
explicit about the sequence of values, once that is
On Thu, 28 Apr 2022 10:24:46 GMT, Jaikiran Pai wrote:
> Hello Joe, should the property description have a note stating what kind of a
> value this property holds, if at all present? Would it be free form text or
> an integer value?
>
There is some discussion about the sequence of values in
On Thu, 28 Apr 2022 19:37:00 GMT, Sean Mullan wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> sin
On Thu, 28 Apr 2022 20:02:36 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Brian Burkhalter has updated the
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please a
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the
On Wed, 27 Apr 2022 09:06:12 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
On Thu, 28 Apr 2022 17:36:32 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
On Thu, 28 Apr 2022 18:24:33 GMT, Andrey Turbanov wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commits
>
On Thu, 28 Apr 2022 17:36:32 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Thu, 28 Apr 2022 18:05:39 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in an
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in another bug if that would ease maintenance of that code
On Fri, 22 Apr 2022 07:08:24 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>>
On Thu, 28 Apr 2022 16:58:40 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Thu, 28 Apr 2022 12:31:31 GMT, Sean Mullan wrote:
> Should this be added to the default permissions in the
> `conf/security/java.policy` file along with other similar properties?
Seems reasonable; good catch.
-
PR: https://git.openjdk.java.net/jdk/pull/8437
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please a
On Thu, 28 Apr 2022 16:58:40 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Thu, 28 Apr 2022 08:10:38 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/WatchEvent.java line 51:
>
>> 49: /**
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in another bug if that would ease maintenance of that code
On Thu, 28 Apr 2022 08:08:37 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/nio/file/SecureDirectoryStream.java line 55:
>
>> 5
On Mon, 25 Apr 2022 04:35:13 GMT, Sergey Bylokhov wrote:
> The new test added as part of the
> [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot
> trigger that bug and pass w/ and w/o fix.
>
> An updated test validates the "default" case when the `jdk.io.File.enableADS`
>
On Mon, 25 Apr 2022 04:35:13 GMT, Sergey Bylokhov wrote:
> The new test added as part of the
> [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot
> trigger that bug and pass w/ and w/o fix.
>
> An updated test validates the "default" case when the `jdk.io.File.enableADS`
>
On Thu, 28 Apr 2022 15:10:18 GMT, Markus Grönlund wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/VirtualThreadSubmitFailedEvent.java
>> line 35:
>>
>>> 33:
>>> 34: @Category({"Java Runtime"})
>>> 35: @Label("Virtual thread submit task failed")
>>
>> The label is a bit a long, would "Virtu
On Thu, 28 Apr 2022 14:44:05 GMT, Erik Gahlin wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp line
On Wed, 27 Apr 2022 15:32:35 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright, @bug list
>
> LGTM
Thanks for reviews @RogerRiggs and @mlchung
-
PR: https://git.openjdk
On Wed, 27 Apr 2022 09:24:24 GMT, Kim Barrett wrote:
> Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
> passing if CloneableReference::clone were to throw CloneNotSupportedException.
> That should be a failure.
>
> Testing:
> Locally (linux-x64) verified test still
On Thu, 28 Apr 2022 14:41:04 GMT, Erik Gahlin wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp
On Thu, 28 Apr 2022 14:37:22 GMT, Erik Gahlin wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.cpp l
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
I will do a small ch
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
> This is a (preliminary) patch for javac implementation for the third preview
> of pattern matching for switch (type patterns in switches).
>
> Draft JLS:
> http://cr.openjdk.java.net/~gbierman/PatternSwitchPlusRecordPatterns/PatternSwitchPlusRecordPatterns-20220407/specs/patterns-switch-jls.htm
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
On Fri, 22 Apr 2022 03:37:27 GMT, Stuart Marks wrote:
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch
> in the bug report that breaks `IdentityHashMap` now causes several cases in
> this new test to fail. There's more that could be done, but the new tests
> cover
On Thu, 28 Apr 2022 07:16:30 GMT, Matthias Baesken wrote:
> Hi Erik/David/Phil, we already have a good central place where we set the
> definition of WIN32_LEAN_AND_MEAN
>
> autoconf/flags-cflags.m4:460: ALWAYS_DEFINES_JDK="-DWIN32_LEAN_AND_MEAN
> -D_CRT_SECURE_NO_DEPRECATE autoconf/flags-cfla
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote:
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for
On Wed, 27 Apr 2022 03:28:09 GMT, Stuart Marks wrote:
>> test/jdk/java/util/IdentityHashMap/Basic.java line 77:
>>
>>> 75: E[] contents = (E[]) c.toArray();
>>> 76:
>>> 77: assertEquals(c.size(), given.length);
>>
>> I believe testng has the expected values in front in the `ass
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote:
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for
On Wed, 30 Mar 2022 11:38:59 GMT, Aleksey Shipilev wrote:
> See bug report for more details. This change improves
> SPECjvm2008:xml.validation for about +3%:
>
>
> baseline: 298.353 ± 1.008 ops/min
> patched: 309.912 ± 1.347 ops/min
>
> Of course, the real improvements might be even high
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Wed, 27 Apr 2022 19:43:22 GMT, Paul Sandoz wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/java.base/share/classes/java/util/concurrent/ThreadPerTaskExecu
On Wed, 27 Apr 2022 19:21:58 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/UnsafeConstants.java line 122:
>>
>>> 120: */
>>> 121:
>>> 122: public static final int SCOPED_CACHE_SHIFT;
>>
>> I can't find this constant being used. If added for future, maybe
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Wed, 27 Apr 2022 15:10:51 GMT, Alan Bateman wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/winpro
82 matches
Mail list logo
