On Sep 24, 3:10pm, rob.mcke...@oracle.com (Rob McKenna) wrote:
-- Subject: Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of str
| Hi folks,
|
| Uploaded a newer version:
|
| http://cr.openjdk.java.net/~robm/8133249/webrev.02/
|
| To address Rogers question, this needed to be separ
On Sep 21, 10:38pm, rob.mcke...@oracle.com (Rob McKenna) wrote:
-- Subject: Re: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of str
| I'll have a new webrev up soon that addresses the first comment and
| Rogers feedback.
You know, given the complexity of the strerror_r() hacks to make
On Sep 21, 4:53pm, rob.mcke...@oracle.com (Rob McKenna) wrote:
-- Subject: RFR - 8133249: Occasional SIGSEGV: non thread-safe use of strerr
| Hi folks,
|
| Requesting a review of this change which switches corelibs usages of the
| thread-unsafe strerror over to strerror_r/strerror_s:
|
| http
On May 22, 10:54am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR 9: 8074818: Resolve disabled warnings for libjava
| I agree it's a good idea to increase safety by replacing calls to *printf
| with calls to *nprintf, BUT when we do so we should also add debugging
| assertions t
On Mar 3, 2:41pm, dmitry.samers...@oracle.com (Dmitry Samersoff) wrote:
-- Subject: Re: stop using mmap for zip I/O
| Christos,
|
| JVM install it's own signal handler and use it to numerous tasks, so add
| signal handler to zip_util.c is problematic.
Yes, I understand; this is why I mentioned
On Feb 27, 1:49pm, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: stop using mmap for zip I/O
| > The issues I've been looking at are SEGV issues concerning multiple threads
| > operating on the same zip structure. (one freeing, while another is
| > attempting access)
Yes, I am not refer
On Feb 27, 9:51am, sean.cof...@oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=)
wrote:
-- Subject: Re: stop using mmap for zip I/O
| The sun.zip.disableMemoryMapping=true property helps with ZipFile class
| only. There are other related issues in the ZipInput/Output streams.
| Some code areas don
On Feb 27, 9:34am, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: stop using mmap for zip I/O
| On 26/02/15 22:17, Christos Zoulas wrote:
| > There are numerous bug reports about the jvm crashing in libzip...
| > Just google for "libzip java crash". The bottom line is tha
On Feb 26, 2:32pm, xueming.s...@oracle.com (Xueming Shen) wrote:
-- Subject: Re: stop using mmap for zip I/O
| That's true, unfortunately, the mmap does trigger crash here and there
|
| There is a property you can define to disable it in later releases
| -Dsun.zip.disableMemoryMapping=true
|
Hi,
There are numerous bug reports about the jvm crashing in libzip...
Just google for "libzip java crash". The bottom line is that using
mmap is problematic (I can get into more per OS details if necessary)
because it will potentially signal when the file size is altered.
Can we please turn USE_
On Feb 15, 6:52pm, dmitry.samers...@oracle.com (Dmitry Samersoff) wrote:
-- Subject: RFR(S): JDK-8073175, 8073174: Fix native warnings in libjli and l
| Hi Everyone,
|
| It's my $0.02 to the warning cleanup work. Please review:
|
| http://cr.openjdk.java.net/~dsamersoff/JDK-8073175/webrev.01
|
On Feb 13, 4:29pm, vladimir.koz...@oracle.com (Vladimir Kozlov) wrote:
-- Subject: Re: RFR: 8073093: AARCH64: C2 generates poor code for ByteBuffer
| On 2/13/15 4:22 PM, Dean Long wrote:
| > There is a system register bit to read, but I don't think it can be
| > accessed by an application, only
On Feb 13, 2:52pm, dean.l...@oracle.com (Dean Long) wrote:
-- Subject: Re: RFR: 8073093: AARCH64: C2 generates poor code for ByteBuffer
| My understanding is that whether or not aarch64 allows unaligned=20
| accesses is based on a
| system setting, so this change is too simplistic. I would pref
On Feb 12, 4:56pm, lev.pri...@oracle.com (Lev Priima) wrote:
-- Subject: Re: 8072909: TimSort fails with ArrayIndexOutOfBoundsException on
| Christos,
|
| Test may fail on shorter arrays(page 8 of paper). For instance, on worst
| case, generated by test, it starts to fail on length 67108864.
|
On Feb 12, 9:57pm, david.hol...@oracle.com (David Holmes) wrote:
-- Subject: Re: 8072909: TimSort fails with ArrayIndexOutOfBoundsException on
| Ok - thanks Lev!
|
| David
For posterity can someone document this, and also the value for which
Integer.MAX_VALUE-4 fails?
christos
On Oct 30, 11:26am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: Losing features of JVM_Open, e.g. CLOEXEC
| On Thu, Oct 30, 2014 at 10:52 AM, Mario Torre
| wrote:
| > Indeed, but /proc/$PID/fd can perhaps be useful here? Not sure if this
| > can make a reasonable test though.
|
On Oct 29, 1:12pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Losing features of JVM_Open, e.g. CLOEXEC
| throwing away use of old shared infrastructure and replacing with "naked"
| calls to the OS. Although understandable, this abandons benefits of using
| shared infrastructure.
On Jul 23, 10:43am, david.ll...@redhat.com ("David M. Lloyd") wrote:
-- Subject: Re: RFR [8020669] java.nio.file.Files.readAllBytes() does not rea
| > The only sure way to read all the data from a file in Unix is to attempt
| > to read(2) until it returns 0 (or -1 on error). If you think you can t
On Jul 22, 11:58am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR [8020669] java.nio.file.Files.readAllBytes() does not rea
| It's the OS/filesystem implementer deciding to return a bogus number.
|
| More accurate would be to count by reading all the bytes, but that is
| imprac
On Apr 10, 1:44pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| Christos, I think you may have overlooked the subtlety that pathv is *not*
| a const pointer - it just looks like one.
|
Yes, indeed; you are right!
christos
On Apr 10, 11:54am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| > 1. We did we switch from NEW() to xmalloc()? Why is the xmalloc cast
| > needed?
|
| NEW is for allocating homogeneous arrays, but here the memory block is
| being used for both chars and pointers.
I
On Apr 10, 1:54pm, john.zavg...@oracle.com (John Zavgren) wrote:
-- Subject: Re: RFR-8008118
| Your comments are welcome.
1. We did we switch from NEW() to xmalloc()? Why is the xmalloc cast needed?
2. I would not declare pathv "const char **", but "char **", and then
cast the return if neede
On Apr 2, 11:20pm, mark.shepp...@oracle.com (Mark Sheppard) wrote:
-- Subject: Re: RFR-8008118
| Hi Martin,
|are there any concerns that the string literal "." might be on the
| stack and not in data segment or heap?
| In previous exchanges the static const char *const cwd was declared to
On Mar 28, 8:42pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| Latest webrev does it this way:
|
| for (i = 0; i < count; i++) {
| char *q = p + strcspn(p, ":");
| pathv[i] = (p == q) ? "." : p;
| *q = '\0';
| p = q + 1;
| }
On Mar 28, 11:12am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| My apologies for unrelenting perfectionism - I noticed that we can:
| - colocate the pathv and path in one malloc'ed chunk
| - can discard xstrdup
| - can iterate through path with only one char* pointer
On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote:
-- Subject: Re: DefaultProxySelector socks override
| On 03/27/2013 05:22 PM, chris...@zoulas.com wrote:
| >
| > Sure, I just requested a subscription to net-dev so I might not see the
| > first few messages. To clarify:
| >
On Mar 27, 3:54pm, chris.hega...@oracle.com (Chris Hegarty) wrote:
-- Subject: Re: DefaultProxySelector socks override
Hi Chris,
| [cc'ing net-dev, we can then probably drop core-libs-dev and continue
| the discussion over on net-dev]
|
| Christos,
|
| SOCKS is really old and not as widely de
This trivial patch add "socksNonProxyHosts" to the default proxy,
so that we can select which socket traffic will be directed to
the proxy and which not. There is currently no way to do this. In
my scenario, I have applications that would benefit in terms of
performance to connect directly to our
On Mar 26, 6:13pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| Here is my alternative set of perfectionist changes:
:-)
| # Fix PATH handling
| http://cr.openjdk.java.net/~martin/webrevs/openjdk8/pathv/
LGTM, only question is why error from one allocation throws
On Mar 21, 11:36am, john.zavg...@oracle.com (John Zavgren) wrote:
-- Subject: Re: RFR-8008118
| All:
|
| How does this look?
| 1.) I reverted the for statement formatting change.
Not exactly. Now it is indented incorrectly.
| 2.) I removed the goto statement and "inlined" some code instead.
I
On Mar 21, 10:10am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR-8008118
| Please revert this formatting change:
|
| -for (q = p; (*q != ':') && (*q != '\0'); q++)
| -;
| +for (q = p; (*q != ':') && (*q != '\0'); q++);
| +
|
Stylistically I prefer
On Feb 6, 10:04am, chris.hega...@oracle.com (Chris Hegarty) wrote:
-- Subject: Re: RFR: race with nested repos in hgforest.sh
| Yes this is better, but the quotes are incorrect. It should simply be
|for rc in ${tmp}/*.pid.rc ; do
This will break if there is no match.
christos
On Oct 19, 9:11am, weijun.w...@oracle.com (Weijun Wang) wrote:
-- Subject: Re: bug fix for native kerberos libraries
| Hi Christos
|
| You mean the exception thrown in NativeGSSFactory.java lines 52-60?
|
| Vector creds = GSSUtil.searchSubject
| (name, mech, initiate, GSSC
Hello,
This simple fix allows kerberos authentication to work with:
-Dsun.security.jgss.native=true
and microsoft's sqljdbc 4.0.2206.100 driver.
Enjoy,
christos
--- a/java/src/sun/security/jgss/GSSUtil.java Mon Oct 15 17:43:08 2012 -0400
+++ b/java/src/sun/security/jgss/GSSUtil.java
On Oct 8, 11:07pm, david.hol...@oracle.com (David Holmes) wrote:
-- Subject: Re: StackTraceElement question
| > There is also the problem of having a class hierarchy like:
| >
| > class A extends class I
| > class B extends class I
| >
| > and then trying to figure out if it is A or B when you jus
On Oct 8, 7:33pm, rednaxel...@gmail.com (Krystal Mok) wrote:
-- Subject: Re: StackTraceElement question
| > Can't you just do Class.forName(getClassName()) and then find the
| > enclosing class?
| >
| > There could be potential class loader issues to
| use Class.forName(getClassName()) in this ca
On Aug 30, 9:17am, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java
| -Werror is probably OK for Java code, but not for HotSpot.
|
| We GCC developers keep adding new warnings, so poor souls who keep
| up-to-date with new Fedora
On Aug 5, 10:41am, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: JDK 8 code review request for 7075098: Remove unused fdlibm f
| On 08/04/2011 09:09 PM, Joe Darcy wrote:
|
| > Mike Duigou wrote:
| >> Looks good to me.
| >>
| >> I did wonder if we have a policy for tracking fdlibm updates
On May 24, 4:55pm, xer...@zafena.se (=?UTF-8?B?WGVyeGVzIFLDpW5ieQ==?=) wrote:
-- Subject: Re: Math.log(17197) produces inconsistent results between javac,
| Im only able to test x86:
|
| But no javac still produces different ressult when compiling
|
| static double log_result = Math.log(log_va
On Feb 27, 5:49pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: Codereview needed for #6929479
| On Thu, Feb 25, 2010 at 12:09, Lance J. Andersen
wrote:
| > Going forward, should we be using sun or oracle in the property names?
|
| It is impractical to stamp out the "sun" in th
On Nov 12, 8:29am, david.hol...@sun.com (David Holmes - Sun Microsystems)
wrote:
-- Subject: Re: Anyway in java to way for the child process to wait for paren
| Paulo Levi said the following on 11/12/09 05:31:
| > In process builder.
|
| No.
|
| I'm not aware of any OS support for waiting for
On Jun 30, 4:39pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: Review request for 5049299
| In the JDK...
| We close all non-relevant file descriptors in the child instead of relying
| on
| having the FD_CLOEXEC bit set properly for every fd in the parent.
|
| The technique of c
On Jun 23, 3:33pm, a...@redhat.com (Andrew Haley) wrote:
-- Subject: Re: Review request for 5049299
| I can debug this.
|
| Please try first syscall(SYS_clone ...) to bypass the libc gubbins.
| That might be all you need. If that doesn't help I'll have a look.
|
| Isn't there some point at whi
On May 26, 3:20pm, michael.mcma...@sun.com (Michael McMahon) wrote:
-- Subject: Re: Review request for 5049299
| Christos Zoulas wrote:
| > Let's forget about the overcommit heuristics/settings alltogether.
| > We need a portable solution to the problem that works in all scenar
On May 26, 12:10pm, michael.mcma...@sun.com (Michael McMahon) wrote:
-- Subject: Re: Review request for 5049299
| I played around with your test and I see similar behaviour on my Ubuntu
| 8.04 system.
| When you switch on "always overcommit" (not the default) then you get
| the expected
| behavi
On Mar 26, 11:01am, thomas.rodrig...@sun.com (Tom Rodriguez) wrote:
-- Subject: Re: SIGFPE with FPE_FLTRES
| > I would just remove the trancendental c implementation. It is not
| > consistent
| > with the java one anyway on amd64:
|
| You've got that backwards. The C implementation is actually
On Mar 25, 4:28pm, thomas.rodrig...@sun.com (Tom Rodriguez) wrote:
-- Subject: Re: SIGFPE with FPE_FLTRES
| That's even more odd to me. x86_64 shouldn't be using the old FP
| instructions and the SSE based one don't produce an inexact traps as
| far as I can tell. Maybe they are still being
On Jan 28, 12:16pm, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: [PATCH]: Portability fixes
| Christos, thanks for the bug report.
|
| For low level code like this, it's almost always a mistake
| (my mistake, that is; I am the author)
| to use the locale-dependent functions like i
Hello,
Here are some simple changes for your consideration:
1. passing possibly negative values to isdigit is undefined behavior:
http://www.opengroup.org/onlinepubs/009695399/functions/isdigit.html
2. passing possibly negative values to isspace is undefined behavior:
http://www.opengroup.o
49 matches
Mail list logo
