Re: RFR: JDK-8287867: Bad merge of jdk/test/lib/util/ForceGC.java causing test compilation error

2022-06-06 Thread Daniel D . Daugherty
On Mon, 6 Jun 2022 21:58:20 GMT, Mandy Chung wrote: > A typo in ForceGC.java causes several test failing due to compilation error. Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/9043

Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
On Sun, 5 Jun 2022 14:00:09 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in > -Xcomp. This pull request has now been integrated. Changeset: 3df4b034 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/

Re: Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
On Sun, 5 Jun 2022 14:05:42 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in >> -Xcomp. > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the fast review! Especially early on a Sunday!! - PR: https://git.openj

Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp. - Commit messages: - 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp Changes: https://git.openjdk.java.net/jdk/pull/9033/files Webrev: https://webrevs.openjdk.java.net/?repo=

Re: RFR: 8287746: ProblemList jni/nullCaller/NullCallerTest.java

2022-06-02 Thread Daniel D . Daugherty
On Thu, 2 Jun 2022 18:57:36 GMT, Mandy Chung wrote: > 8287746: ProblemList jni/nullCaller/NullCallerTest.java Marked as reviewed by dcubed (Reviewer). test/jdk/ProblemList.txt line 500: > 498: java/lang/invoke/lambda/LambdaFileEncodingSerialization.java8249079 > linux-x64 > 499: java/lang

Re: RFR: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java [v2]

2022-05-05 Thread Daniel D . Daugherty
On Thu, 5 May 2022 19:56:36 GMT, Roger Riggs wrote: >> Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191. > > Roger Riggs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in

Re: RFR: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java

2022-05-05 Thread Daniel D . Daugherty
On Thu, 5 May 2022 15:30:15 GMT, Roger Riggs wrote: > Put jdk/jshell/ExternalEditorTest.java on the problem list due to 8286191. Thumbs up (after resync). This is a trivial fix. test/lib-test/ProblemList.txt line 40: > 38: # > 39: >

Re: RFR: JDK-8286191: misc tests fail due to JDK-8286191

2022-05-05 Thread Daniel D . Daugherty
On Thu, 5 May 2022 15:21:23 GMT, Matthias Baesken wrote: > The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. @MBaesken - I corrected a typo

Re: RFR: JDK-8286191: misc tests fail due to JDK-8286191

2022-05-05 Thread Daniel D . Daugherty
On Thu, 5 May 2022 15:21:23 GMT, Matthias Baesken wrote: > The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. Changes requested by dcubed (Re

Re: RFR: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java

2022-05-05 Thread Daniel D . Daugherty
On Thu, 5 May 2022 14:33:51 GMT, Roger Riggs wrote: > Add a failing test library test to the ProblemList. > > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openj

Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Daniel D . Daugherty
On Wed, 27 Apr 2022 16:53:44 GMT, Daniel D. Daugherty wrote: > A trivial fix for JDK-8236128 causes validate-source failures. This pull request has now been integrated. Changeset: 5b42747b Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/com

Re: Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Daniel D . Daugherty
On Wed, 27 Apr 2022 16:53:44 GMT, Daniel D. Daugherty wrote: > A trivial fix for JDK-8236128 causes validate-source failures. The bot is being very, very, slow to integrate this... - PR: https://git.openjdk.java.net/jdk/pull/8429

Re: Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Daniel D . Daugherty
On Wed, 27 Apr 2022 16:55:11 GMT, Mikael Vidstedt wrote: >> A trivial fix for JDK-8236128 causes validate-source failures. > > Marked as reviewed by mikael (Reviewer). @vidmik and @alexeysemenyukoracle - Thanks for the fast reviews. - PR: https://git.openjdk.java.net/jdk/pull/8429

Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Daniel D . Daugherty
A trivial fix for JDK-8236128 causes validate-source failures. - Commit messages: - 8285736: JDK-8236128 causes validate-source failures Changes: https://git.openjdk.java.net/jdk/pull/8429/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8429&range=00 Issue: https://bu

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-04-27 Thread Daniel D . Daugherty
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Integrated: 8285677: ProblemList two tests from JDK-8285671 on macosx-x64

2022-04-26 Thread Daniel D . Daugherty
On Tue, 26 Apr 2022 19:35:19 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two tests from JDK-8285671 on macosx-x64. This pull request has now been integrated. Changeset: e3d714d3 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/com

Re: Integrated: 8285677: ProblemList two tests from JDK-8285671 on macosx-x64

2022-04-26 Thread Daniel D . Daugherty
On Tue, 26 Apr 2022 19:39:02 GMT, Daniel Fuchs wrote: >> A trivial fix to ProblemList two tests from JDK-8285671 on macosx-x64. > > LGTM Dan. Thanks for taking care of that! @dfuch - Thanks for the fast review! And no worries about handling the ProblemListing... - PR: https://git.o

Integrated: 8285677: ProblemList two tests from JDK-8285671 on macosx-x64

2022-04-26 Thread Daniel D . Daugherty
A trivial fix to ProblemList two tests from JDK-8285671 on macosx-x64. - Commit messages: - 8285677: ProblemList two tests from JDK-8285671 on macosx-x64 Changes: https://git.openjdk.java.net/jdk/pull/8406/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8406&range=00

Integrated: 8283720: ProblemList java/time/test/java/time/TestZoneOffset.java

2022-03-26 Thread Daniel D . Daugherty
On Sat, 26 Mar 2022 13:04:33 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/time/test/java/time/TestZoneOffset.java. This pull request has now been integrated. Changeset: c587b29b Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8283720: ProblemList java/time/test/java/time/TestZoneOffset.java

2022-03-26 Thread Daniel D . Daugherty
On Sat, 26 Mar 2022 13:25:00 GMT, Alan Bateman wrote: >> A trivial fix to ProblemList java/time/test/java/time/TestZoneOffset.java. > > Marked as reviewed by alanb (Reviewer). @AlanBateman - Thanks for the fast review! Especially for a Saturday... - PR: https://git.openjdk.java.net

RFR: 8283720: ProblemList java/time/test/java/time/TestZoneOffset.java

2022-03-26 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/time/test/java/time/TestZoneOffset.java. - Commit messages: - 8283720: ProblemList java/time/test/java/time/TestZoneOffset.java Changes: https://git.openjdk.java.net/jdk/pull/7970/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7970&ran

Re: RFR: 8283325: US_ASCII decoder relies on String.decodeASCII being exhaustive [v2]

2022-03-17 Thread Daniel D . Daugherty
On Thu, 17 Mar 2022 19:47:14 GMT, Claes Redestad wrote: >> Adjust `String.decodeASCII` to deal with the possibility that >> `StringCoding.countPositives` can return a value less than the exact number >> of leading positive bytes. This is the likely cause of a number of >> intermittent but some

Re: RFR: 8283325: US_ASCII decoder relies on String.decodeASCII being exhaustive

2022-03-17 Thread Daniel D . Daugherty
On Thu, 17 Mar 2022 16:08:42 GMT, Claes Redestad wrote: > Adjust `String.decodeASCII` to deal with the possibility that > `StringCoding.countPositives` can return a value less than the exact number > of leading positive bytes. This is the likely cause of a number of > intermittent but somewhat

Integrated: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java

2022-02-08 Thread Daniel D . Daugherty
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java. This pull request has now been integrated. Changeset: 5fb56dbb Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/com

Re: Integrated: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java

2022-02-08 Thread Daniel D . Daugherty
On Tue, 8 Feb 2022 20:10:38 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java. > > Marked as reviewed by azvegint (Reviewer). @azvegint and @bplb - Thanks for the lightning fast reviews! - PR: https://git.openjdk.java.ne

Integrated: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java

2022-02-08 Thread Daniel D . Daugherty
A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java. - Commit messages: - 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java Changes: https://git.openjdk.java.net/jdk/pull/7390/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7390&r

Re: RFR: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops

2022-01-30 Thread Daniel D . Daugherty
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote: > Recent test regression after adding new cases in the test. Without compressed > oops, ~1G elements `Object[]` array takes >8G of memory, which fails the > test. The fix cuts it down to 512M when reference size is 8 bytes. > Additional

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

2022-01-26 Thread Daniel D . Daugherty
On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from GetModuleHandle("zip.dll"),

[jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
A couple of trivial ProblemListings: JDK-8279529 ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 JDK-8279532 ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java - Commit messages: - 8279532: ProblemList sun/secur

Integrated: 8277649 [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-23 Thread Daniel D . Daugherty
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty wrote: > This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21. > > The fix for JDK-8277507 is causing 38 failures per Tier2 job set. This pull request has now been integrated. Changeset: 64bdc843 Author: Daniel D.

Integrated: 8277649 [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-23 Thread Daniel D . Daugherty
This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21. The fix for JDK-8277507 is causing 38 failures per Tier2 job set. - Commit messages: - Revert "8277507: Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures" Chan

Re: Integrated: 8277649 [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-23 Thread Daniel D . Daugherty
On Tue, 23 Nov 2021 15:12:43 GMT, Stefan Karlsson wrote: >> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21. >> >> The fix for JDK-8277507 is causing 38 failures per Tier2 job set. > > Marked as reviewed by stefank (Reviewer). @stefank and @AlanBateman - Thanks for the lightning fa

Integrated: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Daniel D . Daugherty
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty wrote: > This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. > > So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this > [BACKOUT] has > passed the macosx-aarch64 test task that was failin

Re: RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Daniel D . Daugherty
On Fri, 19 Nov 2021 22:33:40 GMT, Alexey Semenyuk wrote: >> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. >> >> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this >> [BACKOUT] has >> passed the macosx-aarch64 test task that was failing before. > > Marked

Re: RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Daniel D . Daugherty
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty wrote: > This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. > > So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this > [BACKOUT] has > passed the macosx-aarch64 test task that was faili

Re: RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Daniel D . Daugherty
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty wrote: > This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. > > So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this > [BACKOUT] has > passed the macosx-aarch64 test task that was faili

RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Daniel D . Daugherty
This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this [BACKOUT] has passed the macosx-aarch64 test task that was failing before. - Commit messages: - Revert "8276150: Quarantined jpackage apps are la

Re: RFR: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

2021-09-01 Thread Daniel D . Daugherty
On Wed, 1 Sep 2021 17:35:12 GMT, Naoto Sato wrote: >> A trivial fix to ProblemList >> java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the review! - PR: https://git.openjdk.java.net/jdk/pull/53

Integrated: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

2021-09-01 Thread Daniel D . Daugherty
On Wed, 1 Sep 2021 17:33:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. This pull request has now been integrated. Changeset: 4ee0dace Author:Daniel D. Daugherty URL:

Re: Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

2021-09-01 Thread Daniel D . Daugherty
On Tue, 31 Aug 2021 20:02:37 GMT, Naoto Sato wrote: >> Trivial fixes to reduce the noise in the JDK18 CI: >> JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 >> JDK-8273198 ProblemList >> java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188 >> >> These failures ha

RFR: 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs

2021-09-01 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs. - Commit messages: - 8273248: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh on all configs Changes: https://git.openjdk.java.net/jdk/pull/5337/files Webrev:

Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

2021-08-31 Thread Daniel D . Daugherty
On Tue, 31 Aug 2021 19:44:08 GMT, Daniel D. Daugherty wrote: > Trivial fixes to reduce the noise in the JDK18 CI: > JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 > JDK-8273198 ProblemList > java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-827318

Integrated: 8273197: ProblemList 2 jtools tests due to JDK-8273187

2021-08-31 Thread Daniel D . Daugherty
Trivial fixes to reduce the noise in the JDK18 CI: JDK-8273197 ProblemList 2 jtools tests due to JDK-8273187 JDK-8273198 ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188 These failures happen in Tier5 so I'm ProblemListing them now to give @naotoj time to wo

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 - Commit messages: - 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 Changes: https://git.openjdk.java.net/jdk/pull/5032/files Webrev: https://w

Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
On Fri, 6 Aug 2021 13:32:00 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 This pull request has now been integrated. Changeset: f4cf2f7c Author:Daniel D. Daugherty URL:

Re: Integrated: 8272095: ProblemList java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64

2021-08-06 Thread Daniel D . Daugherty
On Fri, 6 Aug 2021 13:34:37 GMT, Alan Bateman wrote: >> A trivial fix to ProblemList >> java/nio/channels/FileChannel/Transfer2GPlus.java on linux-aarch64 > > Marked as reviewed by alanb (Reviewer). @AlanBateman - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/

[jdk17] Integrated: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
On Wed, 28 Jul 2021 17:51:31 GMT, Daniel D. Daugherty wrote: > 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java This pull request has now been integrated. Changeset: 7bf72ce3 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk17/com

Re: [jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
On Wed, 28 Jul 2021 18:42:11 GMT, Naoto Sato wrote: >> 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/pull/291

[jdk17] RFR: 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java

2021-07-28 Thread Daniel D . Daugherty
8271412: ProblemList javax/sound/midi/Sequencer/Looping.java - Commit messages: - 8271413: ProblemList 2 locale tests on macOS-x64 - 8271412: ProblemList javax/sound/midi/Sequencer/Looping.java Changes: https://git.openjdk.java.net/jdk17/pull/291/files Webrev: https://webrevs.open

[jdk17] Integrated: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

2021-06-28 Thread Daniel D . Daugherty
On Mon, 28 Jun 2021 17:05:49 GMT, Daniel D. Daugherty wrote: > A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java > from ProblemList.txt This pull request has now been integrated. Changeset: 20640a57 Author:Daniel D. Daugherty URL:

Re: [jdk17] RFR: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

2021-06-28 Thread Daniel D . Daugherty
On Mon, 28 Jun 2021 17:15:23 GMT, Igor Ignatyev wrote: >> A trivial fix to remove >> java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt > > Marked as reviewed by iignatyev (Reviewer). @iignatev and @tschatzl - Thanks for the fast reviews. - PR: https://git.

[jdk17] RFR: 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt

2021-06-28 Thread Daniel D . Daugherty
A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt - Commit messages: - 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt Changes: https://git.openjdk.java.net/jdk17/pull/164/files Webrev: ht

[jdk17] Integrated: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

2021-06-17 Thread Daniel D . Daugherty
On Thu, 17 Jun 2021 16:32:52 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java > on win-x64. This pull request has now been integrated. Changeset: b66001a5 Author:Daniel D. Daugherty URL: https://git.openjdk.ja

Re: [jdk17] RFR: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

2021-06-17 Thread Daniel D . Daugherty
On Thu, 17 Jun 2021 16:49:49 GMT, Andy Herrick wrote: >> A trivial fix to ProblemList >> tools/jpackage/windows/WinInstallerIconTest.java on win-x64. > > Marked as reviewed by herrick (Reviewer). @andyherrick - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk17/p

[jdk17] RFR: 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64

2021-06-17 Thread Daniel D . Daugherty
A trivial fix to ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64. - Commit messages: - 8268971: ProblemList tools/jpackage/windows/WinInstallerIconTest.java on win-x64 Changes: https://git.openjdk.java.net/jdk17/pull/90/files Webrev: https://webrevs.openjd

Re: RFR: Merge jdk17

2021-06-14 Thread Daniel D . Daugherty
On Mon, 14 Jun 2021 14:28:33 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 Thumbs up! Thanks for doing this sync forward. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4484

Re: RFR: 8268227: java/foreign/TestUpcall.java still times out

2021-06-07 Thread Daniel D . Daugherty
On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore wrote: > Turns out that adding more timeout is a lost cause here. The root cause of > the slowdown when running the test in debug build is: > > https://bugs.openjdk.java.net/browse/JDK-8266074 > > Which has also caused related test issues:

Re: RFR: 8268227: java/foreign/TestUpcall.java still times out

2021-06-05 Thread Daniel D . Daugherty
On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore wrote: > Turns out that adding more timeout is a lost cause here. The root cause of > the slowdown when running the test in debug build is: > > https://bugs.openjdk.java.net/browse/JDK-8266074 > > Which has also caused related test issues:

Re: RFR: 8268131: 2 java/foreign tests timed out

2021-06-03 Thread Daniel D . Daugherty
On Wed, 2 Jun 2021 21:20:53 GMT, Maurizio Cimadamore wrote: > This patch increases time out for both TestUpcall and TestDowncall. These > tests were already long-running, but with JEP-412, they were beefed up even > more, so now they time out on some debug builds. > > This patch also address

Re: Integrated: 8268146: fix for JDK-8266254 fails validate-source

2021-06-02 Thread Daniel D . Daugherty
On Wed, 2 Jun 2021 21:50:24 GMT, Bradford Wetmore wrote: >> A trivial copyright fix. > > LGTM @bradfordwetmore - Thanks for the review. - PR: https://git.openjdk.java.net/jdk/pull/4323

Integrated: 8268146: fix for JDK-8266254 fails validate-source

2021-06-02 Thread Daniel D . Daugherty
On Wed, 2 Jun 2021 21:39:15 GMT, Daniel D. Daugherty wrote: > A trivial copyright fix. This pull request has now been integrated. Changeset: 76fdf2c8 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/76fdf2c89bb7df9140438fcbaf16ea5fda024551 Stats: 1 l

Re: Integrated: 8268146: fix for JDK-8266254 fails validate-source

2021-06-02 Thread Daniel D . Daugherty
On Wed, 2 Jun 2021 21:40:59 GMT, Paul Sandoz wrote: >> A trivial copyright fix. > > Marked as reviewed by psandoz (Reviewer). @PaulSandoz - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/pull/4323

Integrated: 8268146: fix for JDK-8266254 fails validate-source

2021-06-02 Thread Daniel D . Daugherty
A trivial copyright fix. - Commit messages: - 8268146: fix for JDK-8266254 fails validate-source Changes: https://git.openjdk.java.net/jdk/pull/4323/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4323&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268146

Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

2021-05-27 Thread Daniel D . Daugherty
On Thu, 27 May 2021 20:17:59 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. This pull request has now been integrated. Changeset: 8a31c075 Author:Daniel D. Daugherty URL:

Re: Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

2021-05-27 Thread Daniel D . Daugherty
On Thu, 27 May 2021 20:22:31 GMT, Stuart Marks wrote: >> A trivial fix to ProblemList >> javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. > > Marked as reviewed by smarks (Reviewer). @stuart-marks - Thanks for the fast review. - PR: https://git.openjdk.java.

Integrated: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

2021-05-27 Thread Daniel D . Daugherty
A trivial fix to ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java. - Commit messages: - 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java Changes: https://git.openjdk.java.net/jdk/pull/4231/files Webrev:

Re: Integrated: 8267180: Typo in copyright header for HashesTest

2021-05-14 Thread Daniel D . Daugherty
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote: > Please review this fix for a typo in the copyright header in HashTest which > the jdk-tier1 does not catch > > Best > Lance Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.o

Integrated: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64

2021-04-16 Thread Daniel D . Daugherty
On Fri, 16 Apr 2021 18:07:01 GMT, Daniel D. Daugherty wrote: > A set of trivial ProblemListing for macos-aarch64 Tier2 test failures: > > - JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 > - JDK-8265361 ProblemList a few compiler/whitebox tests on macos-aar

Re: RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 [v2]

2021-04-16 Thread Daniel D . Daugherty
On Fri, 16 Apr 2021 19:42:06 GMT, Brian Burkhalter wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove changes for JDK-8265366 at @fguallini's request. > > Marked as

Re: RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 [v2]

2021-04-16 Thread Daniel D . Daugherty
t.java on macos-aarch64 > - JDK-8265368 ProblemList 3 java/net/httpclient/websocket tests on > macos-aarch64 > - JDK-8265370 ProblemList java/net/MulticastSocket/Promiscuous.java on > macos-aarch64 Daniel D. Daugherty has updated the pull request incrementally with one additional com

RFR: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64

2021-04-16 Thread Daniel D . Daugherty
A set of trivial ProblemListing for macos-aarch64 Tier2 test failures: - JDK-8265358 ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64 - JDK-8265361 ProblemList a few compiler/whitebox tests on macos-aarch64 - JDK-8265363 ProblemList java/net/Socket/UdpSocket.java on macos-aarch64 - JDK-8

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

2021-04-06 Thread Daniel D . Daugherty
On Tue, 6 Apr 2021 16:45:15 GMT, Joe Darcy wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add bug number > > test/jdk/java/util/Random/RandomTestBsi1999.java line 443: > >> 441: >> 442: if (currentRNG.

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

2021-04-06 Thread Daniel D . Daugherty
On Tue, 6 Apr 2021 16:46:06 GMT, Jim Laskey wrote: >> SecureRandom is stochastic and will become unpredictable over time (hence >> the intermittent nature). > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Add bug number Mar

Re: RFR: 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters

2021-03-25 Thread Daniel D . Daugherty
On Thu, 25 Mar 2021 13:27:45 GMT, Alexey Semenyuk wrote: > Add missing escape single quote (') and typo fix The original change in JDK-8220266 shows the introduction of three single quotes and this fix addresses all three along with another typo. Thumbs up. - Marked as reviewed by

Re: RFR: 8263556: remove `@modules java.base` from tests

2021-03-15 Thread Daniel D . Daugherty
On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this trivial cleanup? > from JBS: > >> jtreg `@modules X` directive does two things: >> - exclude a test from execution if JDK under test doesn't have module X >> - if JDK under test has module X, m

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

2021-03-13 Thread Daniel D . Daugherty
On Sat, 13 Mar 2021 06:44:12 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this dull patch that replaces `ClassFileInstaller` >> w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions >> to ensure we won't get split testlibrary, and removes >> `jdk/te

Integrated: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Daniel D . Daugherty
On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. This pull request has now been integrated. Changeset: cf1c0219 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/cf1c0219 Stats: 2 li

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Daniel D . Daugherty
On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth and @azvegint - Thanks for the reviews! - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Daniel D . Daugherty
On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth - Thanks for the heads up. I've pinged in the jdk-gatekeeping Slack channel. - PR: https://git.openjdk.java.ne

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Daniel D . Daugherty
On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. @alexeysemenyukoracle or @kevinrushforth - can either of you folks review this ProblemListing? - PR: https://git.openjdk.java.net/jdk/pull/2952

RFR: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList two new tests on Windows. - Commit messages: - 8263480: ProblemList two jpackage tests on Windows Changes: https://git.openjdk.java.net/jdk/pull/2952/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2952&range=00 Issue: https://bugs.openjdk

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java

2021-02-19 Thread Daniel D . Daugherty
On Sat, 20 Feb 2021 00:44:29 GMT, Naoto Sato wrote: > The subject test case is failing under the JMS-enabled environment. Changes requested by dcubed (Reviewer). test/jdk/ProblemList.txt line 799: > 797: # jdk_util > 798: > 799: java/util/Locale/LocaleProvidersRun.java

Re: RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

2021-02-19 Thread Daniel D . Daugherty
On Fri, 19 Feb 2021 17:29:42 GMT, Joe Wang wrote: >> A trivial fix to ProblemList >> javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. > > Marked as reviewed by joehw (Reviewer). @JoeWang-Java - Thanks for the review! - PR: https://git.openjdk.java.net/jd

Integrated: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

2021-02-19 Thread Daniel D . Daugherty
On Fri, 19 Feb 2021 16:52:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. This pull request has now been integrated. Changeset: 8b4fd77f Author:Daniel D. Daugherty URL:

Re: RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

2021-02-19 Thread Daniel D . Daugherty
On Fri, 19 Feb 2021 16:52:12 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. @JoeWang-Java - Can you please review this ProblemListing? That will allow us to reduce the noise in Tier2 and gi

RFR: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows

2021-02-19 Thread Daniel D . Daugherty
A trivial fix to ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows. - Commit messages: - 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows Changes: https://git.openjdk.java.net/jdk/pull/2650/files

Integrated: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

2021-02-11 Thread Daniel D . Daugherty
On Thu, 11 Feb 2021 17:55:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java > in order to reduce noise in the JDK17 CI. This pull request has now been integrated. Changeset: 75c8489c Author: Daniel D. Daugh

Re: RFR: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

2021-02-11 Thread Daniel D . Daugherty
On Thu, 11 Feb 2021 18:04:31 GMT, Harold Seigel wrote: >> A trivial fix to ProblemList >> jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java >> in order to reduce noise in the JDK17 CI. > > Looks good and trivial. > Thanks, Harold @hseigel - Thanks for the fast review! - PR: htt

RFR: 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java

2021-02-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java in order to reduce noise in the JDK17 CI. - Commit messages: - 8261604: ProblemList jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java Changes: https://git.openjdk.java.net/jdk/pull/2531/files Webr

Re: RFR: 8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed

2021-02-05 Thread Daniel D . Daugherty
On Fri, 5 Feb 2021 21:09:37 GMT, Alex Menkov wrote: > JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools). > The fix un-problemlists RemovingUnixDomainSocketTest and changes > serviceability tests to use > OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings inste

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Daniel D . Daugherty
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Integrated: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). This pull request has now been integrated. Changeset: 9880c4cd Author:Da

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:21:06 GMT, David Holmes wrote: >> A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on >> the >> ProblemList. It was removed in error (see the bug for the details). > > LGTM @dholmes-ora - Thanks for the fast review! - PR: https://git.op

Re: RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the > ProblemList. It was removed in error (see the bug for the details). @JimLaskey or @sundararajana - If either if you are on-line and can review t

RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2021-02-01 Thread Daniel D . Daugherty
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). - Commit messages: - 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.java.net/jdk/pull/2

[jdk16] Integrated: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. This pull request has now been integrated. Changeset: eabc9030 Author:Daniel D. Daughert

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
On Tue, 22 Dec 2020 17:14:24 GMT, Phil Race wrote: >> ProblemList two java/rmi/Naming tests on Windows in order to reduce the >> noise in the JDK16 CI. This is a trivial fix. > > overdue Thanks for the fast reviews! - PR: https://git.openjdk.java.net/jdk16/pull/58

[jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
ProblemList two java/rmi/Naming tests on Windows in order to reduce the noise in the JDK16 CI. This is a trivial fix. - Commit messages: - 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows Changes: https://git.open

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v7]

2020-10-21 Thread Daniel D . Daugherty
On Wed, 21 Oct 2020 13:00:09 GMT, Martin Doerr wrote: >> CoreyAshford has updated the pull request incrementally with one additional >> commit since the last revision: >> >> CheckGraalIntrinsics.java: fix copy/paste error > > Marked as reviewed by mdoerr (Reviewer). Buried in that GitHub tes

Re: RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v6]

2020-10-14 Thread Daniel D . Daugherty
On Wed, 14 Oct 2020 17:59:53 GMT, Roger Riggs wrote: >> This integration without testing with a current merge from the master and >> has caused two build failures. >> >> JDK-8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar >> >> JDK-8254775: Microbenchmark StringIndexOfCha

  1   2   3   >