On Mon, 15 Feb 2021 10:39:32 GMT, Evan Whelan wrote:
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This f
On Tue, 23 Feb 2021 14:00:16 GMT, Evan Whelan wrote:
>> Marked as reviewed by dfuchs (Reviewer).
>
> Thanks for the feedback Daniel! As I've already posted the integrate command,
> I believe all this needs now is a sponsor :)
Oops, never mind I've to re-issue the c
On Tue, 23 Feb 2021 13:08:29 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed copyright year in FileHandlerAccessTest.java
>
> Marked as reviewed by dfuc
On Tue, 23 Feb 2021 10:16:26 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> I've removed the problematic "process" handling logic and have stripped the
>> test back to only use threads.
>>
>> The problem was reproducible (intermittently on my Windows machine) using
>> this smaller test and should make
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
On Tue, 23 Feb 2021 10:14:07 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Stripped back FileHandlerAccessTest to only use threads
>
&
On Fri, 19 Feb 2021 14:06:23 GMT, Daniel Fuchs wrote:
>> LGTM
>
> I'm seeing some intermittent test failures with the new test (after merging
> in latest master changes). Can you retest and have a look:
>
> --System.out:(25/1343)--
> Testing with arguments: type=process, count=2
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
On Wed, 17 Feb 2021 12:24:46 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Remove ClassPathException copyright statement
>
> test/jdk/java/util/logging/F
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
On Wed, 17 Feb 2021 07:37:42 GMT, David Holmes wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Throw exception if exit code of child process is non-zero
>
&
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
On Tue, 16 Feb 2021 11:48:05 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Doc cleanup, code formatting and throwing exceptions instead of
>> catching
On Tue, 16 Feb 2021 11:33:08 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Doc cleanup, code formatting and throwing exceptions instead of
>> catching
On Tue, 16 Feb 2021 11:33:08 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review this fix for JDK-8252883. This handles the case when an
>> AccessDeniedException is being thrown on Windows, due to a delay in deleting
>> the lock file it is trying to write to.
>
> Hi,
>
> Please review this fix for JDK-8252883. This handles the case when an
> AccessDeniedException is being thrown on Windows, due to a delay in deleting
> the lock file it is trying to write to.
>
> This fix passes all testing.
>
> Kind regards,
> Evan
Ev
On Mon, 15 Feb 2021 12:55:46 GMT, Daniel Fuchs wrote:
>> Evan Whelan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8252883: Doc cleanup, code formatting and throwing exceptions instead of
>> catch
Hi,
Please review this fix for JDK-8252883. This handles the case when an
AccessDeniedException is being thrown on Windows, due to a delay in deleting
the lock file it is trying to write to.
This fix passes all testing.
Kind regards,
Evan
-
Commit messages:
- 8252883: AccessDeni
On Tue, 12 Jan 2021 16:26:27 GMT, Evan Whelan wrote:
> Hi,
>
> Please review this small change which enables the GB18030 charset to be built
> into java.base
>
> Thanks
This pull request has now been integrated.
Changeset: 5f7ccce0
Author:Evan Whelan
Committer:
On Thu, 3 Dec 2020 14:57:16 GMT, Evan Whelan wrote:
> This is a straightforward fix to resolve a potential memory leak in
> imageFile.cpp.
>
> If `find_location` returns true, the `path` char array is never released.
>
> This has been fixed
This pull request has n
This is a straightforward fix to resolve a potential memory leak in
imageFile.cpp.
If `find_location` returns true, the `path` char array is never released.
This has been fixed
-
Commit messages:
- 8255845: Memory leak in imageFile.cpp
Changes: https://git.openjdk.java.net/jdk/pu
* will receive an {@link InterruptedException}.
*
Thanks in advance,
Evan Whelan
Hi all,
This is a small fix that helps with some test cleanup. One redundant test file
has been removed.
Webrev found at: http://cr.openjdk.java.net/~kravikumar/8249691/webrev/
Link to JBS issue: https://bugs.openjdk.java.net/browse/JDK-8249691
Any follow up questions are welcomed.
24 matches
Mail list logo
