Re: RFR8194230, jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with NPE

Hi Alan,     please review the update patch, and reduced checking as suggested: http://cr.openjdk.java.net/~xiaofeya/8194230/webrev.01/ Thanks, Felix On 2018/8/6 18:23, Alan Bateman wrote: On 31/07/2018 07:16, Felix Yang wrote: Hi all,     please review a patch to improve the checking on

RFR8194230, jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with NPE

Hi all,     please review a patch to improve the checking on the settings. Originally it will throw NPE, if specified path is invalid. Bug:     https://bugs.openjdk.java.net/browse/JDK-8194230 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8194230/webrev.00/ Thanks, Felix

RFR 8202708, Add a check of opening stream for not-existing UNC url

Hi all,    please review a change to add additional checking for opening stream with not-existing UNC url. Bug:     https://bugs.openjdk.java.net/browse/JDK-8202708 Webrev:     http://cr.openjdk.java.net/~xiaofeya/8202708/webrev.00/ Thanks, Felix

RFR 8201348, ProblemList update for bugid associated with SSLSocketParametersTest.sh

Hi,     please review a minor change on the associated bug id in ProblemList.txt. Bug:     https://bugs.openjdk.java.net/browse/JDK-8201348 Patch: diff -r f088ec60bed5 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Mon Apr 09 10:39:29 2018 -0700 +++ b/test/jdk/ProblemList.txt  Mon

RFR 8190505, typo in test/jdk/ProblemList.txt

Please review a minor patch to correct typo in test/jdk/ProblemList.txt. Change "Hashmap" to "HashMap". diff -r 4a35a00eb001 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Wed Nov 01 16:45:28 2017 +0100 +++ b/test/jdk/ProblemList.txt    Wed Nov 01 23:34:44 2017 -0400 @@ -320,7 +320,7

Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

Hi Alan, pushed as suggested. Thanks, Felix > On 20 Jul 2017, at 7:23 PM, Alan Bateman wrote: > > This skips the testing on exploded builds, which I think is okay. A minor > point before pushing is that you replace "lib/modules" with "lib", "modules" > as the elements will be joined by the

Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

) Webrev: http://cr.openjdk.java.net/~xiaofeya/8184904/webrev.01/ Thanks, Felix On 2017/7/19 17:50, Alan Bateman wrote: On 19/07/2017 10:43, Felix Yang wrote: Hi all, please review a patch to skip parts of testing with exploded builds. Bug: https://bugs.openjdk.java.net/browse/JDK-8184904

RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

Hi all, please review a patch to skip parts of testing with exploded builds. Bug: https://bugs.openjdk.java.net/browse/JDK-8184904 Webrev: http://cr.openjdk.java.net/~xiaofeya/8184904/webrev.00/ Thanks, Felix

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

Hi Roger, is it necessary to add the bug id to OnExitTest? -Felix On 2017/7/19 2:46, Roger Riggs wrote: Please review a fix for an intermittent failure in the ProcessHandle OnExitTest that fails frequently on Solaris. ProcessHandle.isAlive is using /proc/pid/psinfo to determine if a pro

Re: JDK 10 RFR of JDK-8183378: Refactor java/lang/System/MacEncoding/MacJNUEncoding.sh to java

Hi Amy, looks fine. Just one comment on sentence below. "LOCALE" looks to be a local variable, though used several times. Switch to usual naming? 50 final String LOCALE = args[2]; -Felix On 2017/7/6 9:47, Amy Lu wrote: java/lang/System/MacEncoding/MacJNUEncoding.sh Please revi

JDK 10 RFR 8182620, Problem list java/lang/String/nativeEncoding/StringPlatformChars.java for JDK-8182569

Hi there, please review a patch to problem list java/lang/String/nativeEncoding/StringPlatformChars.java temporarily. It has been failing in some test setup with "Error. Use -nativepath to specify the location of native code". Bug: https://bugs.openjdk.java.net/browse/JDK-8182620 Thanks,

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

-Hamlin On 2017/6/16 9:41, Felix Yang wrote: Hi Hamlin, I think you need something like: /ProcessTools.executeCommand("sh", "-c", yourTestCmd).../ yourTestCmd is like the original cmd in shell " export LC_ALL=en_US.UTF-8 ;${TESTJAVA}/bin/java ${TESTVMOPTS} -cp ${T

RFR 8182321/10, Mark java/lang/ProcessHandle/OnExitTest.java as intermittent

Hi, please review a minor patch to add @key intermittent to java/lang/ProcessHandle/OnExitTest.java. It has been observed to be failing intermittently on Solaris x64. Bug: https://bugs.openjdk.java.net/browse/JDK-8182321 Patch: diff -r d6e163b08d8c test/java/lang/ProcessHandle/OnExitTes

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

Hi Hamlin, I think you need something like: /ProcessTools.executeCommand("sh", "-c", yourTestCmd).../ yourTestCmd is like the original cmd in shell " export LC_ALL=en_US.UTF-8 ;${TESTJAVA}/bin/java ${TESTVMOPTS} -cp ${TESTCLASSES} MacPathTest" -Felix On 2017/6/16 9:32, Naoto Sato wrote:

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Excuse me, Alan, could you have a look at this patch? Thanks, Felix On 2017/6/7 15:04, Felix Yang wrote: Hi Alan, updated patch. Keep the first version of OtherResourcesTest with clean-up. http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.02/ Thanks, Felix On 2017/6/7 0:36, Alan

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Hi Alan, updated patch. Keep the first version of OtherResourcesTest with clean-up. http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.02/ Thanks, Felix On 2017/6/7 0:36, Alan Bateman wrote: On 06/06/2017 16:54, Felix Yang wrote: Well, probably no. executeTestJava will add test vm opts

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Alan, comments inline thanks -Felix On 2017/6/6 23:40, Alan Bateman wrote: On 06/06/2017 16:28, Felix Yang wrote: All 3 tests will fail with error missing java.compiler module. I also attempted with --limit-modules=java.se. Then other resources will fail with "java.lang.RuntimeExce

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Alan and Chris, On 2017/6/6 18:12, Alan Bateman wrote: On 06/06/2017 10:27, Felix Yang wrote: Addressed all comments. Please review the updated patch: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.01/ Can you run the tests in sun/net/www/protocol/jrt with `-vmoption:--limit-modules

Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Addressed all comments. Please review the updated patch: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.01/ Thanks, Felix On 2017/6/6 16:25, Alan Bateman wrote: On 06/06/2017 09:15, Chris Hegarty wrote: : OtherResourcesTest.java is not strictly needed. You should be able to provide an

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

y exceptions. This was originally added by Max in https://bugs.openjdk.java.net/browse/JDK-7078355. TO Max, could you comment if such chmod is still necessary? If yes, since this is just for test clean-up rather than a part of test logic, is it enough with "File.setReadable(...)"? -

Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Thanks:-) -Felix On 2017/6/1 16:32, Felix Yang wrote: Hi there, please review the patch convert several sun/net shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181080 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/ Thanks

Re: RFR 8181414/10, Refactor misc test/sun/net/www/protocol/jar shell tests to plain java tests

net/www/protocol/jar/B5105410.java.udiff.html> + # @summary ZipFile$ZipFileInputStream doesn't close handle to zipfile a typo, it should be * @summary -- Igor On Jun 1, 2017, at 12:39 AM, Felix Yang wrote: Hi there, please review the patch to convert several shell tests to plain

Re: RFR 8181413/10, Refactor test/sun/net/www/protocol/jar/jarbug/run.sh to plain java tests

Jun 2017, at 00:13, Felix Yang wrote: Hi there, please review the patch to covert a shell test to a plain java test, and simplify a few of unnecessary test logic. Bug: https://bugs.openjdk.java.net/browse/JDK-8181413 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181413/webrev.00

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

the same way we did it in hotspot, which reliably removed almost all our NCDFE failures, -- remove explicit @build, if not all for all classes, then at least for jdk/test/lib/** classes. -- Igor On Jun 1, 2017, at 6:52 PM, Felix Yang <mailto:felix.y...@oracle.com>> wrote: Hi Igor and

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Igor and Ioi, I partially agree with you. As initially stated in the proposal and bug(JDK-8181299 ), I don't think this patch is a fix but a quick workaround to make them runnable. "explicit" is reasonable for me. But "explicit" s

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Chris, updated webrev: http://cr.openjdk.java.net/~xiaofeya/8181299/webrev.01/ -Felix On 2017/6/1 17:11, Chris Hegarty wrote: On 1 Jun 2017, at 04:27, Felix Yang wrote: Hi Chris and Daniel, new webrev with a few of explicit builds than wildcard. http://cr.openjdk.java.net

RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Hi there, please review the patch convert several sun/net shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181080 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/ Thanks, Felix

RFR 8181414/10, Refactor misc test/sun/net/www/protocol/jar shell tests to plain java tests

Hi there, please review the patch to convert several shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181414 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181414/webrev.00/ Thanks, Felix

RFR 8181413/10, Refactor test/sun/net/www/protocol/jar/jarbug/run.sh to plain java tests

Hi there, please review the patch to covert a shell test to a plain java test, and simplify a few of unnecessary test logic. Bug: https://bugs.openjdk.java.net/browse/JDK-8181413 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181413/webrev.00/ Thanks, Felix

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

-8181391 [2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048012.html [3] http://cr.openjdk.java.net/~iignatyev//8181391/webrev.00/index.html <http://cr.openjdk.java.net/%7Eiignatyev//8181391/webrev.00/index.html> Thanks, -- Igor On May 31, 2017, at 8:27 PM, Feli

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Chris and Daniel, new webrev with a few of explicit builds than wildcard. http://cr.openjdk.java.net/~xiaofeya/8181299/webrev.01/ Thanks, Felix On 2017/5/31 18:20, Chris Hegarty wrote: On 31 May 2017, at 10:42, Felix Yang wrote: Hi there, please review the patch to various jdk

RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi there, please review the patch to various jdk tests to explicitly compiling test libraries and the lib's dependencies. Though it could be a jtreg issue (I think so), it is necessary to get the tests running firstly. Bug: https://bugs.openjdk.java.net/browse/JDK-8181299 Webrev:

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Alan even with explicit compilation, I also observed failures. I'm curious what is the best practice here. IMO, there could be a potential jtreg bug. See: https://bugs.openjdk.java.net/browse/JDK-8181299 https://bugs.openjdk.java.net/browse/JDK-8181300 Thanks, Felix On 2017/5/31 15:

Re: RFR 8166139/10, Refactor java/net shell cases to java

Hi Chris, pushed, thank you very much! -Felix On 2017/5/30 17:44, Chris Hegarty wrote: On 29/05/17 16:17, Felix Yang wrote: Hi Chris, please review the updated webrev below. Comments inline. http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.03/ Thanks Felix. .. 2) test/java

Re: RFR 8166139/10, Refactor java/net shell cases to java

According with JDK-503, it is to cover endorsed scenarios, while endorsed mechanism has been removed in JDK 9. -Felix -Chris. On 27/05/17 02:15, Felix Yang wrote: Hi Roger, thanks for the comments. Please see the new webrev http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.02/

Re: RFR 8166139/10, Refactor java/net shell cases to java

ir"). It is not expected to run outside jtreg. -Felix URLConnection/6212146/Test.java:47 typo: ULR -> URL Regards, Roger On 5/25/2017 11:14 PM, Felix Yang wrote: Hi Roger, please review the updated webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/ Thanks, Felix On 2017

Re: RFR 8166139/10, Refactor java/net shell cases to java

(Not a reviewer.) Thanks, Amy [1] http://hg.openjdk.java.net/jdk10/jdk10/file/tip/test/lib/jdk/test/lib/compiler/CompilerUtils.java On 5/26/17 11:14 AM, Felix Yang wrote: Hi Roger, please review the updated webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.01/ Thanks, Fe

Re: RFR 8166139/10, Refactor java/net shell cases to java

d. That is because corresponding prerequisite was removed even in JDK 8. -Felix Regards, Roger On 5/25/2017 4:08 AM, Felix Yang wrote: Hi there, please review following patch to convert all shell cases under java/net to plain java codes. Webrev: http://cr.openjdk.java.net/~xiaofe

RFR 8166139/10, Refactor java/net shell cases to java

Hi there, please review following patch to convert all shell cases under java/net to plain java codes. Webrev: http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8166139 Thanks, Felix

Re: RFR 8087307/9, new tests for ServiceLoader updates for module

8.3 correct indent, e.g. in PermissionTest.java 8.4 Is default constructor "public ProviderX() { }" necessary in multi.ProviderX ? Resolved above, thanks 8.5 rename Service to OrderedService? I may keep to be identical with existing ServiceLoader module tests. -Felix Thank yo

Re: RFR 8087307/9, new tests for ServiceLoader updates for module

Ping:) -Felix > On 16 May 2017, at 4:59 PM, Felix Yang wrote: > > Hi there, > >please review the new tests added for ServiceLoader updates for module > system. > > Test bug: > >https://bugs.openjdk.java.net/browse/JDK-8087307 > > Webrev: > &g

RFR 8087307/9, new tests for ServiceLoader updates for module

Hi there, please review the new tests added for ServiceLoader updates for module system. Test bug: https://bugs.openjdk.java.net/browse/JDK-8087307 Webrev: http://cr.openjdk.java.net/~xiaofeya/8087307/webrev.00/ Related product Changes: https://bugs.openjdk.java.net/browse

RFR 8178912, Throw away sample tests

Hi there, please review following change to remove tests for several samples, which have been removed in "JEP 298: Remove Demos and Samples". Webrev: http://cr.openjdk.java.net/~xiaofeya/8178912/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8178912 Corresponding JEP: https://bu

RFR 8176195/9, Fix misc module dependencies in jdk_core tests

Hi there, please review the changes to explicitly declare dependencies in tests. This will make better test selection with --limit-module option. Bug: https://bugs.openjdk.java.net/browse/JDK-8176195 Webrev: http://cr.openjdk.java.net/~xiaofeya/8176195/webrev.00/ I didn't use TE

RFR 8173159, Problem list java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java on Windows

Hi there, please review the request to problem-list the test on Windows platform. It has been observed to be failing frequently. Bug https://bugs.openjdk.java.net/browse/JDK-8173159 Thanks, Felix diff -r 1045f9722697 test/ProblemList.txt

Re: RFR 8172765, closed/javax/sound/sampled/Clip/AppletAudioClip/SoundBug.java failed in headless system

oops! Incidentally sent to wrong alias. Sorry, please ignore it. Thanks, Felix > On 13 Jan 2017, at 9:57 AM, Felix Yang wrote: > > Hi team, >please review the patch to mark following test as headful. It has been > failing in Mach 5 for several runs > > Bug: https://

RFR 8172765, closed/javax/sound/sampled/Clip/AppletAudioClip/SoundBug.java failed in headless system

Hi team, please review the patch to mark following test as headful. It has been failing in Mach 5 for several runs Bug: https://bugs.openjdk.java.net/browse/JDK-8172765 Thanks, Felix Patch: diff -r 2ca43b220611 javax/sound/sampled/Clip/AppletAudioClip/SoundBug.java --- a/javax/sound/sample

Re: RFR 8075884, new tests to check runtime usage with Multi-Release jars

+ mainVersionActual); > 177 } > > You can use Assert.equals. > > > 191 @Test(dataProvider = "jarFiles") > 192 void testJjs(String jar, int mainVer, int helperVer, int resVer) > 193 throws Throwable { > > What is th

RFR 8075884, new tests to check runtime usage with Multi-Release jars

Hi there, please review the following new tests to check runtime usage with Multi-Release jars. Bug: https://bugs.openjdk.java.net/browse/JDK-8075884 Webrev: http://cr.openjdk.java.net/~xiaofeya/8075884/webrev.00/ Thanks, Felix

Ping - Re: RFR 8170890, Problem list tools/javadoc/CheckResourceKeys.java and tools/javadoc/ReleaseOption.java until fix for JDK-8170772

Hi all, any comment on this problem-list request? Thanks, Felix On 2016/12/8 11:06, Felix Yang wrote: Hi, please review the patch to problem-list two tier1 tests from Linux platform. Bug: https://bugs.openjdk.java.net/browse/JDK-8170890 Thanks, Felix diff -r 586c93260d3b

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

rds Christoph -Original Message- From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Felix Yang Sent: Donnerstag, 8. Dezember 2016 11:35 To: Dmitry Samersoff ; core-libs- d...@openjdk.java.net; net-...@openjdk.java.net; CHRIS.HEGARTY Subject: Re: RFR 8169115, java/net/In

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

tack=true that do A and PRT lookup in one run. 2. Read results of process above, do PTR lookup with default settings and compare results. -Dmitry On 2016-12-06 12:06, Felix Yang wrote: Hi, please review the following patch. It generally coverts codes from shell t

RFR 8170890, Problem list tools/javadoc/CheckResourceKeys.java and tools/javadoc/ReleaseOption.java until fix for JDK-8170772

Hi, please review the patch to problem-list two tier1 tests from Linux platform. Bug: https://bugs.openjdk.java.net/browse/JDK-8170890 Thanks, Felix diff -r 586c93260d3b test/ProblemList.txt --- a/test/ProblemList.txt Mon Dec 05 15:08:24 2016 -0800 +++ b/test/ProblemList.txt

Ping - Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

:-) -Felix > On 6 Dec 2016, at 9:28 AM, Felix Yang wrote: > > Add core-libs. > > Thanks, > Felix > On 2016/12/5 22:14, Felix Yang wrote: >> Hi, >> >> updated webrev. May I have a reviewer to review this >> >> http://cr.openjdk.java.net/~x

Re: RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

o A and PRT lookup in one run. 2. Read results of process above, do PTR lookup with default settings and compare results. -Dmitry On 2016-12-06 12:06, Felix Yang wrote: Hi, please review the following patch. It generally coverts codes from shell to plain java. Bug: https://bu

Re: RFR 8081390, javax/management/remote/mandatory/connection/RMIConnector_NPETest.java may leave orphaned processes

failing logs would be have been useful. Roger On 12/6/2016 2:32 AM, Hamlin Li wrote: I see, looks fine. But I'm not a reviewer. Thank you -Hamlin On 2016/12/6 11:38, Felix Yang wrote: Hi Hamlin, as stated in the bug, the timeout is more-likely a test setup issue that small timeout f

RFR 8169115, java/net/InetAddress/ptr/lookup.sh failed intermittently

Hi, please review the following patch. It generally coverts codes from shell to plain java. Bug: https://bugs.openjdk.java.net/browse/JDK-8169115 Webrev: http://cr.openjdk.java.net/~xiaofeya/8169115/webrev.00/ Thanks, Felix

Re: RFR 8081390, javax/management/remote/mandatory/connection/RMIConnector_NPETest.java may leave orphaned processes

On 2016/12/6 10:08, Felix Yang wrote: Hi, please review the small fix to avoid orphaned processes left. Bug: https://bugs.openjdk.java.net/browse/JDK-8081390 Webrev: http://cr.openjdk.java.net/~xiaofeya/8081390/webrev.00/ Thanks, Felix

RFR 8081390, javax/management/remote/mandatory/connection/RMIConnector_NPETest.java may leave orphaned processes

Hi, please review the small fix to avoid orphaned processes left. Bug: https://bugs.openjdk.java.net/browse/JDK-8081390 Webrev: http://cr.openjdk.java.net/~xiaofeya/8081390/webrev.00/ Thanks, Felix

Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly

Add core-libs. Thanks, Felix On 2016/12/5 22:14, Felix Yang wrote: Hi, updated webrev. May I have a reviewer to review this http://cr.openjdk.java.net/~xiaofeya/8043838/webrev.01/ -Felix On 2016/12/5 15:50, Felix Yang wrote: On 2016/12/5 15:47, Langer, Christoph wrote: Hi Felix

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

d also suggest to use try-with-resource to close in CacheImpl (int port) and CacheImpl::writeMap to make sure the file is always properly closed. Updated all the history codes, as you suggested Thanks, Felix best regards, -- daniel On 01/12/16 09:47, Felix Yang wrote: Hi, please review the

RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

Hi, please review the following patch. The code was converted from shell script to plain Java. Since it is by-design to bind on a prior-used port, add a few of re-tries for possible BindException. Bug: https://bugs.openjdk.java.net/browse/JDK-8162521 Webrev: http://cr.openjdk.j

RFR 8170559, Incorrect bug id in problem list

Hi there, please review the change to correct a mistake. An incorrect bug id was incidentally used in problem list. Bug: https://bugs.openjdk.java.net/browse/JDK-8170559 Thanks, Felix diff -r a563aaa85446 test/ProblemList.txt --- a/test/ProblemList.txt Wed Nov 30 17:15:58 2016 -08

Re: RFR 8170248, Problem list javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Excuse me, On 2016/11/23 13:15, Felix Yang wrote: Hi, this test fails frequently on Linux platforms. I suggest to exclude it until JDK-8169737 is fixed. Thanks, Felix Corrected diff: diff -r 67d3235a317f test/ProblemList.txt --- a/test/ProblemList.txt Wed Nov 23 10:12:01 2016

RFR 8170248, Problem list javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java

Hi, this test fails frequently on Linux platforms. I suggest to exclude it until JDK-8169737 is fixed. Thanks, Felix diff -r 67d3235a317f test/ProblemList.txt --- a/test/ProblemList.txt Wed Nov 23 10:12:01 2016 +0800 +++ b/test/ProblemList.txt Tue Nov 22 20:44:56 2016 -0800 @@

RFR 8170249/9, Problem list jdk/jshell/ToolFormatTest.java and jdk/jshell/ReplaceTest.java until 8170216 is fixed

Hi there, please review the change to problem following tests on Soalris Sparcv9. They have been observed to be failing quite frequently on Solaris Sparcv9 Thanks, Felix diff -r 318dd5fce0ee test/ProblemList.txt --- a/test/ProblemList.txt Tue Nov 22 16:31:03 2016 -0800 +++ b/test/P

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

A comment on naming, alpha to ALPHA ? -Felix > 在 2016年10月13日，17:05，Frank Yuan 写道： > > Hi all > > > > Would you like to review http://cr.openjdk.java.net/~fyuan/8167478/webrev.00/ > ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167478 > > > > This is a test bug, because Bug6341770

RFR 8157135, Fix module dependencies javax/* EE tests

Hi all, please review the patch for some tests, which explicitly declare module dependencies to EE modules. Bug: https://bugs.openjdk.java.net/browse/JDK-8157135 Webrev: http://cr.openjdk.java.net/~xiaofeya/8157135/webrev.00/ This is a partial fix left by https://bugs.openjdk.java.net/br

RFR 8157530/9, Remove intermittent key from javax/net/ssl/DTLS/WeakCipherSuite.java

javax/net/ssl/DTLS/WeakCipherSuite.java failed intermittently with (JDK-8129389 ). It had been resolved and no new failure was observed in pass round of same binaries runs. It looks necessary to remove @key intermittent from the test. bug: htt

RFR 8157816, Mark 4 httpclient tests as intermittently failing

Hi all, please review the change to mark following tests with keyword 'intermittent'. These tests have been observed to fail intermittently for a while. test/java/net/httpclient/SplitResponse.java test/java/net/httpclient/http2/BasicTest.java test/java/net/httpclient/http2/ErrorTest.java tes

Re: RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

another issue to track latter one. Because without fix for CODETOOLS-7901671( in next jtreg promotion ), those tests with EE modules in @modules will be skipped by default. Thanks, Felix On 2016/5/4 23:44, Felix Yang wrote: Hi Alan, On 2016/5/4 22:45, Alan Bateman wrote: On 04/05/2016

Re: RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

Hi Alan, On 2016/5/4 22:45, Alan Bateman wrote: On 04/05/2016 15:39, Felix Yang wrote: Hi Alan, please review the updated webrev. Reverted changes for those tests with "-addmods". http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.01/ For the javax.transaction test then

Re: RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

Hi Alan, please review the updated webrev. Reverted changes for those tests with "-addmods". http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.01/ Thanks, Felix On 2016/4/29 15:25, Alan Bateman wrote: On 29/04/2016 03:16, Felix Yang wrote: Hi there, please review the

Re: RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

On 2016/4/29 15:25, Alan Bateman wrote: On 29/04/2016 03:16, Felix Yang wrote: Hi there, please review the changes to explicitly declare module dependencies for "java/sql/*" and "javax/*" tests; Bug: https://bugs.openjdk.java.net/browse/JDK-8155088 Webrev: http:/

RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

Hi there, please review the changes to explicitly declare module dependencies for "java/sql/*" and "javax/*" tests; Bug: https://bugs.openjdk.java.net/browse/JDK-8155088 Webrev: http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.00/ Thanks, Felix

Re: RFR 8154733, Fix module dependencies missed in java.rmi tests

correct me. Example: $ cat jdk/test/java/rmi/TEST.properties modules = java.rmi Thanks, Amy On 4/26/16 4:53 PM, Felix Yang wrote: Hi all, please review the fix to explicitly declare module dependencies for rmi tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8154733 Webrev: http

RFR 8154733, Fix module dependencies missed in java.rmi tests

Hi all, please review the fix to explicitly declare module dependencies for rmi tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8154733 Webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.00/ Thanks, Felix

Re: RFR 8146758, NetworkInterfaceStreamTest.java fails intermittently at comparing network interfaces

Hi Chris, thanks for the review. Could you sponsor the change? Thanks, Felix On 2016/4/15 18:45, Chris Hegarty wrote: On 15/04/16 10:29, Felix Yang wrote: Hi all, please review the following fix. It is an intermittent failure because of Teredo Tunneling Pseudo-Interface. Bug: https

RFR 8146758, NetworkInterfaceStreamTest.java fails intermittently at comparing network interfaces

Hi all, please review the following fix. It is an intermittent failure because of Teredo Tunneling Pseudo-Interface. Bug: https://bugs.openjdk.java.net/browse/JDK-8146758 Webrev: http://cr.openjdk.java.net/~xiaofeya/8146758/webrev.00/ Thanks, Felix

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Hi Alan and Amy, thanks for figuring this out. Updated to suggested practice. New webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.01/ Felix On 2016/4/11 14:46, Alan Bateman wrote: On 11/04/2016 06:04, Felix Yang wrote: Amy, thanks. I'm not sure which practice

Re: RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

11:47 AM, Felix Yang wrote: Hi there, please review the following bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8153928 Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/ You might want to do some cleanup to avoid using two @modules tags? BTW. I'm not openjdk review

RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Hi there, please review the following bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8153928 Webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.00/ After changes in JDK-8153737 , it introduced new dependency of java.base/jdk

Re: [8u-dev] Request for Approval for Backport: 8151352 (8151574), jdk/test/sample fails with "effective library path is outside the test suite"

Hi Sean, thank you very much. BTW, I will look into https://bugs.openjdk.java.net/browse/JDK-8151535 you mentioned. -Felix On 2016/3/16 23:01, Seán Coffey wrote: On 15/03/16 14:38, Felix Yang wrote: Hi Sean, thank you for the review. Could you sponsor this change? Pushed : http

[8u-dev] RFR 8151535: java/lang/invoke/AccessControlTest.java should be modified to run with JTREG 4.1 b13

Hi there, please, help to review the fix for test 'java/lang/invoke/AccessControlTest.java'. Bug: https://bugs.openjdk.java.net/browse/JDK-8151535 Webrev: http://cr.openjdk.java.net/~xiaofeya/8151535/webrev.00/ This fix removed "@library ../../../...", which is invalid with the la

Re: [8u-dev] Request for Approval for Backport: 8151352 (8151574), jdk/test/sample fails with "effective library path is outside the test suite"

ude master bug ID (8151352). Approved. The jtreg upgrade disrupted test results for quite a few teams (again). https://bugs.openjdk.java.net/browse/JDK-8151535 is another one that needs attention. Regards, Sean. On 15/03/2016 05:44, Felix Yang wrote: Hi there, please approve the backport

[8u-dev] Request for Approval for Backport: 8151574, jdk/test/sample fails with "effective library path is outside the test suite"

Hi there, please approve the backport of 8151574 from 9 to 8. Webrev: http://cr.openjdk.java.net/~xiaofeya/8151574/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8151574 Changeset in jdk9: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dbb0fd7f2a2b Review: http://mail.openjdk.java.net

Ping - Re: RFR 8151676/9, Add jdk/internal/jline/console/StripAnsiTest.java into problem list for MacOSX

Hi, can we get either exclusion request or Jan's fix reviewed? This hanging test keeps on affecting other tests on some Mac OSX environments. Thanks, Felix On 2016/3/11 16:59, Felix Yang wrote: Hi Jan, we have seen test runs hanging 15+ hours on several environments, which b

Re: RFR 8151676/9, Add jdk/internal/jline/console/StripAnsiTest.java into problem list for MacOSX

this fix: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039165.html will fix also the Mac OSX problem. Sadly, I didn't hear any feedback on that yet. Thanks, Jan On 11.3.2016 08:15, Felix Yang wrote: Hi, please review at your convenience. This test jdk

RFR 8151676/9, Add jdk/internal/jline/console/StripAnsiTest.java into problem list for MacOSX

Hi, please review at your convenience. This test jdk/internal/jline/console/StripAnsiTest.java has been observed hanging on several Mac OSX environments. Suggest to temporarily put into problemlist for Mac OSX. Bug: https://bugs.openjdk.java.net/browse/JDK-8151676 Thanks, Felix Pa

Re: RFR 8151352, jdk/test/sample fails with "effective library path is outside the test suite"

Joe, thank you for the quick review. Amy, could you sponsor this change? -Felix On 2016/3/8 2:51, joe darcy wrote: Hello, Looks fine; thanks, -Joe On 3/7/2016 8:04 AM, Felix Yang wrote: Hi all, please review the fix for two tests under "test/sample/". Bug:

RFR 8151352, jdk/test/sample fails with "effective library path is outside the test suite"

Hi all, please review the fix for two tests under "test/sample/". Bug: https://bugs.openjdk.java.net/browse/JDK-8151352 Webrev: http://cr.openjdk.java.net/~xiaofeya/8151352/webrev.00/ Original declaration, "@library ../../../src/sample...", is invalid with the latest change in jtreg.

Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

016, at 12:45 PM, Chris Hegarty wrote: > > On 20 Jan 2016, at 06:36, Chris Hegarty <mailto:chris.hega...@oracle.com>> wrote: > >> Felix, >> >> On 14 Jan 2016, at 06:07, Felix Yang wrote: >> >>> Hi all, >>> please review the fix fo

RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

Hi all, please review the fix for test/java/net/SocketPermission/SocketPermissionTest.java, which fails frequently with "java.net.BindException: Address already in use". Bug: https://bugs.openjdk.java.net/browse/JDK-8065076 Webrev: http://cr.openjdk.java.net/~xiaofeya/8065076/webrev.00 Th

RFR 8143015/9: 5 tests fail with error "Can't find source for class: java.util.stream.OpTestCase"

Hi, please review the following fix for 5 broken test cases, which was introduced by JDK-8142996. These tests refer with java.util.stream.OpTestCase, which was relocated from test/java/util/stream/bootlib/ to test/java/util/stream/bootlib/java.base/ Bug: https://bugs.openjdk.java.net/brow

Re: RFR: 8142996: move jdk java/util/streams tests into java.base directories

Hi Alan and Jonathon, the fix was pushed without addressing this comment, so 5 tests has been broken. Just filed https://bugs.openjdk.java.net/browse/JDK-8143015. -Felix On 2015/11/14 15:30, Alan Bateman wrote: On 13/11/2015 23:46, Jonathan Gibbons wrote: Please review the following fix

Re: [9] RFR 8129833: Need basic tests for rmic

On 7/15/2015 7:01 PM, Daniel Fuchs wrote: On 13/07/15 14:53, FELIX YANG wrote: Hi Daniel, please help to review the change for 8129833. Issue:https://bugs.openjdk.java.net/browse/JDK-8129833 Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try

[9] RFR 8129833: Need basic tests for rmic

Hi Daniel, please help to review the change for 8129833. Issue:https://bugs.openjdk.java.net/browse/JDK-8129833 Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/ The patch add a new class to try rmic with. It covers a problem of locating the class java.awt.Panel in jigsaw buil

[9]RFR 8130394: DatagramChannel tests need to be hardened to ignore stray datagrams

Hi all, please help to review the change for 8130394. Issue: https://bugs.openjdk.java.net/browse/JDK-8130394 Patch:http://cr.openjdk.java.net/~fyuan/felix/8130394/ The patch updates tests to ignore stray datagrams, or at least print more information to ease troubleshooting. than

RFR JDK-8079778: Mark intermittently failing: java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java

Hi all, java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java has been observed to fail intermittently. This fix is to mark it with keyword 'intermittent'. Bug: https://bugs.openjdk.java.net/browse/JDK-8079778 thanks, -Felix diff -r d18205a1ef80 test/java/rmi/activation/r

RFR 8061448, Update sun/misc/JarIndex tests to cleanup the check for the "jre" directory

Hi all, please review the fix for 8061448. It cleans up dependency with "jre" directory and tools.jar, which have been removed by Jigsaw feature. Bug: https://bugs.openjdk.java.net/browse/JDK-8061448 Webrev: http://cr.openjdk.java.net/~xiaofeya/8061448/webrev.00/ I needs a sponsor f

  1   2   >