Re: DigitList bug in recent patch

2013-03-27 Thread Frank Ding
turned result would be 78.1 since the binary representation is "below" the tie. The previous behavior of JDK (DigitList) was wrong because it did *no* took correctly into account what value is recorded in memory, and the new behavior is the correct one. Hope that helps, Olivier. Fr

Re: DigitList bug in recent patch

2013-03-27 Thread Frank Ding
Current JDK gives the output of "78.0001". Best regards, Frank On 3/27/2013 3:48 PM, Frank Ding wrote: Hi guys, We noticed there is a recent change (patch @ http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bc1f16f5566f ) that changed the behavior of the following program

DigitList bug in recent patch

2013-03-27 Thread Frank Ding
Hi guys, We noticed there is a recent change (patch @ http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bc1f16f5566f ) that changed the behavior of the following program. import java.math.RoundingMode; public class TestNumberFormat { public static void main(String[] args) { java.tex

Java 8 syntax change between b63 and b65

2013-01-29 Thread Frank Ding
Hi guys, I noticed there is a change in Java 8 between b63 and b65. The change can be illustrated by compiling following Issue class. public class Issue { interface Handler { public void handle(); } interface Listener { public void listen(); } Handler handlerImpl = new Handler() { public void

Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-09 Thread Frank Ding
Hi Lance, The code refactory looks good. By the way, the newly added unit test is not jtreg test case? Best regards, Frank On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote: All, Attached is the patch for: 8004374 based off the issue that Frank reported. for http://cr.openjdk.java.

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-03 Thread Frank Ding
against. Best Lance On Nov 30, 2012, at 12:26 AM, Frank Ding wrote: Hi Lance, Sorry for late response and thanks for your comment. You mean I can write a jtreg test case that connects to Java DB? I can do that. Best regards, Frank On 11/13/2012 10:13 PM, Lance Andersen - Oracle wrote: Hi

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-29 Thread Frank Ding
, Frank Ding wrote: Hi Lance Thanks for your quick response. Please find the bug info below. The problem: When CachedRowSetImpl.acceptChanges() is called, incorrect number of conflicts, if any, is reported. The number of conflicts is the actual number of existing rows in database, which is

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-12 Thread Frank Ding
ance Andersen - Oracle wrote: Frank, If you can please post the bug info here, I will take a look at your patch Best Lance On Nov 8, 2012, at 10:01 PM, Frank Ding wrote: Hi guys, We discovered a bug in CachedRowSetWriter.writeData method where incorrect number of conflicts is reported. I

JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-08 Thread Frank Ding
Hi guys, We discovered a bug in CachedRowSetWriter.writeData method where incorrect number of conflicts is reported. I searched in Oracle bug database and no similar record was found. So I submitted a new one whose internal review ID is 2376620. A test case with code is illustrated in the

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-23 Thread Frank Ding
Hi David, Sorry that Jonathan has already committed the code with bug id 7193463. Could you please dup the 2 bugs? Best regards, Frank On 8/23/2012 4:27 PM, David Holmes wrote: On 23/08/2012 6:05 PM, Frank Ding wrote: Thanks all. I created sun bug 7193463 to track the code change. We

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-23 Thread Frank Ding
Thanks all. I created sun bug 7193463 to track the code change. Best regards, Frank On 8/22/2012 10:13 AM, David Holmes wrote: On 22/08/2012 12:11 PM, Frank Ding wrote: Hi Alan and David, So is it OK to commit the patch in Terminator class? I think Neil will continue proposing the change in

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-21 Thread Frank Ding
Hi Alan and David, So is it OK to commit the patch in Terminator class? I think Neil will continue proposing the change in cvmi mailing list. Many thanks to all. Best regards, Frank On 8/17/2012 4:58 PM, Alan Bateman wrote: On 16/08/2012 16:32, Neil Richards wrote: : However, I still c

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-09 Thread Frank Ding
Thanks Neil for clarifying it in such a convincing way. And David for creating CR. So now we're ready to commit this patch? Best regards, Frank On 8/8/2012 8:57 AM, David Holmes wrote: On 8/08/2012 4:07 AM, Neil Richards wrote: On Tue, 2012-08-07 at 18:01 +0100, Alan Bateman wrote: On 07/08/2

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-06 Thread Frank Ding
In both cases, I think Terminator.setup() should work at best effort to register all. Best regards, Frank On 8/6/2012 7:08 PM, David Holmes wrote: On 6/08/2012 6:57 PM, Frank Ding wrote: Hi Holmes, I agree with your comment on duplicated comment. It should be factored out. The cont

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-06 Thread Frank Ding
rank On 8/6/2012 9:51 AM, David Holmes wrote: Hi Frank, On 3/08/2012 5:39 PM, Frank Ding wrote: Hi guys, I found that in java.lang.Terminator, setup() method, The following code of registering default signal handlers can be improved: / try { Signal.handle(new Signal("INT

Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-03 Thread Frank Ding
Hi guys, I found that in java.lang.Terminator, setup() method, The following code of registering default signal handlers can be improved: /try { Signal.handle(new Signal("INT"), sh); Signal.handle(new Signal("TERM"), sh); } catch (IllegalArgumentException