[9] RFR: 8149923 invalid javadoc in javax.xml.bind.JAXBContext (introduced by 8138699)

2016-02-16 Thread Miroslav Kos
Hi Lance, could you review this minor patch? It is just minor overlook I didn't catch while doing 8138699. Filed a new JBS issue: https://bugs.openjdk.java.net/browse/JDK-8149923 webrev: http://cr.openjdk.java.net/~mkos/8149923/jaxws.01/ Thanks Miran

Re: RFR [9] 8148861: Remove sun.misc.ManagedLocalsThread from jaxws

2016-02-09 Thread Miroslav Kos
Looks ok to me, will take care of it in standalone project. Thanks Miran On 08/02/16 17:20, Chris Hegarty wrote: Receiving some feedback off list, this code needs to be able to run on older releases, so the new Thread constructor, added in JDK 9, should be accessed reflectively. Webrev updated

RFR [9]: 8138699 Iproving JAX-B javadoc

2016-01-29 Thread Miroslav Kos
Hi everybody, please review following patch - those are changes to javadoc, previously consulted with sqe. The javadoc now is not always clear, which makes difficult to develop proper tests. JIRA: https://bugs.openjdk.java.net/browse/JDK-8138699 webrev: http://cr.openjdk.java.net/~mkos/8138699

Re: RFR [9]: 8145104: NPE is thrown when JAXBContextFactory implementation is specified in system property, 8145112: newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as

2016-01-28 Thread Miroslav Kos
Hi Lance, this is the RFR Alan was mentioning. Thanks a lot! Miran On 11/01/16 12:14, Miroslav Kos wrote: Ping ... anybody? On 22/12/15 14:44, Miroslav Kos wrote: Hi everybody, I'd like to ask for reviewing following patch. It fixes two issues: JBS: https://bugs.openjdk.java.net/brows

Re: RFR [9]: 8145104: NPE is thrown when JAXBContextFactory implementation is specified in system property, 8145112: newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as

2016-01-25 Thread Miroslav Kos
Ping again - would somebody find some time to review those, please? Thanks M. On 11/01/16 12:14, Miroslav Kos wrote: Ping ... anybody? On 22/12/15 14:44, Miroslav Kos wrote: Hi everybody, I'd like to ask for reviewing following patch. It fixes two issues: JBS: https://bugs.openjdk.jav

Re: RFR [9]: 8146086 Publishing two webservices on same port fails with "java.net.BindException: Address already in use"

2016-01-18 Thread Miroslav Kos
Hi Chris, are you ok with the change? Thanks Miran On 11/01/16 15:41, Miroslav Kos wrote: Hi Chris, good catch - thanks! Simple fix here: http://cr.openjdk.java.net/~mkos/8146086/jdk.01/ M. On 11/01/16 12:20, Chris Hegarty wrote: Miran, On 11/01/16 11:12, Miroslav Kos wrote: Ping

Re: RFR [9]: 8146086 Publishing two webservices on same port fails with "java.net.BindException: Address already in use"

2016-01-11 Thread Miroslav Kos
Hi Chris, good catch - thanks! Simple fix here: http://cr.openjdk.java.net/~mkos/8146086/jdk.01/ M. On 11/01/16 12:20, Chris Hegarty wrote: Miran, On 11/01/16 11:12, Miroslav Kos wrote: Ping ... anybody? On 23/12/15 15:14, Miroslav Kos wrote: Hi everybody, I'd like to ask for revi

Re: RFR [9]: 8145104: NPE is thrown when JAXBContextFactory implementation is specified in system property, 8145112: newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as

2016-01-11 Thread Miroslav Kos
Ping ... anybody? On 22/12/15 14:44, Miroslav Kos wrote: Hi everybody, I'd like to ask for reviewing following patch. It fixes two issues: JBS: https://bugs.openjdk.java.net/browse/JDK-8145104 NPE is thrown when JAXBContextFactory implementation is specified in system property In

Re: RFR [9]: 8146086 Publishing two webservices on same port fails with "java.net.BindException: Address already in use"

2016-01-11 Thread Miroslav Kos
Ping ... anybody? On 23/12/15 15:14, Miroslav Kos wrote: Hi everybody, I'd like to ask for review of . This simple patch allows publishing more webeservices on same port. The fix has been submitted by Kubota Yuji, it is already integrated in standalone JAX-WS repo, regression test

RFR [9]: 8146086 Publishing two webservices on same port fails with "java.net.BindException: Address already in use"

2015-12-23 Thread Miroslav Kos
Hi everybody, I'd like to ask for review of . This simple patch allows publishing more webeservices on same port. The fix has been submitted by Kubota Yuji, it is already integrated in standalone JAX-WS repo, regression test added. JBS: https://bugs.openjdk.java.net/browse/JDK-8146086 jaxws

RFR [9]: 8145104: NPE is thrown when JAXBContextFactory implementation is specified in system property, 8145112: newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as exp

2015-12-22 Thread Miroslav Kos
Hi everybody, I'd like to ask for reviewing following patch. It fixes two issues: JBS: https://bugs.openjdk.java.net/browse/JDK-8145104 NPE is thrown when JAXBContextFactory implementation is specified in system property In short, it's a regression of recent changes in JAXB-AP. The old versio

Re: Unexpected BindException in Endpoint.publish

2015-12-02 Thread Miroslav Kos
Hi Yuji, thanks for the patch - it fixes the issue and looks ok to me. I'll integrate it to standalone JAX-WS repo and it will be integrated into openjdk during next syncup. Thanks Miran On 01/12/15 11:11, KUBOTA Yuji wrote: Hi Miroslav and all, Could you please review the below issue and

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-20 Thread Miroslav Kos
On 20/11/15 15:25, Daniel Fuchs wrote: On 20/11/15 09:43, Miroslav Kos wrote: Locally, it worked for me, but I understand that it's dengerous - global state is evil ... I removed all the scenarios modifying JDK/conf/ dir - I just commented out those parts so if necessary, it can be uncomm

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-20 Thread Miroslav Kos
Locally, it worked for me, but I understand that it's dengerous - global state is evil ... I removed all the scenarios modifying JDK/conf/ dir - I just commented out those parts so if necessary, it can be uncommented and run locally. http://cr.openjdk.java.net/~mkos/8131334/jdk.02/ Thanks Mira

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-19 Thread Miroslav Kos
5, at 8:28 AM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: I have a set of tests in standalone project (using bash scripts), but the problem is that to test the correct behavior, configuring of jdk is necessary (property file) - have no idea if something like this is possi

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-12 Thread Miroslav Kos
Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> Sent from my iPad On Nov 12, 2015, at 3:55 AM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: .. anyone? On 10/11/15 15:3

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-12 Thread Miroslav Kos
.. anyone? On 10/11/15 15:31, Miroslav Kos wrote: Ping ... Would somebody find time for this one? Thanks M. On 26/10/15 13:59, Miroslav Kos wrote: Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about chang

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-11-10 Thread Miroslav Kos
Ping ... Would somebody find time for this one? Thanks M. On 26/10/15 13:59, Miroslav Kos wrote: Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary se

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-27 Thread Miroslav Kos
not in the specdiff and not in the webrev. Intentional? Best Lance On Oct 23, 2015, at 11:07 AM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: Hi Lance, here is the new version - all the issues addressed, except for ones with extraspace - it looks it's only in specdi

[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-26 Thread Miroslav Kos
Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary service loading implementation which was not fully compatible with to use java.util.ServiceLoader facility. Ther

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-23 Thread Miroslav Kos
arshallerImpl.html <http://cr.openjdk.java.net/%7Emkos/8139743/specdiff.02/javax/xml/bind/helpers/AbstractMarshallerImpl.html> extra space before ')' Best, Lance On Oct 21, 2015, at 12:42 PM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: Hi Lance, yes, it makes

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-21 Thread Miroslav Kos
Miran On Oct 16, 2015, at 11:49 AM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: Hi Lance, the javadoc fixes are just about formal issues (... for {@code .. }, broken links etc.) - there are no other changes. Understand, but the specdiff makes it easier to see that the

Re: [9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-16 Thread Miroslav Kos
16, 2015, at 11:14 AM, Miroslav Kos <mailto:miroslav@oracle.com>> wrote: Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8139743/jaxws.01/ <http://cr.openjdk.java.net/%7Emkos/8139743/jaxws.01/> more details in iss

[9] RFR: 8139743 regular JAX-* sync-up from standalone repos

2015-10-16 Thread Miroslav Kos
Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8139743/jaxws.01/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8139743 Could I ask for a review? It's quite big (2570 lines changed): * many javadoc fixes * some perf

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-05 Thread Miroslav Kos
On 02/10/15 19:36, Georgiy Rakov wrote: On 02.10.2015 18:52, Miroslav Kos wrote: There is an updated version: http://cr.openjdk.java.net/~mkos/8131334/specdiff.07/index.html Two changes: 1) SAAJMetaFactory javadoc - new (self contained) paragraph describing the algorithm for the factory

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-02 Thread Miroslav Kos
There is an updated version: http://cr.openjdk.java.net/~mkos/8131334/specdiff.07/index.html Two changes: 1) SAAJMetaFactory javadoc - new (self contained) paragraph describing the algorithm for the factory + apiNote 2) package javadoc: added back SAAJMetaFactory + "all these factories define n

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-02 Thread Miroslav Kos
Hi Georgiy, would you be ok with this defensive solution? Thanks Miran On 01/10/15 17:10, Miroslav Kos wrote: Hi, there is a new version of specdiff: http://cr.openjdk.java.net/~mkos/8131334/specdiff.06/index.html To remind, there were two problems to be addressed, both related to

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-01 Thread Miroslav Kos
Hi, there is a new version of specdiff: http://cr.openjdk.java.net/~mkos/8131334/specdiff.06/index.html To remind, there were two problems to be addressed, both related to SAAJMetaFactory: http://cr.openjdk.java.net/~mkos/8131334/specdiff.06/javax/xml/soap/SAAJMetaFactory.html 1) hidden featu

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-10-01 Thread Miroslav Kos
On 30/09/15 17:31, Miroslav Kos wrote: On 30/09/15 16:50, Georgiy Rakov wrote: 2. This is not related to ServiceLoader feature, but anyway - SAAJMetaFactory.java: 30 * SAAJ API./_*All *_//_*of the {@code newInstance} methods defined on factories*_/ in 31 * SAAJ 1.3 defer to

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-09-30 Thread Miroslav Kos
a problem with backwards compatibility here ... More defensive would be to name the two factories instead of saying "all"? Thanks Miran Btw. I sent this RFR initially to wrong mailing lists, would you check when answering that it's to Core-Libs-Dev ? Thank you, Georgiy. On

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-09-30 Thread Miroslav Kos
g this mentioning in package-info.java? Thanks, Georgiy. The rest of your changes look ok to me. Also cc’ing Chen for any additional comments Deva On Sep 29, 2015, at 9:45 AM, Miroslav Kos wrote: On 25/09/15 20:24, Georgiy Rakov wrote: Hello Miroslav, sorry for delay, was busy du

Re: [9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-09-30 Thread Miroslav Kos
he updated specdiff is here: http://cr.openjdk.java.net/~mkos/8131334/specdiff.05/ ApiNote removed, SAAJMetaFactory kept package private. Thanks Miran The rest of your changes look ok to me. Also cc’ing Chen for any additional comments Deva On Sep 29, 2015, at 9:45 AM, Miroslav Kos <ma

Re: [9] RFR: 8061466 - RELAX NG API visible but not accessible

2015-09-25 Thread Miroslav Kos
On 25/09/15 11:46, Alan Bateman wrote: On 25/09/2015 10:36, Miroslav Kos wrote: Hi, I prepared the webrev again with hg move: http://cr.openjdk.java.net/~mkos/8061466/jaxws.02/index.html For sure, jprt built again and all tests rerun. The move and re-packaging looks good to me. However I

Re: [9] RFR: 8061466 - RELAX NG API visible but not accessible

2015-09-25 Thread Miroslav Kos
On 24/09/15 16:20, Alan Bateman wrote: On 24/09/2015 14:57, Miroslav Kos wrote: Hi everybody, I'd like to ask for review of following fix: RELAX NG API visible but not accessible JBS: https://bugs.openjdk.java.net/browse/JDK-8061466 webrev: http://cr.openjdk.java.net/~mkos/8061466/jax

[9] RFR: 8061466 - RELAX NG API visible but not accessible

2015-09-24 Thread Miroslav Kos
Hi everybody, I'd like to ask for review of following fix: RELAX NG API visible but not accessible JBS: https://bugs.openjdk.java.net/browse/JDK-8061466 webrev: http://cr.openjdk.java.net/~mkos/8061466/jaxws.01/index.html - org.relaxng.* classes in jdk.xml.bind module are not repackaged, but t

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-09-16 Thread Miroslav Kos
On 15/09/15 15:46, Alan Bateman wrote: On 27/08/2015 19:26, Miroslav Kos wrote: Hi Alan, I added logging (at least for now) - would it work for you? updated webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.02/ If you think the exception shouldn't be ignored I suggest to solve th

[9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

2015-09-15 Thread Miroslav Kos
Hi everybody, I am sending changes for review for JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader JBS: https://bugs.openjdk.java.net/browse/JDK-8131334 webrev: http://cr.openjdk.java.net/~mkos/8131334/jaxws.01/ It's about migrating to standard java.util.ServiceLoader. This pa

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-09-11 Thread Miroslav Kos
On 27/08/15 20:26, Miroslav Kos wrote: On 20/08/15 19:18, Alan Bateman wrote: On 19/08/2015 16:37, Miroslav Kos wrote: Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-08-27 Thread Miroslav Kos
On 20/08/15 19:18, Alan Bateman wrote: On 19/08/2015 16:37, Miroslav Kos wrote: Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.01/ It's

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-08-21 Thread Miroslav Kos
20/08/15 19:18, Alan Bateman wrote: On 19/08/2015 16:37, Miroslav Kos wrote: Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.01/ It&

[9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-08-19 Thread Miroslav Kos
Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.01/ It's about migrating to standard java.util.ServiceLoader. This part of service discovery was imp

Re: [9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

2015-07-09 Thread Miroslav Kos
ances toward the start of the patch where {@code Foo} is listed as being replaced by Foo, but {@code Foo} is what we want to use now. Are you running doclint over Java source or in a docs build to verify the changes? Thanks, -Joe On 7/8/2015 5:29 AM, Miroslav Kos wrote: Hi everybody, I'

[9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

2015-07-08 Thread Miroslav Kos
Hi everybody, I'd like to ask for review for following issue: JBS: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API webrev: http://cr.openjdk.java.net/~mkos/8130753/jaxws.01/ It addresses all the javadoc errors in all 3 JSRs: SAAJ, JAX-B and JAX-WS an

Re: RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

2015-06-02 Thread Miroslav Kos
Hi Alan, Daniel, would you have some time to check the changes in this one? Thanks a lot Miran On 27/05/15 00:50, Miroslav Kos wrote: On 20/05/15 15:30, Daniel Fuchs wrote: Hi Miroslav, I haven't looked in all details, but this text in JAXBContext.java looks odd to me - it seems tha

Re: RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

2015-05-26 Thread Miroslav Kos
nently in the bullet itself. I added a note mentioning that the step is deprecated. Corrected version: http://cr.openjdk.java.net/~mkos/8072839/jaxws.03/ I also came over the changed files and added new lines to make lines shorter. Thanks Miran best regards, -- daniel On 15/05/15 17:13, Mirosl

Re: RFR [9] 8080502: Changing accessing module resources

2015-05-26 Thread Miroslav Kos
On 21/05/15 14:34, Alan Bateman wrote: On 19/05/2015 10:38, Miroslav Kos wrote: : JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.01/index.html testing: JAX-WS unit test; basically it is fix for existing tests (JCK, ...) One thing

Re: RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

2015-05-20 Thread Miroslav Kos
On 19/05/15 22:44, Alan Bateman wrote: On 15/05/2015 16:13, Miroslav Kos wrote: Hi everybody, this is review request for: 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader The JAX-B API changed a little bit - proprietary ServiceLoader-like code has been replaced by

RFR [9] 8080502: Changing accessing module resources

2015-05-19 Thread Miroslav Kos
Hi everybody, this is a review request for 8080502: Changing accessing module resources. This change adapts to Jigsaw JDK runtime - it isn't possible to access module resource using Class::getResource() any more. JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.

RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

2015-05-15 Thread Miroslav Kos
Hi everybody, this is review request for: 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader The JAX-B API changed a little bit - proprietary ServiceLoader-like code has been replaced by java.util.ServiceLoader. This change is required by Jigsaw, old configuration way still suppor

Re: RFR: 8061293: Update javax/xml tests to remove references of jre dir

2015-03-05 Thread Miroslav Kos
Looks ok to me. Thanks Miran On 05/03/15 08:30, Frank Yuan wrote: Hi All Would you like to review the code change for bug: https://bugs.openjdk.java.net/browse/JDK-8061293, this is a Jigsaw related bug, it's to clean up the reference to "jre" dir. webrev: http://cr.openjdk.java.net/~fyua

Re: Review request 8057645: Deprivilege JAX-WS, JAXB, JAF to extension class loader

2015-02-06 Thread Miroslav Kos
On 26/01/15 21:55, Alan Bateman wrote: On 26/01/2015 19:23, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8057645/webrev.00/ This patch proposes to move java.xml.ws, java.xml.bind, java.activation out of the boot loader and be loaded by the extension class loader. We gr

Re: RFR: 8071585: Update JAX-WS RI integration to latest version (2.2.11-b150127.1410)

2015-02-02 Thread Miroslav Kos
On 29/01/15 16:06, Alan Bateman wrote: On 29/01/2015 14:51, Aleksej Efimov wrote: Hi, Can I have a review for a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~aefimov/8071585/webrev/ more details in JBS: https://bugs.openjdk.java.net/browse/JDK-8071585 Th

Re: Review request 8057645: Deprivilege JAX-WS, JAXB, JAF to extension class loader

2015-01-28 Thread Miroslav Kos
On 26/01/15 20:23, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8057645/webrev.00/ This patch proposes to move java.xml.ws, java.xml.bind, java.activation out of the boot loader and be loaded by the extension class loader. We grant java.xml.ws and java.xml.bind the mini

Re: RFR: 8065870 Update JAX-WS RI integration to latest version (2.2.11-b141124.1933)

2014-12-02 Thread Miroslav Kos
riginal file. ** src/jdk.xml.ws/share/classes/com/sun/tools/internal/ws/version.properties Copyright years 2014 => 2013. == Nothing earth-shattering here. If you want to push this changeset and fix up these issues later (if indeed they need to be fixed up), I'd be fine with t

RFR: 8065870 Update JAX-WS RI integration to latest version (2.2.11-b141124.1933)

2014-11-27 Thread Miroslav Kos
Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8065870/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8065870 Could I ask for a review? It seems quite big (1126 lines changed) but there are just minor chan

Re: RFR: 8046817: JDK 8 schemagen tool does not generate xsd files for enum types

2014-10-15 Thread Miroslav Kos
Hi Aleksej, the change looks ok to me, but it would be good to integrate it into upstream (standalone JAX-B RI project) first to be on safe side - there are much more tests then in OpenJDK. Copying Iaroslav who is JAX-B RI lead and can help you with integration and running tests. Thanks Mi

Re: [9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

2014-09-24 Thread Miroslav Kos
ayout. I've converted them. I'm am seeing the new test fail on windows though. Will share the details with you offline. regards, Sean. On 18/09/14 16:22, Miroslav Kos wrote: Ok then, the webrev updated: http://cr.openjdk.java.net/~mkos/8038966/jdk.03/ http://cr.openjdk.java.net/~mko

Re: [9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

2014-09-18 Thread Miroslav Kos
reg should remove the work/scratch directory upon test completion but it's best practice to attempt to clean up generated files. No harm there I think. Also needed in cases where test might be run manually. I'd suggest keeping the clean up code in the testcase. regards, Sean. On 18/09/20

Re: [9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

2014-09-18 Thread Miroslav Kos
11:49, Seán Coffey wrote: On 18/09/2014 10:12, Miroslav Kos wrote: Thanks, Sean, good catch ... I changed the destination for generated files: http://cr.openjdk.java.net/~mkos/8038966/jdk.02/ Regarding usage ProcessBuilder instead of shell script - the problem is, that to compile test classes,

Re: [9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

2014-09-18 Thread Miroslav Kos
ectory. This is often read only and won't work. TESTCLASSES is the variable you're probably looking for. In any case, I think it's possible for you to avoid use of scripting. Can you invoke wsimport via the ProcessBuilder API like that done for other wsimport tests ? regards, Sean

[9] RFR: 8038966 JAX-WS handles wrongly xsd:any arguments for Web services

2014-09-17 Thread Miroslav Kos
Hi everybody, please review patch fixing following issue: JBS: https://bugs.openjdk.java.net/browse/JDK-8038966 webrev: http://cr.openjdk.java.net/~mkos/8038966/jaxws.00/ http://cr.openjdk.java.net/~mkos/8038966/jdk.01/ It is second part of fix ensuring that content of type xsd:any/content=mix

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Miroslav Kos
On 12/09/14 11:51, Alan Bateman wrote: On 12/09/2014 09:39, Miroslav Kos wrote: I agree that the code looks scary, but it's because we have to support range of jdk (currently jdk6 to jdk9) and we want to avoid maintaining several branches. The standalone project must work even with jdk6

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Miroslav Kos
On 11/09/14 14:39, Alan Bateman wrote: On 11/09/2014 12:20, Miroslav Kos wrote: Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection

[9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-11 Thread Miroslav Kos
Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection by javax.tools API plus removing old unused code. I ran the unit tests against b

Re: RFR: 8047724: @since tag cleanup in jaxws

2014-07-28 Thread Miroslav Kos
Hi Henry, sorry for no response, I missed this one. Yes, this looks reasonable. You can proceed with the change, I'll integrate it into upstream projects. Thanks Miran On 28/07/14 11:11, Henry Jen wrote: Hi Micoslav, What do you think about the webrev[1]? Does it make sense for upstream

Re: [9] RFR 8038970: Deprivilege JAX-WS/JAF code

2014-07-18 Thread Miroslav Kos
:02, Mandy Chung wrote: On 7/17/2014 8:12 AM, Miroslav Kos wrote: Hi everybody, here is a request for review for 8038970: Deprivilege JAX-WS/JAF code JBS: https://bugs.openjdk.java.net/browse/JDK-8038970 webrev: http://cr.openjdk.java.net/~mkos/8038970/jaxws.04/ FYI. The href at the above

[9] RFR 8038970: Deprivilege JAX-WS/JAF code

2014-07-17 Thread Miroslav Kos
Hi everybody, here is a request for review for 8038970: Deprivilege JAX-WS/JAF code JBS: https://bugs.openjdk.java.net/browse/JDK-8038970 webrev: http://cr.openjdk.java.net/~mkos/8038970/jaxws.04/ This is first part of changes - after this also jdk build will have to be changed. Changeset has b

Re: RFR: 8044656: Update JAX-WS RI integration to latest version

2014-07-09 Thread Miroslav Kos
d via reflection. M. Thanks, Joe On 6/30/2014 9:22 AM, Miroslav Kos wrote: Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8044656/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8044656 Could I ask

RFR: 8044656: Update JAX-WS RI integration to latest version

2014-06-30 Thread Miroslav Kos
Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8044656/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8044656 Could I ask for a review/approval? Thanks Miran

Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-29 Thread Miroslav Kos
Hi Hajo, I agree with you, this issue means major loss of functionality. I already started processing backport to jdk8 and after that will continue with jdk7. Thanks Miran On 26/05/14 18:50, i...@kliemeck.de wrote: Hey Miroslav, is this correct that the issue will be fixed on jdk9 only (as

RFR: 8043762: Remove unused files from jaxws repository

2014-05-26 Thread Miroslav Kos
Hi everybody, here is the request for review for 8043762: Remove unused files from jaxws repository JBS: https://bugs.openjdk.java.net/browse/JDK-8043762 webrev: http://cr.openjdk.java.net/~mkos/8043762/jaxws.01/ Simple fix removing unused files in jaxws repo, no tests necessary. Thanks Miran

Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-20 Thread Miroslav Kos
ue without adding, what appears to be, a large jar file. -Chris. On 19/05/14 14:36, Miroslav Kos wrote: Hi, this is review request for: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail JBS: https://bugs.openjdk.java.net/browse/JDK-8043129 WEBREV: http://cr.openjdk.java

RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-19 Thread Miroslav Kos
Hi, this is review request for: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail JBS: https://bugs.openjdk.java.net/browse/JDK-8043129 WEBREV: http://cr.openjdk.java.net/~mkos/8043129/jaxws.00/ http://cr.openjdk.java.net/~mkos/8043129/jdk.00/ (test) This solves conflict b

RFR: 8039210: Fix type error in DefaultResourceInjector

2014-05-19 Thread Miroslav Kos
Hi, this is review request for: 8039210: Fix type error in DefaultResourceInjector JBS: https://bugs.openjdk.java.net/browse/JDK-8039210 WEBREV: http://cr.openjdk.java.net/~mkos/8039210/jaxws.00/ It is simple one-line fix; it's blocker for another issue. Thanks Miran

RFR: 8040754: Break the circular dependency between SAAJ and JAXB

2014-04-28 Thread Miroslav Kos
Hi, this is review request for: 8040754: Break the circular dependency between SAAJ and JAXB JBS: https://bugs.openjdk.java.net/browse/JDK-8040754 WEBREV: http://cr.openjdk.java.net/~mkos/8040754/jaxws.01/ It is basically moving classes in order to fix dependency between SAAJ, JAX-B and JAX-W

RFR: 8039899: Missing licence headers in test for JDK-8033113

2014-04-10 Thread Miroslav Kos
Hi, please review the following change - this is just missing license headers fix - 8039899: Missing licence headers in test for JDK-8033113 JBS: https://bugs.openjdk.java.net/browse/JDK-8039899 WEBREV: http://cr.openjdk.java.net/~mkos/8039899/jdk.01/ Chris, may I ask you to push it to jdk9u-d

RFR: 8033113: wsimport fails on WSDL:header parameter name customization

2014-04-07 Thread Miroslav Kos
Hi, I'd like to ask for approval and sponsoring fix for following issue (escalation from customer): JBS: https://bugs.openjdk.java.net/browse/JDK-8033113 BugDB: https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=17348912 jaxws changeset: http://cr.openjdk.java.net/~mkos/8033113/jaxw

Re: RFR: tests for JDK-8032884

2014-04-03 Thread Miroslav Kos
Hi Chris, the test moved: http://cr.openjdk.java.net/~mkos/8032884/jdk.02/ Thanks Miran On 02/04/14 15:47, Chris Hegarty wrote: On 02/04/14 14:32, Miroslav Kos wrote: In the test, I need to do following steps: 1. compile schema file using xjc tool 2. compile generated sources 3. load

Re: RFR: tests for JDK-8032884

2014-04-02 Thread Miroslav Kos
fine to me. Trivially, you could eliminate the shell script and run xic from ProcessBuilder? Also, does it make sense to move the test to jdk/test/javax/xml/ws/xjc? With the other jaxws tests, or is xjc different. -Chris,. On 1 Apr 2014, at 16:21, Miroslav Kos wrote: Hi everybody, I'd

RFR: tests for JDK-8032884

2014-04-01 Thread Miroslav Kos
Hi everybody, I'd like to ask for review of following tests: http://cr.openjdk.java.net/~mkos/8032884/jdk.01/ Original bug (already fixed): Bug: https://bugs.openjdk.java.net/browse/JDK-8032884 Issue fixing the bug (bulk update): https://bugs.openjdk.java.net/browse/JDK-8036030 The test veri

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

2014-04-01 Thread Miroslav Kos
live, and will be picked up in the usual developer cycle by the jdk_other test group. -Chris. On 31 Mar 2014, at 15:33, Chris Hegarty wrote: On 31/03/14 15:05, Miroslav Kos wrote: Thanks Chris, the code adjusted: http://cr.openjdk.java.net/~mkos/8038307/jaxws.02/ Approved. Glad, if yo

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

2014-03-31 Thread Miroslav Kos
andle UnsupportedEncodingException. I can sponsor this for you, if you need a sponsor. -Chris. [1] http://docs.oracle.com/javase/8/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 On 31/03/14 14:19, Miroslav Kos wrote: Hi there, please review folowing simple fix - Bug: https://bugs.openjdk.java.net/b

RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

2014-03-31 Thread Miroslav Kos
Hi there, please review folowing simple fix - Bug: https://bugs.openjdk.java.net/browse/JDK-8038307 Fix: http://cr.openjdk.java.net/~mkos/8038307/jaxws.01/ Test: http://cr.openjdk.java.net/~mkos/8038307/jdk.01/ Issue related to EBCDIC encoding/WsImport tool. Thanks Miran

Re: RFR: 8036030: Update JAX-WS RI integration to latest version

2014-03-28 Thread Miroslav Kos
16:21, Miroslav Kos wrote: Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8036030/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8036030 Thanks Miran

RFR: 8036030: Update JAX-WS RI integration to latest version

2014-03-07 Thread Miroslav Kos
Hi, there is a bulk update of JAX-B/WS from upstream projects - webrev: http://cr.openjdk.java.net/~mkos/8036030/jaxws.00/ more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8036030 Thanks Miran

Re: JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

2014-01-24 Thread Miroslav Kos
the patches apply cleanly I can push it for you. Do you want it in JDK 9? -Chris. On 24/01/14 09:41, Miroslav Kos wrote: Hi Chris, thanks for reviewing - I generated the patches today again so now it should be ok: http://cr.openjdk.java.net/~mkos/8029237/copyrights-2012-v02.patch http

Re: JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

2014-01-24 Thread Miroslav Kos
get any response on this yet? MartiNG On 17/01/14 10:57, Miroslav Kos wrote: Hi Steve and Alan, I just reminding this issue - I have no response from anybody yet and it would really simplify our integration if I could handle copyright years inconsistencies this way - I see this issue in many jd

Re: JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

2014-01-17 Thread Miroslav Kos
ntegration much more pain. Thanks for any idea on this. Miran On 10/01/14 18:05, Miroslav Kos wrote: Hi, this is about fixing copyright years for jdk8 (!); the incorrect years found for both 2012 and 2013, so not to confuse script jdk8/make/scripts/update_copyright_year.sh it is necessary to

JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

2014-01-10 Thread Miroslav Kos
Hi, this is about fixing copyright years for jdk8 (!); the incorrect years found for both 2012 and 2013, so not to confuse script jdk8/make/scripts/update_copyright_year.sh it is necessary to use option -d "" for commit. I tested that and it seems to work perfect. I used following: [2012 modi

Re: Update JAX-WS RI integration to 2.2.9-b130918.1732 - JDK-8025054

2013-10-01 Thread Miroslav Kos
fore pushing. Maybe something like : test/javax/xml/ws/clientJarTest/ regards, Sean. -Chris. regards, Sean. On 26/09/2013 17:14, Miroslav Kos wrote: Hi Sean, anything new about this? I fixed the copyright/indentation problems (the only change), so the updated jaxws-webrev i

Re: Update JAX-WS RI integration to 2.2.9-b130918.1732 - JDK-8025054

2013-10-01 Thread Miroslav Kos
though so you'll need someone else as reviewer. regards, Sean. On 26/09/2013 17:14, Miroslav Kos wrote: Hi Sean, anything new about this? I fixed the copyright/indentation problems (the only change), so the updated jaxws-webrev is located here: http://cr.openjdk.java.net/~mkos/8025054/

Re: Update JAX-WS RI integration to 2.2.9-b130918.1732

2013-09-26 Thread Miroslav Kos
://bugs.openjdk.java.net/browse/JDK-8025054 It would be good to push it soon. Thanks Miran On 9/23/13 5:38 PM, Alan Bateman wrote: On 23/09/2013 02:19, Miroslav Kos wrote: Hi everybody, There is another update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. As usually

Update JAX-WS RI integration to 2.2.9-b130918.1732

2013-09-23 Thread Miroslav Kos
Hi everybody, There is another update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. As usually, it is quite big changeset (6k+ LOC changed) and includes several bug fixes, for details see the issue description: https://bugs.openjdk.java.net/browse/JDK-8025054 P

Re: RFR: 8016271: wsimport -clientjar does not create portable jar on windows due to hardcoded '\'

2013-09-03 Thread Miroslav Kos
o both repos independently? How often does JAX-WS team sync with openJDK ? I need to get this ported to jdk7u also. regards, Sean. On 03/09/2013 11:11, Miroslav Kos wrote: Hi Alan, good catch! Yes, we need to apply the fix on our side too, otherwise it would be reverted with a new integration

Re: RFR: 8016271: wsimport -clientjar does not create portable jar on windows due to hardcoded '\'

2013-09-03 Thread Miroslav Kos
ync from upstream. I've cc'ed martin Grebac and Miroslav Kos to comment. -Alan.

Re: Update jdk8/tl/jaxws to v2.2.9-b14140 ready for review

2013-08-19 Thread Miroslav Kos
Bateman wrote: On 19/08/2013 13:56, Miroslav Kos wrote: Hi Alan, yes, this is true for rngom library - we downgraded it to the version which has been approved to be used as a 3rd party library. Licences are unchanged from the ones in the library; is there somebody who could approve these are ok

Re: Update jdk8/tl/jaxws to v2.2.9-b14140 ready for review

2013-08-19 Thread Miroslav Kos
Bateman wrote: On 16/08/2013 11:15, Miroslav Kos wrote: There is an update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. It is quite big changeset (13k+ LOC changed) and includes several bug fixes: http://java.net/jira/browse/JAX_WS-1114 problem sending XML primitive

Update jdk8/tl/jaxws to v2.2.9-b14140 ready for review

2013-08-16 Thread Miroslav Kos
There is an update syncing JAX-WS sources in jdk8/tl/jaxws to most recent development version. It is quite big changeset (13k+ LOC changed) and includes several bug fixes: http://java.net/jira/browse/JAX_WS-1114 problem sending XML primitive type gMonth (the request ends up null on server) htt

Re: JAX-WS update coming soon

2013-04-08 Thread Miroslav Kos
On 04/08/2013 05:05 PM, Alan Bateman wrote: On 21/03/2013 11:27, Alan Bateman wrote: Just a heads-up that there is a JAX-WS update coming for jdk8. Miroslav Kos will be sending a webrev soon with the changes that update what we have in jdk8 from 2.2.7-b09 to 2.2.9-b13922. Miroslav has put a

Re: 7140918: Remove dependency on apt and com.sun.mirror API

2012-02-08 Thread Miroslav Kos
Hi Alan, do you have any update about approving the changeset? The jaxws bundle is already in place, so there should be nothing blocking us from the final step(?) We already have PIT Certificate from QA: https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=13491649 Regards Miran O

  1   2   >