On Wed, 1 Sep 2021 06:45:26 GMT, Wu Yan wrote:
> Hi,
> Please help me review the change to enhance getting time zone ID from
> /etc/localtime on linux.
>
> We use `realpath` instead of `readlink` to obtain the link name of
> /etc/localtime, because `readlink` can only r
On Wed, 1 Sep 2021 13:39:46 GMT, Naoto Sato wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value
On Fri, 15 Oct 2021 07:03:18 GMT, Hamlin Li wrote:
>> Wu Yan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additi
"/Asia/Shanghai", not "Asia/Shanghai", which
> consider as invalid in `ZoneInfoFile.getZoneInfo()`. Using `realpath`, you
> can get “/usr/share/zoneinfo/Asia/Shanghai“ directly from “/etc/localtime“.
>
> Thanks,
> wuyan
Wu Yan has updated the pull r
"/Asia/Shanghai", not "Asia/Shanghai", which
> consider as invalid in `ZoneInfoFile.getZoneInfo()`. Using `realpath`, you
> can get “/usr/share/zoneinfo/Asia/Shanghai“ directly from “/etc/localtime“.
>
> Thanks,
> wuyan
Wu Yan has updated the pull requ
"/Asia/Shanghai", not "Asia/Shanghai", which
> consider as invalid in `ZoneInfoFile.getZoneInfo()`. Using `realpath`, you
> can get “/usr/share/zoneinfo/Asia/Shanghai“ directly from “/etc/localtime“.
>
> Thanks,
> wuyan
Wu Yan has updated the pull request i
On Mon, 11 Oct 2021 18:18:02 GMT, Naoto Sato wrote:
>> Wu Yan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> replace realpath
>
> src/java.base/unix/native/libjava/path_util.h line 31:
>
>>
On Mon, 11 Oct 2021 18:16:28 GMT, Naoto Sato wrote:
>> Wu Yan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> replace realpath
>
> src/java.base/unix/native/libjava/TimeZone_md.c line 113:
>
>> 1
On Wed, 1 Sep 2021 13:39:46 GMT, Naoto Sato wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value
On Sun, 5 Sep 2021 13:23:21 GMT, Andrew Haley wrote:
>> Thanks, I'll fix it.
>
> It's fine. I don't think it'll affect any real programs, so it's rather
> pointless. I don't know if that's any reason not to approve it.
Andrew, can you help us to approve this?
-
PR: https://git.ope
On Thu, 9 Sep 2021 08:25:44 GMT, Wu Yan wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `
"/Asia/Shanghai", not "Asia/Shanghai", which
> consider as invalid in `ZoneInfoFile.getZoneInfo()`. Using `realpath`, you
> can get “/usr/share/zoneinfo/Asia/Shanghai“ directly from “/etc/localtime“.
>
> Thanks,
> wuyan
Wu Yan has updated the pull req
On Tue, 7 Sep 2021 01:38:02 GMT, Nick Gasson wrote:
> Please check the Windows tier1 failure:
> https://github.com/Wanghuang-Huawei/jdk/runs/3459332995
>
> Seems unlikely that it's anything to do with this patch so you may just want
> to re-run it or merge from master.
OK, The rerun of presub
On Wed, 28 Jul 2021 08:51:38 GMT, Andrew Haley wrote:
>> I don't think we want to keep two copies of the compareTo intrinsic. If
>> there are no cases where the LDP version is worse than the original version
>> then we should just delete the old one and replace it with this.
>
>> I don't think
On Wed, 1 Sep 2021 12:38:38 GMT, Alan Bateman wrote:
> I haven't come across this configuration like but changing it to use realpath
> seem reasonable.
Thanks, this scenario comes from our customers.
> Using `realpath` instead of `readlink` will change results on systems which
> use symbolic
On Wed, 1 Sep 2021 12:51:15 GMT, Florian Weimer wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the v
Hi,
Please help me review the change to enhance getting time zone ID from
/etc/localtime on linux.
We use `realpath` instead of `readlink` to obtain the link name of
/etc/localtime, because `readlink` can only read the value of a symbolic of
link, not the canonicalized absolute pathname.
For
On Wed, 25 Aug 2021 07:40:56 GMT, Nick Gasson wrote:
> I've run the benchmark on several different machines and didn't see any
> performance regressions, and the speed-up for longer strings looks quite
> good. I also ran jtreg tier1-3 with no new failures so I think this is ok.
>
> If you fix
On Wed, 28 Jul 2021 08:51:38 GMT, Andrew Haley wrote:
>> I don't think we want to keep two copies of the compareTo intrinsic. If
>> there are no cases where the LDP version is worse than the original version
>> then we should just delete the old one and replace it with this.
>
>> I don't think
On Tue, 3 Aug 2021 13:33:07 GMT, Wang Huang wrote:
>> Dear all,
>> Can you do me a favor to review this patch. This patch use `ldp` to
>> implement String.compareTo.
>>
>> * We add a JMH test case
>> * Here is the result of this test case
>>
>> Benchmark |(s
On Wed, 4 Aug 2021 03:27:49 GMT, Nick Gasson wrote:
>> Wang Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits sinc
On Wed, 4 Aug 2021 03:29:40 GMT, Nick Gasson wrote:
> Please provide the updated benchmark results for this version. Are you able
> to test it on several different machines?
We tested this version on Raspberry Pi 4B.
base:
Benchmark (diff_pos) (size) Mode
On Wed, 28 Jul 2021 09:55:18 GMT, Nick Gasson wrote:
> Adding prefetches was one of the reasons to introduce the separate stub for
> long strings, see the mail below:
>
> https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-April/02.html
Thank you for pointing this out, we di
On Wed, 28 Jul 2021 08:51:38 GMT, Andrew Haley wrote:
> The trouble is, what does "worse" mean? I'm looking at SDEN-1982442, Neoverse
> N2 errata, 2001293, and I see that LDP has to be slowed down on streaming
> workloads, which will affect this. (That's just an example: I'm making the
> point
On Mon, 12 Jul 2021 15:36:29 GMT, Andrew Haley wrote:
>> Wang Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> draft of refactor
>
> And with longer strings, M1 and ThunderX2:
>
>
> Benchmark
25 matches
Mail list logo
