Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-18 Thread Alan Bateman
On 17/10/2013 20:25, Andrew wrote: : Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use of APIs that are only in this implementation of the JDK. Just to add to Mandy'

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-17 Thread Mandy Chung
On 10/17/13 12:25 PM, Andrew wrote: I just came across this trying to understand what the new annotation means. Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use of

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-17 Thread Andrew
- Original Message - > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number of > JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs:

hg: jdk8/tl/jdk: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-09 Thread alan . bateman
Changeset: 2ea162b2ff55 Author:alanb Date: 2013-10-09 09:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55 8008662: Add @jdk.Exported to JDK-specific/exported APIs Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy ! src/share/classes/com/sun/jdi

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Joseph Darcy
Hello, I skimmed the patch and it looked fine. More generally, we want every package and top-level class in the com.sun.* namespace to be either explicitly exported or not. Cheers, -Joe On 10/6/2013 1:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
On 10/07/2013 08:58 AM, Alan Bateman wrote: On 07/10/2013 13:36, Sean Mullan wrote: We have only started removing some deprecated things in JDK, so it just was never thought about until now. Marking these as supported going forward strikes me as a bit strange, since we don't really want anyone

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Alan Bateman
On 07/10/2013 13:36, Sean Mullan wrote: We have only started removing some deprecated things in JDK, so it just was never thought about until now. Marking these as supported going forward strikes me as a bit strange, since we don't really want anyone using these anymore. As a guide, I think w

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
On 10/07/2013 08:28 AM, Alan Bateman wrote: On 07/10/2013 13:26, Sean Mullan wrote: 7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean I know but aren't they still exported and supported? They have all had AP

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Alan Bateman
On 07/10/2013 13:26, Sean Mullan wrote: 7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean I know but aren't they still exported and supported? DialogCallbackHandler is the only one with its name on a bullet.

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Sean Mullan
7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean On 10/06/2013 04:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Alan Bateman
On 07/10/2013 11:31, Mandy Chung wrote: : For the review then the intention is that @jdk.Exported be added to the package-info and all public/protected types in these APIs. The only exceptions are two cases where I've added @jdk.Exported(false), specifically: - com.sun.management.OSMBeanF

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Mandy Chung
On 10/6/2013 1:03 PM, Alan Bateman wrote: The webrev with the proposed update is here: http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ I went through the entire webrev and the change looks good. For the review then the intention is that @jdk.Exported be added to the package-info a

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Daniel Fuchs
Hi Alan, The com.sun.management changes look good. -- daniel On 10/6/13 10:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are long standing export

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Vincent Ryan
The JAAS and JGSS changes look fine too. On 7 Oct 2013, at 09:23, Chris Hegarty wrote: > Alan, > > I checked the httpsever and sctp changes. All look good to me. > > -Chris. > > On 10/06/2013 09:03 PM, Alan Bateman wrote: >> >> As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exp

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-07 Thread Chris Hegarty
Alan, I checked the httpsever and sctp changes. All look good to me. -Chris. On 10/06/2013 09:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are l

8008662: Add @jdk.Exported to JDK-specific/exported APIs

2013-10-06 Thread Alan Bateman
As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are long standing exported, documented and supported APIs. Specifically, the following APIs: - Java Debug Interface (com.sun.