On 10/06/2013 20:59, Daniel Fuchs wrote:
On 6/10/13 9:04 PM, Mike Duigou wrote:
StubDelegateImpl.java::
- Could just call Objects.hashCode(ior);
RepIdDelegator::
- Could also call Objects.hashCode(delegate) as it extends nothing
the super.equals(delegate) is calling Object.equals
Depends on
On 6/10/13 9:04 PM, Mike Duigou wrote:
StubDelegateImpl.java::
- Could just call Objects.hashCode(ior);
RepIdDelegator::
- Could also call Objects.hashCode(delegate) as it extends nothing the
super.equals(delegate) is calling Object.equals
Depends on whether you intend to backport the patch
StubDelegateImpl.java::
- Could just call Objects.hashCode(ior);
RepIdDelegator::
- Could also call Objects.hashCode(delegate) as it extends nothing the
super.equals(delegate) is calling Object.equals
Mike
On Jun 10 2013, at 04:11 , Alan Bateman wrote:
>
> The warnings from the build of the
Changeset: 5845df371e25
Author:alanb
Date: 2013-06-10 17:15 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5845df371e25
8016218: Warnings building corba repo due to missing hashCode methods
Reviewed-by: chegar, coffeys, dfuchs
! src/share/classes/com/sun/corba/se/impl
On 10/06/2013 16:42, Daniel Fuchs wrote:
:
In ParserTable.java, I wonder whether it would be worth
returning a different constant for each different class.
I could although I don't think they are used (and probably could be
deleted).
-Alan.
The warnings from the build of the corba repository on missing hashCode
methods have been annoying me for some time. I was hoping they would
annoy others too but looks like I blinked first :-)
Here's the webrev with the changes that I'd like to push to fix the issues:
http://cr.openjdk.java.
All look good to me.
These, hashCode/equals, warning have been annoying me for a while now
too, but I have yet to blink!
-Chris.
On 10/06/2013 12:11, Alan Bateman wrote:
The warnings from the build of the corba repository on missing hashCode
methods have been annoying me for some time. I wa
On 6/10/13 1:11 PM, Alan Bateman wrote:
The warnings from the build of the corba repository on missing hashCode
methods have been annoying me for some time. I was hoping they would
annoy others too but looks like I blinked first :-)
Here's the webrev with the changes that I'd like to push to fi
Thanks for taking care of that Alan. Those changes look fine to me. Hope
the testing works out ok.
regards,
Sean.
On 10/06/13 12:11, Alan Bateman wrote:
The warnings from the build of the corba repository on missing
hashCode methods have been annoying me for some time. I was hoping
they wou
