: core-libs-dev@openjdk.java.net; nio-...@openjdk.java.net
Subject: Re: RFR (S): 8223015: Cleanups for zipfs tests
Hi Christoph,
On Apr 26, 2019, at 12:50 PM, Langer, Christoph
mailto:christoph.lan...@sap.com>> wrote:
Hi Lance,
thanks for reviewing.
:-)
As for ZipFSTester: the printf is
To: Langer, Christoph <mailto:christoph.lan...@sap.com>>
> Cc: core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net>;
> nio-...@openjdk.java.net <mailto:nio-...@openjdk.java.net>
> Subject: Re: RFR (S): 8223015: Cleanups for zipfs tests
&g
-...@openjdk.java.net
Subject: Re: RFR (S): 8223015: Cleanups for zipfs tests
Hi Christoph,
Thank you for doing this. Overall the changes look good.
A few minor thoughts
ZIpFSTester.java - 537: Given you removed the method variable, I would tweak
the printf string to make it a bit clearer
Hi Christoph,
Thank you for doing this. Overall the changes look good.
A few minor thoughts
ZIpFSTester.java - 537: Given you removed the method variable, I would tweak
the printf string to make it a bit clearer that what the output its.
JFSTester.java and MultiReleaseJarTest.java - I had
Thank you, Claes.
> -Original Message-
> From: Claes Redestad
> Sent: Freitag, 26. April 2019 14:44
> To: Langer, Christoph ; core-libs-
> d...@openjdk.java.net; nio-...@openjdk.java.net
> Subject: Re: RFR (S): 8223015: Cleanups for zipfs tests
>
> Looks good
Looks good to me.
I took some extra care to check that use of new Integer in
MultiReleaseJarTest wasn't intentional but that doesn't seem to be the
case here.
Thanks!
/Claes
On 2019-04-26 14:35, Langer, Christoph wrote:
Hi,
please help reviewing these cleanups to the zipfs tests. In detail:
