Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Thanks for the reviews everyone! cheers /Joel On Sep 4, 2013, at 3:25 PM, Joel Borggren-Franck joel.fra...@oracle.com wrote: Hi all, Thanks for the comments. New webrev here: http://cr.openjdk.java.net/~jfranck/5047859/webrev.03/ I have also created a specdiff to make it easier to

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi all, Thanks for the comments. New webrev here: http://cr.openjdk.java.net/~jfranck/5047859/webrev.03/ I have also created a specdiff to make it easier to visualize the doc change: http://cr.openjdk.java.net/~jfranck/5047859/specdiff/overview-summary.html I made some bigger changes this

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi Joel, The spec changes look good in their current form. I'd prefer to see the test re-structure to have class code duplication, but it is acceptable in its present form. Cheers, -Joe On 9/4/2013 6:25 AM, Joel Borggren-Franck wrote: Hi all, Thanks for the comments. New webrev here:

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi Mandy, Thanks for your comments, On 2013-08-26, Mandy Chung wrote: Joel, The spec of the getFields and getDeclaredFields() methods both states this: This method returns an array of length 0 if the class or interface declares no fields, or if this|Class| object represents a

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi David, On Aug 27, 2013, at 5:21 AM, David Holmes david.hol...@oracle.com wrote: Hi Joel, On 26/08/2013 10:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

On 8/28/2013 6:39 AM, Joel Borggrén-Franck wrote: Hi Mandy, Thanks for your comments, On 2013-08-26, Mandy Chung wrote: Joel, The spec of the getFields and getDeclaredFields() methods both states this: This method returns an array of length 0 if the class or interface declares no

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

On 29/08/2013 6:26 AM, Joel Borggrén-Franck wrote: Hi David, On Aug 27, 2013, at 5:21 AM, David Holmes david.hol...@oracle.com wrote: Hi Joel, On 26/08/2013 10:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859

RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec change to update the spec to match the long-standing implementation. There is also a clarification of getFields() javadoc without

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi Florian, Thanks for the comments, On 2013-08-26, Florian Weimer wrote: On 08/26/2013 02:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi Joel, Looks fine except for a typo in the test ArrayLength.java, line 28: Filed - Field. (Not a Reviewer). Roger On 8/26/2013 8:39 AM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Joel, The spec of the getFields and getDeclaredFields() methods both states this: This method returns an array of length 0 if the class or interface declares no fields, or if this|Class| object represents a primitive type, an array class, or void. The spec of the getDeclaredField()

Re: RFR: 5047859 : (reflect) Class.getField can't find String[].length

Hi Joel, On 26/08/2013 10:39 PM, Joel Borggren-Franck wrote: Hi, Please review doc fix and test for http://bugs.sun.com/view_bug.do?bug_id=5047859 http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/ This is a spec change to update the spec to match the long-standing implementation.