RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Paul Sandoz
Hi, For the flatMap operations of streams we forgot to say what it does with the mapped streams after it has processed them i.e. closes them, which is important for I/O backed streams (e.g. map Path -> Stream for lines of a file). The following patch fixes that omission in the docs: https://b

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Chris Hegarty
It is good to clarify that the streams are closed. I find the following updated wording a little odd, "If a mapped stream is {@code null} then it treated as if it was an empty stream." I thought the previous wording was better, but that could be just me. -Chris. On 20/01/14 10:38, Paul Sando

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Paul Sandoz
On Jan 20, 2014, at 3:18 PM, Chris Hegarty wrote: > It is good to clarify that the streams are closed. > > I find the following updated wording a little odd, "If a mapped stream is > {@code null} then it treated as if it was an empty stream." I thought the > previous wording was better, but t

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Alan Bateman
On 20/01/2014 10:38, Paul Sandoz wrote: Hi, For the flatMap operations of streams we forgot to say what it does with the mapped streams after it has processed them i.e. closes them, which is important for I/O backed streams (e.g. map Path -> Stream for lines of a file). The following patch

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-20 Thread Chris Hegarty
> On 20 Jan 2014, at 15:18, Paul Sandoz wrote: > > >> On Jan 20, 2014, at 3:18 PM, Chris Hegarty wrote: >> >> It is good to clarify that the streams are closed. >> >> I find the following updated wording a little odd, "If a mapped stream is >> {@code null} then it treated as if it was an em

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-21 Thread Paul Sandoz
On Jan 20, 2014, at 11:16 PM, Alan Bateman wrote: > On 20/01/2014 10:38, Paul Sandoz wrote: >> Hi, >> >> For the flatMap operations of streams we forgot to say what it does with the >> mapped streams after it has processed them i.e. closes them, which is >> important for I/O backed streams (e

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-21 Thread Mike Duigou
On Jan 20 2014, at 07:18 , Paul Sandoz wrote: > > On Jan 20, 2014, at 3:18 PM, Chris Hegarty wrote: > >> It is good to clarify that the streams are closed. >> >> I find the following updated wording a little odd, "If a mapped stream is >> {@code null} then it treated as if it was an empty s