Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods of
`java.io.FilterInputStream`.
-
Commit messages:
- 8284930: Re-examine FilterInputStream mark/reset
Changes: https://git.openjdk.java.net/jdk/pull/8309/files
Webrev: https://webrevs.openjdk.java.net/?re
On Tue, 19 Apr 2022 23:26:44 GMT, Brian Burkhalter wrote:
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
I wonder if it should be removed from InputStream at the same time.
-
PR: https://git.openjdk.java.net/jdk/pul
On Wed, 20 Apr 2022 07:33:14 GMT, Alan Bateman wrote:
> I wonder if it should be removed from InputStream at the same time.
Interesting. I hadn't noticed `InputStream` had those two methods synchronized.
I suspect removing synchronization from those two methods on `InputStream` is
probably a l
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> I wonder if it should be removed from InputStream at the same time.
I took the presence of synchronized on those empty methods as a hint to
subclasses that they too should be synchronized.
-
PR: https://git.openjdk.java.net/j
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> As for the changes to `FilterInputStream`, would this change require a CSR?
There might be a case where a subclass of `FilterInputStream` has overridden
all other methods to add `synchronized` but has not overridden `mark` and
`reset`, re
> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
> of `java.io.FilterInputStream`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8284930: Also remove synchronized keyword from mark() and reset() of
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 18:40:13 GMT, Alan Bateman wrote:
> Thanks for the update. I can't think how anything could depend on this but
> unfortunately it's been like that since early JDK releases. We will need a
> release note, I'm sure Joe will give his opinion on whether a CSR should be
> create
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Thu, 21 Apr 2022 00:00:47 GMT, Stuart Marks wrote:
>
> I think it's a vanishingly small possibility that anything is relying on the
> synchronization in these methods. Synchronization here would provide proper
> memory visibility effects across threads. To use input streams from multiple
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Thu, 21 Apr 2022 10:13:11 GMT, Lance Andersen wrote:
> Looks fine Brian. Any thoughts as to whether a release note is warranted?
Thanks, @LanceAndersen. The issue is labelled as needing a release note so you
are spot on.
-
PR: https://git.openjdk.java.net/jdk/pull/8309
16 matches
Mail list logo
