Looks good to me.
On Wed, Aug 23, 2017 at 4:02 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
> Removed ArrayDeque from patch.
> Updated webrev and API
>
> Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.01/index.html
> API: http://cr.openjdk.java.net/~jjg/8186684/api.01/overvi
On 8/24/17 1:26 PM, Jonathan Gibbons wrote:
Fixed broken link in Configuration.java
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.02/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.02/overview-summary.html
The fix looks good. On the other hand, as we discussed offline, w
Fixed broken link in Configuration.java
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.02/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.02/overview-summary.html
-- Jon
On 08/23/2017 04:16 PM, mandy chung wrote:
On 8/23/17 4:02 PM, Jonathan Gibbons wrote:
Removed ArrayD
On 8/23/17 4:02 PM, Jonathan Gibbons wrote:
Removed ArrayDeque from patch.
Updated webrev and API
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.01/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.01/overview-summary.html
src/java.base/share/classes/java/lang/module/Config
Removed ArrayDeque from patch.
Updated webrev and API
Webrev: http://cr.openjdk.java.net/~jjg/8186684/webrev.01/index.html
API: http://cr.openjdk.java.net/~jjg/8186684/api.01/overview-summary.html
-- Jon
On 08/23/2017 03:29 PM, Martin Buchholz wrote:
Jon, please just drop ArrayDeque. We'll fix
On Wed, Aug 23, 2017 at 3:37 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
> Martin,
>
> Understood.
>
> Do you want to file a followup JBS issue, or shall I?
>
It'll just arrive as part of the next jsr166 integration; train is already
en route.
Martin,
Understood.
Do you want to file a followup JBS issue, or shall I?
-- Jon
On 08/23/2017 03:29 PM, Martin Buchholz wrote:
Jon, please just drop ArrayDeque. We'll fix it separately by renaming
the private add method.
On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons
mailto:jonathan.g
Jon, please just drop ArrayDeque. We'll fix it separately by renaming the
private add method.
On Wed, Aug 23, 2017 at 3:17 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> On 08/23/2017 03:12 PM, Martin Buchholz wrote:
>
>
>
> On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
> j
On 08/23/2017 03:16 PM, Martin Buchholz wrote:
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
javadoc is at fault for not giving the warning, and if we fixed
the tool first, we would just get the warnings, and would still
have to
On 08/23/2017 03:12 PM, Martin Buchholz wrote:
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons
mailto:jonathan.gibb...@oracle.com>> wrote:
Although it is not immediately clear in the webrev, the underlying
characteristic of all places where I had to add an empty arg list
is t
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> javadoc is at fault for not giving the warning, and if we fixed the tool
> first, we would just get the warnings, and would still have to fix the
> comments.
>
Yeah, but you get synergy - fixing the warnin
On Wed, Aug 23, 2017 at 3:04 PM, Jonathan Gibbons <
jonathan.gibb...@oracle.com> wrote:
>
> Although it is not immediately clear in the webrev, the underlying
> characteristic of all places where I had to add an empty arg list is that
> there was a private field of the same name in scope.
>
I too
Hi Martin,
On 08/23/2017 02:41 PM, Martin Buchholz wrote:
I would be inclined to "fix the tool first" if it's not too hard.
Both should be fixed. Going back in time, the spec has long said:
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#specifyingname
If any met
Hi Jon
The changes provided look reasonable
> On Aug 23, 2017, at 5:15 PM, Jonathan Gibbons
> wrote:
>
> Please review a reasonably simple patch to fix most of the broken links in
> the API docs for java.base module.
> All the fixes are in the small "typo" category, and so should not material
The changes in these packages look good.
Brian
On Aug 23, 2017, at 2:15 PM, Jonathan Gibbons
wrote:
> java.nio.channels.spi
> java.nio.file
> java.nio.file.attribute
I would be inclined to "fix the tool first" if it's not too hard.
---
Shouldn't the below have a proper arglist?
Consider instead
{@link #add(Object) add(E)}
Consider fixing the javadoc tool so that one can actually write {@link
#add(E)}
--- old/src/java.base/share/classes/java/util/ArrayDeque.
src/java.base/share/classes/java/util/jar/package-info.java
src/java.base/share/classes/java/util/zip/Deflater.java
src/java.base/share/classes/java/util/zip/Inflater.java
looks good.
On 8/23/17, 2:15 PM, Jonathan Gibbons wrote:
Please review a reasonably simple patch to fix most of th
Please review a reasonably simple patch to fix most of the broken links
in the API docs for java.base module.
All the fixes are in the small "typo" category, and so should not
materially affect the specification.
I've provided a copy of the API, in case folk want to test the updated
links. Th
18 matches
Mail list logo
