On 14/11/2018 12:40 am, Brian Goetz wrote:
But don’t they? We intend to start generating condy in classfiles from
javac soon; at that point, anyone not using ASM7 will fail when reading
classfiles generated by javac.
See later email. They need this for nestmates now as well.
Cheers,
David
O
Hi Igor,
Thanks for your comment. I have already applied in my local copy.
Vicente
On 11/13/18 8:30 PM, Igor Ignatyev wrote:
Hi Vicente,
you need to replace "@ignore 8194951: some mlvm tests fail w/ ASMv7" w/ "@ignore
8194951" in all the occurrences, as we have monitoring tools which expect
Hi Vicente,
you need to replace "@ignore 8194951: some mlvm tests fail w/ ASMv7" w/
"@ignore 8194951" in all the occurrences, as we have monitoring tools which
expect @ignore to be followed by a space-separated list of bug ids. the rest
looks good to me.
Thanks,
-- Igor
> On Nov 13, 2018, at
Hi Alan,
On 11/13/18 9:18 AM, Alan Bateman wrote:
On 13/11/2018 14:00, Vicente Romero wrote:
any other comment after the last iteration? we are in a bit of a
hurry to push this before the JDK 12 train departs :(
The original patch updated all the use sites (and tests) to specify
ASM7 for the A
But don’t they? We intend to start generating condy in classfiles from javac
soon; at that point, anyone not using ASM7 will fail when reading classfiles
generated by javac.
> On Nov 8, 2018, at 4:03 AM, David Holmes wrote:
>
> Is it that case that the code the uses the ASM library, like th
On 13/11/2018 14:00, Vicente Romero wrote:
any other comment after the last iteration? we are in a bit of a hurry
to push this before the JDK 12 train departs :(
The original patch updated all the use sites (and tests) to specify ASM7
for the API version. I just checked the webrev again now and
any other comment after the last iteration? we are in a bit of a hurry
to push this before the JDK 12 train departs :(
Thanks,
Vicente
On 11/8/18 11:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes
t;
> , "hotspot-dev"
> , "core-libs-dev"
>
> Envoyé: Vendredi 9 Novembre 2018 22:12:48
> Objet: Re: RFR: JDK-8213480: update internal ASM version to 7.0
> Hi Remi,
>
>
> w/ SymbolTable::get being private method _and_ SymbolTable being final class,
>
ot-dev" , "core-libs-dev"
>>
>> Envoyé: Vendredi 9 Novembre 2018 17:25:49
>> Objet: Re: RFR: JDK-8213480: update internal ASM version to 7.0
>
>> Vicente, Alan,
>>
>> back when we 1st bumped into this problem w/ ClassWriterExt (about 1y ago)
Hi David,
On 11/8/18 11:00 PM, David Holmes wrote:
Hi Vicente,
On 9/11/2018 2:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible
to see the actual substantive changes :(
ASM 7
/objectweb/asm/SymbolTable.java#L393
- Mail original -
> De: "Igor Ignatyev"
> À: "Vicente Romero" , "Alan Bateman"
>
> Cc: "hotspot-dev" , "core-libs-dev"
>
> Envoyé: Vendredi 9 Novembre 2018 17:25:49
> Objet: Re
Vicente, Alan,
back when we 1st bumped into this problem w/ ClassWriterExt (about 1y ago), it
was my AI to discuss it w/ Remi. I sent him an email, didn't get a replay, and
as it usually goes, had to switch to something else, completely forgot about
that and didn't follow up.
Thanks,
-- Igor
Hi Vicente,
On 9/11/2018 2:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was tryi
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was trying to see
how/where that appeared but its somewhat obscur
On 11/8/18 8:14 AM, Alan Bateman wrote:
On 07/11/2018 19:33, Igor Ignatyev wrote:
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK
11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK
needs that, has it been changed? put somewhat differently,
On 07/11/2018 19:33, Igor Ignatyev wrote:
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK 11TF, and
AFAIR it was decided not to update ASM b/c nothing in JDK needs that, has it
been changed? put somewhat differently, why are we doing this?
in any case, I don'
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was trying to see
how/where that appeared but its somewhat obscure. Oh well.
Is it that case that the code the uses the A
Hi Igor,
On 11/7/18 2:33 PM, Igor Ignatyev wrote:
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK
11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK
needs that, has it been changed? put somewhat differently, why are we
doing this?
we need
Hi Vicente,
I recall an (internal?) discussion about updating ASM somewhen in JDK 11TF, and
AFAIR it was decided not to update ASM b/c nothing in JDK needs that, has it
been changed? put somewhat differently, why are we doing this?
in any case, I don't like the changes in mlvm tests. I understa
Hi,
Version 7.0 of ASM has been released. This version supports condy, yay!,
and we want to include it in JDK 12. Please review [1] which includes:
- the new version perse substituting the preview ASM internal version in
the JDK
- changes to additional files in particular some tests, mostly hot
20 matches
Mail list logo
