Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Thanks Daniel! -Joe On 1/17/20 3:57 AM, Daniel Fuchs wrote: On 16/01/2020 18:22, Joe Wang wrote: It's because the class itself is declared final (at least on the few files I've taken a look), so final on a method is redundant. Ah! I had missed that. Thaks Rémi! Meanwhile, I noticed I

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

On 16/01/2020 18:22, Joe Wang wrote: It's because the class itself is declared final (at least on the few files I've taken a look), so final on a method is redundant. Ah! I had missed that. Thaks Rémi! Meanwhile, I noticed I missed the new classes in the webrev. I used a changelist to create

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

"Joe Wang" mailto:huizhe.w...@oracle.com>> À: "Daniel Fuchs" <mailto:daniel.fu...@oracle.com>>, "core-libs-dev" <mailto:core-libs-dev@openjdk.java.net>> Envoyé: Jeudi 16 Janvier 2020 18:40:18 Objet: Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

" >>> >>> Envoyé: Jeudi 16 Janvier 2020 18:40:18 >>> Objet: Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1 >>> On 1/16/20 2:35 AM, Daniel Fuchs wrote: >>>> Hi Joe, >>>> >>>> Looks OK to me as well

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

On 1/16/20 9:50 AM, Remi Forax wrote: - Mail original - De: "Joe Wang" À: "Daniel Fuchs" , "core-libs-dev" Envoyé: Jeudi 16 Janvier 2020 18:40:18 Objet: Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1 On 1/16/20 2:35 AM, Daniel Fuchs w

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

- Mail original - > De: "Joe Wang" > À: "Daniel Fuchs" , "core-libs-dev" > > Envoyé: Jeudi 16 Janvier 2020 18:40:18 > Objet: Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1 > On 1/16/20 2:35 AM, Daniel Fuchs wrote: >

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

On 1/16/20 2:35 AM, Daniel Fuchs wrote: Hi Joe, Looks OK to me as well. Thanks for the review! I am a bit surprised by the number of methods that are no longer `final` though. Do you know what was the motivation for those changes? The original patch did not have any detailed comment or

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Hi Joe, Looks OK to me as well. I am a bit surprised by the number of methods that are no longer `final` though. Do you know what was the motivation for those changes? best regards, -- daniel On 14/01/2020 20:08, Joe Wang wrote: Hi, Please review an update to BCEL 6.4.1. JBS:

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Thanks Lance! -Joe On 1/15/20 2:21 PM, Lance Andersen wrote: Hi Joe, This seems OK. On Jan 14, 2020, at 3:08 PM, Joe Wang > wrote: Hi, Please review an update to BCEL 6.4.1. JBS: https://bugs.openjdk.java.net/browse/JDK-8235368 webrev:

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Hi Joe, This seems OK. > On Jan 14, 2020, at 3:08 PM, Joe Wang > wrote: > > Hi, > > Please review an update to BCEL 6.4.1. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8235368 > > webrev:

Re: RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Performance test results show no regression over the current build (15-b5). -Joe On 1/14/20 12:08 PM, Joe Wang wrote: A performance test is running.

RFR [15/java.xml] 8235368 : Update BCEL to Version 6.4.1

Hi, Please review an update to BCEL 6.4.1. JBS: https://bugs.openjdk.java.net/browse/JDK-8235368 webrev: http://cr.openjdk.java.net/~joehw/jdk15/8235368/webrev/index.html Similar approach as the last update: 1. Format     All format changes are kept as they are in the source in order to