Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-21 Thread Ivan Gerasimov
On 21.09.2013 16:42, Alan Bateman wrote: On 20/09/2013 09:24, Ivan Gerasimov wrote: Hi Alan! I yet modified the test, so now it can be run both from jprt and as a standalone test. I also added a comment for QA with the instruction on how to test the fix manually. Would you please review th

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-21 Thread Alan Bateman
On 20/09/2013 09:24, Ivan Gerasimov wrote: Hi Alan! I yet modified the test, so now it can be run both from jprt and as a standalone test. I also added a comment for QA with the instruction on how to test the fix manually. Would you please review the hopefully final webrev? http://cr.openjdk

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-20 Thread Ivan Gerasimov
Hi Alan! I yet modified the test, so now it can be run both from jprt and as a standalone test. I also added a comment for QA with the instruction on how to test the fix manually. Would you please review the hopefully final webrev? http://cr.openjdk.java.net/~igerasim/8023130/4/webrev/

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-17 Thread Ivan Gerasimov
Hi Alan! On 15.09.2013 23:49, Alan Bateman wrote: On 15/09/2013 12:06, Ivan Gerasimov wrote: : I decided to check whether this test really detects the failure, and run JPRT job with the new test but no fix included. Unfortunately, the new test *does not* fail with unmodified jdk. The same t

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-16 Thread Martin Buchholz
I'm only doing superficial review, but Looks Good To Me!

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-15 Thread Alan Bateman
On 15/09/2013 12:06, Ivan Gerasimov wrote: : I decided to check whether this test really detects the failure, and run JPRT job with the new test but no fix included. Unfortunately, the new test *does not* fail with unmodified jdk. The same thing happens when the test is run with jtreg locally.

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-15 Thread Ivan Gerasimov
On 15.09.2013 11:15, Alan Bateman wrote: On 14/09/2013 19:58, Ivan Gerasimov wrote: : Yes, done. Would you please review the updated webrev? http://cr.openjdk.java.net/~igerasim/8023130/2/webrev/ Thanks for the update, I think it's l

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-15 Thread Alan Bateman
On 14/09/2013 19:58, Ivan Gerasimov wrote: : Yes, done. Would you please review the updated webrev? http://cr.openjdk.java.net/~igerasim/8023130/2/webrev/ Thanks for the update, I think it's looks okay now. It is of course disappointi

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-14 Thread Ivan Gerasimov
On 14.09.2013 22:58, Ivan Gerasimov wrote: On 12.09.2013 19:21, Alan Bateman wrote: On 12/09/2013 06:59, Ivan Gerasimov wrote: Hello Alan, Martin, everyone! Some update on the issue. When trying to integrate my test into Basic.java, I found that it already contains exactly the same. I have

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-14 Thread Ivan Gerasimov
On 12.09.2013 19:21, Alan Bateman wrote: On 12/09/2013 06:59, Ivan Gerasimov wrote: Hello Alan, Martin, everyone! Some update on the issue. When trying to integrate my test into Basic.java, I found that it already contains exactly the same. I have just overlooked it before. Additional inves

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-12 Thread Alan Bateman
On 12/09/2013 06:59, Ivan Gerasimov wrote: Hello Alan, Martin, everyone! Some update on the issue. When trying to integrate my test into Basic.java, I found that it already contains exactly the same. I have just overlooked it before. Additional investigation showed that inheritIO() doesn't al

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-11 Thread Ivan Gerasimov
Hello Alan, Martin, everyone! Some update on the issue. When trying to integrate my test into Basic.java, I found that it already contains exactly the same. I have just overlooked it before. Additional investigation showed that inheritIO() doesn't always fail on Windows. If the scenario is l

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-08-23 Thread Ivan Gerasimov
Thank you Alan! On 23.08.2013 14:28, Alan Bateman wrote: On 23/08/2013 04:07, Ivan Gerasimov wrote: Hello everybody! The method ProcessBuilder#inheritIO() is reported to not have any effect on Windows platform. The same story is with redirectOutput/Input/Error(Redirect.INHERIT) methods. As

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-08-23 Thread Alan Bateman
On 23/08/2013 04:07, Ivan Gerasimov wrote: Hello everybody! The method ProcessBuilder#inheritIO() is reported to not have any effect on Windows platform. The same story is with redirectOutput/Input/Error(Redirect.INHERIT) methods. As the result, standard in/out/err aren't inherited. It turn

RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-08-22 Thread Ivan Gerasimov
Hello everybody! The method ProcessBuilder#inheritIO() is reported to not have any effect on Windows platform. The same story is with redirectOutput/Input/Error(Redirect.INHERIT) methods. As the result, standard in/out/err aren't inherited. It turn out that the culprit is the CREATE_NO_WINDOW