Re: RFR 8025971 and 8026197

2013-10-17 Thread Stephen Colebourne
On 17 October 2013 22:14, Xueming Shen wrote: > On 10/17/2013 02:01 PM, Stephen Colebourne wrote: >> >> I'm happy with the contents of this webrev. >> >> As pointed out previously, it doesn't address the specific issue in >> 8025971 > > I will file a separate issue to address the issue. I would as

Re: RFR 8025971 and 8026197

2013-10-17 Thread Xueming Shen
On 10/17/2013 02:01 PM, Stephen Colebourne wrote: I'm happy with the contents of this webrev. As pointed out previously, it doesn't address the specific issue in 8025971 Stephen On 17 October 2013 21:53, Xueming Shen wrote: Webrev has been updated accordingly based on your suggestion. http

Re: RFR 8025971 and 8026197

2013-10-17 Thread Stephen Colebourne
I'm happy with the contents of this webrev. As pointed out previously, it doesn't address the specific issue in 8025971 Stephen On 17 October 2013 21:53, Xueming Shen wrote: > Webrev has been updated accordingly based on your suggestion. > > http://cr.openjdk.java.net/~sherman/8025971_8026197/

Re: RFR 8025971 and 8026197

2013-10-17 Thread Xueming Shen
Webrev has been updated accordingly based on your suggestion. http://cr.openjdk.java.net/~sherman/8025971_8026197/webrev thanks! -Sherman On 10/16/2013 01:09 AM, Stephen Colebourne wrote: On 15 October 2013 20:35, Xueming Shen wrote: Please help codereview the changes for 8025971: Remove Ti

Re: RFR 8025971 and 8026197

2013-10-16 Thread Stephen Colebourne
On 15 October 2013 20:35, Xueming Shen wrote: > Please help codereview the changes for > > 8025971: Remove Time-Zone IDs HST/EST/MST The method ZoneId.systemDefault() now does not match its specification: /** * Gets the system default time-zone. * * This queries {@link TimeZone#getDefault()}

Re: RFR 8025971 and 8026197

2013-10-15 Thread roger riggs
Hi Sherman, On 10/15/2013 4:23 PM, Xueming Shen wrote: On 10/15/2013 01:03 PM, roger riggs wrote: Hi Sherman, I can't help but notice that the tzdb.dat file is read using a doPrivilege block in ZoneInfoFile.java but not in TzdbZoneRulesProvider.java. TzdbZoneRulesProvider is package priva

Re: RFR 8025971 and 8026197

2013-10-15 Thread Xueming Shen
On 10/15/2013 01:03 PM, roger riggs wrote: Hi Sherman, I can't help but notice that the tzdb.dat file is read using a doPrivilege block in ZoneInfoFile.java but not in TzdbZoneRulesProvider.java. TzdbZoneRulesProvider is package private. It is initialized inside the doPrivilege block in the

Re: RFR 8025971 and 8026197

2013-10-15 Thread roger riggs
Hi Sherman, I can't help but notice that the tzdb.dat file is read using a doPrivilege block in ZoneInfoFile.java but not in TzdbZoneRulesProvider.java. It is not new but is that correct? Was there an opportunity to check the performance before and after both in the local a remote cases? tzd

RFR 8025971 and 8026197

2013-10-15 Thread Xueming Shen
Hi, Please help codereview the changes for 8025971: Remove Time-Zone IDs HST/EST/MST 8026197: Slow reading tzdb.dat if the JRE is on a high-latency, remote file system http://cr.openjdk.java.net/~sherman/8025971_8026197/webrev Note: for 8026197, the only real native resource here needed to be