> On Oct 12, 2016, at 11:31 AM, Brent Christian
> wrote:
>
> On 10/11/16 8:25 AM, Alan Bateman wrote:
> >
>> One thing that would be good is to beef up
>> the test to cover more scenarios, esp. loader L1 extends loader L2 where
>> you've got 4 combination of capable/non-capable to test.
>
> I
On 10/11/16 8:25 AM, Alan Bateman wrote:
>
One thing that would be good is to beef up
the test to cover more scenarios, esp. loader L1 extends loader L2 where
you've got 4 combination of capable/non-capable to test.
I updated the test case to provide better coverage:
http://cr.openjdk.java.net
> On Oct 10, 2016, at 11:03 PM, Peter Levart wrote:
>
> Hi Brent,
>
>
> On 10/11/2016 12:44 AM, Brent Christian wrote:
>> On 10/10/16 2:30 PM, Mandy Chung wrote:
>>>
>>> The patch looks fine. It would be good to add @see
>>> #registerAsParallelCapable in this new method. Also the first
>>>
On 10/10/2016 23:44, Brent Christian wrote:
On 10/10/16 2:30 PM, Mandy Chung wrote:
The patch looks fine. It would be good to add @see
#registerAsParallelCapable in this new method. Also the first
“parallel capable” occurrance in the class spec and the
registerAsParallelCapable method spec t
Hi Brent,
On 10/11/2016 12:44 AM, Brent Christian wrote:
On 10/10/16 2:30 PM, Mandy Chung wrote:
The patch looks fine. It would be good to add @see
#registerAsParallelCapable in this new method. Also the first
“parallel capable” occurrance in the class spec and the
registerAsParallelCapable
On 10/10/16 3:51 PM, Mandy Chung wrote:
Do you mind fixing @return in the registerAsParallelCapable method
with {@code true} amd {@code false} since you are in this method. No
need for a new webrev.
Sure, no problem.
Thanks,
-Brent
> On Oct 10, 2016, at 3:44 PM, Brent Christian
> wrote:
>
> Thanks for having a look, and for the suggestions. I also added an @see
> #isParallelCapable in registerAsParallelCapable().
>
> Webrev updated in place:
> http://cr.openjdk.java.net/~bchristi/8165793/webrev.00/
>
+1
Do you mind
On 10/10/16 2:30 PM, Mandy Chung wrote:
The patch looks fine. It would be good to add @see
#registerAsParallelCapable in this new method. Also the first
“parallel capable” occurrance in the class spec and the
registerAsParallelCapable method spec to @linkplain
#isParallelCapable.
Thanks for
> On Oct 10, 2016, at 1:36 PM, Brent Christian
> wrote:
>
> Hi,
>
> Please review my fix for 8165793. This follows the discussion here:
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009328.html
>
> The proposal is to add a new public method on ClassLoader:
>
> /**
> * R
