Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

On 25/04/2013 15:41, Alexey Utkin wrote: Alan, Thanks for your comments. I did the changes in code. Please, read my answers below. Here is fixed version: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.02/ The implementation changes look good now. : One thing I see is th

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Alan, Thanks for your comments. I did the changes in code. Please, read my answers below. Here is fixed version: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.02/ Regards, -uta On 24.04.2013 18:23, Alan Bateman wrote: On 24/04/2013 13:58, Alexey Utkin wrote: I changed

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

On 24/04/2013 13:58, Alexey Utkin wrote: I changed in the ProcessBuilder class to restore the compatibility with Java documentation. In accordance with spec, the IllegalArgumentException exception could not be thrown from the start method. I made it a cause for declared IOException. This par

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Thanks for clarification, Alan! A part of the fix was not covered by summary, but need to be mentioned. I changed in the ProcessBuilder class to restore the compatibility with Java documentation. In accordance with spec, the IllegalArgumentException exception could not be thrown from the start

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Hi Martin, On 23.04.2013 20:45, Martin Buchholz wrote: Random comments from a former maintainer: I was never brave enough to tackle windows argument parsing or trying to change legacy behavior. I'm surprised you used LinkedList, which is almost never useful. Why not ArrayList? Here is the

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Alexey, I plan to review this, just don't have time to do a detailed review today. At a high-level then I think the approach looks reasonable. If someone has gone to the trouble of quoting a program path with spaces in it, then the fallback should handle it. It's important that the security m

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Random comments from a former maintainer: I was never brave enough to tackle windows argument parsing or trying to change legacy behavior. I'm surprised you used LinkedList, which is almost never useful. Why not ArrayList? Windows has arcane command line parsing rules, which are rather difficul

Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Bug description: https://jbs.oracle.com/bugs/browse/JDK-8012453 http://bugs.sun.com/view_bug.do?bug_id=8012453 Here is the suggested trivial fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.00/ Summary: -- Summary: Since the changes f