Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-13 Thread Paul Sandoz
On Jun 13, 2013, at 6:47 AM, Mandy Chung wrote: > Alan, Paul, > > Thanks for the review. Here is the revised webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.01 > Looks OK. > See my comments inlined below. > > On 6/12/2013 3:48 AM, Paul Sandoz wrote: >> Hi Mandy,

Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Mandy Chung
Alan, Paul, Thanks for the review. Here is the revised webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.01 See my comments inlined below. On 6/12/2013 3:48 AM, Paul Sandoz wrote: Hi Mandy, JdepsTask: Given that the dot graph output is likely to be just as human reada

Re: jdeps -c/--classpath Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Chris Hegarty
>>> Webrev at: >>> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.00/ Looks ok to me. -Chris. >>> >>> This also extends --verbose option to take an optional argument ("class" >>> and "package") to replace the --verbose-level option and cleans up >>> PlatformClassPath to use j

Re: jdeps -c/--classpath Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Paul Sandoz
On Jun 12, 2013, at 6:19 PM, Mandy Chung wrote: > On 6/12/13 4:43 AM, Paul Sandoz wrote: >> Hi Mandy, >> >> Regarding the command line arguments of jdeps, would it not be more >> consistent to re-use the same classpath related arguments as >> javac/java/javap/javah >> >> "-c" becomes "-cp"

Re: jdeps -c/--classpath Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Mandy Chung
On 6/12/13 4:43 AM, Paul Sandoz wrote: Hi Mandy, Regarding the command line arguments of jdeps, would it not be more consistent to re-use the same classpath related arguments as javac/java/javap/javah "-c" becomes "-cp" "--classpath" becomes "-classpath" ? jdeps follows the GNU-style

jdeps -c/--classpath Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Paul Sandoz
Hi Mandy, Regarding the command line arguments of jdeps, would it not be more consistent to re-use the same classpath related arguments as javac/java/javap/javah "-c" becomes "-cp" "--classpath" becomes "-classpath" ? Paul. On Jun 11, 2013, at 4:46 AM, Mandy Chung wrote: > This adds jde

Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Paul Sandoz
On Jun 12, 2013, at 1:16 PM, Alan Bateman wrote: > On 12/06/2013 11:48, Paul Sandoz wrote: >> : >> >> You might be able to use a lambda expression when creating the comparator >> for the TreeSet: >> >> Set profiles = new TreeSet((p1, p2) -> { ... }); >> >> I realize that is just for debugg

Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Alan Bateman
On 12/06/2013 11:48, Paul Sandoz wrote: : You might be able to use a lambda expression when creating the comparator for the TreeSet: Set profiles = new TreeSet((p1, p2) -> { ... }); I realize that is just for debugging so it's not really important, but i have lambda goggles on so cannot

Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Paul Sandoz
Hi Mandy, JdepsTask: Given that the dot graph output is likely to be just as human readable as your original format it is very tempting just to support that format. In fact it is likely to be more human readable since the output is of a known syntax. So IMHO we don't need a format option and d

Re: Review request JDK-8015912: jdeps support to output in dot file format

2013-06-12 Thread Alan Bateman
On 11/06/2013 03:46, Mandy Chung wrote: This adds jdeps --format=dot option to print the output in dot-style format that can be taken to generate a dependency graph. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.00/ This also extends --verbose option to take an opti

Review request JDK-8015912: jdeps support to output in dot file format

2013-06-10 Thread Mandy Chung
This adds jdeps --format=dot option to print the output in dot-style format that can be taken to generate a dependency graph. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.00/ This also extends --verbose option to take an optional argument ("class" and "package") to