On Thu, 26 Nov 2020 21:23:16 GMT, Vladimir Ivanov wrote:
> Concurrent updates may lead to redundant LambdaForms created and unnecessary
> class loading when those are compiled.
>
> Most notably, it severely affects MethodHandle customization: when a
> MethodHandle is called from multiple thre
On Thu, 26 Nov 2020 21:23:16 GMT, Vladimir Ivanov wrote:
> Concurrent updates may lead to redundant LambdaForms created and unnecessary
> class loading when those are compiled.
>
> Most notably, it severely affects MethodHandle customization: when a
> MethodHandle is called from multiple thre
> …id as 1st word in @ignore
>
> https://bugs.openjdk.java.net/browse/JDK-8249836
Mahendra Chhipa has updated the pull request incrementally with two additional
commits since the last revision:
- /integrate
Merge branch 'JDK-8249836' of https://github.com/mahendrachhipa/jdk into
JDK-824983
> Adding support for record classes in the historical data for ct.sym. This
> includes a few changes not strictly needed for the change:
> -updating and moving tests into test/langtools, so that it is easier to run
> them.
> -fixing Record attribute reading in javac's ClassReader (used for tests,
On Fri, 27 Nov 2020 17:01:35 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 528:
>>
>>> 526: * a range of the character array.
>>> 527: *
>>> 528: * Each byte value is parsed as the prefix, two case insensitive
>>> hexadecimal characters,
>>
On Mon, 30 Nov 2020 20:56:17 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified parame
On Mon, 30 Nov 2020 20:55:19 GMT, Mandy Chung wrote:
>> This proposes a new static `Proxy::invokeDefaultMethod` method to invoke
>> the given default method on the given proxy instance.
>>
>> The implementation looks up a method handle for `invokespecial` instruction
>> as if called from with th
On Tue, 1 Dec 2020 01:43:47 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> test/langtools/tools/javac/platform/createsymbols/CreateSymbol
On Tue, 1 Dec 2020 02:18:18 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests on Windows - normalizing line endings.
>
> Looks mostly OK; some minor comments inline.
Thanks for the c
On Tue, 1 Dec 2020 11:18:11 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing Record
On Fri, 27 Nov 2020 16:11:54 GMT, Mahendra Chhipa
wrote:
> …id as 1st word in @ignore
>
> https://bugs.openjdk.java.net/browse/JDK-8249836
This pull request has now been integrated.
Changeset: c859fb02
Author:Mahendra Chhipa
Committer: Igor Ignatyev
URL: https://git.openjdk.java.n
This patch fixes a place where we failed to adjust properly for getBytes taking
a length rather than end offset. (Something the public API in
AbstractStringBuilder is apparently inconsistent about..)
Although this was caught by JCK testing, this patch adds a few trivial sanity
tests to get at l
> Defined new test groups as defined in ticket. @fguallini
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
8257516: removing trailing space
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1416/files
- new: http
On Thu, 26 Nov 2020 09:38:15 GMT, Alan Bateman wrote:
>> This is a corner case that arises when creating a Configuration for a child
>> module layer. If an explicit module in the child configuration reads an
>> automatic module in a parent configuration then it should read all automatic
>> mod
On Mon, 23 Nov 2020 15:27:52 GMT, Alan Bateman wrote:
> This is a corner case that arises when creating a Configuration for a child
> module layer. If an explicit module in the child configuration reads an
> automatic module in a parent configuration then it should read all automatic
> modules
On Tue, 1 Dec 2020 10:05:04 GMT, Peter Levart wrote:
>> Concurrent updates may lead to redundant LambdaForms created and unnecessary
>> class loading when those are compiled.
>>
>> Most notably, it severely affects MethodHandle customization: when a
>> MethodHandle is called from multiple thr
On Tue, 1 Dec 2020 15:45:45 GMT, Peter Levart wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandle.java line 1783:
>>
>>> 1781: } finally {
>>> 1782: updateInProgress = false;
>>> 1783: }
>>
>> Line 1782. I understand that in case the try b
On Tue, 1 Dec 2020 14:49:01 GMT, Claes Redestad wrote:
> This patch fixes a place where we failed to adjust properly for getBytes
> taking a length rather than end offset. (Something the public API in
> AbstractStringBuilder is apparently inconsistent about..)
>
> Although this was caught by J
On Tue, 1 Dec 2020 10:37:40 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarified hexadecimal characters used in converting from characters to
>> values to be strictly 0-9, a-f, and A-F.
>>
On Mon, 30 Nov 2020 20:55:19 GMT, Mandy Chung wrote:
>> This proposes a new static `Proxy::invokeDefaultMethod` method to invoke
>> the given default method on the given proxy instance.
>>
>> The implementation looks up a method handle for `invokespecial` instruction
>> as if called from with th
On Tue, 1 Dec 2020 00:36:54 GMT, Mandy Chung wrote:
>> The JVM method that returns the permitted subclasses (and interfaces) does
>> not weed out permitted subclasses based on the above module requirements.
>> It returns all the classes listed in the PermittedSubclasses attribute that
>> it i
> This proposes a new static `Proxy::invokeDefaultMethod` method to invoke
> the given default method on the given proxy instance.
>
> The implementation looks up a method handle for `invokespecial` instruction
> as if called from with the proxy class as the caller, equivalent to calling
> `X.supe
On Tue, 22 Sep 2020 22:38:04 GMT, Mandy Chung wrote:
> This proposes a new static `Proxy::invokeDefaultMethod` method to invoke
> the given default method on the given proxy instance.
>
> The implementation looks up a method handle for `invokespecial` instruction
> as if called from with the pro
> Please review this modification of `java.io.InputStream.skipNBytes(long)` to
> improve its performance when `skip(long)` skips fewer than the requested
> number of bytes. In the current implementation, `skip(long)` is invoked once
> and, if not enough bytes have been skipped, then `read()` is
Please review this change which includes:
- If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda proxy
classes or to find them from an archive.
- Not passing the `initialize` (same as `!disableEagerI
Update Class::isRecord to only return true for classes that are final.
The removal of non-specified JVM checks on classes with a Record Attribute (see
JDK-8255342), has resulted in more types of loadable classes that may contain a
Record Attribute. Since these checks are not performed by the JVM
On Tue, 1 Dec 2020 14:49:01 GMT, Claes Redestad wrote:
> This patch fixes a place where we failed to adjust properly for getBytes
> taking a length rather than end offset. (Something the public API in
> AbstractStringBuilder is apparently inconsistent about..)
>
> Although this was caught by J
On Tue, 1 Dec 2020 19:34:11 GMT, Chris Hegarty wrote:
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a
On Tue, 1 Dec 2020 19:34:11 GMT, Chris Hegarty wrote:
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a
On Tue, 1 Dec 2020 19:30:45 GMT, Calvin Cheung wrote:
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an
On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote:
> Please review this modification of `java.io.InputStream.skipNBytes(long)` to
> improve its performance when `skip(long)` skips fewer than the requested
> number of bytes. In the current implementation, `skip(long)` is invoked once
> a
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a Record Attribute. Since these checks are not performed
On Tue, 1 Dec 2020 19:56:25 GMT, Mandy Chung wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Mandy's review comments
>
> src/java.base/share/classes/java/lang/Class.java line 3668:
>
>> 3666: * The {@linkpl
On Tue, 1 Dec 2020 19:30:45 GMT, Calvin Cheung wrote:
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an
Float/DoubleVector implementations contain redundant cases for bitwise
operations. Such bitwise operations will fail on such FP vectors before the
case is reached.
-
Commit messages:
- 8257537: [vector] Cleanup redundant bitwise cases on floating point vectors
Changes: https://git
On Tue, 1 Dec 2020 19:30:45 GMT, Calvin Cheung wrote:
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an
On Tue, 1 Dec 2020 14:49:01 GMT, Claes Redestad wrote:
> This patch fixes a place where we failed to adjust properly for getBytes
> taking a length rather than end offset. (Something the public API in
> AbstractStringBuilder is apparently inconsistent about..)
>
> Although this was caught by J
On Tue, 1 Dec 2020 20:13:14 GMT, Chris Hegarty wrote:
>> Update Class::isRecord to only return true for classes that are final.
>>
>> The removal of non-specified JVM checks on classes with a Record Attribute
>> (see JDK-8255342), has resulted in more types of loadable classes that may
>> cont
> The fix for JDK-8256693 too often produces a ParameterizedType as the result
> of getAnnotatedReceiverType().getType() . A ParameterizedType is necessary
> when this type or any of its transitive owner types has type parameters, but
> should be avoided if this isn't the case.
>
> This impleme
On Tue, 1 Dec 2020 20:50:11 GMT, Claes Redestad wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> Looks good to me!
@mlchung, @iklam, @cl4es Thanks for the review.
I've added a test.
-
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an archive.
>
> - Not passing the `initialize` (same as `
On Fri, 27 Nov 2020 18:42:49 GMT, Richard Fussenegger
wrote:
>> The bug report does not make a strong case for adding a NIL constant to the
>> UUID API.
>> It would add (a small amount) to both footprint and startup time with very
>> limited benefit.
>> Any application needing a placeholder ca
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
On Tue, 1 Dec 2020 11:25:15 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarified hexadecimal characters used in converting from characters to
>> values to be strictly 0-9, a-f, and A-F.
>>
On Tue, 1 Dec 2020 20:36:48 GMT, Paul Sandoz wrote:
> Float/DoubleVector implementations contain redundant cases for bitwise
> operations. Such bitwise operations will fail on such FP vectors before the
> case is reached.
Looks good.
-
Marked as reviewed by vlivanov (Reviewer).
On Tue, 1 Dec 2020 21:58:16 GMT, Calvin Cheung wrote:
>> Please review this change which includes:
>>
>> - If the `jdk.internal.lambda.disableEagerInitialization`property is
>> enabled, the `InnerClassLambdaMetafactory` will not involve CDS to archive
>> lambda proxy classes or to find them fr
On Tue, 1 Dec 2020 22:16:58 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 36:
>
>> 34: * @requires vm.cds
>> 35
On Tue, 1 Dec 2020 22:34:58 GMT, Calvin Cheung wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 36:
>>
>>> 34: * @requires vm.cds
>>> 35: * @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds
>>> 36: * @compile
>>> ../../../../../jdk/java/lang/invoke/lambda/Lam
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
On Tue, 1 Dec 2020 14:49:01 GMT, Claes Redestad wrote:
> This patch fixes a place where we failed to adjust properly for getBytes
> taking a length rather than end offset. (Something the public API in
> AbstractStringBuilder is apparently inconsistent about..)
>
> Although this was caught by J
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an archive.
>
> - Not passing the `initialize` (same as `
On Tue, 1 Dec 2020 16:49:03 GMT, Jan Lahoda wrote:
>> So it could also return a class listed in `PermittedSubclasses` attribute
>> but not a subclass of this sealed class, right?
>>
>> The specification of `Class::getPermittedSubclasses` says:
>>
>>> Returns an array containing {@code Class} o
On Fri, 27 Nov 2020 16:57:54 GMT, Jan Lahoda wrote:
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference c
On Tue, 1 Dec 2020 22:19:55 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 77:
>
>> 75: .shouldHave
On Tue, 1 Dec 2020 22:47:18 GMT, Ioi Lam wrote:
>> I can make a copy and put it under the
>> `open/test/hotspot/jtreg/runtime/cds/appcds/test-classes` dir. I'd still
>> need the `@compile` and would be something like `@compile
>> test-classes/LambdaEagerInitTest.java`.
>
> The `@compile` can b
On Tue, 1 Dec 2020 23:16:13 GMT, Calvin Cheung wrote:
>> Please review this change which includes:
>>
>> - If the `jdk.internal.lambda.disableEagerInitialization`property is
>> enabled, the `InnerClassLambdaMetafactory` will not involve CDS to archive
>> lambda proxy classes or to find them fr
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an archive.
>
> - Not passing the `initialize` (same as `
On Tue, 1 Dec 2020 20:36:48 GMT, Paul Sandoz wrote:
> Float/DoubleVector implementations contain redundant cases for bitwise
> operations. Such bitwise operations will fail on such FP vectors before the
> case is reached.
This pull request has now been integrated.
Changeset: cfd070ec
Author:
On Wed, 2 Dec 2020 01:12:17 GMT, Calvin Cheung wrote:
>> Please review this change which includes:
>>
>> - If the `jdk.internal.lambda.disableEagerInitialization`property is
>> enabled, the `InnerClassLambdaMetafactory` will not involve CDS to archive
>> lambda proxy classes or to find them fr
On Thu, 26 Nov 2020 15:54:46 GMT, Richard Fussenegger
wrote:
> Adds a constant for the special NIL UUID where all bits are zero to
> `java.util.UUID`. The
> [8207329](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8207329)
> mentions the usage of it to avoid `null`, it for sure is also
60 matches
Mail list logo
