the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull req
On Mon, 23 Nov 2020 19:25:31 GMT, Aleksey Shipilev wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. T
On Mon, 23 Nov 2020 13:19:23 GMT, Aleksey Shipilev wrote:
>> Jorn Vernee has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Use the Unimplemented() macro instead of hlt()
-
Changes:
- al
On Tue, 24 Nov 2020 06:12:55 GMT, David Holmes wrote:
>> src/hotspot/share/prims/universalUpcallHandler.cpp line 36:
>>
>>> 34: extern struct JavaVM_ main_vm;
>>> 35:
>>> 36: JNI_ENTRY_CPP_NOENV(void,
>>> ProgrammableUpcallHandler::upcall_helper(jobject rec, address buff))
>>
>> I do not like
orn
On 24/11/2020 13:35, David Holmes wrote:
On 24/11/2020 9:38 pm, Jorn Vernee wrote:
On Tue, 24 Nov 2020 06:12:55 GMT, David Holmes
wrote:
src/hotspot/share/prims/universalUpcallHandler.cpp line 36:
34: extern struct JavaVM_ main_vm;
35:
36: JNI_ENTRY_CPP_NOENV(void,
ProgrammableUpc
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request incrementally with two additional
commits since the last revision:
- Remove JNI_ENTRY_CPP_NOENV
- - Move reset_last_Java_frame
---
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull
On Tue, 24 Nov 2020 13:31:17 GMT, Aleksey Shipilev wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove JNI_ENTRY_CPP_NOENV
>> - - Move reset_last_Java_frame
>
> This look
On Tue, 24 Nov 2020 23:59:11 GMT, David Holmes wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 addi
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Pass in thread instead of rematerializing it.
-
Changes:
- all: h
On Wed, 25 Nov 2020 12:16:01 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass in thread instead of rematerializing it.
>
> src/hotspot/cpu/x86/universa
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Split out 32-bit impl from native invoker and upcall handler
---
On Wed, 25 Nov 2020 12:41:40 GMT, Chris Hegarty wrote:
> The ByteBuffers micro benchmark seems to be a little dated.
>
> It should be a useful resource to leverage when analysing the performance
> impact of any potential implementation changes in the byte buffer classes.
> More specifically,
On Wed, 25 Nov 2020 00:01:47 GMT, David Holmes wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 addi
the correct
> `#ifdef` blocks.
>
> Testing: `make images` on Linux and Windows x86_32 platforms.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into Linker_32bit
On Tue, 17 Nov 2020 17:19:13 GMT, Jorn Vernee wrote:
> JDK-8254231 breaks the Linux and Windows x86 (32-bit) builds. This contains
> the needed changes to get it working again.
>
> Perhaps the most interesting change is adding the `JNI_ENTRY_CPP_NOENV`
> macro. Using jus
This patch fixes several failures on x86_32 of java/foreign tests.
This is mostly done by disabling the failing tests, but the impl of CLinker is
also adjusted ton properly detect 32 bit platforms as unsupported.
CLinker is specified to fail in the initializer on unsupported platforms, and a
te
dk.java.net/browse/JDK-8256757 is filed for the remaining
> failure in TestStringLatin1IndexOfChar.
>
> CSR link: https://bugs.openjdk.java.net/browse/JDK-8256863
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Exclude Te
On Mon, 23 Nov 2020 14:54:21 GMT, Jorn Vernee wrote:
> This patch fixes several failures on x86_32 of java/foreign tests.
>
> This is mostly done by disabling the failing tests, but the impl of CLinker
> is also adjusted ton properly detect 32 bit platforms as unsupported.
>
This upstreams the patch from:
https://github.com/openjdk/panama-foreign/pull/396
There were only some minor merge conflicts due to imports and some tests being
replaced by java/foreign/TestNulls. All tests still pass, no other changes were
needed.
-
Commit messages:
- Add a meth
On Thu, 26 Nov 2020 18:29:42 GMT, Maurizio Cimadamore
wrote:
> There is a subtle bug in the heap segment factories: the byte size is
> computed using an int multiplication instead of a long multiplication.
> Because of that, it is possible to observe overflow when creating segments
> out of a
On Fri, 27 Nov 2020 10:48:31 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments:
>> - remove explicit @throws NPE tags
>> - add
d.
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8257187
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments:
- remove explicit @throws NPE tags
- add example to class doc
-
Changes:
- all: https://git.o
d.
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8257187
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java
Co-authored-by: Maurizio Cimada
On Wed, 2 Dec 2020 18:47:10 GMT, Maurizio Cimadamore
wrote:
> The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
> annotations. This causes odd behavior on certain benchmarks, especially if
> these methods are called many times in the body of a single method.
Marked a
On Thu, 26 Nov 2020 19:24:16 GMT, Jorn Vernee wrote:
> This upstreams the patch from:
> https://github.com/openjdk/panama-foreign/pull/396
>
> There were only some minor merge conflicts due to imports and some tests
> being replaced by java/foreign/TestNulls. All tests still
On Mon, 7 Dec 2020 17:38:40 GMT, Maurizio Cimadamore
wrote:
> This simple patch updates the jaavdoc in the module-info file of
> jdk.incubator.foreign to reflect the fact that support of foreign function
> calls has been added.
Marked as reviewed by jvernee (Committer).
-
PR: ht
On Thu, 10 Dec 2020 09:15:47 GMT, Nick Gasson wrote:
>> This is more-or-less a straight port of the x86 code to AArch64.
>> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
>> to generate a blob that jumps to the native function entry point. This
>> simply switches the thre
On Thu, 10 Dec 2020 09:46:07 GMT, Chris Hegarty wrote:
>> Marked as reviewed by bpb (Reviewer).
>
> While the updated set of scenarios covered by this benchmark is
> reasonably (and vastly improves coverage), I find myself reluctant to
> add the last remaining buffer property - read-only views. I
Hi,
This small patch fixes the NPE in the following case:
MethodHandle mh = MethodHandles.empty(MethodType.methodType(void.class,
int.class, int.class));
MethodHandles.permuteArguments(mh, MethodType.methodType(void.class,
int.class), 0, 0);
If a parameter name was changed by a lam
On Mon, 18 Jan 2021 12:09:23 GMT, Claes Redestad wrote:
> Change `MethodHandles.byteArrayViewVarHandle` to throw
> `ArrayIndexOutOfBoundsException` rather than the more generic
> `IndexArrayOutOfBoundsException`. This feels more natural, and reduces the
> risk for subtle behavioral mismatch wh
On Tue, 12 Jan 2021 16:58:45 GMT, Jorn Vernee wrote:
> Hi,
>
> This small patch fixes the NPE in the following case:
>
> MethodHandle mh = MethodHandles.empty(MethodType.methodType(void.class,
> int.class, int.class));
> MethodHandles.permuteArguments(mh,
On Wed, 10 Mar 2021 16:04:22 GMT, Roger Riggs wrote:
>> Use requireNonNull instead.
>
> Well spotted.
Nice catch!
We have a test that is supposed to test this:
https://github.com/openjdk/jdk/blob/master/test/jdk/java/foreign/TestNulls.java
But it is only checking if an NPE is thrown, and not
This patch speeds up MethodHandle.asCollector handles where the array type is
not Object[], as well as speeding up all collectors where the arity is greater
than 10.
The old code is creating a collector handle by combining a set of hard coded
methods for collecting arguments into an Object[], u
On Thu, 1 Apr 2021 19:12:42 GMT, Paul Sandoz wrote:
>> This patch speeds up MethodHandle.asCollector handles where the array type
>> is not Object[], as well as speeding up all collectors where the arity is
>> greater than 10.
>>
>> The old code is creating a collector handle by combining a se
On Thu, 1 Apr 2021 19:09:14 GMT, John R Rose wrote:
>> This patch speeds up MethodHandle.asCollector handles where the array type
>> is not Object[], as well as speeding up all collectors where the arity is
>> greater than 10.
>>
>> The old code is creating a collector handle by combining a se
On Thu, 1 Apr 2021 19:09:53 GMT, John R Rose wrote:
>> This patch speeds up MethodHandle.asCollector handles where the array type
>> is not Object[], as well as speeding up all collectors where the arity is
>> greater than 10.
>>
>> The old code is creating a collector handle by combining a se
dAsCollector.testObjectCollect avgt 30 6.813 � 0.035 ns/op
> TypedAsCollector.testObjectCollectHighArity avgt 30 9.718 � 0.066 ns/op
> TypedAsCollector.testStringCollect avgt 30 6.737 � 0.016 ns/op
> TypedAsCollector.testStringCollectHighArity avgt 30
On Thu, 1 Apr 2021 19:19:10 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Address review comments
>> - Use cached version of store func getter
>> -
On Fri, 2 Apr 2021 13:56:31 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Address review comments
>> - Use cached version of store func getter
>> -
dAsCollector.testObjectCollect avgt 30 6.813 � 0.035 ns/op
> TypedAsCollector.testObjectCollectHighArity avgt 30 9.718 � 0.066 ns/op
> TypedAsCollector.testStringCollect avgt 30 6.737 � 0.016 ns/op
> TypedAsCollector.testStringCollectHighArity avgt 30
On Fri, 2 Apr 2021 15:12:04 GMT, Vladimir Ivanov wrote:
>> That's what I thought as well (but not 100% sure). I can partially roll back
>> the last commit so the code still uses an injected array constructor handle,
>> and then it should be easy to add caching in the cases where the component
On Fri, 2 Apr 2021 13:23:07 GMT, Jorn Vernee wrote:
>> That's an elegant solution.
>>
>> At first i thought it might unduly perturb lambda form generation and
>> caching. but you slotted a different lambda form implementation underneath
>> the varargs implem
dAsCollector.testObjectCollect avgt 30 6.813 � 0.035 ns/op
> TypedAsCollector.testObjectCollectHighArity avgt 30 9.718 � 0.066 ns/op
> TypedAsCollector.testStringCollect avgt 30 6.737 � 0.016 ns/op
> TypedAsCollector.testStringCollectHighArity avgt 3
On Mon, 5 Apr 2021 12:48:07 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Revert back to injected constructor handle
>> - Add lambda form sharing
>>
On Mon, 5 Apr 2021 15:39:39 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comment: Rearrange code to explicitly reference erased setter
>
> Looks good.
On Thu, 1 Apr 2021 13:25:05 GMT, Jorn Vernee wrote:
> This patch speeds up MethodHandle.asCollector handles where the array type is
> not Object[], as well as speeding up all collectors where the arity is
> greater than 10.
>
> The old code is creating a collector handle by com
This patch adds a `tableSwitch` combinator that can be used to switch over a
set of method handles given an index, with a fallback in case the index is out
of bounds, much like the `tableswitch` bytecode.
The combinator does not support specifying the starting index, so the switch
cases always
On 09/04/2021 18:54, Remi Forax wrote:
- Mail original -
De: "Jorn Vernee"
À: "core-libs-dev"
Envoyé: Vendredi 9 Avril 2021 12:51:53
Objet: RFR: 8263087: Add a MethodHandle combinator that switches over a set of
MethodHandles
This patch adds a `tableSwitch` co
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description
On Fri, 9 Apr 2021 18:27:07 GMT, Jorn Vernee wrote:
>> This patch adds a `tableSwitch` combinator that can be used to switch over a
>> set of method handles given an index, with a fallback in case the index is
>> out of bounds, much like the `tableswitch` bytecode. Here is a
On Mon, 12 Apr 2021 10:45:20 GMT, Claes Redestad wrote:
> Desugaring the single-case switch in MethodHandleNatives::canBeCalledVirtual
> is a cleanup and minimal startup improvement on apps spinning up
> MethodHandles.
Marked as reviewed by jvernee (Committer).
-
PR: https://git.
This patch implements 2 leftover TODOs for implementing var handle invoker MH
caching (lambda forms for those were already shared/cached).
This piggybacks on the existing mechanism for method handle invoker caching.
Testing: Local testing `java/lang/invoke` tests. Tier 1-3
Thanks,
Jorn
---
e` tests. Tier 1-3
>
> Thanks,
> Jorn
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Review comments:
- Use boolean instead of index for var handle cache
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
On Mon, 12 Apr 2021 16:24:37 GMT, Jorn Vernee wrote:
> This patch implements 2 leftover TODOs for implementing var handle invoker MH
> caching (lambda forms for those were already shared/cached).
>
> This piggybacks on the existing mechanism for method handle invoker caching.
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description
On Tue, 13 Apr 2021 22:00:57 GMT, Remi Forax wrote:
> About your benchmark, did you test with some strings going into "default",
> because it is usually in that case that you need a proper lookup switch,
another way to say it is that, your results are too good when you use a cascade
of guardWit
On Tue, 13 Apr 2021 22:00:57 GMT, Remi Forax wrote:
> About your benchmark, did you test with some strings going into "default",
> because it is usually in that case that you need a proper lookup switch,
another way to say it is that, your results are too good when you use a cascade
of guardWit
e` tests. Tier 1-3
>
> Thanks,
> Jorn
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Review comment: simplify test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3439/files
- new: https://git.openjdk.j
On Tue, 13 Apr 2021 15:24:13 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments:
>> - Use boolean instead of index for var handle cache
e` tests. Tier 1-3
>
> Thanks,
> Jorn
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Remove manual -ea -esa test flags
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3439/files
- new: https://git.openjdk.j
On Wed, 14 Apr 2021 22:57:59 GMT, Mandy Chung wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comment: simplify test
>
> test/jdk/java/lang/invoke/TestVHInvokerCaching.java lin
On Mon, 12 Apr 2021 16:24:37 GMT, Jorn Vernee wrote:
> This patch implements 2 leftover TODOs for implementing var handle invoker MH
> caching (lambda forms for those were already shared/cached).
>
> This piggybacks on the existing mechanism for method handle invoker caching.
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the
On Tue, 27 Apr 2021 02:14:07 GMT, Nick Gasson wrote:
>> How about StandardAArch64Linker? Otherwise MacOsAArch64Linker sounds like it
>> should be a specialisation of AArch64Linker.
>
> Or LinuxAArch64Linker if we're going to rename the CABI enum AArch64 ->
> LinuxAArch64? But this would also be
On Mon, 3 May 2021 15:31:53 GMT, Jorn Vernee wrote:
>> macOS on Apple silicon uses slightly different ABI conventions to the
>> standard AArch64 ABI. The differences are outlined in [1]. In
>> particular in the standard (AAPCS) ABI, variadic arguments may be passed
>> i
On Mon, 26 Apr 2021 14:30:17 GMT, Maurizio Cimadamore
wrote:
>> macOS on Apple silicon uses slightly different ABI conventions to the
>> standard AArch64 ABI. The differences are outlined in [1]. In
>> particular in the standard (AAPCS) ABI, variadic arguments may be passed
>> in either regist
Hi,
I see that the jar tool has validation logic for multi-release jars that
is triggered when creating or updating a jar that has a versioned file
as an input. I wanted to ask what people think about the idea of
exposing this validation logic directly under a --validate command line
flag as
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description
On 12/05/2021 14:41, Alan Bateman wrote:
On 12/05/2021 11:58, Jorn Vernee wrote:
Hi,
I see that the jar tool has validation logic for multi-release jars
that is triggered when creating or updating a jar that has a
versioned file as an input. I wanted to ask what people think about
the idea
On Wed, 12 May 2021 14:06:46 GMT, Vladimir Ivanov wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Remove unused imports
>> * Fix broken javadoc after removal of @throws clauses
>> * Remove other `@Call
100 150
> true avgt 30 4.676 � 0.011 ms/op
> MethodHandlesTableSwitchRandom.testSwitch 100 150
> false avgt 30 13.476 � 0.043 ms/op
>
>
> Testing:
> - [x] Running of included benchmarks
> - [x] Inspecting inlining trace and
On Fri, 14 May 2021 07:27:08 GMT, Claes Redestad wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
I'll go ahead with this enhancement, and make sure the wording is open
to adding validation logic not related to multi-release jars in the future.
Jorn
On 12/05/2021 14:47, Jorn Vernee wrote:
On 12/05/2021 14:41, Alan Bateman wrote:
On 12/05/2021 11:58, Jorn Vernee wrote:
Hi,
I see
This patch adds a `--validate` option to the jar tool which can be used to
validate a jar file that might be malformed. For instance, if a jar is a
multi-release jar, it is malformed if different versions expose different APIs.
The implementation is straight forward since there already exists va
On Tue, 11 May 2021 10:51:18 GMT, Jorn Vernee wrote:
> This patch adds a `--validate` option to the jar tool which can be used to
> validate a jar file that might be malformed. For instance, if a jar is a
> multi-release jar, it is malformed if different versions expose differen
On Tue, 18 May 2021 20:59:49 GMT, Claes Redestad wrote:
> Using a switch expression instead of a (read-only) static `HashMap` reduces
> initialization overhead of `VarHandle$AccessMode`. This gets loaded earlier
> after JDK-8265079, so it started showing up in a few lambda startup tests.
>
> T
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-May/077420.html
>
> Testing: running jdk/tools/jar test suite locally, tier 1-3 (in progress),
> manual testing.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last
On Wed, 19 May 2021 16:29:33 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
On Thu, 20 May 2021 13:00:14 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 35
>> addit
On Fri, 21 May 2021 08:53:51 GMT, Gavin Bierman wrote:
>> Hi all,
>>
>> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was
>> promised in its Javadoc, now that sealed classes are finalising in JDK 17.
>>
>> Thanks,
>> Gavin
>
> Gavin Bierman has updated the pull requ
100 150
> true avgt 30 4.676 � 0.011 ms/op
> MethodHandlesTableSwitchRandom.testSwitch 100 150
> false avgt 30 13.476 � 0.043 ms/op
>
>
> Testing:
> - [x] Running of included benchmarks
> - [x] Inspecting inlining trace an
On Mon, 17 May 2021 17:19:16 GMT, Jorn Vernee wrote:
>> This patch adds a `tableSwitch` combinator that can be used to switch over a
>> set of method handles given an index, with a fallback in case the index is
>> out of bounds, much like the `tableswitch` bytecode. Her
On Fri, 21 May 2021 15:39:33 GMT, Aleksei Voitylov
wrote:
>> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line
>> 262:
>>
>>> 260: } finally {
>>> 261: releaseNativeLibraryLock(name);
>>> 262: }
>>
>> The new locking scheme looks incorrect t
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description
On Thu, 22 Apr 2021 08:19:53 GMT, Nick Gasson wrote:
> macOS on Apple silicon uses slightly different ABI conventions to the
> standard AArch64 ABI. The differences are outlined in [1]. In
> particular in the standard (AAPCS) ABI, variadic arguments may be passed
> in either registers or on the
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore
wrote:
> This patch overhauls the library loading mechanism used by the Foreign Linker
> API. We realized that, while handy, the *default* lookup abstraction
> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>
> T
On Thu, 3 Jun 2021 03:28:56 GMT, Nick Gasson wrote:
>> macOS on Apple silicon uses slightly different ABI conventions to the
>> standard AArch64 ABI. The differences are outlined in [1]. In
>> particular in the standard (AAPCS) ABI, variadic arguments may be passed
>> in either registers or on
On Fri, 4 Jun 2021 10:06:26 GMT, Nick Gasson wrote:
>> The JEP has been integrated, so we can pick this back up (and handle it as a
>> bug for 17 even after the fork).
>>
>> Thank you for your patience.
>
> Thanks @JornVernee! I noticed VaListTest has started failing on Windows with
> this err
On Thu, 3 Jun 2021 03:28:56 GMT, Nick Gasson wrote:
>> macOS on Apple silicon uses slightly different ABI conventions to the
>> standard AArch64 ABI. The differences are outlined in [1]. In
>> particular in the standard (AAPCS) ABI, variadic arguments may be passed
>> in either registers or on
On Fri, 4 Jun 2021 11:04:33 GMT, Jorn Vernee wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> No variadic upcalls
>>
>> Change-Id: Ibf91c570c88be2587e9e23240477c4a5cc56b4c5
&
ode_for_apple_platforms
>
> Nick Gasson has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains ten commits:
>
> - Fix build after merge
> - Merge master
> - Redundant cast to long
> - Merge master
>
Hi,
The documentation of `CLinker::systemLookup` [1] says this:
* Obtains a system lookup which is suitable to find symbols in the standard C
libraries.
However, currently it is not possible to look up common stdio.h symbols, such
as `printf`, using the system lookup on Windows 10. This is
Hi,
This is part 1 of a two part upstreaming process of the patch mentioned in the
subject line. The patch was split into 2 in order to document 2 separate
specification changes that arose from a change in the implementation, with 2
separate CSRs.
This patch changes the handling of method hand
Hi,
This is part 2 of a two part upstreaming process of the patch mentioned in the
subject line. The patch was split into 2 in order to document 2 separate
specification changes that arose from a change in the implementation, with 2
separate CSRs. The first patch can be found here:
https://git
On Mon, 7 Jun 2021 16:38:01 GMT, Jorn Vernee wrote:
> Hi,
>
> This is part 2 of a two part upstreaming process of the patch mentioned in
> the subject line. The patch was split into 2 in order to document 2 separate
> specification changes that arose from a change in the imple
On Mon, 7 Jun 2021 11:00:00 GMT, Athijegannathan Sundararajan
wrote:
> jlink should clean up output directory on any failure. should not leave
> partially filled output.
WRT the test failure on Windows discussed offline: when the directory is
deleted as a result of a `PluginException` being t
101 - 200 of 384 matches
Mail list logo
