Re: RFR: (jaxp) 8003260 : some fields should be package protected

Hi Joe, Shouldn't this also be private: static final char [] xmlDecl = {'<','?','x','m','l'}; otherwise it is fine Best Lance On Dec 14, 2012, at 1:33 PM, Joe Wang wrote: > Hi, > > This is one of the three [findbug] issues. I've checked with Drew. None of > them are vulnerabilities. Nonethel

Re: RFR: (jaxp) 8003260 : some fields should be package protected

Thanks Joe. maybe a quick comment would help in the code could be useful Best Lance On Dec 14, 2012, at 2:49 PM, Joe Wang wrote: > > > On 12/14/2012 10:36 AM, Lance Andersen - Oracle wrote: >> >> Hi Joe, >> >> Shouldn't this also be private

Re: RFR: (jaxp) 8003260 : some fields should be package protected

+1 On Dec 14, 2012, at 3:43 PM, Joe Wang wrote: > Thanks. I added a comment. Here's the webrev again: > http://cr.openjdk.java.net/~joehw/7u12/8003260/webrev/ > > Best > Joe > > On 12/14/2012 11:52 AM, Lance Andersen - Oracle wrote: >> >> Thanks Joe. m

Re: 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present

I went through this and the changes look OK On Dec 18, 2012, at 9:17 AM, Alan Bateman wrote: > > I've refreshed the webrev here to take in another change from Joe to the root > element handling in PropertiesDefaultHandler. > > http://cr.openjdk.java.net/~alanb/8004371/webrev.03/ > > I'd like

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

o, please let > me know. > > Thanks a lot! > On 11/24/2012 12:45 AM, Lance Andersen - Oracle wrote: >> It is on my list. to update the javadocs I need a ccc which I have not done >> yet and is needed as part of this change >> >> On Nov 23, 2012, at 3:07 AM, D

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

o see the patch for implementing these methods are committed. > > Do you have a plan to add the test cases[1] I created too? > > Thanks a lot! > > [1]http://cr.openjdk.java.net/~youdwei/OJDK-576/webrev.01/ > > > On 01/10/2013 08:31 PM, Lance Andersen - Oracle wrote: >

Review request 8005080: JDBC 4.2

The following webrev has the bulk of the JDBC 4.2 changes: http://cr.openjdk.java.net/~lancea/8005080/webrev.00/ There will be additional updates to java.sql.Date/TIme/Timestamp (by Sherman) once JSR 310 is integrated to aide in moving to and from the new date time datatypes. I will also pr

Re: RFR: javax.xml.validation: Using ServiceLoader to load JAXP schema factories (7169894: JAXP Plugability Layer: using service loader)

On Jan 11, 2013, at 2:05 PM, Joe Wang wrote: > > > On 1/11/2013 8:58 AM, Alan Bateman wrote: >> On 09/01/2013 14:28, Daniel Fuchs wrote: >>> Hi, >>> >>> Here is a new webrev in the series that addresses using ServiceLoader in >>> JAXP for JDK 8. >>> >>> 7169894: JAXP Plugability Layer: using

review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Hi This is a review request for 8006139 which adds missing methods to SQLInput/Output The webrev can be found at http://cr.openjdk.java.net/~lancea/8006139/webrev.00/ best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burl

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

On Jan 13, 2013, at 4:25 PM, Ulf Zibis wrote: > > Am 13.01.2013 21:08, schrieb Alan Bateman: >> Assuming CCE is long standing behavior then it would be good to update the >> spec of all the other read* methods too. Alternatively a statement in the >> class description to cover it. Yes that is

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

lier thread, these classes are hardly ever, if at all used and would only be used when UDTs are used and the majority of databases do not support this. Best lance On Jan 14, 2013, at 5:11 AM, Alan Bateman wrote: > On 13/01/2013 23:51, Lance Andersen - Oracle wrote: >> : >> >

Re: 8006344: Broken javadoc link in javax.lang.model.element.Element

+1 On Jan 15, 2013, at 12:59 PM, Chris Hegarty wrote: > Minor oversight in the changes from 7193719: "Support repeating annotations > in javax.lang.model". > > ~/repos/jdk8/tl/adder/build/solaris-i586/impsrc/javax/lang/model/element/Element.java:199: > warning - Tag @see: can't find getAnnotati

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Thank you Ulf. I deleted the extra line on 579 Best Lance On Jan 15, 2013, at 3:45 PM, Ulf Zibis wrote: > Looks great! > > Little nit: > SQLOutputImpl.java line 579 could be dropped. > > -Ulf > > > Am 15.01.2013 17:48, schrieb Lance Andersen - Oracle: >&g

Re: review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

On Jan 19, 2013, at 9:43 AM, Alan Bateman wrote: > On 15/01/2013 16:48, Lance Andersen - Oracle wrote: >> Here is a revision >> >> http://cr.openjdk.java.net/~lancea/8006139/webrev.01 >> >> I still have to enter the JBS entry for the javadoc clarifications (and

Re: 8006764: FunctionalInterface missing from rt.jar (old build)

+1 On Jan 23, 2013, at 9:54 AM, Alan Bateman wrote: > > The j.l.FunctionalInterface annotation was added recently but it's not > showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately > we have to keep the old build on life support until the new build is bedded > down an

Re: Codereview request for 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream

+1 On Jan 31, 2013, at 5:15 PM, Xueming Shen wrote: > Hi, > > Obviously ioe is not an appropriate exception for invalid base64 bytes, > and it's inconsistent with the rest of decode methods, as the submitter > suggested. > The change is to explicitly specify (as other decoding methods do) that >

Re: Review Request for JDK-8007389: Remove uses of _ as identifier in jaxp

Its OK. Not sure I would have replaced it with 'unused' but not a big deal as it is just a personal preference. On Feb 1, 2013, at 11:45 AM, Eric McCorkle wrote: > Hello, > > Please review this trivial patch which removes uses of _ as an > identifier in the jaxp API. > > The webrev is here:

review request: 8006505 additional updates for JSR 310

HI, This is a review request for http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to SQLInput/Ouput (used for UDTs) to have generic methods for types allowing support for JSR 310. Also now that 310 is in M6, update Types and JDBCType to add entries for TIME/TIMESTAMP

Re: review request: 8006505 additional updates for JSR 310

Hi Ulf, On Feb 5, 2013, at 6:07 PM, Ulf Zibis wrote: > Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle: >> HI, >> >> >> This is a review request for >> http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to >> SQLInput/Ouput

Re: review request: 8006505 additional updates for JSR 310

Thank you again for the feedback Ulf On Feb 5, 2013, at 7:22 PM, Ulf Zibis wrote: > Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle: >> >> I can change that text and will do so before i put back. > > fine! I am going to change the message from "readObject no

Re: review request: 8006505 additional updates for JSR 310

On Feb 6, 2013, at 9:26 AM, Ulf Zibis wrote: > > Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle: >> I am going to change the message from >> >> "readObject not implemented" >> >> to "method readObject(Class) not implemented" >

Re: RFR: 7199858: Marshal exception is wrong

Looks Ok Dmeetry. Best Lance On Feb 11, 2013, at 3:58 PM, Dmeetry Degrave wrote: > Hi, > > Resending a code review request for a corba fix for 7 and 8, which is > identical to fix went to earlier releases. > > A wrong unexpectedUnionDefault exception is thrown in TypeCode handling code > when

Re: [Review Request] 8008161: Regression: j.u.TimeZone.getAvailableIDs(rawOffset) returns non-sorted list

+1 On Feb 13, 2013, at 2:02 PM, Xueming Shen wrote: > Hi, > > This is the "regression" triggered by my changeset > 8007572: Replace existing jdk timezone data at /lib/zi with > JSR310's tzdb. > > While the specification does not specify that the returned list from > j.u.TimeZone.getAvailableIDs

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

Alan, the changes look good and glad you added the extra comments for clarity. Best Lance On Feb 21, 2013, at 9:33 AM, Alan Bateman wrote: > > This one is a startup-time regression caused by the compact profiles work. > > As background, there was a lot of work done in the distant past on start

Re: 8008662: Add @jdk.Supported to JDK-specific/supported API

Well, that was quite a few files to have to go through :-) Looks fine On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote: > > Joe Darcy recently added @jdk.Supported [1] to make it possible to identify > JDK-specific APIs. > > I'd like to add this to a number of APIs in the com.sun namespace to

Review request for 8008716 to address typo in CallableStatement javadocs

H alli, This is a review request for 8008716 to address a couple of typos in CallableStatement: $ hg diff CallableStatement.java diff -r 7dcb74c3ffba src/share/classes/java/sql/CallableStatement.java --- a/src/share/classes/java/sql/CallableStatement.java Tue Feb 12 09:25:43 2013 -0800 +++

Review request 8010416 Addition of Driver.deregisterDriver

Need a reviewer for 8010416, addition of Driver.deregisterDriver. The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.00/. I will be submitting the ccc request later today but want to do this in parallel Best Lance Lance Andersen| Principal Member of Technical Staff |

Re: Review request for 7198429: need checked categorization of caller-sensitive methods in the JDK

Hi Mandy the DriverManager change looks fine. Best Lance On Mar 27, 2013, at 1:35 PM, Mandy Chung wrote: > This is the JDK change for JEP 176: JEP 176: Mechanical Checking of > Caller-Sensitive Methods [1]. Christian has posted the webrev for the > hotspot VM change a couple weeks ago [2]. >

Review request for 8011393 - javadoc typo in SerialClob.truncate

Hi all Need a reviewer for the correction of the following typo in SerialClob.java which is bug 8011393 hg diff SerialClob.java diff -r e6c3b8e74e50 src/share/classes/javax/sql/rowset/serial/SerialClob.java --- a/src/share/classes/javax/sql/rowset/serial/SerialClob.java Tue Apr 02 10:12:20

Re: Review request for 8011393 - javadoc typo in SerialClob.truncate

there is a lot of code that could be cleaned up besides JDBC :-) Thank you again. Best Lance On Apr 3, 2013, at 1:49 PM, Mandy Chung wrote: > Looks fine. You may want to use {@code CLOB} to replace ... > > Mandy > > On 4/3/2013 9:15 AM, Lance Andersen - Oracle wrote: >>

Re: RFR: 8006036, (process) cleanup code in java/lang/Runtime/exec/WinCommand.java

looks ok On Apr 5, 2013, at 5:18 PM, Jim Gish wrote: > Please review trivial change to add back in delete of test files on test > completion. > > http://cr.openjdk.java.net/~jgish/Bug8006036-WinCommand/ > > > Thanks, > Jim > > --

review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

Hi, This is a request to review adding a netbeans freeform project to jdk/make/netbeans for jdbc As part of this change, I also modified common/shared.xml to properly look for the jtreg report.html in the html directory and so the javadoc was using version 1.8 The web rev is here http://cr.o

Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

Thank you ulf, I made the change in my workspace so that it will be accommodated as part of the putback Best Lance On Apr 9, 2013, at 11:26 AM, Ulf Zibis wrote: > Hi, > > there is a little indentation error in build.xml in line 42. > > -Ulf > > Am 09.04.2013 16:55, s

Re: Review Request: 8012624: Add sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java in ProblemList.txt

+1 On Apr 18, 2013, at 2:07 PM, Mandy Chung wrote: > This fix adds GetSafepointSyncTime.java test in the ProblemList.txt > until 8010897 is resolved. It has been failing intermittently on macosx-x64. > > diff --git a/test/ProblemList.txt b/test/ProblemList.txt > --- a/test/ProblemList.txt > +++ b

review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

Hi, We have been asked by a few JDBC driver vendors to allow a JDBC driver to be notified when/if it was deregistered via DriverManager.deregisterDriver if desired. The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01 Best Lance Lance Andersen| Principal Memb

Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

still looking for a committer to bless this webrev so I can put it back thank you in advance best Lance On Apr 9, 2013, at 11:58 AM, Lance Andersen - Oracle wrote: > Thank you ulf, I made the change in my workspace so that it will be > accommodated as part of the putback > >

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

Thank you for the feedback Alan, Please see below and the webrev http://cr.openjdk.java.net/~lancea/8010416/webrev.02/ On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote: > On 19/04/2013 18:34, Lance Andersen - Oracle wrote: >> Hi, >> >> We have been asked by a few JDBC dri

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

stent (or as much as it can be) > DriverManager line 355: missing space after comma. fixed this. thank for this Best Lance > > -Ulf > > Am 21.04.2013 13:45, schrieb Lance Andersen - Oracle: >> Thank you for the feedback Alan, >> >> Please see below and the web

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote: > On 21/04/2013 12:45, Lance Andersen - Oracle wrote: >> : >>> >>> DriverManager >>> >>> - one point that isn't covered in the spec is whether the DriverAction's >>> deregister

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that were pointed out and also fixes a couple javadoc warnings Best, Lance On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote: > > On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote: > >> On 2

Re: review request for 8010416: Provide a way for DriverManager.deregisterDriver to notify the JDBC driver that it has been deregistered.

On Apr 26, 2013, at 8:35 AM, Alan Bateman wrote: > On 25/04/2013 21:53, Lance Andersen - Oracle wrote: >> http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos >> that were pointed out and also fixes a couple javadoc warnings >> > This looks ok

Re: RFR: [corba] 4504275, 8011986 - two issues with generated code

This is good to go. Also reviewed by Russ Gold from the Corba team Best Lance On Apr 12, 2013, at 6:48 AM, Dmeetry Degrave wrote: > > Hi all, > > I'm looking for a review for two ancient issues in idlj. > > First is an issue with uncompilable java code generated for unions with > boolean dis

Re: RFR: 8011814/8013271/8013272: Three improvements to J2SE Netbeans project

Hi Mike, The changes look good to me. Best Lance On Apr 29, 2013, at 10:11 PM, Mike Duigou wrote: > Hello All; > > This is a review for three changes to the J2SE Netbeans project. If necessary > I can break this up into three separate patches but I would rather not if > possible. > > > ht

Re: RFEs implementing JEP 170

Hi Neil, Just back from holiday and catching up (or trying to) On May 2, 2013, at 7:13 AM, Neil Richards wrote: > > Hi Lance, > I've been trying to identify the Java bug ids for the RFEs which > implement JEP 170 (which, from what I can tell, should be in OpenJDK 8 > since milestone 6 [1]).

Re: 8014500: bootcycle-images fails after upgrade to JAXP 1.5

+1 On May 14, 2013, at 8:16 AM, Alan Bateman wrote: > > The bootcycle-images target is currently broken in jdk8/tl. > > Jon has taken 8014461 to fix genstubs but once you get past that then the > CLDRConverter fails parsing LDML due to DTD references that aren't allowed by > the default policy

Re: Code review request, JDK-8010814, More buffers are stored or returned without cloning

Looks fine Xuelei best Lance On May 16, 2013, at 5:08 AM, Xuelei Fan wrote: > Hi, > > There is another fix to avoid the use of mutable objects. > > webrev: http://cr.openjdk.java.net/~xuelei/8010814/webrev.00/ > > Thanks, > Xuelei Lance Andersen| Principal Member of Technical Staff | +1.781.

Re: RFR (JAXP) : 8014891 : incorrect handling FEATURE_SECURE_PROCESSING in jdk xerces

looks fine Joe On May 20, 2013, at 4:15 PM, huizhe wang wrote: > Hi, > > This is a patch to remove redundant property settings. In the previous patch, > the new jaxp properties were set while copying features onto DOM/SAX parsers. > However, this is already done during the initialization of DOM

Re: RFR: 8000450: Restrict access to com/sun/corba/se/impl package

the changes make sense to me On Jun 4, 2013, at 6:57 PM, Seán Coffey wrote: > The com.sun.corba.se.impl package is a private package. The API is subject to > change at any time and no 3rd party code should be using it. As a result, I'd > like to add it to the package restricted list. I've run ou

Review request for 8016101, javadoc typos for SerialRef and SerialStruct

Hi, Need a reviewer for this minor javadoc update for bug 8016101 SerialStruct was missing a javadoc @param tag in the constructor SerialRef had an extra '.' Best Lance hg diff diff -r b4742d038100 src/share/classes/javax/sql/rowset/serial/SerialRef.java --- a/src/share/classes/javax/sql/ro

Re: Review request for 8016101, javadoc typos for SerialRef and SerialStruct

} * @param map a java.util.Map object in which *each entry consists of 1) a String object *giving the fully qualified name of a UDT and 2) the On Jun 6, 2013, at 4:34 PM, Aleksey Shipilev wrote: > Hi Lance, > > On 06/07/2013 12:09 AM, Lance Andersen - Ora

Re: RFR (jaxp): 8015016: Improve JAXP 1.5 error message

Hi Joe, The change looks OK. I know the messages have to be translated by the globalization team for the other languages. Best Lance On Jun 6, 2013, at 5:42 PM, huizhe wang wrote: > This is a quick fix to improve the error message so that it's clearly > differentiated from those reported by t

Re: RFR (jaxp): 8015016: Improve JAXP 1.5 error message

sage has to be in the repository before the tool can pull them out. > I know it takes time, to get that done. Thank you for clarifying the error message. Best Lance > Best, > Joe > > On 6/6/2013 2:51 PM, Lance Andersen - Oracle wrote: >> Hi Joe, >> >> The chang

Re: 8016217: More javadoc warnings

This looks good. Thank you for taking this on Alan. Best Lance On Jun 10, 2013, at 6:31 AM, Alan Bateman wrote: > > About 8 months ago I tried an early build of doclint [1] and used it to fix > up a bunch issues at the time [2]. It's been awhile, so I decided to try out > the latest version t

Re: RFR (jaxp): 8016153 : Property http://javax.xml.XMLConstants/property/accessExternalDTD is not recognized.

looks fine joe -lance On Jun 8, 2013, at 4:11 PM, huizhe wang wrote: > Hi, > > This patch is to continue the support of plugging in 3rd party parser impls > (such as Xerces) that do not support JAXP 1.5. The fix is to catch > SAXNotRecognizedException, print out a warning, and then continue as

Re: RFR (jaxp): 8016153 : Property http://javax.xml.XMLConstants/property/accessExternalDTD is not recognized.

rev=3134 > > Thanks, > Joe > > On 6/10/2013 9:44 AM, Lance Andersen - Oracle wrote: >> looks fine joe >> >> -lance >> On Jun 8, 2013, at 4:11 PM, huizhe wang wrote: >> >>> Hi, >>> >>> This patch is to continue

Re: JDK 8 code review request: doclint cleanup of java.util.logging

+1 On Jun 27, 2013, at 2:58 PM, Joe Darcy wrote: > Hello, > > Please review the patch below which resolves doclint warnings in > java.util.logging. > > Thanks, > > -Joe > > diff -r 1c31082f0a51 src/share/classes/java/util/logging/Handler.java > --- a/src/share/classes/java/util/logging/Handle

Re: JDK 8 core review request for doclint warnings in javax.script

looks fine joe On Jun 27, 2013, at 3:47 PM, Joe Darcy wrote: > Hello, > > Please review the next patch in a series of patches to resolve doclint > warnings in the JDK; this time in javax.script. > > Thanks, > > -Joe > > diff -r b8f16cb2d95b src/share/classes/javax/script/Invocable.java > ---

Re: JDK 8 code review request for doclint cleanup of javax.naming.*

Hi Joe, Looks good. fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy. Not sure if it matters below but thought I would point it out if you want a smaller heading Best Lance On Jun 28, 2013, at 1:54 PM, Joe Darcy wrote: > Hello, > > Still more doclint fixes for re

Review needed for ResultSet.next typo bug 8019286

Hi, Looking for a reviewer for this minor typo in ResultSet.next() $ hg diff diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10:21:22 2013 +0100 +++ b/src/share/classes/java/sql/ResultSet.java Fri Jun 28 18:09:36 2013 -0400

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

looks good Joe On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote: > Hello, > > Pack200 has some doclint issues; please review the fixes to them below. > > Thanks, > > -Joe > > --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11 > 2013 -0700 > +++ b/src/share/classes/java/util

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

Looks fine Joe including Mandy's feedback Best Lance On Jul 8, 2013, at 10:10 PM, Joe Darcy wrote: > Hello, > > Please review my changes to resolve (almost all of): > >JDK-8020095 Fix doclint warnings in java.util.regex >http://cr.openjdk.java.net/~darcy/8020095.0/ > > Full text of the

Re: RFR: JAXP 1.5 for JDK8/7u40: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

Hi Joe Looks good Best Lance On Jul 8, 2013, at 9:07 PM, huizhe wang wrote: > Hi, > > I've updated webrev with improved property management, and quality backed by > 320 test cases. Thanks Daniel for the help expanding the test suite! > > Here's the webrev: > http://cr.openjdk.java.net/~joehw/

Re: RFR: (JAXP) 8020430 : NullPointerException in xml sqe nightly result on 2013-07-12

The fix looks fine to me Joe as does the test. I assume you will go with Chris's plan below for the test locations? Best Lance On Jul 12, 2013, at 5:44 AM, Chris Hegarty wrote: > The source changes look fine to me. > > The tests should be located elsewhere, otherwise they will collide with an

Re: RFR : 6799426 : (xs) Add constructor PriorityQueue(Comparator)

looks fine Mike Best Lance On Jul 22, 2013, at 3:24 PM, Mike Duigou wrote: > Hello all; > > A simple rewiew for the addition of another constructor to PriorityQueue. > Currently if you wish to specify a Comparator you must also supply a size. > This addition allows use of the default size whic

Re: RFR: JAXP in JDK8/7u40 : 8021148 Regression in SAXParserImpl in 7u40 b34 (NPE)

Agree with the change and making fSecurityPropertyMgr final Best Lance On Jul 24, 2013, at 5:04 AM, chris Hegarty wrote: > Joe, > > I can see in SAXParserImpl constructor, setFeature0 could throw, leaving the > fSecurityPropertyMgr uninitialized. There my be other code paths too. > > I agree w

Re: RFR doclint issues in java.net

Good to go On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote: > This is a request for review for some doclint warnings in the java.net > package. Trivially, the list type should be left to the CSS. > > Note: with these changes there are still warnings for two DatagramPacket > constructors that a

Re: RFR: JAXP in JDK8/7u40 : 8021148 Regression in SAXParserImpl in 7u40 b34 (NPE)

d): > http://cr.openjdk.java.net/~joehw/7u40/8021148/webrev/ > > Thanks, > Joe > > On 7/24/2013 3:41 AM, Lance Andersen - Oracle wrote: >> Agree with the change and making fSecurityPropertyMgr final >> >> Best >> Lance >> On Jul 24, 2013, a

Re: RFR JDK 8 javac lint cleanup of java.lang.ref

Looks fine joe On Jul 25, 2013, at 4:33 PM, Joe Darcy wrote: > Hello, > > Please review these changes to remove the javac lint warnings from the > java.lang.ref package: > >8021429 Fix lint warnings in java.lang.ref >http://cr.openjdk.java.net/~darcy/8021429.0/ > > Care was taken to no

Re: RFR: 8022479: clean up warnings from sun.tools.asm

Hi Stuart, On the surface the changes look fine, including what you did for SwitchData. Certainly another pair of eyes would be good also on this. Best Lance On Aug 7, 2013, at 2:28 AM, Stuart Marks wrote: > Hi, > > Please review the fix for this warnings cleanup bug. > > Bug: http://bugs.sun

Re: RFR: JDK-8022554 -- Fix Warnings in sun.invoke.anon Package

looks fine Dan On Aug 7, 2013, at 1:49 PM, Dan Xu wrote: > Hi All, > > Please review the simple warning fix in > src/share/classes/sun/invoke/anon/ConstantPoolPatch.java. > > webrev: http://cr.openjdk.java.net/~dxu/8022554/webrev/ > > Thanks, > > -Dan Lance Andersen| Principal Member of Tec

Re: RFR: JAXP in JDK8/7u40 : 8022548 : SPECJVM2008 has errors introduced in 7u40-b34

Hi Joe, The changes look fine Best Lance On Aug 9, 2013, at 1:57 AM, huizhe wang wrote: > Hi, > > The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM > 1.1 to convert the output to its canonical form. The XOM parser directly > references to the JDK parser implementati

Re: RFR lint warnings in j.u.concurrent.**

looks fine chris Best Lance On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote: > These changes address the remaining lint warnings in the j.u.concurrent.** > package(s). > > The changes are already in the JSR166 CVS, this is a request to bring them > into jdk8. > > diff -r 84004d0e3fdd > src/

Re: RFR: JDK-8021977 -- Open File Using Java.IO May Throw IOException On Windows

Looks OK Dan Best Lance On Aug 8, 2013, at 7:26 PM, Dan Xu wrote: > Hi All, > > Please review a simple bug fix for JDK8021977. For the backward > compatibility, I have to remove the code that might throw out IOExceptionin > the native side. The issue has never been reported.But it exists in a

Reviewer needed for 8022753: SQLXML example typo in the SQLXML javadoc

Hi all, Need a reviewer for the following trivial javadoc typo. Bug is 8022753 Best Lance hg diff SQLXML.java diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java --- a/src/share/classes/java/sql/SQLXML.javaSat Jun 29 06:12:28 2013 -0400 +++ b/src/share/classes/java/sql/SQLXML.java

Re: 8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile

I think this look OK Alan Best Lance On Aug 20, 2013, at 8:13 AM, Alan Bateman wrote: > > For some time now we have been chipping away at the make files that are used > to run the jdk tests. Mike has his wielded his axe on several occasions > recently to remove logic and rules that are no long

Re: RFR: 8005899: Logger.getLogger(name, null) should not allow to reset a non-null resource bundle

Looking at the jdk7 source and comparing your change this looks OK. Would be good to get one more pair of eyes on this as well but I think you should be good to go Best Lance On Aug 23, 2013, at 10:41 AM, Daniel Fuchs wrote: > Hi, > > Please find below a fix for: > > 8005899: Logger.getLogg

Re: RFR: 8005899: Logger.getLogger(name, null) should not allow to reset a non-null resource bundle

looks fine dan! On Aug 23, 2013, at 1:26 PM, Daniel Fuchs wrote: > On 8/23/13 5:50 PM, Mandy Chung wrote: >> Hi Daniel, >> >> The fix looks good. It might be good to clarify the spec in the case >> when the given resourceBundleName parameter is null? Perhaps in the >> @params resourceBundleN

Review request for 8014967: Clarify NPE thrown by DriverManager.registerDriver when driver is null

Looking for a reviewer for this trivial change to clarify the long outstanding behavior of registererDriver: $ hg diff DriverManager.java diff -r 262a625809fd src/share/classes/java/sql/DriverManager.java --- a/src/share/classes/java/sql/DriverManager.java Thu Sep 12 01:47:05 2013 -0700 ++

review request: 8015340: remove erroneous @since tag

Looking for a reviewer for this trivial fix: hg diff PreparedStatement.java diff -r 262a625809fd src/share/classes/java/sql/PreparedStatement.java --- a/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 01:47:05 2013 -0700 +++ b/src/share/classes/java/sql/PreparedStatement.java Thu

review request 7097386: Correct error in Predicate javadoc example

Hi Everyone, Looking for a reviewer for this trivial fix to correct the sample example in the Predicate javadoc for the evaluate method() -- !hg hg diff Predicate.java diff -r 60d6f60416ca src/share/classes/javax/sql/rowset/Predicate.java --- a/src/share/classes/javax/sql/rowse

Re: review request 7097386: Correct error in Predicate javadoc example

I added a webrev http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be a bit easier for this review. Best lance On Sep 13, 2013, at 4:40 PM, Lance Andersen - Oracle wrote: > Hi Everyone, > > Looking for a reviewer for this trivial fix to correct the sample example

Re: review request 7097386: Correct error in Predicate javadoc example

Thanks for the input. On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote: > On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote: >> I added a webrev >> http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be >> a bit easier for this review. > > Notes:

Fwd: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer

Hi Folks, Aleksey has been kind enough to review this change. Still need the blessing of a reviewer to put this back... any takers :-) Best Lance Begin forwarded message: > From: Lance Andersen - Oracle > Date: September 16, 2013 7:12:09 AM EDT > To: Aleksey Shipilev > Cc: c

Re: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer

On Sep 17, 2013, at 7:14 AM, Alan Bateman wrote: > On 17/09/2013 11:55, Lance Andersen - Oracle wrote: >> Hi Folks, >> >> Aleksey has been kind enough to review this change. Still need the blessing >> of a reviewer to put this back... >> >> any takers

Re: RFR 8024707: TRANSFORMEREXCEPTION : ITEM() RETURNS NULL WITH NODE LIST OF LENGTH =1 IN JAXP

+1 On Sep 30, 2013, at 1:23 PM, huizhe wang wrote: > Aleksej, > > The change looks good. > > Thanks, > Joe > > On 9/28/2013 7:54 AM, Aleksej Efimov wrote: >> Joe, >> Thank you for a suggestion. But I modified it a little bit: >> public Node item(int index) { >> if (m_iter != null)

Re: Review Request for java.time test fix 8024612

+1 On Oct 9, 2013, at 10:36 AM, roger riggs wrote: > Please Review a locale sensitive test correction: > > The API under test is based on Locale.getDefault(Locale.Category.FORMAT) > and the test data should be using the same Locale. > The failure was seen in locale: ar_EG with Locale.Category.FOR

Re: RFR: improved exception messages in java.time 8025718

+1 On Oct 9, 2013, at 10:38 AM, roger riggs wrote: > Ping... any Reviewer... > > Thanks > > On 10/4/2013 3:37 PM, roger riggs wrote: >> Hi, >> >> Please review these small improvements in messages resulting from >> parsing date and time errors and corresponding tests. >> >> Webrev: >> http:/

Re: RFR (JAXP) : 8003262 reverse translation required changes

+1 On Oct 9, 2013, at 1:35 PM, huizhe wang wrote: > Hi, > > These resource bundles in JAXP were refactored due to request by WPTG. Now > that the WPTG tool has been approved to support the original format, I'm > reverting the previous change back to the original format: > > http://cr.openjdk.j

Re: RFR (JAXP) : 8003262 reverse translation required changes

openjdk.java.net/~joehw/jdk8/8003262/webrev/ > > Thanks, > Joe > > > On 10/9/2013 10:58 AM, Lance Andersen - Oracle wrote: >> +1 >> On Oct 9, 2013, at 1:35 PM, huizhe wang wrote: >> >>> Hi, >>> >>> These resource bundles in JAXP we

Re: Please Review javadoc cleanup 8026516

Hi Roger, I think what you have done is OK. I do have questions on should more be done in general so that we use (as I thought that was no required vs just a solo ?). As I started to look through some of the JDBC warnings, I saw more tags that I thought should have been reported by doclin

Re: Please Review javadoc cleanup 8026516

l for > that would restore the spacing. > > Roger > > On 10/16/2013 4:37 PM, Lance Andersen - Oracle wrote: >> Hi Roger, >> >> I think what you have done is OK. >> >> I do have questions on should more be done in general so that we use >>

Re: Please Review javadoc warning fixes to java.lang.invoke

+1 On Oct 17, 2013, at 1:15 PM, roger riggs wrote: > Please review a couple of issues with javadoc in java.lang.invoke to cleanup > javadoc warnings. > > https://bugs.openjdk.java.net/browse/JDK-8026183 > https://bugs.openjdk.java.net/browse/JDK-8015808 > > Webrev: > http://cr.openjdk.java.ne

Re: RFR (JAXP) : 8015243 : SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI.

+1 On Oct 16, 2013, at 2:53 PM, huizhe wang wrote: > Hi, > > This is a conformance issue. The issue is that a JCK test fails since invalid > URI such as "//" was not caught. The fix is to check and allow empty > authority only if there's non empty path, query component or fragment > identifier

Review request 8026812, doclint clean up for java.sql and javax.sql

Hi all, Need a reviewer for 8026812 which addresses the new doclint warnings. Webrev is at: http://cr.openjdk.java.net/~lancea/8026812/webrev.00/ Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lanc

Re: Please Review javadoc fixes 8026982

Overall, I think is this good. I think in MessageDigest --- old/src/share/classes/java/security/MessageDigest.java 2013-10-21 17:31:32.734881244 -0400 +++ new/src/share/classes/java/security/MessageDigest.java 2013-10-21 17:31:32.558891607 -0400 @@ -54,21 +54,21 @@ * * Implementa

Re: RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

looks OK joe On Oct 23, 2013, at 3:42 PM, huizhe wang wrote: > Hi Daniel, > > Thanks for the review and the detailed list. I've updated the webrev: > > http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/ > > Thanks, > Joe > > On 10/23/2013 11:25 AM, Daniel Fuchs wrote: >> Hi Joe, >> >> I b

Re: RFR: minor doc fixes for java.util.Formatter

+1 On Oct 25, 2013, at 4:50 PM, Stuart Marks wrote: > Hi all, > > Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs > are: > > https://bugs.openjdk.java.net/browse/JDK-5063500 > https://bugs.openjdk.java.net/browse/JDK-7126305 > https://bugs.openjdk.java.net/browse/J

Re: RFR (JAXP): 8027484 : Implementation error in SAX2DOM.java

+1 On Oct 29, 2013, at 5:13 PM, huizhe wang wrote: > A quick fix to add the missing braces and correct the misspellings. > > webrevs: http://cr.openjdk.java.net/~joehw/jdk8/8027484/webrev/ > > The following is where the braces were missing, others were a global > substitution of the misspelling

Re: RFR (JAXP): 8024378 : StAX parser shall support JAXP properties

Hi Joe, I think this is all OK Best Lance On Oct 30, 2013, at 11:40 AM, huizhe wang wrote: > > On 10/30/2013 2:58 AM, Daniel Fuchs wrote: >> On 10/30/13 1:14 AM, huizhe wang wrote: >>> I updated the webrev to also fix the error message that showed the >>> actual number of attributes parsed rath

<    1   2   3