+1
On Jan 23, 2013, at 9:54 AM, Alan Bateman wrote:
The j.l.FunctionalInterface annotation was added recently but it's not
showing up in rt.jar when using the old build (NEWBUILD=false). Unfortunately
we have to keep the old build on life support until the new build is bedded
down and
+1
On Jan 31, 2013, at 5:15 PM, Xueming Shen wrote:
Hi,
Obviously ioe is not an appropriate exception for invalid base64 bytes,
and it's inconsistent with the rest of decode methods, as the submitter
suggested.
The change is to explicitly specify (as other decoding methods do) that
IAE
HI,
This is a review request for
http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to
SQLInput/Ouput (used for UDTs) to have generic methods for types allowing
support for JSR 310.
Also now that 310 is in M6, update Types and JDBCType to add entries for
TIME/TIMESTAMP
Hi Ulf,
On Feb 5, 2013, at 6:07 PM, Ulf Zibis wrote:
Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle:
HI,
This is a review request for
http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to
SQLInput/Ouput (used for UDTs) to have generic methods for types
Thank you again for the feedback Ulf
On Feb 5, 2013, at 7:22 PM, Ulf Zibis wrote:
Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle:
I can change that text and will do so before i put back.
fine!
I am going to change the message from
readObject not implemented
to method readObject
On Feb 6, 2013, at 9:26 AM, Ulf Zibis wrote:
Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle:
I am going to change the message from
readObject not implemented
to method readObject(ClassT) not implemented
There is 1 % missing to be perfect: method T T readObject(ClassT type
Looks Ok Dmeetry.
Best
Lance
On Feb 11, 2013, at 3:58 PM, Dmeetry Degrave wrote:
Hi,
Resending a code review request for a corba fix for 7 and 8, which is
identical to fix went to earlier releases.
A wrong unexpectedUnionDefault exception is thrown in TypeCode handling code
when an
+1
On Feb 13, 2013, at 2:02 PM, Xueming Shen wrote:
Hi,
This is the regression triggered by my changeset
8007572: Replace existing jdk timezone data at java.home/lib/zi with
JSR310's tzdb.
While the specification does not specify that the returned list from
Alan,
the changes look good and glad you added the extra comments for clarity.
Best
Lance
On Feb 21, 2013, at 9:33 AM, Alan Bateman wrote:
This one is a startup-time regression caused by the compact profiles work.
As background, there was a lot of work done in the distant past on startup
Well, that was quite a few files to have to go through :-)
Looks fine
On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote:
Joe Darcy recently added @jdk.Supported [1] to make it possible to identify
JDK-specific APIs.
I'd like to add this to a number of APIs in the com.sun namespace to make
H alli,
This is a review request for 8008716 to address a couple of typos in
CallableStatement:
$ hg diff CallableStatement.java
diff -r 7dcb74c3ffba src/share/classes/java/sql/CallableStatement.java
--- a/src/share/classes/java/sql/CallableStatement.java Tue Feb 12 09:25:43
2013 -0800
+++
Need a reviewer for 8010416, addition of Driver.deregisterDriver.
The webrev can be found at
http://cr.openjdk.java.net/~lancea/8010416/webrev.00/.
I will be submitting the ccc request later today but want to do this in parallel
Best
Lance
Lance Andersen| Principal Member of Technical Staff
Hi all
Need a reviewer for the correction of the following typo in SerialClob.java
which is bug 8011393
hg diff SerialClob.java
diff -r e6c3b8e74e50 src/share/classes/javax/sql/rowset/serial/SerialClob.java
--- a/src/share/classes/javax/sql/rowset/serial/SerialClob.java Tue Apr 02
10:12:20
there is a lot of code that could
be cleaned up besides JDBC :-)
Thank you again.
Best
Lance
On Apr 3, 2013, at 1:49 PM, Mandy Chung wrote:
Looks fine. You may want to use {@code CLOB} to replace code.../code
Mandy
On 4/3/2013 9:15 AM, Lance Andersen - Oracle wrote:
Hi all
Need
looks ok
On Apr 5, 2013, at 5:18 PM, Jim Gish wrote:
Please review trivial change to add back in delete of test files on test
completion.
http://cr.openjdk.java.net/~jgish/Bug8006036-WinCommand/
http://cr.openjdk.java.net/%7Ejgish/Bug8006036-WinCommand/
Thanks,
Jim
--
Jim Gish
Hi,
This is a request to review adding a netbeans freeform project to
jdk/make/netbeans for jdbc
As part of this change, I also modified common/shared.xml to properly look for
the jtreg report.html in the html directory and so the javadoc was using
version 1.8
The web rev is here
Thank you ulf, I made the change in my workspace so that it will be
accommodated as part of the putback
Best
Lance
On Apr 9, 2013, at 11:26 AM, Ulf Zibis wrote:
Hi,
there is a little indentation error in build.xml in line 42.
-Ulf
Am 09.04.2013 16:55, schrieb Lance Andersen - Oracle
+1
On Apr 18, 2013, at 2:07 PM, Mandy Chung wrote:
This fix adds GetSafepointSyncTime.java test in the ProblemList.txt
until 8010897 is resolved. It has been failing intermittently on macosx-x64.
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC driver to be
notified when/if it was deregistered via DriverManager.deregisterDriver if
desired.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01
Best
Lance
Lance Andersen| Principal
Thank you for the feedback Alan,
Please see below and the webrev
http://cr.openjdk.java.net/~lancea/8010416/webrev.02/
On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote:
On 19/04/2013 18:34, Lance Andersen - Oracle wrote:
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC
(or as
much as it can be)
DriverManager line 355: missing space after comma.
fixed this. thank for this
Best
Lance
-Ulf
Am 21.04.2013 13:45, schrieb Lance Andersen - Oracle:
Thank you for the feedback Alan,
Please see below and the webrev
http://cr.openjdk.java.net/~lancea/8010416/webrev
On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
On 21/04/2013 12:45, Lance Andersen - Oracle wrote:
:
DriverManager
- one point that isn't covered in the spec is whether the DriverAction's
deregister is invoked before or after it is deregistered. This distinction
is probably only
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that
were pointed out and also fixes a couple javadoc warnings
Best,
Lance
On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote:
On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
On 21/04/2013 12:45, Lance
On Apr 26, 2013, at 8:35 AM, Alan Bateman wrote:
On 25/04/2013 21:53, Lance Andersen - Oracle wrote:
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos
that were pointed out and also fixes a couple javadoc warnings
This looks okay to me.
One small suggestion
Hi Mike,
The changes look good to me.
Best
Lance
On Apr 29, 2013, at 10:11 PM, Mike Duigou wrote:
Hello All;
This is a review for three changes to the J2SE Netbeans project. If necessary
I can break this up into three separate patches but I would rather not if
possible.
Hi Neil,
Just back from holiday and catching up (or trying to)
On May 2, 2013, at 7:13 AM, Neil Richards wrote:
Hi Lance,
I've been trying to identify the Java bug ids for the RFEs which
implement JEP 170 (which, from what I can tell, should be in OpenJDK 8
since milestone 6 [1]).
The
+1
On May 14, 2013, at 8:16 AM, Alan Bateman wrote:
The bootcycle-images target is currently broken in jdk8/tl.
Jon has taken 8014461 to fix genstubs but once you get past that then the
CLDRConverter fails parsing LDML due to DTD references that aren't allowed by
the default policy in
Looks fine Xuelei
best
Lance
On May 16, 2013, at 5:08 AM, Xuelei Fan wrote:
Hi,
There is another fix to avoid the use of mutable objects.
webrev: http://cr.openjdk.java.net/~xuelei/8010814/webrev.00/
Thanks,
Xuelei
Lance Andersen| Principal Member of Technical Staff |
the changes make sense to me
On Jun 4, 2013, at 6:57 PM, Seán Coffey wrote:
The com.sun.corba.se.impl package is a private package. The API is subject to
change at any time and no 3rd party code should be using it. As a result, I'd
like to add it to the package restricted list. I've run our
Hi,
Need a reviewer for this minor javadoc update for bug 8016101
SerialStruct was missing a javadoc @param tag in the constructor
SerialRef had an extra '.'
Best
Lance
hg diff
diff -r b4742d038100 src/share/classes/javax/sql/rowset/serial/SerialRef.java
---
}
* @param map a codejava.util.Map/code object in which
*each entry consists of 1) a codeString/code object
*giving the fully qualified name of a UDT and 2) the
On Jun 6, 2013, at 4:34 PM, Aleksey Shipilev wrote:
Hi Lance,
On 06/07/2013 12:09 AM, Lance Andersen
Hi Joe,
The change looks OK. I know the messages have to be translated by the
globalization team for the other languages.
Best
Lance
On Jun 6, 2013, at 5:42 PM, huizhe wang wrote:
This is a quick fix to improve the error message so that it's clearly
differentiated from those reported by
to be in the repository before the tool can pull them out.
I know it takes time, to get that done. Thank you for clarifying the error
message.
Best
Lance
Best,
Joe
On 6/6/2013 2:51 PM, Lance Andersen - Oracle wrote:
Hi Joe,
The change looks OK. I know the messages have to be translated
This looks good. Thank you for taking this on Alan.
Best
Lance
On Jun 10, 2013, at 6:31 AM, Alan Bateman wrote:
About 8 months ago I tried an early build of doclint [1] and used it to fix
up a bunch issues at the time [2]. It's been awhile, so I decided to try out
the latest version to
looks fine joe
-lance
On Jun 8, 2013, at 4:11 PM, huizhe wang wrote:
Hi,
This patch is to continue the support of plugging in 3rd party parser impls
(such as Xerces) that do not support JAXP 1.5. The fix is to catch
SAXNotRecognizedException, print out a warning, and then continue as
://cr.openjdk.java.net/~joehw/jdk8/8016153/webrev/
[1] jaxp standalone source
https://java.net/projects/jaxp-sources/sources/svn/content/trunk/xml-xerces/java/src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java?rev=3134
Thanks,
Joe
On 6/10/2013 9:44 AM, Lance Andersen
+1
On Jun 27, 2013, at 2:58 PM, Joe Darcy wrote:
Hello,
Please review the patch below which resolves doclint warnings in
java.util.logging.
Thanks,
-Joe
diff -r 1c31082f0a51 src/share/classes/java/util/logging/Handler.java
--- a/src/share/classes/java/util/logging/Handler.java
looks fine joe
On Jun 27, 2013, at 3:47 PM, Joe Darcy wrote:
Hello,
Please review the next patch in a series of patches to resolve doclint
warnings in the JDK; this time in javax.script.
Thanks,
-Joe
diff -r b8f16cb2d95b src/share/classes/javax/script/Invocable.java
---
Hi Joe,
Looks good.
fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy.
Not sure if it matters below but thought I would point it out if you want a
smaller heading
Best
Lance
On Jun 28, 2013, at 1:54 PM, Joe Darcy wrote:
Hello,
Still more doclint fixes for
Hi,
Looking for a reviewer for this minor typo in ResultSet.next()
$ hg diff
diff -r 4e69a7dfbeac src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Thu Jun 27 10:21:22 2013 +0100
+++ b/src/share/classes/java/sql/ResultSet.java Fri Jun 28 18:09:36 2013
looks good Joe
On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote:
Hello,
Pack200 has some doclint issues; please review the fixes to them below.
Thanks,
-Joe
--- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11
2013 -0700
+++
Looks fine Joe including Mandy's feedback
Best
Lance
On Jul 8, 2013, at 10:10 PM, Joe Darcy wrote:
Hello,
Please review my changes to resolve (almost all of):
JDK-8020095 Fix doclint warnings in java.util.regex
http://cr.openjdk.java.net/~darcy/8020095.0/
Full text of the patch
Hi Joe
Looks good
Best
Lance
On Jul 8, 2013, at 9:07 PM, huizhe wang wrote:
Hi,
I've updated webrev with improved property management, and quality backed by
320 test cases. Thanks Daniel for the help expanding the test suite!
Here's the webrev:
The fix looks fine to me Joe as does the test. I assume you will go with
Chris's plan below for the test locations?
Best
Lance
On Jul 12, 2013, at 5:44 AM, Chris Hegarty wrote:
The source changes look fine to me.
The tests should be located elsewhere, otherwise they will collide with an
looks fine Mike
Best
Lance
On Jul 22, 2013, at 3:24 PM, Mike Duigou wrote:
Hello all;
A simple rewiew for the addition of another constructor to PriorityQueue.
Currently if you wish to specify a Comparator you must also supply a size.
This addition allows use of the default size which is
Agree with the change and making fSecurityPropertyMgr final
Best
Lance
On Jul 24, 2013, at 5:04 AM, chris Hegarty wrote:
Joe,
I can see in SAXParserImpl constructor, setFeature0 could throw, leaving the
fSecurityPropertyMgr uninitialized. There my be other code paths too.
I agree with
Good to go
On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:
This is a request for review for some doclint warnings in the java.net
package. Trivially, the list type should be left to the CSS.
Note: with these changes there are still warnings for two DatagramPacket
constructors that are
/webrev/
Thanks,
Joe
On 7/24/2013 3:41 AM, Lance Andersen - Oracle wrote:
Agree with the change and making fSecurityPropertyMgr final
Best
Lance
On Jul 24, 2013, at 5:04 AM, chris Hegarty wrote:
Joe,
I can see in SAXParserImpl constructor, setFeature0 could throw, leaving
Looks fine joe
On Jul 25, 2013, at 4:33 PM, Joe Darcy wrote:
Hello,
Please review these changes to remove the javac lint warnings from the
java.lang.ref package:
8021429 Fix lint warnings in java.lang.ref
http://cr.openjdk.java.net/~darcy/8021429.0/
Care was taken to not change
Hi Stuart,
On the surface the changes look fine, including what you did for SwitchData.
Certainly another pair of eyes would be good also on this.
Best
Lance
On Aug 7, 2013, at 2:28 AM, Stuart Marks wrote:
Hi,
Please review the fix for this warnings cleanup bug.
Bug:
looks fine Dan
On Aug 7, 2013, at 1:49 PM, Dan Xu wrote:
Hi All,
Please review the simple warning fix in
src/share/classes/sun/invoke/anon/ConstantPoolPatch.java.
webrev: http://cr.openjdk.java.net/~dxu/8022554/webrev/
Thanks,
-Dan
Lance Andersen| Principal Member of Technical
Hi Joe,
The changes look fine
Best
Lance
On Aug 9, 2013, at 1:57 AM, huizhe wang wrote:
Hi,
The root cause of this issue is that SPECJVM2008 uses a 3rd party parser XOM
1.1 to convert the output to its canonical form. The XOM parser directly
references to the JDK parser implementation
looks fine chris
Best
Lance
On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote:
These changes address the remaining lint warnings in the j.u.concurrent.**
package(s).
The changes are already in the JSR166 CVS, this is a request to bring them
into jdk8.
diff -r 84004d0e3fdd
Looks OK Dan
Best
Lance
On Aug 8, 2013, at 7:26 PM, Dan Xu wrote:
Hi All,
Please review a simple bug fix for JDK8021977. For the backward
compatibility, I have to remove the code that might throw out IOExceptionin
the native side. The issue has never been reported.But it exists in a
Hi all,
Need a reviewer for the following trivial javadoc typo. Bug is 8022753
Best
Lance
hg diff SQLXML.java
diff -r a4eb59bffb60 src/share/classes/java/sql/SQLXML.java
--- a/src/share/classes/java/sql/SQLXML.javaSat Jun 29 06:12:28 2013 -0400
+++
I think this look OK Alan
Best
Lance
On Aug 20, 2013, at 8:13 AM, Alan Bateman wrote:
For some time now we have been chipping away at the make files that are used
to run the jdk tests. Mike has his wielded his axe on several occasions
recently to remove logic and rules that are no longer
Looking at the jdk7 source and comparing your change this looks OK. Would be
good to get one more pair of eyes on this as well but I think you should be
good to go
Best
Lance
On Aug 23, 2013, at 10:41 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8005899:
looks fine dan!
On Aug 23, 2013, at 1:26 PM, Daniel Fuchs wrote:
On 8/23/13 5:50 PM, Mandy Chung wrote:
Hi Daniel,
The fix looks good. It might be good to clarify the spec in the case
when the given resourceBundleName parameter is null? Perhaps in the
@params resourceBundleName of the
Looking for a reviewer for this trivial change to clarify the long outstanding
behavior of registererDriver:
$ hg diff DriverManager.java
diff -r 262a625809fd src/share/classes/java/sql/DriverManager.java
--- a/src/share/classes/java/sql/DriverManager.java Thu Sep 12 01:47:05
2013 -0700
Looking for a reviewer for this trivial fix:
hg diff PreparedStatement.java
diff -r 262a625809fd src/share/classes/java/sql/PreparedStatement.java
--- a/src/share/classes/java/sql/PreparedStatement.java Thu Sep 12 01:47:05
2013 -0700
+++ b/src/share/classes/java/sql/PreparedStatement.java Thu
Hi Everyone,
Looking for a reviewer for this trivial fix to correct the sample example in
the Predicate javadoc for the evaluate method()
--
!hg
hg diff Predicate.java
diff -r 60d6f60416ca src/share/classes/javax/sql/rowset/Predicate.java
---
I added a webrev http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it
might be a bit easier for this review.
Best
lance
On Sep 13, 2013, at 4:40 PM, Lance Andersen - Oracle wrote:
Hi Everyone,
Looking for a reviewer for this trivial fix to correct the sample example
Thanks for the input.
On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote:
On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote:
I added a webrev
http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be
a bit easier for this review.
Notes:
- change C-style int v
Hi Folks,
Aleksey has been kind enough to review this change. Still need the blessing of
a reviewer to put this back...
any takers :-)
Best
Lance
Begin forwarded message:
From: Lance Andersen - Oracle lance.ander...@oracle.com
Date: September 16, 2013 7:12:09 AM EDT
To: Aleksey Shipilev
On Sep 17, 2013, at 7:14 AM, Alan Bateman wrote:
On 17/09/2013 11:55, Lance Andersen - Oracle wrote:
Hi Folks,
Aleksey has been kind enough to review this change. Still need the blessing
of a reviewer to put this back...
any takers :-)
It looks okay although if is this is sample code
+1
On Oct 9, 2013, at 10:36 AM, roger riggs wrote:
Please Review a locale sensitive test correction:
The API under test is based on Locale.getDefault(Locale.Category.FORMAT)
and the test data should be using the same Locale.
The failure was seen in locale: ar_EG with
+1
On Oct 9, 2013, at 10:38 AM, roger riggs wrote:
Ping... any Reviewer...
Thanks
On 10/4/2013 3:37 PM, roger riggs wrote:
Hi,
Please review these small improvements in messages resulting from
parsing date and time errors and corresponding tests.
Webrev:
+1
On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
Hi,
These resource bundles in JAXP were refactored due to request by WPTG. Now
that the WPTG tool has been approved to support the original format, I'm
reverting the previous change back to the original format:
/8003262/webrev/
Thanks,
Joe
On 10/9/2013 10:58 AM, Lance Andersen - Oracle wrote:
+1
On Oct 9, 2013, at 1:35 PM, huizhe wang wrote:
Hi,
These resource bundles in JAXP were refactored due to request by WPTG. Now
that the WPTG tool has been approved to support the original format
Hi Roger,
I think what you have done is OK.
I do have questions on should more be done in general so that we use P /P
(as I thought that was no required vs just a solo P?). As I started to look
through some of the JDBC warnings, I saw more tags that I thought should have
been reported by
.
Roger
On 10/16/2013 4:37 PM, Lance Andersen - Oracle wrote:
Hi Roger,
I think what you have done is OK.
I do have questions on should more be done in general so that we use P
/P (as I thought that was no required vs just a solo P?). As I started
to look through some of the JDBC warnings
+1
On Oct 17, 2013, at 1:15 PM, roger riggs wrote:
Please review a couple of issues with javadoc in java.lang.invoke to cleanup
javadoc warnings.
https://bugs.openjdk.java.net/browse/JDK-8026183
https://bugs.openjdk.java.net/browse/JDK-8015808
Webrev:
+1
On Oct 16, 2013, at 2:53 PM, huizhe wang wrote:
Hi,
This is a conformance issue. The issue is that a JCK test fails since invalid
URI such as // was not caught. The fix is to check and allow empty
authority only if there's non empty path, query component or fragment
identifier.
Hi all,
Need a reviewer for 8026812 which addresses the new doclint warnings.
Webrev is at: http://cr.openjdk.java.net/~lancea/8026812/webrev.00/
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.734881244 -0400
+++ new/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.558891607 -0400
@@ -54,21 +54,21 @@
*
*
looks OK joe
On Oct 23, 2013, at 3:42 PM, huizhe wang wrote:
Hi Daniel,
Thanks for the review and the detailed list. I've updated the webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/
Thanks,
Joe
On 10/23/2013 11:25 AM, Daniel Fuchs wrote:
Hi Joe,
I believe all the
+1
On Oct 25, 2013, at 4:50 PM, Stuart Marks wrote:
Hi all,
Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs
are:
https://bugs.openjdk.java.net/browse/JDK-5063500
https://bugs.openjdk.java.net/browse/JDK-7126305
+1
On Oct 29, 2013, at 5:13 PM, huizhe wang wrote:
A quick fix to add the missing braces and correct the misspellings.
webrevs: http://cr.openjdk.java.net/~joehw/jdk8/8027484/webrev/
The following is where the braces were missing, others were a global
substitution of the misspelling.
Hi Joe,
I think this is all OK
Best
Lance
On Oct 30, 2013, at 11:40 AM, huizhe wang wrote:
On 10/30/2013 2:58 AM, Daniel Fuchs wrote:
On 10/30/13 1:14 AM, huizhe wang wrote:
I updated the webrev to also fix the error message that showed the
actual number of attributes parsed rather than
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error. Also
cleaned up a couple of other minor issues in these classes.
The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/
Thank you for catching the error.
Regards
Lance
On Sep 5, 2010,
Hi David,
Thanks for the feedback.
Please see below.
On Nov 6, 2010, at 2:04 AM, David Schlosnagle wrote:
On Fri, Nov 5, 2010 at 5:51 PM, Lance Andersen - Oracle
lance.ander...@oracle.com wrote:
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error
Thank you Alan.
Yes I am planning on doing additional clean up across the code utilizing a
separate CR.
Regards,
Lance
On Nov 11, 2010, at 4:59 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
Hi Remi (and team),
I made changes to SyncFactory and one other class for a similar error
Looks good to me Alan.
Regards
Lance
On Nov 16, 2010, at 9:34 AM, Alan Bateman wrote:
I need a reviewer to a trivial drive-by fix to java.lang.Readable's javadoc.
Thanks,
Alan.
diff --git a/src/share/classes/java/lang/Readable.java
b/src/share/classes/java/lang/Readable.java
---
Hi Joe,
Looks fine to me.
-lance
On Dec 1, 2010, at 12:24 PM, Joe Darcy wrote:
Hello.
Please review my simple fix for
7002594 Math.max and Math.min should use floatToRawIntBits() to check for
-0.0
http://cr.openjdk.java.net/~darcy/7002594.0/
Besides addressing the reported
looks fine to me Alan
On Jan 4, 2011, at 8:50 AM, Alan Bateman wrote:
The HPI is left over from bygone years where we had a portability layer and
needed to support green and native threading models. Some of the code has not
been used or maintained since the transition to HotSpot back in
looks fine Alan
On Mar 2, 2011, at 10:12 AM, Alan Bateman wrote:
I need a reviewer for a small regression in the native2ascii tool whereby its
error messages aren't as expected. Early in the jdk7 this code appears to
have been changed to address a non-varargs call of varargs method warning
Hi,
I have posted the diffs to DriverManager for review at
http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
CopyOnWriteArrayList instead of the Vectors previously used.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java
, I will look at the javadoc changes that you
suggest then (there are existing CRs on this)
I do not mind moving the constructor, I just left it where it was since
DriverManager was written, but happy to do so.
Regards
Lance
-Ulf
Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle:
Hi
Hi Dave,
Yes it could be made final. This is just a hold over from the original code,
but there is no reason that I cannot make it final.
Regards
Lance
On Mar 11, 2011, at 6:26 PM, David Schlosnagle wrote:
On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle
lance.ander...@oracle.com
Hi all,
This is a request for a review of the changes to remove the lint warnings for
DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/.
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network
Hi all,
This is a request for a review of the changes to remove the lint warnings for
javax.sql.rowset. The diff is at http://cr.openjdk.java.net/~lancea/7035615
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1
Hi Joe, Alan,
Thank you for your feedback Joe.
On Apr 11, 2011, at 2:35 PM, Alan Bateman wrote:
joe.da...@oracle.com wrote:
Hi Lance.
The generification looks fine.
Thank you Joe
Separately I'd recommend considering replacing Vector with ArrayList and
Hashtable with HashMap.
I was
On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
:
PS: javac was updated recently to emit warnings for unreachable catch
clauses and one place that generates this warning is
src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be
great
On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
:
PS: javac was updated recently to emit warnings for unreachable catch
clauses and one place that generates this warning is
src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be
great to get
Hi Alan,
http://cr.openjdk.java.net/~lancea/7035615/webrev.02/ has your suggested
changes below.
Regards
Lance
On Apr 12, 2011, at 4:08 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
Hi Alan, Joe
I pushed the revised webrev out (webrev.01). I am going through a directory
Hi folks,
Looking for a reviewer for the following simple change to ResultSet to address
CR 7007772
hg diff
diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java
--- a/src/share/classes/java/sql/ResultSet.java Tue Apr 12 12:25:15 2011 -0400
+++
HI all,
Need a reviewer for this minor update to the SQLPermission constructors which I
missed when I added the updates for the new permission target names.
Thank you.
Regards,
Lance
hg diff
diff -r 0bae251b548b src/share/classes/java/sql/SQLPermission.java
---
Hi Alan,
thank you. Yes I will be going through all of JDBC to clean up the java docs
in the coming weeks.
Regards,
lance
On Apr 13, 2011, at 10:39 AM, Alan Bateman wrote:
Lance Andersen - Oracle wrote:
HI all,
Need a reviewer for this minor update to the SQLPermission constructors
Hi all,
Need a reviewer for the following minor change which adds hasCode() to
Timestamp to address a Findbugs warning.
Regards
Lance
hg diff
diff -r d9248245a88c src/share/classes/java/sql/Timestamp.java
--- a/src/share/classes/java/sql/Timestamp.java Wed Apr 13 11:21:36 2011 -0400
+++
.
Regards
Lance
On Apr 15, 2011, at 3:37 PM, Eamonn McManus wrote:
This isn't wrong, but wouldn't it be simpler to just add or xor the nanos
field into the hashcode, rather than explicitly saying that you don't?
Éamonn
On 15/4/11 8:54 PM, Lance Andersen - Oracle wrote:
Hi all,
Need
101 - 200 of 262 matches
Mail list logo
