On Fri, 10 Feb 2023 02:11:35 GMT, Brian Burkhalter wrote:
> Replace the two occurrences of `character` with `byte`.
Looks okay, I assume you've done a wider search to see if there are any more.
-
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12505
> Hi all,
> When -Xcomp be used, this testcase will use more codecaches, causing the GC
> to be triggered early, then causing this test failed on LoongArch64
> architecture.
>
> This PR fix the issue, Please help review it.
>
> Thanks.
SUN Guoyun has updated the pull request incrementally
Replace the two occurrences of `character` with `byte`.
-
Commit messages:
- 6595142: (spec) ByteArrayInputStream treats bytes, not characters
Changes: https://git.openjdk.org/jdk/pull/12505/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=12505=00
Issue:
On Thu, 9 Feb 2023 16:54:42 GMT, Roger Riggs wrote:
>> SUN Guoyun has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8301737:
>> java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java fail
>> with -Xcomp
>
>
On Wed, 18 Jan 2023 08:58:42 GMT, Xiaohong Gong wrote:
> The Vector API `"indexInRange(int offset, int limit)"` is used
> to compute a vector mask whose lanes are set to true if the
> index of the lane is inside the range specified by the `"offset"`
> and `"limit"` arguments, otherwise the lanes
On Mon, 6 Feb 2023 17:39:42 GMT, Paul Sandoz wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add smaller array size for benchmark tests
>
> I think it would be useful to adjust the naming and comments of some
On Tue, 7 Feb 2023 09:51:19 GMT, Xiaohong Gong wrote:
>> The Vector API `"indexInRange(int offset, int limit)"` is used
>> to compute a vector mask whose lanes are set to true if the
>> index of the lane is inside the range specified by the `"offset"`
>> and `"limit"` arguments, otherwise the
On Thu, 9 Feb 2023 18:08:15 GMT, Scott Gibbons wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
On Wed, 8 Feb 2023 00:15:27 GMT, Joe Wang wrote:
> Update Commons BCEL in the JDK from 6.5.0 to 6.7.0.
>
> 1. Improvement
>Code modernization (using relatively more modern language features),
> normalization (such as naming), javadocs, cleanup and minor improvements made
> up most of the
On Thu, 9 Feb 2023 11:03:44 GMT, Varada M wrote:
> These tests is passing without adding lpthread in JtregNativeHotspot.gmk. Do
> I need to update the makefile?
I'm somewhat surprised that the tests pass without explicit linkage, but
perhaps libpthread is a default on AIX. If things are
On Wed, 8 Feb 2023 00:37:57 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> This pull request suppose to chain on the 8294982: Implementation of
> Classfile API https://github.com/openjdk/jdk/pull/10982
>
> Please review.
>
> Thank
On Wed, 8 Feb 2023 00:38:23 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
> Prior to
> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
> LambdaMetaFactory has created VM-anonymous classes which could easily be
> unloaded once they were not referenced any more. Starting with JDK 15 and the
> new
On Thu, 9 Feb 2023 15:20:23 GMT, Volker Simonis wrote:
> Prior to
> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
> LambdaMetaFactory has created VM-anonymous classes which could easily be
> unloaded once they were not
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64Encode.testBase64Encode 1024 thrpt3
On Thu, 9 Feb 2023 15:20:23 GMT, Volker Simonis wrote:
> 4. the lambda proxy class has the strong relationship with the class loader
> (that will share the VM metaspace for its defining loader - implementation
> details)
A lambda proxy class is the implementation of the lambda/method
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64Encode.testBase64Encode 1024 thrpt3
On Tue, 7 Feb 2023 11:48:52 GMT, Maurizio Cimadamore
wrote:
>> Yes, performance is the main reason.
>> I'll note to do a fresh differential performance benchmarks with a HashMap.
>
> thanks
I tried HashMap with String keys and it cause performance regressions, however
with Utf8Entry
On Thu, 9 Feb 2023 15:47:31 GMT, Jorn Vernee wrote:
> Your analysis in the JBS issue seems reasonable, but I'll wait for Mandy to
> respond here.
>
> I looked at the original PR and don't see a discussion of `STRONG` there, but
> I very vaguely remember it being talked about as being needed
On Thu, 9 Feb 2023 15:45:35 GMT, Jorn Vernee wrote:
>> Prior to
>> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
>> LambdaMetaFactory has created VM-anonymous classes which could easily be
>> unloaded once they were not
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
> This PR proposed to reduce contention in synchronized methods mainly by doing
> I/O operations outside synch blocks.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Undo more unintended edits
-
Changes:
- all:
> This PR proposed to reduce contention in synchronized methods mainly by doing
> I/O operations outside synch blocks.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Fix things from PR comments
- Undo unintended changes
On Thu, 9 Feb 2023 15:19:38 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Unsafe instead of synchronized
>
> src/java.base/share/classes/java/lang/Module.java line 120:
>
>> 118: //
On Thu, 9 Feb 2023 15:20:23 GMT, Volker Simonis wrote:
> Prior to
> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
> LambdaMetaFactory has created VM-anonymous classes which could easily be
> unloaded once they were not
On Thu, 9 Feb 2023 15:05:13 GMT, Per Minborg wrote:
>> This PR proposed to reduce contention in synchronized methods mainly by
>> doing I/O operations outside synch blocks.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
Prior to
[JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
LambdaMetaFactory has created VM-anonymous classes which could easily be
unloaded once they were not referenced any more. Starting with JDK 15 and the
new "hidden
On Thu, 9 Feb 2023 08:44:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>>
On Wed, 1 Feb 2023 08:51:16 GMT, Per Minborg wrote:
>> This PR proposed to reduce contention in synchronized methods mainly by
>> doing I/O operations outside synch blocks.
>
> Per Minborg has updated the pull request incrementally with three additional
> commits since the last revision:
>
>
> This PR proposed to reduce contention in synchronized methods mainly by doing
> I/O operations outside synch blocks.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Use Unsafe instead of synchronized
-
Changes:
-
On Thu, 9 Feb 2023 12:57:19 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 08:44:41 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>>
On Thu, 9 Feb 2023 13:46:05 GMT, Varada M wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX
On Thu, 9 Feb 2023 11:30:11 GMT, Thomas Stuefe wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/jdk/jni/nullCaller/exeNullCallerTest.cpp line 159:
>
>> 157: }
>> 158:
>> 159: int main(int argc, char**
> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for values
> in the range [-18h, 18h] for each second that is on an even quarter of an
> hour (i.e. at most 2*18*4+1 = 145 values).
>
> Instead of using a `ConcurrentHashMap` for caching instanced, we could
> instead use an
> 1. test/jdk/jni/nullCaller/NullCallerTest.java
> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>
> The above tests were blocked on AIX [@require os.family != "aix"] because
> these tests are
> `ZoneOffset` instances are cached by the `ZoneOffset` class itself for values
> in the range [-18h, 18h] for each second that is on an even quarter of an
> hour (i.e. at most 2*18*4+1 = 145 values).
>
> Instead of using a `ConcurrentHashMap` for caching instanced, we could
> instead use an
On Thu, 9 Feb 2023 11:46:42 GMT, Eirik Bjorsnos wrote:
> > In addition to - or instead of - an `equals` shortcut then if coders are
> > the same we could use `ArraysSupport.mismatch` which should get similar
> > speed and help more generally.
>
> ..and if String had (an optimized) mismatch
On Wed, 8 Feb 2023 13:44:13 GMT, Adam Sotona wrote:
>> OK, I see your point now, I'll fix it.
>> Thanks
>
> During the fix I found the definition that `ThrowableSig` (as a super-set of
> `ClassTypeSig` and `TypeVarSig`) IS `Signature` - that fact is critical for
> processing.
> For example
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Thu, 9 Feb 2023 07:43:28 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 20 -> JDK 21
This pull request has now been integrated.
Changeset: af8973dc
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/af8973dc509c1f326223e3ffd1773c9e930141d8
Stats: 69 lines
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Thu, 9 Feb 2023 11:39:18 GMT, Claes Redestad wrote:
> Yes, I'll file a PR to see if we can make `startsWith` a bit sharper
Thanks! I pushed the change to ZipCoder.compare.
> In addition to - or instead of - an `equals` shortcut then if coders are the
> same we could use
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Thu, 9 Feb 2023 11:17:54 GMT, Varada M wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX
On Thu, 9 Feb 2023 11:28:47 GMT, Thomas Stuefe wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c line 48:
>
>> 46: int checkAccess(JNIEnv
On Thu, 9 Feb 2023 11:17:54 GMT, Eirik Bjorsnos wrote:
> It helps... a lot!
I guess an update to String.startsWith should be handled separately from this
PR.
If startsWith will be optimized, then I'm happy to update this PR to use
startsWith as you suggested. Then ZipCoder will speed up for
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Thu, 9 Feb 2023 11:07:17 GMT, Claes Redestad wrote:
> Could be interesting to see if special-casing `startsWith` to call `equals`
> when possible would help:
It helps... a lot!
Benchmark (size) Mode CntScore Error Units
ZipFileGetEntry.getEntryHit
On Wed, 8 Feb 2023 15:53:52 GMT, Tyler Steele wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2021,
> 1. test/jdk/jni/nullCaller/NullCallerTest.java
> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>
> The above tests were blocked on AIX [@require os.family != "aix"] because
> these tests are
On Wed, 8 Feb 2023 16:36:16 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Wed, 8 Feb 2023 21:30:29 GMT, David Holmes wrote:
> It just occurred to me that we may also need to update the test makefiles to
> link to libpthread for these modified tests?
Running test
'jtreg:test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java'
Passed:
On Thu, 9 Feb 2023 10:05:06 GMT, Claes Redestad wrote:
> Should be a win and avoids the need for a new mismatch method here.
Interestingly, this is not a win:
PR:
Benchmark (size) Mode CntScore Error Units
ZipFileGetEntry.getEntryHit 512
Please review this documentation-only change which fixes incorrect
capitalization when referencing "aToIndex" and "bToIndex" in the Javadocs
of Arrays.compare and Arrays.mismatch.
https://github.com/openjdk/jdk/pull/12488
Thanks,
Eirik.
On Wed, 8 Feb 2023 16:36:16 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Thu, 9 Feb 2023 08:48:17 GMT, SUN Guoyun wrote:
>> Hi all,
>> When -Xcomp be used, this testcase will use more codecaches, causing the GC
>> to be triggered early, then causing this test failed on LoongArch64
>> architecture.
>>
>> This PR fix the issue, Please help review it.
>>
>>
On Wed, 8 Feb 2023 16:36:16 GMT, Eirik Bjorsnos wrote:
>> After finding a hash match, getEntryPos needs to compare the lookup name up
>> to the encoded entry name in the CEN. This comparison is done by decoding
>> the entry name into a String. The names can then be compared using the
>>
On Wed, 8 Feb 2023 11:16:14 GMT, Maurizio Cimadamore
wrote:
>> `ofSymbols` is an alternative to `of` when conflicting method parameters.
>> In such case `of` refers to CP entries and `ofSymbols` refer to independent
>> symbols describing the objects, like for example `ClassDesc`,
>>
> Hi all,
> When -Xcomp be used, this testcase will use more codecaches, causing the GC
> to be triggered early, then causing this test failed on LoongArch64
> architecture.
>
> This PR fix the issue, Please help review it.
>
> Thanks.
SUN Guoyun has updated the pull request incrementally
64 matches
Mail list logo
