On Thu, 16 Mar 2023 21:25:44 GMT, Viktor Klang wrote:
>> Addresses the situation where exceptional completion of `orTimeout`:ed
>> CompletableFutures wouldn't cancel the timeout task which could lead to
>> memory leaks if done frequently enough with long enough timeout durations.
>>
>> Fix dis
While using ClassDesc, I find that it is somewhat hard to convert it
to a binary or internal name as calling substring makes the code much
more complex, especially when we know that the given ClassDesc is a
class or interface.
Thus, I propose an API serving as the inverse of
ClassDesc::of(String),
On Thu, 16 Mar 2023 21:30:04 GMT, Naoto Sato wrote:
>> This is a blocker for
>> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
>> weed out non-class files for calling `ClassReader` by checking the file
>> extension. Regression tests are not provided as it is not poss
On Wed, 15 Mar 2023 08:44:34 GMT, Adam Sotona wrote:
> Massive parallel execution of parametrised CorpusTest junit tests revealed
> race condition in
> `ClassHierarchyImpl.CachedClassHierarchyResolver::getClassInfo`.
>
> The race condition may skip calculation of the ClassHierarchyInfo. In thi
> The StreamPumper is fixed to process the last line even it is not finishes
> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify
> that tests are not broken.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
t
On Fri, 17 Mar 2023 00:02:12 GMT, Leonid Mesnik wrote:
>> The StreamPumper is fixed to process the last line even it is not finishes
>> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify
>> that tests are not broken.
>
> Leonid Mesnik has updated the pull request incremen
> This is needed for performance improvements in support of virtual threads.
> The update includes the following:
>
> 1. Refactored the `VirtualThread` native methods:
> `notifyJvmtiMountBegin` and `notifyJvmtiMountEnd` =>
> `notifyJvmtiMount`
> `notifyJvmtiUnmountBegin` and `not
On Thu, 16 Mar 2023 20:43:30 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove main related constants, update specification for initialization
>> constants
>
> src/java.base/share/classes/java/
> Add String constants INIT_NAME, CLASS_INIT_NAME, MTD_void for the names and
> method type of instance and class initializers; add String constant MAIN_NAME
> and MTD_void_StringArray for the name and method type of main method.
>
> Update occurrences of and in core libraries API specificatio
> Add String constants INIT_NAME, CLASS_INIT_NAME, MTD_void for the names and
> method type of instance and class initializers; add String constant MAIN_NAME
> and MTD_void_StringArray for the name and method type of main method.
>
> Update occurrences of and in core libraries API specificatio
On Thu, 16 Mar 2023 14:42:10 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
On Thu, 16 Mar 2023 06:19:14 GMT, Thomas Stuefe wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comments added
>
> That also affects OutputAnalyzer, right? Does this affect parsing or is this
> only printing?
>
> The StreamPumper is fixed to process the last line even it is not finishes
> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify
> that tests are not broken.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
f
This is similar to many other issues we had with `hdiutil` failures. Fixed in
similar way by repeating `hdiutil` command. Cannot confirm that it will resolve
this issue, but similar issues got resolved by repeating command. Also,
switched writing output from `hdiutil` to file. It is known issue
On Thu, 16 Mar 2023 08:14:25 GMT, Varada M wrote:
> jdk/test/jdk/tools/jimage/VerifyJimage.java is failing because the module
> java.base is not exporting jdk.internal.org.objectweb.asm to module
> jdk.jshell.
>
> Reported Issue : [JDK-8304320](https://bugs.openjdk.org/browse/JDK-8304320)
I
On Thu, 16 Mar 2023 21:30:04 GMT, Naoto Sato wrote:
>> This is a blocker for
>> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
>> weed out non-class files for calling `ClassReader` by checking the file
>> extension. Regression tests are not provided as it is not poss
On Thu, 2 Mar 2023 22:35:52 GMT, Brian Burkhalter wrote:
>> Break up `BigIntegerTest` and `SymmetricRangeTests` into subsets which are
>> run quasi-randomly as a function of second within the minute at the time the
>> test is running. `LargeValueExceptions` does not appear amenable to this
>>
On Thu, 16 Mar 2023 15:20:27 GMT, Chen Liang wrote:
>> Possible extensions of `ClassHierarchyResolver` factories, or maybe even
>> extensions of the default resolver are on the table and I just planned to
>> open this discussion.
>>
>> Here is specific case where original code passes `ClassLoa
On Thu, 16 Mar 2023 10:47:01 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since t
On Thu, 16 Mar 2023 09:08:08 GMT, Matthias Baesken wrote:
>> The test fails on Alpine Linux 3.17, when checking the environment variable
>> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
>> test expects. It turned out that at least on Linux (probably also on other
> This is a blocker for
> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
> weed out non-class files for calling `ClassReader` by checking the file
> extension. Regression tests are not provided as it is not possible to detect
> the fix from the artifact jimage, but ma
On Thu, 16 Mar 2023 20:51:29 GMT, Pavel Rappo wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Making the test for orTimeout+completeExceptionally only based on
>> iterations and not duration.
>
> test/jdk/java/uti
> Addresses the situation where exceptional completion of `orTimeout`:ed
> CompletableFutures wouldn't cancel the timeout task which could lead to
> memory leaks if done frequently enough with long enough timeout durations.
>
> Fix discussed with @DougLea
Viktor Klang has updated the pull reque
On Thu, 16 Mar 2023 21:21:51 GMT, Viktor Klang wrote:
>> Addresses the situation where exceptional completion of `orTimeout`:ed
>> CompletableFutures wouldn't cancel the timeout task which could lead to
>> memory leaks if done frequently enough with long enough timeout durations.
>>
>> Fix dis
On Thu, 16 Mar 2023 20:51:29 GMT, Pavel Rappo wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update
>> test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java
>>
>> C
On Thu, 16 Mar 2023 20:43:38 GMT, Naoto Sato wrote:
> This is a blocker for
> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
> weed out non-class files for calling `ClassReader` by checking the file
> extension. Regression tests are not provided as it is not possible
On Thu, 16 Mar 2023 20:54:49 GMT, Mandy Chung wrote:
> > confirmed it would effectively weed out `LineBreakIteratorData_th`,
> > `WordBreakIteratorData_th`, and `thai_dict` files by running
> > IncludeLocalesPluginTest.java.
>
> I think you meant these files are filtered out but they remain in
On Thu, 16 Mar 2023 20:43:38 GMT, Naoto Sato wrote:
> This is a blocker for
> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
> weed out non-class files for calling `ClassReader` by checking the file
> extension. Regression tests are not provided as it is not possible
On Thu, 16 Mar 2023 16:58:53 GMT, Chen Liang wrote:
> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>
> Add a test to validate that all constants in ConstantDescs can be resolved
> with a minimally-trusted lookup, and select constants represent the objects
> they claim to b
On Thu, 16 Mar 2023 20:51:37 GMT, Viktor Klang wrote:
>> Addresses the situation where exceptional completion of `orTimeout`:ed
>> CompletableFutures wouldn't cancel the timeout task which could lead to
>> memory leaks if done frequently enough with long enough timeout durations.
>>
>> Fix dis
> Addresses the situation where exceptional completion of `orTimeout`:ed
> CompletableFutures wouldn't cancel the timeout task which could lead to
> memory leaks if done frequently enough with long enough timeout durations.
>
> Fix discussed with @DougLea
Viktor Klang has updated the pull reque
On Tue, 14 Mar 2023 14:30:32 GMT, Chen Liang wrote:
> Add String constants INIT_NAME, CLASS_INIT_NAME, MTD_void for the names and
> method type of instance and class initializers; add String constant MAIN_NAME
> and MTD_void_StringArray for the name and method type of main method.
>
> Update o
This is a blocker for
[JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to weed
out non-class files for calling `ClassReader` by checking the file extension.
Regression tests are not provided as it is not possible to detect the fix from
the artifact jimage, but manually con
On Thu, 16 Mar 2023 18:40:16 GMT, Mandy Chung wrote:
>> There is no common binary format for "localedata", the file in question is
>> the custom format specific for `BreakIterator`, ancient code from Taligent.
>> IIUC, only description of the format is in the source:
>> https://github.com/open
On Thu, 16 Mar 2023 13:37:10 GMT, Viktor Klang wrote:
> Addresses the situation where exceptional completion of `orTimeout`:ed
> CompletableFutures wouldn't cancel the timeout task which could lead to
> memory leaks if done frequently enough with long enough timeout durations.
>
> Fix discusse
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote:
>> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>>
>> Add a test to validate that all constants in ConstantDescs can be resolved
>> with a minimally-trusted lookup, and select constants represent the objects
>> they claim
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote:
>> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>>
>> Add a test to validate that all constants in ConstantDescs can be resolved
>> with a minimally-trusted lookup, and select constants represent the objects
>> they claim
On Thu, 16 Mar 2023 13:37:10 GMT, Viktor Klang wrote:
> Addresses the situation where exceptional completion of `orTimeout`:ed
> CompletableFutures wouldn't cancel the timeout task which could lead to
> memory leaks if done frequently enough with long enough timeout durations.
>
> Fix discusse
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote:
>> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>>
>> Add a test to validate that all constants in ConstantDescs can be resolved
>> with a minimally-trusted lookup, and select constants represent the objects
>> they claim
On Thu, 16 Mar 2023 18:40:12 GMT, Chen Liang wrote:
>> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>>
>> Add a test to validate that all constants in ConstantDescs can be resolved
>> with a minimally-trusted lookup, and select constants represent the objects
>> they claim
On Thu, 2 Mar 2023 20:00:56 GMT, Martin Buchholz wrote:
> Inviting @DougLea and @viktorklang-ora to review.
>
> As usual, I couldn't resist more fiddling.
> - Added missing tests for take, remove(), remove(Object).
> - Improved DelayQueueTest's testing infrastructure
> - added more test assert
On Wed, 15 Mar 2023 02:18:37 GMT, Chen Liang wrote:
> Add Constant Descriptors for DirectMethodHandleDesc of
> MethodHandles::classData and classDataAt in ConstantDescs. This facilitates
> easier access of class data via condy in Classfile API-generated bytecode.
> Most other constant bootstra
On Wed, 15 Mar 2023 19:53:07 GMT, Naoto Sato wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Wed, 15 Mar 2023 19:50:46 GMT, Naoto Sato wrote:
>> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
>> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
>> `DAY_OF_WEEK` combo.
>>
>> For example, Rolling _Monday, 30 December 2019_ by 1 week produced
On Thu, 16 Mar 2023 17:00:59 GMT, Naoto Sato wrote:
>> @naotoj as these localedata resource files are not `.class`, the plugin
>> should not use ASM (or Classfile API) to parse it but ASM ClassReader just
>> happens to work. Is the format documented anywhere?
>>
>> @asotona I agree that thi
On Thu, 16 Mar 2023 18:12:23 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switch to DataProvider
>
> test/jdk/java/lang/constant/ConstantDescsTest.java line 65:
>
>> 63: */
>> 64: @Test
> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>
> Add a test to validate that all constants in ConstantDescs can be resolved
> with a minimally-trusted lookup, and select constants represent the objects
> they claim to be.
Chen Liang has updated the pull request incrementa
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in t
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
> .properties files as UTF-8 during the conversion fro
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>> - Redo translation for CS.properti
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in t
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>> - Redo translation for CS.properties
>>
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
> .properties files as UTF-8 during the conversion fro
On Thu, 16 Mar 2023 16:58:53 GMT, Chen Liang wrote:
> https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
>
> Add a test to validate that all constants in ConstantDescs can be resolved
> with a minimally-trusted lookup, and select constants represent the objects
> they claim to b
https://github.com/openjdk/jdk/pull/13033#issuecomment-1470857327
Add a test to validate that all constants in ConstantDescs can be resolved with
a minimally-trusted lookup, and select constants represent the objects they
claim to be.
-
Commit messages:
- Whitespace
- constantdes
On Thu, 16 Mar 2023 16:18:46 GMT, Mandy Chung wrote:
>> The file `LineBreakIteratorData_th` is not a class file, thus the exception
>> is appropriate. This plugin test is trying to verify the integrity of the
>> generated jimage, not only the required class files for the specified
>> locale, b
On Thu, 16 Mar 2023 08:43:46 GMT, Alan Bateman wrote:
> jshell was migrated to new the class file API in JDK-8294974 so it shouldn't
> have any references to ASM anymore. Would it be possible to check if you have
> a mismatch between your build and the test?
Hi @AlanBateman. The changes from J
On Thu, 16 Mar 2023 16:06:15 GMT, Naoto Sato wrote:
>> This plugin does not fit to the Classfile API use cases portfolio at all.
>> Here it is only needed to get interfaces list out of the constant pool and
>> then the Utf8 CP entries are in-place modified. That is out of the Classfile
>> API
On Thu, 16 Mar 2023 07:51:25 GMT, Adam Sotona wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/IncludeLocalesPlugin.java
>> line 160:
>>
>>> 158:
>>> resource.type().equals(ResourcePoolEntry.Type.CLASS_OR_RESOURCE)) {
>>> 159: byte[
On Thu, 16 Mar 2023 13:26:35 GMT, Leonid Mesnik wrote:
> The test depends on the jtreg stack and should be updated.
> The fix is backported from loom repo where jtreg with CODETOOLS-7903373 is
> used.
> Tested with current promoted jtreg (without CODETOOLS-7903373) by running
> test.
Marked as
On Wed, 15 Mar 2023 06:16:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes
> `javax/script/Test7.java` from the ProblemList?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8304225, this test no longer
> fails and passes just like the other tests in `jav
On Wed, 15 Mar 2023 06:16:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes
> `javax/script/Test7.java` from the ProblemList?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8304225, this test no longer
> fails and passes just like the other tests in `jav
On Thu, 16 Mar 2023 14:50:14 GMT, Alan Bateman wrote:
>> test/jdk/java/util/ServiceLoader/BadProvidersTest.java line 216:
>>
>>> 214: clb.withSuperclass(CD_Object);
>>> 215: clb.withFlags(AccessFlag.PUBLIC, AccessFlag.SUPER);
>>> 216: var provider$1Desc = Clas
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
On Thu, 16 Mar 2023 13:21:38 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 426:
>>
>>> 424: */
>>> 425: localCache.computeIfAbsent(classDesc, cd -> {
>>> 426: try {
>>
>> This probably can b
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
On Tue, 14 Mar 2023 07:53:25 GMT, Alan Bateman wrote:
> This is class descriptor for ProviderFactory$1, not "Provider" so maybe
> rename this to providerFactory1 or something a bit clearer.
The updated version looks good. I assume you'll do a pass over the updated
tests to bump their copyright
On Thu, 16 Mar 2023 14:17:12 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Wed, 15 Mar 2023 04:09:04 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>> 2.
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Thu, 9 Mar 2023 14:41:47 GMT, Chen Liang wrote:
>> Isn't the "unrelated process such as generating lambda forms" critical for
>> the `ProxyGenerator` functionality?
>
> More accurately, I mean the overhead generated by this:
> https://github.com/openjdk/jdk/blob/1e9942aa112edca33f964db127df6
Thanks Leonid!
Kosta
--- Original Message ---
On Thursday, March 16th, 2023 at 2:29 PM, Leonid Mesnik
wrote:
> Hi
>
> I’ve sent fix out for review: https://github.com/openjdk/jdk/pull/13058
>
> Leonid
>
> From: Tobias Hartmann
> Date: Thursday, March 16, 2023 at 12:20 AM
> To: Kos
On Thu, 16 Mar 2023 13:26:35 GMT, Leonid Mesnik wrote:
> The test depends on the jtreg stack and should be updated.
> The fix is backported from loom repo where jtreg with CODETOOLS-7903373 is
> used.
> Tested with current promoted jtreg (without CODETOOLS-7903373) by running
> test.
Marked as
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
improved met
On Wed, 15 Mar 2023 04:09:04 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>> 2.
Addresses the situation where exceptional completion of `orTimeout`:ed
CompletableFutures wouldn't cancel the timeout task which could lead to memory
leaks if done frequently enough with long enough timeout durations.
Fix discussed with @DougLea
-
Commit messages:
- Adding a regre
The test depends on the jtreg stack and should be updated.
The fix is backported from loom repo where jtreg with CODETOOLS-7903373 is used.
Tested with current promoted jtreg (without CODETOOLS-7903373) by running test.
-
Commit messages:
- 8304314: StackWalkTest.java fails after COD
Hi
I’ve sent fix out for review: https://github.com/openjdk/jdk/pull/13058
Leonid
From: Tobias Hartmann
Date: Thursday, March 16, 2023 at 12:20 AM
To: Kosta Stojiljkovic , core-libs-dev@openjdk.org
Cc: Leonid Mesnik
Subject: Re: jtreg test test/jdk/java/lang/StackWalker/StackWalkTest.java fa
On Sat, 11 Mar 2023 13:45:23 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 196 commits:
>>
>> - Merge branch 'master' into JDK-8294961-proxy
>> - Merge branch 'master' into JDK-8294961-pro
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Thu, 16 Mar 2023 09:03:36 GMT, Matthias Baesken wrote:
>> test/jdk/tools/jpackage/share/AppLauncherEnvTest.java line 93:
>>
>>> 91: } else {
>>> 92: TKit.assertEquals(expectedEnvVarValue, actualEnvVarValue,
>>> msg);
>>> 93: }
>>
>> I'd keep the check as a single
On Thu, 16 Mar 2023 09:08:08 GMT, Matthias Baesken wrote:
>> The test fails on Alpine Linux 3.17, when checking the environment variable
>> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
>> test expects. It turned out that at least on Linux (probably also on other
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply sugges
On Tue, 14 Mar 2023 17:12:50 GMT, Chen Liang wrote:
> Such an API allows creating TypeKind from both Class and ClassDesc than
> having to call descriptorString() explicitly at every use site.
>
> See
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000240.html
> for context.
On Thu, 2 Mar 2023 21:34:28 GMT, Bill Huang wrote:
> The purpose of this task is to add the difference between -manual jdk_core
> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order
> to streamline the manual test execution process, a new test group called
> jdk_core_ma
On Wed, 15 Mar 2023 18:53:08 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the
> sharing mechanism for upcall stubs to AbstractLinker.
This pull request has now been integrated.
Changeset: d4eb3953
Author:Jorn Vernee
URL:
https://g
> Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the
> sharing mechanism for upcall stubs to AbstractLinker.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains five commits:
- Merge branch 'master'
> This PR proposes changing old-type switch statements to newer forms of switch.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Pretty case statements
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13047/files
-
On Wed, 15 Mar 2023 18:10:29 GMT, Per Minborg wrote:
> This PR proposes changing old-type switch statements to newer forms of switch.
This pull request has now been integrated.
Changeset: dfc7214a
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/dfc7214a3ed28f679d7404954d5
> This PR proposes changing old-type switch statements to newer forms of switch.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update after comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13047/files
- n
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Wed, 15 Mar 2023 18:34:50 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reintroduce missing comment
>
> src/java.base/share/classes/jdk/internal/foreign/abi/riscv64/linux/TypeClass.jav
On Thu, 16 Mar 2023 09:40:30 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
>> line 219:
>>
>>> 217: case Binding.Cast unused-> true;
>>> 218: };
>>> 219: }
>>
>> I'd go a bit further here and visuall
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
remaining cleanup in SystemModulesPlugin
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
implementation of custom ResourceHelper in Inc
On Wed, 15 Mar 2023 19:38:53 GMT, Jorn Vernee wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reintroduce missing comment
>
> src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java
> line
1 - 100 of 109 matches
Mail list logo
