On Thu, 11 May 2023 09:22:44 GMT, Raffaello Giulietti
wrote:
>> When appropriate and useful, copies only the relevant portion of the
>> `CharSequence` to the match result.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
On Tue, 16 May 2023 13:38:03 GMT, Claes Redestad wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added some randomness in tests.
>
> src/java.base/share/classes/java/util/regex/Matcher.java line 1381:
>
>>
On Tue, 16 May 2023 06:53:49 GMT, Alan Bateman wrote:
>> Nagata-Haruhito has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Nagata-Haruhito has updated the pull request incrementally with three
additional commits since the last revision:
- Merge branch
On Tue, 16 May 2023 22:36:51 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a simpler method for composing symbol lookups. It is common
>> for clients to chain multiple symbol lookups together, e.g. to find a symbol
>> in multiple libraries.
>>
>> A new instance method, namely
On 16/05/2023 19:03, - wrote:
For FFI, I would prefer some parts of the FFI, especially generic ones
like Indirect Var Handles, to be promoted from the preview status.
They are useful for non-FFI purposes.
These parts (e.g. the additional var handle combinators in
MethodHandles) are the only
> This patch adds a simpler method for composing symbol lookups. It is common
> for clients to chain multiple symbol lookups together, e.g. to find a symbol
> in multiple libraries.
>
> A new instance method, namely `SymbolLookup::or` is added, which first
> searches a symbol in the first
This is a follow-on to
[JDK-8264699](https://bugs.openjdk.org/browse/JDK-8264699) which adds JVMTI
PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec
update, although JDI needs minor changes to properly throw the correct
exception. Note this PR needs JDK-8264699 in
On Tue, 16 May 2023 15:17:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java
>> line 83:
>>
>>> 81: vtis = new
>>> VerificationTypeInfo[methodType.parameterCount()];
>>> 82: }
>>> 83: for(var arg :
Tightening up accessibility of a few nested classes. There is no practical
impact on source compatibility -- source uses within the package still work,
but by default the ability to reflectively call methods on these classes is
disabled.
-
Commit messages:
- JDK-8308239: Tighten
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote:
> Trivial fix that added missed useful command.
> Tested by running make of failure handler and verifying results.
This pull request has now been integrated.
Changeset: 563152f3
Author:Leonid Mesnik
URL:
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote:
> Trivial fix that added missed useful command.
> Tested by running make of failure handler and verifying results.
Marked as reviewed by stefank (Reviewer).
-
PR Review:
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote:
> Trivial fix that added missed useful command.
> Tested by running make of failure handler and verifying results.
This looks good and "trivial". Thanks for fixing this.
-
PR Comment:
On Mon, 15 May 2023 17:05:48 GMT, Jim Laskey wrote:
> InstanceMainTest does check precedence. Are you expecting a test for all
> combinations?
Sorry, we discussed this in previous comments, ignore my latest comment on this.
-
PR Review Comment:
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 29 commits:
- Merge branch 'master' into 8306112
- Requested Changes #2
- Update
On Tue, 16 May 2023 17:06:02 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a simpler method for composing symbol lookups. It is common
>> for clients to chain multiple symbol lookups together, e.g. to find a symbol
>> in multiple libraries.
>>
>> A new instance method, namely
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to
Trivial fix that added missed useful command.
Tested by running make of failure handler and verifying results.
-
Commit messages:
- 8308223
Changes: https://git.openjdk.org/jdk/pull/14018/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14018=00
Issue:
On Sat, 13 May 2023 14:11:11 GMT, Chen Liang wrote:
>> The jdk.internal.classfile.components package's interfaces have
>> implementations in their nested classes, which are implicitly public and
>> exported with the package. They are now moved to the impl package to avoid
>> unwanted
> The jdk.internal.classfile.components package's interfaces have
> implementations in their nested classes, which are implicitly public and
> exported with the package. They are now moved to the impl package to avoid
> unwanted exposures. Fixed a few minor javadoc issues in the interfaces as
On Wed, 10 May 2023 20:11:09 GMT, Naoto Sato wrote:
> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
> collation for Swedish to the modern one. In order to provide a means for
> users who need the old collation, this PR intends to make `Collator`
> recognize the
For FFI, I would prefer some parts of the FFI, especially generic ones
like Indirect Var Handles, to be promoted from the preview status.
They are useful for non-FFI purposes.
Has FFI API considered promoting APIs out of preview incrementally,
like how Virtual Threads and Scoped values are?
Chen
I have not seen any explanation of how this issue is going to be resolved.
Given the new information, shouldn’t the CSR review be reopened to re-evaluate
the cost/benefit analysis?
- Original Message -
> From: "Uwe Schindler"
> To: "core-libs-dev"
> Sent: Tuesday, May 16, 2023 5:38:32 PM
> Subject: JEP 442: Foreign Function & Memory API => why is it again preview
> API?
> Hi,
Hi Uwe,
>
> yesterday Apache Lucene got the information that JDK 21 got the project
>
Hi Alan,
Am 16.05.2023 um 18:07 schrieb Alan Bateman:
On 16/05/2023 16:38, Uwe Schindler wrote:
:
Is it really needed to have a next round of preview API? Why not have
Java 21 with Foreign API finalized in the same way like virtual
threads? To me it is strange that an API like virtual
On Tue, 16 May 2023 15:14:03 GMT, Ichiroh Takiguchi
wrote:
>> According to "JDK 20 Internationalization Guide"
>> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html
>> Following Solaris related Japanese charsets are in "contained in
>> jdk.charsets module" list.
>>
>> -
On Wed, 10 May 2023 23:54:37 GMT, Justin Lu wrote:
> Please review this javadoc only change which uses `@snippet` and `@linkplain`
> in i18n related util packages.
This pull request has now been integrated.
Changeset: 4e929918
Author:Justin Lu
URL:
> This patch adds a simpler method for composing symbol lookups. It is common
> for clients to chain multiple symbol lookups together, e.g. to find a symbol
> in multiple libraries.
>
> A new instance method, namely `SymbolLookup::or` is added, which first
> searches a symbol in the first
On Tue, 16 May 2023 16:55:21 GMT, Paul Sandoz wrote:
>> I was trying to split the sentence so that we could get a compact javadoc
>> header for the factory. How much important is that?
>
> Not very IHMO. I was just trying to say the same thing you said with less
> words, which makes it more
On Tue, 16 May 2023 16:50:34 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/SymbolLookup.java line 136:
>>
>>> 134: * lookup} More specifically, if a symbol is not found using this
>>> lookup, the provided lookup will be
>>> 135: * used as fallback.
On Fri, 12 May 2023 12:11:23 GMT, Maurizio Cimadamore
wrote:
> This patch adds a simpler method for composing symbol lookups. It is common
> for clients to chain multiple symbol lookups together, e.g. to find a symbol
> in multiple libraries.
>
> A new instance method, namely
On Tue, 16 May 2023 16:48:13 GMT, Paul Sandoz wrote:
>> This patch adds a simpler method for composing symbol lookups. It is common
>> for clients to chain multiple symbol lookups together, e.g. to find a symbol
>> in multiple libraries.
>>
>> A new instance method, namely `SymbolLookup::or`
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Reduce linking in File::toPath snippet
-
Changes:
- all:
On 16/05/2023 16:38, Uwe Schindler wrote:
It exists now since Java 14, where it first appeared as incubation. I
know theres still work on the foreign linker, but why aren't the
stable classes like MemorySegment, ValueLayout not public now?
Hi Uwe,
while I understand the frustration (and I'm
> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
> collation for Swedish to the modern one. In order to provide a means for
> users who need the old collation, this PR intends to make `Collator`
> recognize the `co` Unicode locale extension so that multiple
On 16/05/2023 16:38, Uwe Schindler wrote:
:
Is it really needed to have a next round of preview API? Why not have
Java 21 with Foreign API finalized in the same way like virtual
threads? To me it is strange that an API like virtual threads was
thrown to end-users (it caused problems at many
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote:
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
> files to specify `Locale.ROOT` to ensure that case conversion issues don't
> occur,
>
> I didn't add any new tests but ran tier 1-3 with no issues
LGTM. Nice
Hi,
yesterday Apache Lucene got the information that JDK 21 got the project
panama JEP 442 update and I implemented it already in our source tree.
Unfortunately the API is again marked "preview", but JDK 21 is "LTS
release". Many of our users (Elasticserach, Solr) will be switching to
this
On Tue, 16 May 2023 14:23:04 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> LinkedList replaced with ArrayList in benchmarks
>
>
> According to "JDK 20 Internationalization Guide"
> https://docs.oracle.com/en/java/javase/20/intl/supported-encodings.html
> Following Solaris related Japanese charsets are in "contained in jdk.charsets
> module" list.
>
> - PCK (x-PCK)
> - EUC_JP_Solaris (x-eucJP-Open)
>
> These are not
On Tue, 16 May 2023 08:17:02 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is
On Tue, 9 May 2023 19:13:42 GMT, Eric Caspole wrote:
>> These micros were developed while investigating JDK-8305670 by myself and
>> Sergey Kuksenko. The order of thread creation was important in that bug, so
>> there are 2 JMH for creating sleepers before and after the worker threads.
>
>
On Thu, 11 May 2023 09:22:44 GMT, Raffaello Giulietti
wrote:
>> When appropriate and useful, copies only the relevant portion of the
>> `CharSequence` to the match result.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote:
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
> files to specify `Locale.ROOT` to ensure that case conversion issues don't
> occur,
>
> I didn't add any new tests but ran tier 1-3 with no issues
Looks
On Tue, 16 May 2023 12:07:10 GMT, David Holmes wrote:
> > > I wonder if @Martin-Buchholz is able to look at this one?
> > > My concern with changes like this is that they fix an issue but then have
> > > unexpected side-effects themselves.
> >
> >
> > Are there any specific concerns you have?
On Tue, 16 May 2023 07:56:35 GMT, Thomas Stuefe wrote:
> > I wonder if @Martin-Buchholz is able to look at this one?
> > My concern with changes like this is that they fix an issue but then have
> > unexpected side-effects themselves.
>
> Are there any specific concerns you have?
There seems
Updated instances of `toLowerCase` and `toUpperCase` in several net and io
files to specify `Locale.ROOT` to ensure that case conversion issues don't
occur,
I didn't add any new tests but ran tier 1-3 with no issues
-
Commit messages:
- added some case conversions missed
On Mon, 15 May 2023 16:11:46 GMT, Volker Simonis wrote:
> > 2. I think you don't actually have to hand in the in-pipe-read-end fd
> > number via command line arg, just to have the child to close it. You could
> > just, in the parent, set the fd to FD_CLOEXEC. Since posix_spawn() exec's
> >
On Mon, 15 May 2023 19:06:16 GMT, Glavo wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - changed LinkedList to ArrayList in RebuildMethodBodies benchmark
>> - added RepeatedModelTraversal JMH benchmark
>
>
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in
On Mon, 15 May 2023 20:48:47 GMT, Brian Burkhalter wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308016: Fix link in
On Tue, 16 May 2023 07:24:31 GMT, David Holmes wrote:
> I wonder if @Martin-Buchholz is able to look at this one?
>
> My concern with changes like this is that they fix an issue but then have
> unexpected side-effects themselves.
Are there any specific concerns you have?
-
PR
On Mon, 15 May 2023 18:45:24 GMT, Roger Riggs wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly start
On Mon, 15 May 2023 17:04:54 GMT, Claes Redestad wrote:
>> I'm not questioning performance differences between list implementations.
>> The implementation of top level list for this benchmark is irrelevant
>> because ~10ns difference cannot affect ~100µs benchmark run.
>
> Fair point. The only
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start
On Mon, 15 May 2023 14:48:58 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is
On Tue, 16 May 2023 01:34:45 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target
On Tue, 16 May 2023 01:34:45 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target
59 matches
Mail list logo
