Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v5]

2023-06-09 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPath` to find and load the main class being > launched.

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 17:40:58 GMT, Mandy Chung wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> newline at end of test file > > test/jdk/java/net/URL/HandlersPkgPrefix/LargeClasspathWithPkgPrefix.java line > 115: >

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 16:42:21 GMT, Alan Bateman wrote: > I wouldn't normally suggest dropping an import and using a qualified class > name but "Handler" is a very generic class name, replacing it with "new > sun.net.www.protocol.jar.Handler()" might be clearer. I agree. I have now updated the

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v4]

2023-06-09 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPath` to find and load the main class being > launched.

Withdrawn: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

2023-06-09 Thread duke
On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos wrote: > Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature.

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v8]

2023-06-09 Thread Erik Joelsson
On Fri, 9 Jun 2023 23:04:33 GMT, Jiangli Zhou wrote: >> Original description for JDK-8307194 change: >> - >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >>

RFR: 8309622: Re-examine the cache mechanism in BaseLocale

2023-06-09 Thread Naoto Sato
This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the in-house cache with WeakHashMap, and removed the Key class as it is no longer needed (thus the original NPE will no longer be possible). Also

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

2023-06-09 Thread Brent Christian
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Uwe Schindler
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote: > Hi all, > > This pull request contains a backport of commit > [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v8]

2023-06-09 Thread Jiangli Zhou
> Original description for JDK-8307194 change: > - > This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/hotspot static libraries: > > - Build hotspot libjvm.a and JDK static libraries for >

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

2023-06-09 Thread Jiangli Zhou
On Fri, 9 Jun 2023 20:03:23 GMT, Erik Joelsson wrote: > All our builds succeeded, so this is looking pretty good now. Just a minor > suggestion left. Thanks a lot! > This combination of conditions is repeated 3 times. Maybe we could assign the > result to a variable (e.g.

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-09 Thread Man Cao
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Agree with the analysis that this race looks benign, and the slight change in

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

2023-06-09 Thread Erik Joelsson
On Thu, 8 Jun 2023 20:34:15 GMT, Jiangli Zhou wrote: >> Original description for JDK-8307194 change: >> - >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >>

RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Chris Hegarty
Hi all, This pull request contains a backport of commit [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chris Hegarty on 9 Jun 2023 and was

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v3]

2023-06-09 Thread Chris Hegarty
> A trivial use of the Vector API when run with the security manager and a > domain that does not grant permissions fails with > java.security.AccessControlException: access denied > ("java.util.PropertyPermission" > "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read"). > > The fix it

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Chris Hegarty
On Fri, 9 Jun 2023 18:12:36 GMT, Paul Sandoz wrote: >> Chris Hegarty has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add at bug and remove newline > > test/jdk/jdk/incubator/vector/VectorRuns.java line 74: > >> 72: return

Integrated: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Chris Hegarty
On Fri, 9 Jun 2023 13:02:18 GMT, Chris Hegarty wrote: > A trivial use of the Vector API when run with the security manager and a > domain that does not grant permissions fails with > java.security.AccessControlException: access denied > ("java.util.PropertyPermission" >

Re: RFR: JDK-8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

2023-06-09 Thread Serguei Spitsyn
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote: > On AIX , new jtreg test > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with > the output : > > --System.err:(294/28579)-- > STARTED DynamicLoadWarningTest::testLoadJavaAgent

Re: RFR: 8291065: Creating a VarHandle for a static field triggers class initialization [v11]

2023-06-09 Thread Paul Sandoz
On Thu, 8 Jun 2023 01:32:20 GMT, Chen Liang wrote: >> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`. >> >> A few implementation-detail methods in VarHandle are now documented with the >> implied constraints to avoid subtle problems in the future. Changed >>

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Sean Mullan
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Did you consider only showing the security settings if the "security" option is specified? Seems like a lot of data to show in

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Uwe Schindler
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote: >> A trivial use of the Vector API when run with the security manager and a >> domain that does not grant permissions fails with >> java.security.AccessControlException: access denied >> ("java.util.PropertyPermission" >>

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Paul Sandoz
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote: >> A trivial use of the Vector API when run with the security manager and a >> domain that does not grant permissions fails with >> java.security.AccessControlException: access denied >> ("java.util.PropertyPermission" >>

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-09 Thread Roger Riggs
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. I think the race is benign also but the change maintains the essential

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Mandy Chung
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >>

Re: RFR: JDK-8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

2023-06-09 Thread Chris Plummer
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote: > On AIX , new jtreg test > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with > the output : > > --System.err:(294/28579)-- > STARTED DynamicLoadWarningTest::testLoadJavaAgent

Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"

2023-06-09 Thread Amit Kumar
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote: > Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. > > `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM > error occurs it can not recover scoped values. > > Moving `runWith()` into the common subclass

Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote: > Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. > > `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM > error occurs it can not recover scoped values. > > Moving `runWith()` into the common subclass

RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations"

2023-06-09 Thread Andrew Haley
Move `runWith()` from `VirtualThread` to `BaseVirtualThread`. `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM error occurs it can not recover scoped values. Moving `runWith()` into the common subclass of both `VirtualThread` and `BoundVirtualThread` fixes the

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote: >> The test used a too-small heap for generic testing, and coupled with looking >> at `freeMemory()` it led to a less-than-ideal determinism of execution of >> the test. > > Viktor Klang has updated the pull request incrementally with one

Integrated: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

2023-06-09 Thread Mandy Chung
On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote: > The `RuntimeArguments` test verifies the VM arguments returned by > `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails > when running with GraalVM as it was created with `jlink --add-options` and > the application

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >>

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v4]

2023-06-09 Thread Jiangli Zhou
On Fri, 2 Jun 2023 14:04:23 GMT, Erik Joelsson wrote: > > Sounds good for solving the macosx `ar` limitation differently. I'll change > > that. We can also exclude the partial linking part for gcc (due the older > > tool issue that you've found). Any concerns with including partial linking >

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v12]

2023-06-09 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Uwe Schindler
On Fri, 9 Jun 2023 13:07:27 GMT, Chris Hegarty wrote: >> A trivial use of the Vector API when run with the security manager and a >> domain that does not grant permissions fails with >> java.security.AccessControlException: access denied >> ("java.util.PropertyPermission" >>

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Uwe Schindler
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote: >> A trivial use of the Vector API when run with the security manager and a >> domain that does not grant permissions fails with >> java.security.AccessControlException: access denied >> ("java.util.PropertyPermission" >>

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v5]

2023-06-09 Thread Vladimir Kozlov
On Fri, 9 Jun 2023 13:44:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >>

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Roger Riggs
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote: >> A trivial use of the Vector API when run with the security manager and a >> domain that does not grant permissions fails with >> java.security.AccessControlException: access denied >> ("java.util.PropertyPermission" >>

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Brian Burkhalter
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote: > enumeration(list) will create an enumeration, a list and an iterator whereas > the impl only requires an iterator > this PR drops the enumeration wrapper for binary constructor and just maps > the enumeration to an iterator for the

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPath` to find and load the main class being > launched.

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 15:01:47 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> newline at end of test file > > src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 186: > >> 184:

Re: RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Roger Riggs
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote: > New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration src/java.base/share/classes/sun/launcher/LauncherHelper.java line 65: > 63: import java.text.MessageFormat; > 64: import

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v2]

2023-06-09 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a > `jdk.internal.loader.URLClassPath` to find and load the main class being > launched.

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 14:55:50 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8308184? > > When an application is launched, the `app` classloader internally uses a >

RFR: 8281658: Add a security category to the java -XshowSettings option

2023-06-09 Thread Sean Coffey
New functionality in the -XshowSettings menu to display relevant information about JDK security configuration - Commit messages: - minor edits, copyright, descriptions etc - Merge branch 'master' into 8281658-showsettings-security - Merge branch 'master' into

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v5]

2023-06-09 Thread Christian Hagedorn
On Fri, 9 Jun 2023 13:44:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >>

Re: RFR: JDK-8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

2023-06-09 Thread Alan Bateman
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote: > On AIX , new jtreg test > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with > the output : > > --System.err:(294/28579)-- > STARTED DynamicLoadWarningTest::testLoadJavaAgent

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-09 Thread Alan Bateman
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. If I read the existing code correctly, ClassCache::get can't return null. If there are two

RFR: JDK-8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

2023-06-09 Thread Matthias Baesken
On AIX , new jtreg test com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with the output : --System.err:(294/28579)-- STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAgent()' SUCCESSFUL DynamicLoadWarningTest::testLoadJavaAgent

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

2023-06-09 Thread Maurizio Cimadamore
On Fri, 9 Jun 2023 13:40:47 GMT, Maurizio Cimadamore wrote: >> FWIW, it looks like this needs `@Test(expectedExceptions = >> IllegalArgumentException.class)` since range elements are not allowed for >> `byteOffsetHandle` > > Note sure - javadoc says: > > * @throws IllegalArgumentException if

Re: RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

2023-06-09 Thread Maurizio Cimadamore
On Thu, 8 Jun 2023 20:21:48 GMT, Jorn Vernee wrote: >> test/jdk/java/foreign/TestLayoutPaths.java line 125: >> >>> 123: } >>> 124: >>> 125: public void testByteOffsetHandleRange() { >> >> Missing `@Test`? > > FWIW, it looks like this needs `@Test(expectedExceptions = >

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v5]

2023-06-09 Thread Tobias Holenstein
> At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:CompileOnly=package/path/Class.method` > `-XX:CompileOnly=package/path/Class::method` >

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-09 Thread Viktor Klang
On Fri, 9 Jun 2023 11:53:32 GMT, Stefan Karlsson wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Decresing the number of iterations proportional to the increase in the max >> memory size > > I'm happy with the

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v4]

2023-06-09 Thread Christian Hagedorn
On Fri, 9 Jun 2023 13:24:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >>

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v4]

2023-06-09 Thread Tobias Holenstein
> At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:CompileOnly=package/path/Class.method` > `-XX:CompileOnly=package/path/Class::method` >

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
From: kulla-dev on behalf of Brian Goetz > I think there's something fishy going on. Yes, transformation lambdas become significantly slower when moved from ClassModel to Classfile (unless I missed anything else). I’ll do some experiments to get the performance back.

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property [v2]

2023-06-09 Thread Chris Hegarty
> A trivial use of the Vector API when run with the security manager and a > domain that does not grant permissions fails with > java.security.AccessControlException: access denied > ("java.util.PropertyPermission" > "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read"). > > The fix it

RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Chris Hegarty
A trivial use of the Vector API when run with the security manager and a domain that does not grant permissions fails with java.security.AccessControlException: access denied ("java.util.PropertyPermission" "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read"). The fix it minimal, as

Re: RFR: 8309727: Assert privileges while reading the jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK system property

2023-06-09 Thread Chris Hegarty
On Fri, 9 Jun 2023 13:02:18 GMT, Chris Hegarty wrote: > A trivial use of the Vector API when run with the security manager and a > domain that does not grant permissions fails with > java.security.AccessControlException: access denied > ("java.util.PropertyPermission" >

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v3]

2023-06-09 Thread Tobias Holenstein
On Wed, 17 May 2023 16:52:17 GMT, Vladimir Kozlov wrote: >> Tobias Holenstein has updated the pull request incrementally with 11 >> additional commits since the last revision: >> >> - Update TestStableUShort.java >> - Update TestStableUByte.java >> - Update TestStableShort.java >> - Update

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-09 Thread Stefan Karlsson
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote: >> The test used a too-small heap for generic testing, and coupled with looking >> at `freeMemory()` it led to a less-than-ideal determinism of execution of >> the test. > > Viktor Klang has updated the pull request incrementally with one

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Brian Goetz
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Brian Goetz
Observation: It's dramatic how injecting a tiny amount of shared mutable state ripples throughout the design. After thinking about this some more, I think the main problem is that we are still trying to have the cache be transparent, which means that Classfile is taking on all the complexity

Re: RFR: 8309303: jdk/internal/misc/VM/RuntimeArguments test ignores jdk/internal/vm/options

2023-06-09 Thread Alan Bateman
On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote: > The `RuntimeArguments` test verifies the VM arguments returned by > `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails > when running with GraalVM as it was created with `jlink --add-options` and > the application

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-09 Thread Viktor Klang
On Fri, 9 Jun 2023 09:45:33 GMT, Stefan Karlsson wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Decresing the number of iterations proportional to the increase in the max >> memory size > > Did you test if this

Re: RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

2023-06-09 Thread Viktor Klang
> The test used a too-small heap for generic testing, and coupled with looking > at `freeMemory()` it led to a less-than-ideal determinism of execution of the > test. Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Decresing the

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods [v2]

2023-06-09 Thread Claes Redestad
On Thu, 8 Jun 2023 16:15:21 GMT, Brett Okken wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove pointless comments > > src/java.base/share/classes/java/util/Arrays.java line 3845: > >> 3843: */ >>

Integrated: 8309665: Simplify Arrays.copyOf/-Range methods

2023-06-09 Thread Claes Redestad
On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint >

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods [v2]

2023-06-09 Thread Claes Redestad
> https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint > benchmark issues that come down to incurring slightly more JIT

RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors

2023-06-09 Thread Viktor Klang
The test used a too-small heap for generic testing, and coupled with looking at `freeMemory()` it led to a less-than-ideal determinism of execution of the test. - Commit messages: - Increasing minimum heap size to make the BasicCancelTest complete more timely, Changes:

test/jdk/java/foreign/TestLayouts.java fails on S390X

2023-06-09 Thread Vladimir Petko
Dear Maintainers, test/jdk/java/foreign/TestLayouts.java assumes little endian architecture and hardcoded string representation of int. This results in the following failure: -cut- test TestLayouts.testStructToString(): failure java.lang.AssertionError: expected [[i4](struct)] but found

Re: RFR: 8180892: Correct handling of annotations on parameters [v2]

2023-06-09 Thread Chen Liang
On Wed, 26 Apr 2023 14:46:53 GMT, Chen Liang wrote: >> This patch aims to correct handling of annotations on parameters with the >> help of `MethodParameters` attribute, which will be always available once >> #9862 is integrated. >> >> It utilizes and expands upon the existing parameter

Re: RFR: 8309702: Exclude java/lang/ScopedValue/StressStackOverflow.java from JTREG_TEST_THREAD_FACTORY=Virtual runs

2023-06-09 Thread Jaikiran Pai
On Fri, 9 Jun 2023 07:51:03 GMT, Alan Bateman wrote: > This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang > as part of the JEP 446 integration so it is running in a lot more > configurations now. It's unstable in some configurations, including >

RFR: 8309702: Exclude java/lang/ScopedValue/StressStackOverflow.java from JTREG_TEST_THREAD_FACTORY=Virtual runs

2023-06-09 Thread Alan Bateman
This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang as part of the JEP 446 integration so it is running in a lot more configurations now. It's unstable in some configurations, including JTREG_TEST_THREAD_FACTORY=Virtual runs. The implementation may need more

Integrated: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

2023-06-09 Thread Alan Bateman
On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote: > Thread.interrupted is used to "get and clear" the current thread's interrupt > status. When called from a virtual thread, the current implementation always > clears the carrier's interrupt status. There is no need to do this when the >

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Romain Manni-Bucau
On Tue, 11 Apr 2023 07:48:45 GMT, Jens Lidestrom wrote: >> enumeration(list) will create an enumeration, a list and an iterator whereas >> the impl only requires an iterator >> this PR drops the enumeration wrapper for binary constructor and just maps >> the enumeration to an iterator for the

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Jens Lidestrom
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote: > enumeration(list) will create an enumeration, a list and an iterator whereas > the impl only requires an iterator > this PR drops the enumeration wrapper for binary constructor and just maps > the enumeration to an iterator for the

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Benjamin Marwell
On Tue, 24 Jan 2023 06:54:19 GMT, Jaikiran Pai wrote: > PRs which do not have a corresponding bug tracker issue Will write to the mailing list - PR Comment: https://git.openjdk.org/jdk/pull/11718#issuecomment-1464897988

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Jaikiran Pai
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote: > enumeration(list) will create an enumeration, a list and an iterator whereas > the impl only requires an iterator > this PR drops the enumeration wrapper for binary constructor and just maps > the enumeration to an iterator for the

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Jaikiran Pai
On Mon, 16 Jan 2023 19:21:36 GMT, Romain Manni-Bucau wrote: >> enumeration(list) will create an enumeration, a list and an iterator whereas >> the impl only requires an iterator >> this PR drops the enumeration wrapper for binary constructor and just maps >> the enumeration to an iterator for

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Romain Manni-Bucau
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote: > enumeration(list) will create an enumeration, a list and an iterator whereas > the impl only requires an iterator > this PR drops the enumeration wrapper for binary constructor and just maps > the enumeration to an iterator for the

Re: RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Benjamin Marwell
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote: > enumeration(list) will create an enumeration, a list and an iterator whereas > the impl only requires an iterator > this PR drops the enumeration wrapper for binary constructor and just maps > the enumeration to an iterator for the

RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

2023-06-09 Thread Romain Manni-Bucau
enumeration(list) will create an enumeration, a list and an iterator whereas the impl only requires an iterator this PR drops the enumeration wrapper for binary constructor and just maps the enumeration to an iterator for the other case which should be a better compromise in practise. Another

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v9]

2023-06-09 Thread Adam Sotona
The tests use statically specified Transforms and each transformation also held set of options. Now the transformations hold static instance of Classfile context instead. Junit execute them in parallel for each individual class file being transformed, so one context is used in parallel

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v11]

2023-06-09 Thread Adam Sotona
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected

Re: RFR: 8309665: Simplify Arrays.copyOf/-Range methods

2023-06-09 Thread Alan Bateman
On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved > Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks > when copying the entire array, but it's resulted in a few lurking footprint >

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v10]

2023-06-09 Thread Adam Sotona
On Thu, 8 Jun 2023 16:35:28 GMT, Brian Goetz wrote: > I have a hard time imagining heavy parallel use here; concurrency against the > same cache would most likely come from accidental sharing.  So this is not > necessarily a problem.  Are you imagining differnet use cases? I think it is