Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
which is a conformance change to document some exceptions in the specification
of java.text.StringCharacterIterator.
-
Commit messages:
- copyright year
- init
Changes:
On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu wrote:
>> Please review this PR which refines the spec of `equals()` and `hashCode()`
>> in `java.text.Format` related classes.
>>
>> The current spec for most of these methods is either "_Overrides
>> _" or are incomplete/wrong (i.e. see
> Please review this PR which refines the spec of `equals()` and `hashCode()`
> in `java.text.Format` related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see `ChoiceFormat`).
>
> This fix adjusts the spec to provide a
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
> `java.text.ChoiceFormat` specification regarding its pattern.
>
> `j.text.ChoiceFormat` provides an example pattern in the class description,
> but beyond that it does not specify
On Fri, 1 Sep 2023 19:56:53 GMT, Justin Lu wrote:
>> Please review this PR which refines the spec of `equals()` and `hashCode()`
>> in `java.text.Format` related classes.
>>
>> The current spec for most of these methods is either "_Overrides
>> _" or are incomplete/wrong (i.e. see
On Fri, 1 Sep 2023 19:56:28 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607)
>> which clarifies the behavior of patterns in regards to the max integer
>> digits in j.text.DecimalFormat.
>>
>> The current specification (of `applyPattern`)
On Thu, 31 Aug 2023 11:45:31 GMT, Claes Redestad wrote:
> I think this overall looks reasonable, but I think a more thorough proof /
> test would help to build confidence that all these changes are semantically
> neutral.
>
> The `isLowerCaseEx` needs to explain why two lower-case codepoints
> Please review this PR which refines the spec of `equals()` and `hashCode()`
> in `java.text.Format` related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see `ChoiceFormat`).
>
> This fix adjusts the spec to provide a
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607)
> which clarifies the behavior of patterns in regards to the max integer
> digits in j.text.DecimalFormat.
>
> The current specification (of `applyPattern`) states that patterns do not set
> the value of max
On Thu, 31 Aug 2023 11:39:57 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add method CharacterDataLatin1#isLowerCaseEx
>
> src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.StringUpperLower.*"
>
>
>
> ## 1.
> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i)
> * cpu : intel xeon sapphire rapids
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote:
>> I think you may have missed the comment in the JBS issue. Logging means
>> running potentially arbitrary code, doing this at Runtime.halt time is
>> problematic. I thought the conclusion from the work on Runtime.exit was not
>> to log in
On Wed, 30 Aug 2023 23:39:31 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8315383
>
> Oliver Kopp has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove obsolete imports
sure, I can help.
-
PR
On Fri, 1 Sep 2023 08:14:26 GMT, Qing Xiao wrote:
> /test/jdk/tools/lib/tests/JImageValidator.java, tests in
> /test/jdk/tools/jlink and /test/jdk/tools/jimage use on
> com.sun.tools.classfile and should be converted to Classfile API.
It looks good, thanks.
-
PR Comment:
/test/jdk/tools/lib/tests/JImageValidator.java, tests in /test/jdk/tools/jlink
and /test/jdk/tools/jimage use on com.sun.tools.classfile and should be
converted to Classfile API.
-
Commit messages:
- migrate /test/jdk/tools/lib/tests/JImageValidator.java and tests in
In addition to the goals, scope, motivation, specification and requirement
notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
like to describe the most relevant decisions taken during the implementation of
this enhancement. These notes are organized by feature, may
On Thu, 31 Aug 2023 06:53:45 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8233160?
>
> It has been noted in https://bugs.openjdk.org/browse/JDK-8232753 that:
>
>> The java.vendor.url.bug property has been
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit directly from
> constant-folding of BitSets:
>
>
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit directly from
> constant-folding of BitSets:
>
>
On Fri, 1 Sep 2023 13:10:19 GMT, Matthias Baesken wrote:
> Hi Alan , Your assumption 'I assume the use of System.getProperty is
> problematic when running with a SM.' is most likely correct.
You'll need to test with a SM that denies reading the system property to be
sure. There are classes in
On Fri, 1 Sep 2023 12:36:28 GMT, Matthias Baesken wrote:
>> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>>
>> [JShell] Exception in thread "main" java.lang.IllegalStateException:
>> java.util.prefs.BackingStoreException: Couldn't get file lock.
>> [JShell] at
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
On Fri, 1 Sep 2023 12:36:28 GMT, Matthias Baesken wrote:
>> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>>
>> [JShell] Exception in thread "main" java.lang.IllegalStateException:
>> java.util.prefs.BackingStoreException: Couldn't get file lock.
>> [JShell] at
On Fri, 1 Sep 2023 12:36:28 GMT, Matthias Baesken wrote:
>> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>>
>> [JShell] Exception in thread "main" java.lang.IllegalStateException:
>> java.util.prefs.BackingStoreException: Couldn't get file lock.
>> [JShell] at
On Fri, 1 Sep 2023 12:36:28 GMT, Matthias Baesken wrote:
>> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>>
>> [JShell] Exception in thread "main" java.lang.IllegalStateException:
>> java.util.prefs.BackingStoreException: Couldn't get file lock.
>> [JShell] at
On Fri, 1 Sep 2023 12:36:28 GMT, Matthias Baesken wrote:
>> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>>
>> [JShell] Exception in thread "main" java.lang.IllegalStateException:
>> java.util.prefs.BackingStoreException: Couldn't get file lock.
>> [JShell] at
Hello Chen Liang,
The exploded image optimization step runs the newly built JDK (in the
exploded image) to generate data for itself. This means that if you
change something fundamental in the JDK core libraries or the JVM, that
may cause crashes in this build step. To diagnose further, you
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote:
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
>
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added notes to attributes
-
Changes:
On Thu, 31 Aug 2023 02:36:09 GMT, 温绍锦 wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> assert bounds check
>
> @cl4es can you help me to review this PR?
> @wenshao How about of approach used in [James Anhalt's
>
> Optimization for:
> Integer.toString
> Long.toString
> StringBuilder#append(int)
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.lang.Integers.toString*"
> make test TEST="micro:java.lang.Longs.toString*"
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Fri, 1 Sep 2023 11:26:48 GMT, Alan Bateman wrote:
>> Ok. If the thread can run native code as part of the mount / unmount, and
>> the sampler can see the intermediary state there too, the check is needed.
>
> Thanks. One other thing that I see when more testing with generational ZGC is
>
On Thu, 31 Aug 2023 19:53:17 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> assert bounds check
>
> src/java.base/share/classes/java/lang/StringUTF16.java line 1585:
>
>> 1583:
On Fri, 1 Sep 2023 10:47:25 GMT, Markus Grönlund wrote:
>> Just to add that Patricio suggested today to run the stress tests with
>> -Xint and that does lead to triggering the assert quickly when the thread is
>> sampled in native. There are several native methods that are
>>
On Wed, 30 Aug 2023 15:10:45 GMT, Srinivas Vamsi Parasa
wrote:
>>> Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java
>>> is triggering the intrinsic without additional flags
>>
>> Just to add that Sorting.java has short and long run modes. The default when
>> running
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit
On Wed, 30 Aug 2023 13:56:42 GMT, Alan Bateman wrote:
> In the virtual thread implementation, thread identity switches to the carrier
> before freezing and switches back to the virtual thread after thawing. This
> was a forced move due to issues getting JVMTI to work with virtual threads.
>
On Thu, 31 Aug 2023 19:28:50 GMT, Alan Bateman wrote:
>> There are some native methods that we execute during mount/unmount
>> transitions. From what I see they all seem to be defined as
>> `@IntrinsicCandidate`, but if for some reason we don't execute the intrinsic
>> version (interp only
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit
On Fri, 1 Sep 2023 09:07:34 GMT, Per Minborg wrote:
> > Maybe it would make sense to start with a JDK-internal variant before
> > exploring potential public API?
>
> This is certainly one alternative.
When looking at this I thought about that too. It seems like the particular
case where this
On Fri, 1 Sep 2023 09:00:32 GMT, Hannes Greule wrote:
> Maybe it would make sense to start with a JDK-internal variant before
> exploring potential public API?
This is certainly one alternative.
-
PR Comment: https://git.openjdk.org/jdk/pull/15530#issuecomment-1702421871
On Fri, 1 Sep 2023 08:50:42 GMT, Chen Liang wrote:
> What about the missing functionalities, such as ranged get, cardinality,
> next/previousSet/ClearBit?
This was explored in https://github.com/openjdk/jdk/pull/15493
-
PR Comment:
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit
On Thu, 31 Aug 2023 16:47:07 GMT, Mandy Chung wrote:
> Would you consider documenting in the javadoc of XXXAttribute in the
> ClassFile API if it allows multiple? It will make clear to the readers.
Yes, I'll add that information as a part of javadoc update #14968.
Thanks!
-
PR
> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
> as user that is member of the Administrators group. In that case new files
> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
> the assumptions of the test's whoami check. My suggestion
On Thu, 31 Aug 2023 15:08:34 GMT, Roger Riggs wrote:
>> The problem with the environment variables is, that jtreg only passes very
>> few of them down to the testee process - USERDOMAIN and USERNAME are not
>> part of these as far as I know.
>
> ok, more overhead than value in the
On Fri, 25 Aug 2023 09:49:20 GMT, Alan Bateman wrote:
>> I want to add a log output similar to JDK-8301627 to Runtime.halt().
>> To avoid double logging of Runtime.exit(), add a flag to indicate whether
>> logging was done, and fix it so that logging is done only once.
>> Could someone please
This PR proposes adding a new method to BitSet that provides an immutable
snapshot of the set in the form of an `IntPredicate`.
The predicate is eligible for constant folding.
Here are some classes in the JDK that would benefit directly from
constant-folding of BitSets:
PoolReader (6)
On Thu, 31 Aug 2023 12:13:40 GMT, Adam Sotona wrote:
> ModuleTarget and ModuleResolution attributes were flagged as 'allow multiple'
> in the Classfile API.
> This patch removed the flags and allows at most one instance of each
> attribute.
>
> Please review.
>
> Thanks,
> Adam
This pull
On Fri, 25 Aug 2023 09:49:20 GMT, Alan Bateman wrote:
>> I want to add a log output similar to JDK-8301627 to Runtime.halt().
>> To avoid double logging of Runtime.exit(), add a flag to indicate whether
>> logging was done, and fix it so that logging is done only once.
>> Could someone please
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
on some RHEL Linux 8.X machines , we run into errors in test
tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below.
It looks like these errors occur when running the jtreg tests with higher
concurrency, I did not see them when running just the single test.
When adding some
On Wed, 30 Aug 2023 19:30:37 GMT, Mandy Chung wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove obsolete imports
>
> Looks good. Thanks for catching this.
>
> There are a few unused imports in
On Thu, 31 Aug 2023 14:29:41 GMT, iaroslavski wrote:
> Alan, you mentioned that DualPivotQuicksort will need detailed review. Can we
> go ahead and start reviewing? Laurent checked performance, JMH results look
> fine.
As before, I think the main question with this change is whether adding
61 matches
Mail list logo
