Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread David Holmes
On Fri, 3 Nov 2023 03:44:31 GMT, Leonid Mesnik wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >>

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

2023-11-02 Thread Vicente Romero
On Thu, 2 Nov 2023 20:48:45 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread Leonid Mesnik
On Fri, 3 Nov 2023 03:44:31 GMT, Leonid Mesnik wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >>

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread Leonid Mesnik
> The jtreg starts the main thread in a separate ThreadGroup and checks > unhandled exceptions for this group. However, it doesn't catch all unhandled > exceptions. There is a jtreg issue for this > https://bugs.openjdk.org/browse/CODETOOLS-7903526. > Catching such issues for virtual threads is

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

2023-11-02 Thread Mandy Chung
On Thu, 2 Nov 2023 20:48:45 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v3]

2023-11-02 Thread Sandhya Viswanathan
On Tue, 31 Oct 2023 07:19:55 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch optimizes sub-word gather operation for x86 targets with AVX2 and >> AVX512 features. >> >> Following is the summary of changes:- >> >> 1) Intrinsify sub-word gather with high performance backend

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v6]

2023-11-02 Thread Jorn Vernee
On Thu, 2 Nov 2023 23:19:24 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the

Re: RFR: 8319323: FFM: Harmonize the @throws tags in the javadocs

2023-11-02 Thread Jorn Vernee
On Thu, 2 Nov 2023 14:46:49 GMT, Per Minborg wrote: > This PR proposes to harmonize the @throws tags in the javadocs for the FFM > API. > > The @throws tags are using a bit different principles with respect to > formatting and ending with a period or not. > > Looking at some prominent Java

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v6]

2023-11-02 Thread Jorn Vernee
> Explicitly handle UpcallStub allocation failures by terminating. We currently > might try to use the returned `nullptr` which would fail sooner or later. > This patch just makes the termination explicit. Jorn Vernee has updated the pull request incrementally with one additional commit since

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-02 Thread Roger Riggs
On Thu, 2 Nov 2023 14:25:20 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v10]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v9]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

2023-11-02 Thread Lance Andersen
On Thu, 2 Nov 2023 18:21:07 GMT, Eirik Bjorsnos wrote: > > Thinking some more about this, I would like to see us keep the Zip > > generated by python, store it in a byte array (or equivalent) as it also > > validate that we can still process the zip given this was the original test > > and

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v6]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 14:53:44 GMT, Jim Laskey wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 973: >> >>> 971: abort(null, "java.launcher.cls.error3", >>> 972: mainMethod.getDeclaringClass().getName()); >>> 973: } >> >> The

Integrated: JDK-8319195: Move most tier 1 vector API regression tests to tier 3

2023-11-02 Thread Joe Darcy
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote: > Due to their longer-than-typical running time and because the vector API is > not (yet) in the base module, move the vector API tests in tier 1 to tier 2. This pull request has now been integrated. Changeset: 9dc40ba4 Author:Joe Darcy

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v8]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 17:53:12 GMT, Jim Laskey wrote: > I thought it was a clearer way to get rid of the side effect. It means LauncherHelper.checkAndLoadMain description will need to be updated as it says that it checks the public static void main method. But okay, I'll go through what you have

Re: RFR: 8318466: Improve spec of NumberFormat's methods with unsupported operations

2023-11-02 Thread Iris Clark
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote: > Please review this simple change which refines the specification of some > NumberFormat methods (with unsupported operations) to separate the API and > implementation specification. Marked as reviewed by iris (Reviewer). - PR

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v9]

2023-11-02 Thread Eirik Bjorsnos
On Mon, 30 Oct 2023 19:54:12 GMT, Lance Andersen wrote: > Thinking some more about this, I would like to see us keep the Zip generated > by python, store it in a byte array (or equivalent) as it also validate that > we can still process the zip given this was the original test and the zip is

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Rémi Forax
On Thu, 2 Nov 2023 12:24:31 GMT, Jim Laskey wrote: >> Uhmm. In the spec I see implicit classes named here: >> >> >> For reference, the following constructs are declared implicitly in source >> code, but are not marked as mandated because only formal parameters and >> modules can be so

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:21:02 GMT, Jan Lahoda wrote: >> No. It should be left at the first preview level. > > `UNNAMED_CLASSES` should probably be removed, as I think it is fully replaced > with `IMPLICIT_CLASSES`, and I don't think there are bootstrap problems here > (unlike in

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:30:40 GMT, Jan Lahoda wrote: >> Missed that. The issue is that Implicit Classes don't have any API and don't >> show up in the preview page. Fixed. > > Regarding removal of `UNNAMED_CLASSES` here, there was an API annotated using > this constant in `j.l.Class`

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jan Lahoda
On Thu, 2 Nov 2023 16:19:07 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v8]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v8]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:45:51 GMT, Alan Bateman wrote: >> Amazingly enough I seem to have the JNI straight on the first try. > >> Amazingly enough I seem to have the JNI straight on the first try. > > Oh, I wasn't expecting that. My comment was suggesting we change >

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:26:19 GMT, Jan Lahoda wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revised implicit class test > > test/jdk/java/lang/Class/ImplicitClass/TestImplicitClass.java line 25: > >> 23: >> 24: /*

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 15:45:03 GMT, Jim Laskey wrote: > Amazingly enough I seem to have the JNI straight on the first try. Oh, I wasn't expecting that. My comment was suggesting we change LauncherHelper.checkAndLoadMain to set both appClass and mainType after the validate succeeds.

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v7]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 17:17:42 GMT, Jan Lahoda wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revised implicit class test > > src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 33: > >> 31:

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Jan Lahoda
On Thu, 2 Nov 2023 11:55:50 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 249: >> >>> 247: STRING_TEMPLATES(JDK21, Fragments.FeatureStringTemplates, >>> DiagKind.PLURAL), >>> 248: UNNAMED_CLASSES(JDK21,

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Jan Lahoda
On Thu, 2 Nov 2023 14:52:46 GMT, Jim Laskey wrote: >> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 76: >> >>> 74: UNNAMED_CLASSES, >>> 75: @JEP(number=999, title="Implicit Classes and Instance Main >>> Methods") >>> 76: IMPLICIT_CLASSES, >>

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Mark Sheppard
On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung wrote: >> The test fails on windows because unmatched comparison of `Path.toString()` >> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to >> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. > > Mandy

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Mandy Chung
On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung wrote: >> The test fails on windows because unmatched comparison of `Path.toString()` >> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to >> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. > > Mandy

Re: RFR: 8318466: Improve spec of NumberFormat's methods with unsupported operations

2023-11-02 Thread Naoto Sato
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote: > Please review this simple change which refines the specification of some > NumberFormat methods (with unsupported operations) to separate the API and > implementation specification. LGTM - Marked as reviewed by naoto

Integrated: 8316969: Improve CDS module graph support for --module option

2023-11-02 Thread Calvin Cheung
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote: > Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main

Integrated: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar"

2023-11-02 Thread Mandy Chung
On Thu, 2 Nov 2023 01:00:38 GMT, Mandy Chung wrote: > The test fails on windows because unmatched comparison of `Path.toString()` > vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to > evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. This pull

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Jaikiran Pai
On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung wrote: >> The test fails on windows because unmatched comparison of `Path.toString()` >> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to >> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. > > Mandy

Re: RFR: 8316969: Improve CDS module graph support for --module option [v8]

2023-11-02 Thread Calvin Cheung
On Wed, 1 Nov 2023 11:26:48 GMT, Alan Bateman wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more comments from Alan and Ioi; copyright year update > > Marked as reviewed by alanb (Reviewer). Thanks

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v6]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 15:33:25 GMT, Maurizio Cimadamore wrote: >> Since there is no way to detect an implicit class, the test is no longer >> relevant. > > Right, but the test was still checking useful stuff - e.g. like the fact that > the class generated by javac was final, etc (in accordance

Re: RFR: 8319323: FFM: Harmonize the @throws tags in the javadocs

2023-11-02 Thread Roger Riggs
On Thu, 2 Nov 2023 14:46:49 GMT, Per Minborg wrote: > This PR proposes to harmonize the @throws tags in the javadocs for the FFM > API. > > The @throws tags are using a bit different principles with respect to > formatting and ending with a period or not. > > Looking at some prominent Java

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v5]

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 12:34:49 GMT, Jim Laskey wrote: >> Why is the test removed? > > Since there is no way to detect an implicit class, the test is no longer > relevant. Right, but the test was still checking useful stuff - e.g. like the fact that the class generated by javac was final, etc (in

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Mandy Chung
> The test fails on windows because unmatched comparison of `Path.toString()` > vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to > evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. Mandy Chung has updated the pull request incrementally with one

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Roger Riggs
On Thu, 2 Nov 2023 15:57:15 GMT, Mandy Chung wrote: >> The test fails on windows because unmatched comparison of `Path.toString()` >> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to >> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. > > Mandy

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" [v2]

2023-11-02 Thread Mandy Chung
On Thu, 2 Nov 2023 06:38:18 GMT, Jaikiran Pai wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review feedback > > test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java > line 185: > >>

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v6]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

RFR: 8319323: FFM: Harmonize the @throws tags in the javadocs

2023-11-02 Thread Per Minborg
This PR proposes to harmonize the @throws tags in the javadocs for the FFM API. The @throws tags are using a bit different principles with respect to formatting and ending with a period or not. Looking at some prominent Java classes like `List` and `Stream`, they: 1) Indent such that

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v5]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 13:53:02 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove MANDATED flag from implicit classes > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v5]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 14:38:06 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update JEP number in PreviewFeature > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 973: > >> 971:

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-02 Thread Raffaello Giulietti
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by > improving guarantees of internal invariants. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Restored ordering of exceptions. -

RFR: 8304446: javap --system flag doesn't override system APIs

2023-11-02 Thread Adam Sotona
Javap ignores --system option when searching for JDK classes. This patch prepends search over JDK system modules. Please review. Thanks, Adam - Commit messages: - 8304446: javap --system flag doesn't override system APIs Changes: https://git.openjdk.org/jdk/pull/16476/files

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Integrated: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Per Minborg
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote: > This PR proposes to fix a number of JavaDoc typos in the > `MemorySegment::getAtIndex` and `::setAtIndex`. This pull request has now been integrated. Changeset: cb20a3e7 Author:Per Minborg URL:

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v5]

2023-11-02 Thread Martin Doerr
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote: >> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, >> double values have only 4 Byte alignment within structures. This PR is based >> on JDK22 version of the FFI. > > Martin Doerr has updated the pull request

Integrated: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API

2023-11-02 Thread Martin Doerr
On Fri, 13 Oct 2023 10:12:24 GMT, Martin Doerr wrote: > The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, > double values have only 4 Byte alignment within structures. This PR is based > on JDK22 version of the FFI. This pull request has now been integrated.

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v5]

2023-11-02 Thread Jorn Vernee
On Wed, 1 Nov 2023 18:43:24 GMT, Martin Doerr wrote: >> Martin Doerr has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Improve handling of layouts in NativeType.java >> - Check byte order of 4-byte aligned double. > > Thanks for

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 12:04:22 GMT, Maurizio Cimadamore wrote: >> The class is discoverable but only as a regular class. > > Why is the test removed? Since there is no way to detect an implicit class, the test is no longer relevant. - PR Review Comment:

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v4]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 12:11:52 GMT, Maurizio Cimadamore wrote: >> The spec has been updated to include implicit classes. > > Uhmm. In the spec I see implicit classes named here: > > > For reference, the following constructs are declared implicitly in source > code, but are not marked as

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 11:53:09 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >> line 4057: >> >>> 4055: Name name = names.fromString(simplename); >>> 4056: JCModifiers implicitMods = F.at(Position.NOPOS) >>> 4057:

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 11:55:17 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java line 442: >> >>> 440: Errors.ClassPublicShouldBeInFile(topElement, >>> tree.name)); >>> 441: } >>> 442: if

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v3]

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 11:57:09 GMT, Jim Laskey wrote: >> test/langtools/tools/javac/processing/model/element/TestUnnamedClass.java >> line 1: >> >>> 1: /* >> >> Is the implicit class no longer discoverable through annotation processing? > > The class is discoverable but only as a regular class.

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v3]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 11:18:19 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove .orig files > > test/langtools/tools/javac/processing/model/element/TestUnnamedClass.java > line 1: > >>

Integrated: JDK-8315921: Invalid CSS declarations in java.lang class documentation

2023-11-02 Thread Hannes Wallnöfer
On Fri, 15 Sep 2023 13:56:21 GMT, Hannes Wallnöfer wrote: > This change fixes two errors in inline HTML styles in the `java.lang` > package: > > - wrong CSS property name in `java.lang.String` > - CSS declaration terminated by colon instead of semicolon in > `java.lang.Thread` > > Both

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v3]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 11:39:19 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Jim Laskey
On Thu, 2 Nov 2023 11:12:14 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove obsolete tests > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 249: > >>

Re: RFR: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote: > This PR proposes to fix a number of JavaDoc typos in the > `MemorySegment::getAtIndex` and `::setAtIndex`. Marked as reviewed by mcimadamore (Reviewer). - PR Review:

Re: RFR: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 11:50:13 GMT, Per Minborg wrote: >> This PR proposes to fix a number of JavaDoc typos in the >> `MemorySegment::getAtIndex` and `::setAtIndex`. > > src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2014: > >> 2012: * @throws IllegalArgumentException

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote: >> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >>

Provide thread-safe and concurrent sequenced collections with insertion order?

2023-11-02 Thread Sebastian Fischer
Hello. I am new to this list so might have missed previous discussion about this but could not find what I was looking for in the archives. The Sequenced collections JEP adds the following static methods to java.util.Collections. - unmodifiableSequencedCollection - unmodifiableSequencedSet -

Re: RFR: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Per Minborg
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote: > This PR proposes to fix a number of JavaDoc typos in the > `MemorySegment::getAtIndex` and `::setAtIndex`. src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2014: > 2012: * @throws IllegalArgumentException if

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v3]

2023-11-02 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote: >> This change fixes two errors in inline HTML styles in the `java.lang` >> package: >> >> - wrong CSS property name in `java.lang.String` >> - CSS declaration terminated by colon instead of semicolon in >> `java.lang.Thread` >> >>

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Wed, 25 Oct 2023 09:09:07 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/lang/Thread.java line 192: >> >>> 190: * with the following system properties: >>> 191: * >>> 192: * System properties >> >> Just out of curiosity, is that semi-colon even needed, or would >>

Re: RFR: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Maurizio Cimadamore
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote: > This PR proposes to fix a number of JavaDoc typos in the > `MemorySegment::getAtIndex` and `::setAtIndex`. src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 1997: > 1995: * @throws IndexOutOfBoundsException if

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
On Wed, 25 Oct 2023 09:04:37 GMT, Jaikiran Pai wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Find and fix more invalid CSS declarations > > Hello Hannes, the changes look fine to me. I wasn't aware we had

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Maurizio Cimadamore
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Maurizio Cimadamore
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Maurizio Cimadamore
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315921: Invalid CSS declarations in java.lang class documentation [v2]

2023-11-02 Thread Hannes Wallnöfer
> This change fixes two errors in inline HTML styles in the `java.lang` > package: > > - wrong CSS property name in `java.lang.String` > - CSS declaration terminated by colon instead of semicolon in > `java.lang.Thread` > > Both errors caused the style declarations to be ignored and an

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v5]

2023-11-02 Thread null
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote: >> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, >> double values have only 4 Byte alignment within structures. This PR is based >> on JDK22 version of the FFI. > > Martin Doerr has updated the pull request

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-02 Thread Alan Bateman
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

RFR: 8319166: Typos in the JavaDocs for MemorySegment

2023-11-02 Thread Per Minborg
This PR proposes to fix a number of JavaDoc typos in the `MemorySegment::getAtIndex` and `::setAtIndex`. - Commit messages: - Fix typos in the JavaDocs for MemorySegment Changes: https://git.openjdk.org/jdk/pull/16469/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16469=00

Re: RFR: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch

2023-11-02 Thread Jaikiran Pai
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote: > This test requires certain methods to be compiled, but without `-Xbatch` the > compiler races against the test code, which can lead to intermittent failures. Adding hotspot label because from the looks of this change, it appears to

Re: RFR: 8319153: Fix: Class is a raw type in ProcessTools

2023-11-02 Thread Jaikiran Pai
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote: > Changing from `Class c` to `Class c` removes two warnings. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1709548049

Re: RFR: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar"

2023-11-02 Thread Jaikiran Pai
On Thu, 2 Nov 2023 01:00:38 GMT, Mandy Chung wrote: > The test fails on windows because unmatched comparison of `Path.toString()` > vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to > evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does. Marked as