Re: RFR: 8331202: Support for Duration until another Instant [v2]

2024-04-29 Thread Stephen Colebourne
On Mon, 29 Apr 2024 21:32:16 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. >

Re: RFR: 8330182: Start of release updates for JDK 24 [v3]

2024-04-29 Thread Iris Clark
On Mon, 29 Apr 2024 22:50:26 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains seven addi

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Joe Wang
On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote: >> Proposing new overloaded methods in `java.io.Console` class that explicitly >> take a `Locale` argument. Existing methods rely on the default locale, so >> the users won't be able to format their prompts/outputs in a certain locale >> expl

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v10]

2024-04-29 Thread Tim Prinzing
On Mon, 29 Apr 2024 20:01:38 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.Fil

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Mandy Chung
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote: >> I'm looking at ways at reducing/eliminating startup overheads the classfile >> API in preparation of #17108, and have pushed a series of enhancements to >> that effect already. This PR is a collection of minor improvements which add >>

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Naoto Sato
On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > src/java.base/share/classes/java/io/Console.java line 193: > >> 191: * {@code locale}. >>

Re: RFR: 8330276: Console methods with explicit Locale

2024-04-29 Thread Naoto Sato
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote: > Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicit

Re: RFR: 8330276: Console methods with explicit Locale [v2]

2024-04-29 Thread Naoto Sato
> Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicitly. Naoto Sato has updated the pull request increment

Re: RFR: 8330182: Start of release updates for JDK 24 [v3]

2024-04-29 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Update deprecate

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-29 Thread Brent Christian
On Sat, 27 Apr 2024 11:58:52 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> new section for finalizer memviz > > src/java.base/share/classes/java/lang/ref/package-info.java line 157: > >> 155

Re: RFR: 8330276: Console methods with explicit Locale

2024-04-29 Thread Joe Wang
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote: > Proposing new overloaded methods in `java.io.Console` class that explicitly > take a `Locale` argument. Existing methods rely on the default locale, so the > users won't be able to format their prompts/outputs in a certain locale > explicit

Re: RFR: 8310994: Add JFR event for selection operations [v3]

2024-04-29 Thread Tim Prinzing
On Thu, 11 Apr 2024 16:39:24 GMT, Daniel Fuchs wrote: >> I think it's okay for now. If there is another phase of this work to help >> diagnose spinning issues then it will need to re-visited. I'm very concerned >> about the possible changes for that second phase, but this first phase of >> ins

Re: RFR: 8331202: Support for Duration until another Instant [v2]

2024-04-29 Thread Joe Wang
On Mon, 29 Apr 2024 21:32:16 GMT, Naoto Sato wrote: >> A new method on Instant to return the duration `until` another Instant is >> suggested per the following discussion thread: >> >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html >> >> A CSR has also been drafted. >

Re: RFR: 8310994: Add JFR event for selection operations [v9]

2024-04-29 Thread Tim Prinzing
> Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at jdk.jfr.event.io.TestSelectionEvents Tim Prinzing has updat

Re: RFR: 8331202: Support for Duration until another Instant [v2]

2024-04-29 Thread Naoto Sato
> A new method on Instant to return the duration `until` another Instant is > suggested per the following discussion thread: > > https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html > > A CSR has also been drafted. Naoto Sato has updated the pull request incrementally with on

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v29]

2024-04-29 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v28]

2024-04-29 Thread Brent Christian
On Sat, 27 Apr 2024 11:57:23 GMT, Viktor Klang wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> new section for finalizer memviz > > src/java.base/share/classes/java/lang/ref/package-info.java line 137: > >> 135

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v19]

2024-04-29 Thread Joe Darcy
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote: >> Reflection is not retrieving generic type information for mandated >> parameters. This is a known issue which has been explicitly stated in the >> API of some reflection methods. Fix for >> [JDK-8292275](https://bugs.openjdk.org/browse

Re: RFR: 8330998: System.console() writes to stderr when stdout is redirected [v2]

2024-04-29 Thread Archie Cobbs
On Mon, 29 Apr 2024 19:52:17 GMT, Bernd wrote: > Of course the question is if it should write to stderr or /dev/tty like > mechanism.. I was wondering the same thing. My understanding of the definition of "console" is a bidirectional byte channel with a keyboard & screen on the other end. It

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v19]

2024-04-29 Thread Joe Darcy
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote: >> Reflection is not retrieving generic type information for mandated >> parameters. This is a known issue which has been explicitly stated in the >> API of some reflection methods. Fix for >> [JDK-8292275](https://bugs.openjdk.org/browse

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v10]

2024-04-29 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v9]

2024-04-29 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

Re: RFR: 8330998: System.console() writes to stderr when stdout is redirected [v2]

2024-04-29 Thread Bernd
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote: >> Consider code like: >> >> public class ConsoleTest { >> public static void main(String... args) { >> System.console().printf("Hello!"); >> } >> } >> >> >> When run as: >> >> $ java ConsoleTest.java >/dev/null >> >> >> it

RFR: 8331202: Support for Duration until another Instant

2024-04-29 Thread Naoto Sato
A new method on Instant to return the duration `until` another Instant is suggested per the following discussion thread: https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html A CSR has also been drafted. - Commit messages: - Prefer until over between - nonnull

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Claes Redestad
On Mon, 29 Apr 2024 17:45:55 GMT, Mandy Chung wrote: > The changes look good to me but I wonder if the non-zero length check before > calling `arraycopy` really needed? That seems to add some noise to the code. I recall benchmarking similar code in `MethodType` extensively, and found that it h

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v19]

2024-04-29 Thread Vicente Romero
> Reflection is not retrieving generic type information for mandated > parameters. This is a known issue which has been explicitly stated in the API > of some reflection methods. Fix for > [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the > parameters of compact constructors o

Re: RFR: 8330998: System.console() writes to stderr when stdout is redirected [v2]

2024-04-29 Thread Naoto Sato
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote: >> Consider code like: >> >> public class ConsoleTest { >> public static void main(String... args) { >> System.console().printf("Hello!"); >> } >> } >> >> >> When run as: >> >> $ java ConsoleTest.java >/dev/null >> >> >> it

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread Mandy Chung
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote: >> Current implementation of `LambdaMetafactory` does not allow to use lambdas >> in hidden classes. Invocation throws `NoClassDefFoundError` instead. >> >> This patch includes lambda implementation in a hidden class under the >> special han

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread Mandy Chung
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote: >> Current implementation of `LambdaMetafactory` does not allow to use lambdas >> in hidden classes. Invocation throws `NoClassDefFoundError` instead. >> >> This patch includes lambda implementation in a hidden class under the >> special han

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread Chen Liang
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote: >> Current implementation of `LambdaMetafactory` does not allow to use lambdas >> in hidden classes. Invocation throws `NoClassDefFoundError` instead. >> >> This patch includes lambda implementation in a hidden class under the >> special han

Integrated: 8330748: ByteArrayOutputStream.writeTo(OutputStream) pins carrier

2024-04-29 Thread Brian Burkhalter
On Mon, 22 Apr 2024 19:07:04 GMT, Brian Burkhalter wrote: > Prevent blocking due to a carrier thread not being released when > `ByteArrayOutputStream.writeTo` is invoked from a virtual thread. This pull request has now been integrated. Changeset: 819f3d6f Author:Brian Burkhalter URL:

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Mandy Chung
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote: >> I'm looking at ways at reducing/eliminating startup overheads the classfile >> API in preparation of #17108, and have pushed a series of enhancements to >> that effect already. This PR is a collection of minor improvements which add >>

Re: RFR: 8330182: Start of release updates for JDK 24 [v2]

2024-04-29 Thread Joe Darcy
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote: > There are further updates to this test in the pipeline (new deprecated flags > in 23) so you will need to keep updating to reflect that. Thanks @dholmes-ora ; acknowledged. - PR Review Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread Chen Liang
On Mon, 29 Apr 2024 17:09:24 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java >> >> Co-authored-by: Mandy Ch

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread Adam Sotona
On Mon, 29 Apr 2024 17:09:24 GMT, ExE Boss wrote: > This doesn’t fix the case where the lambda is created from an instance > method, e.g.: > Yes, unfortunately the fix is limited to invokeStatic (see the comments above). - PR Comment: https://git.openjdk.org/jdk/pull/18810#issuec

Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]

2024-04-29 Thread ExE Boss
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote: >> Current implementation of `LambdaMetafactory` does not allow to use lambdas >> in hidden classes. Invocation throws `NoClassDefFoundError` instead. >> >> This patch includes lambda implementation in a hidden class under the >> special han

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v17]

2024-04-29 Thread Vicente Romero
On Sat, 27 Apr 2024 00:14:23 GMT, Chen Liang wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> code refactoring > > src/java.base/share/classes/java/lang/reflect/Executable.java line 348: > >> 346:

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v18]

2024-04-29 Thread Vicente Romero
> Reflection is not retrieving generic type information for mandated > parameters. This is a known issue which has been explicitly stated in the API > of some reflection methods. Fix for > [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the > parameters of compact constructors o

Re: RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Joe Darcy
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote: > This checker checks the values of the `@since` tag found in the documentation > comment for an element against the release in which the element first > appeared. > > Real since value of an API element is computed as the oldest release in

Re: RFR: 8329653: JLILaunchTest fails on AIX after JDK-8329131

2024-04-29 Thread Alan Bateman
On Mon, 29 Apr 2024 14:45:07 GMT, Joachim Kern wrote: > Since ~ end of March, after > [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131), > tools/launcher/JliLaunchTest.java fails on AIX. Failure is : > > stdout: []; > stderr: [Error: could not find libjava.so > Error: Could not find

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Chen Liang
On Mon, 29 Apr 2024 14:22:22 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/lang/constant/ConstantDescs.java line 178: >> >>> 176: >>> 177: private static final ClassDesc[] INDY_BOOTSTRAP_ARGS = { >>> 178: CD_MethodHandles_Lookup, >> >> Can these fields be @Stab

Re: RFR: 8330998: System.console() writes to stderr when stdout is redirected [v2]

2024-04-29 Thread Jan Lahoda
> Consider code like: > > public class ConsoleTest { > public static void main(String... args) { > System.console().printf("Hello!"); > } > } > > > When run as: > > $ java ConsoleTest.java >/dev/null > > > it prints `Hello!` to stderr, instead of to stdout (where it would be

RFR: 8329653: JLILaunchTest fails on AIX after JDK-8329131

2024-04-29 Thread Joachim Kern
Since ~ end of March, after [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131), tools/launcher/JliLaunchTest.java fails on AIX. Failure is : stdout: []; stderr: [Error: could not find libjava.so Error: Could not find Java SE Runtime Environment. ] exitValue = 2 java.lang.RuntimeExcep

Re: RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v11]

2024-04-29 Thread Adam Sotona
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and > method handles. > > This patch converts ASM calls to Classfile API. > > This PR is continuation of https://github.com/openjdk/jdk/pull/12945 > > Any comments and suggestions are welcome. > > Please review. > > Tha

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Claes Redestad
On Mon, 29 Apr 2024 14:16:34 GMT, Per Minborg wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplified void check > > src/java.base/share/classes/java/lang/constant/ConstantDescs.java line 178: > >> 176: >> 1

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Per Minborg
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote: >> I'm looking at ways at reducing/eliminating startup overheads the classfile >> API in preparation of #17108, and have pushed a series of enhancements to >> that effect already. This PR is a collection of minor improvements which add >>

Re: RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v10]

2024-04-29 Thread Adam Sotona
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and > method handles. > > This patch converts ASM calls to Classfile API. > > This PR is continuation of https://github.com/openjdk/jdk/pull/12945 > > Any comments and suggestions are welcome. > > Please review. > > Tha

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-29 Thread ExE Boss
On Wed, 3 Apr 2024 07:13:13 GMT, Jan Lahoda wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java >> line 1415: >> >>> 1413: >>> canonicalConstructorTypes, >>> 1414:

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Chen Liang
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote: >> I'm looking at ways at reducing/eliminating startup overheads the classfile >> API in preparation of #17108, and have pushed a series of enhancements to >> that effect already. This PR is a collection of minor improvements which add >>

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v3]

2024-04-29 Thread Claes Redestad
> I'm looking at ways at reducing/eliminating startup overheads the classfile > API in preparation of #17108, and have pushed a series of enhancements to > that effect already. This PR is a collection of minor improvements which add > up to a 1.5% reduction in retired instructions - or a 5% redu

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v2]

2024-04-29 Thread Claes Redestad
On Mon, 29 Apr 2024 12:18:15 GMT, Chen Liang wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Descriptors can't be empty, optimize isArray and isClassOrInterface with >> descriptorString().charAt(0) == > > src/ja

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v2]

2024-04-29 Thread Chen Liang
On Mon, 29 Apr 2024 12:14:17 GMT, Claes Redestad wrote: >> I'm looking at ways at reducing/eliminating startup overheads the classfile >> API in preparation of #17108, and have pushed a series of enhancements to >> that effect already. This PR is a collection of minor improvements which add >>

Re: RFR: 8331264: Reduce java.lang.constant initialization overhead [v2]

2024-04-29 Thread Claes Redestad
> I'm looking at ways at reducing/eliminating startup overheads the classfile > API in preparation of #17108, and have pushed a series of enhancements to > that effect already. This PR is a collection of minor improvements which add > up to a 1.5% reduction in retired instructions - or a 5% redu

Re: RFR: 8320575: generic type information lost on mandated parameters of record's compact constructors [v17]

2024-04-29 Thread Jan Lahoda
On Fri, 26 Apr 2024 23:54:17 GMT, Vicente Romero wrote: >> Reflection is not retrieving generic type information for mandated >> parameters. This is a known issue which has been explicitly stated in the >> API of some reflection methods. Fix for >> [JDK-8292275](https://bugs.openjdk.org/browse

RFR: 8330998: System.console() writes to stderr when stdout is redirected

2024-04-29 Thread Jan Lahoda
Consider code like: public class ConsoleTest { public static void main(String... args) { System.console().printf("Hello!"); } } When run as: $ java ConsoleTest.java >/dev/null it prints `Hello!` to stderr, instead of to stdout (where it would be redirected). The proposed fix

Re: RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v12]

2024-04-29 Thread Hamlin Li
On Sun, 28 Apr 2024 11:34:57 GMT, Andrew Haley wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add vectorized and scalar version Float tests checking full 32 bits range > > test/hotspot/jtreg/compiler/vectorization/Te

Re: RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v13]

2024-04-29 Thread Hamlin Li
> HI, > Can you have a look at this patch adding some tests for Math.round > instrinsics? > Thanks! > > ### FYI: > During the development of RoundVF/RoundF, we faced the issues which were only > spotted by running test exhaustively against 32/64 bits range of int/long. > It's helpful to add thes

Re: RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Nizar Benalla
On Fri, 26 Apr 2024 23:24:19 GMT, Jonathan Gibbons wrote: >> This checker checks the values of the `@since` tag found in the >> documentation comment for an element against the release in which the >> element first appeared. >> >> Real since value of an API element is computed as the oldest re

Re: RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v9]

2024-04-29 Thread Adam Sotona
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and > method handles. > > This patch converts ASM calls to Classfile API. > > This PR is continuation of https://github.com/openjdk/jdk/pull/12945 > > Any comments and suggestions are welcome. > > Please review. > > Tha

Re: RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Nizar Benalla
On Wed, 24 Apr 2024 21:59:02 GMT, Jonathan Gibbons wrote: >> This checker checks the values of the `@since` tag found in the >> documentation comment for an element against the release in which the >> element first appeared. >> >> Real since value of an API element is computed as the oldest re

RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Nizar Benalla
This checker checks the values of the `@since` tag found in the documentation comment for an element against the release in which the element first appeared. Real since value of an API element is computed as the oldest release in which the given API element was introduced. That is: - for modules

Re: RFR: 8331051: Add an `@since` checker test for `java.base` module

2024-04-29 Thread Jonathan Gibbons
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote: > This checker checks the values of the `@since` tag found in the documentation > comment for an element against the release in which the element first > appeared. > > Real since value of an API element is computed as the oldest release in

Re: RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v8]

2024-04-29 Thread Adam Sotona
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and > method handles. > > This patch converts ASM calls to Classfile API. > > This PR is continuation of https://github.com/openjdk/jdk/pull/12945 > > Any comments and suggestions are welcome. > > Please review. > > Tha

RFR: 8331264: Reduce java.lang.constant initialization overhead

2024-04-29 Thread Claes Redestad
I'm looking at ways at reducing/eliminating startup overheads the classfile API in preparation of #17108, and have pushed a series of enhancements to that effect already. This PR is a collection of minor improvements which add up to a 1.5% reduction in retired instructions - or a 5% reduction in

Integrated: 8330684: ClassFile API runs into StackOverflowError while parsing certain class' bytes

2024-04-29 Thread Adam Sotona
On Tue, 23 Apr 2024 07:39:47 GMT, Adam Sotona wrote: > ClassFile API dives into the nested constant pool entries without type > restrictions, while parsing a class file. Validation of the entry is > performed post-parsing. Specifically corrupted constant pool entry may cause > infinite loop du